From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by kanga.kvack.org (Postfix) with ESMTP id 1F5186B0032 for ; Fri, 19 Dec 2014 20:43:38 -0500 (EST) Received: by mail-oi0-f54.google.com with SMTP id u20so3963658oif.13 for ; Fri, 19 Dec 2014 17:43:37 -0800 (PST) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com. [2607:f8b0:4003:c01::22e]) by mx.google.com with ESMTPS id w6si6977573obv.56.2014.12.19.17.43.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 19 Dec 2014 17:43:36 -0800 (PST) Received: by mail-ob0-f174.google.com with SMTP id nt9so16721378obb.5 for ; Fri, 19 Dec 2014 17:43:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20141220002303.GD11975@blaptop> References: <1418993719-14291-1-git-send-email-opensource.ganesh@gmail.com> <20141219143244.1e5fabad8b6733204486f5bc@linux-foundation.org> <20141219233937.GA11975@blaptop> <20141219154548.3aa4cc02b3322f926aa4c1d6@linux-foundation.org> <20141219235852.GB11975@blaptop> <20141219160648.5cea8a6b0c764caa6100a585@linux-foundation.org> <20141220001043.GC11975@blaptop> <20141219161756.bcf7421acb4bc7a286c1afa3@linux-foundation.org> <20141220002303.GD11975@blaptop> Date: Sat, 20 Dec 2014 09:43:34 +0800 Message-ID: Subject: Re: [PATCH v2] mm/zsmalloc: add statistics support From: Ganesh Mahendran Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , Nitin Gupta , Linux-MM , linux-kernel 2014-12-20 8:23 GMT+08:00 Minchan Kim : > On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: >> On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: >> >> > > It involves rehashing a lengthy argument with Greg. >> > >> > Okay. Then, Ganesh, >> > please add warn message about duplicaed name possibility althoug >> > it's unlikely as it is. >> >> Oh, getting EEXIST is easy with this patch. Just create and destroy a >> pool 2^32 times and the counter wraps ;) It's hardly a serious issue >> for a debugging patch. > > I meant that I wanted to change from index to name passed from caller like this > > zram: > zs_create_pool(GFP_NOIO | __GFP_HIGHMEM, zram->disk->first_minor); > > So, duplication should be rare. :) We still can not know whether the name is duplicated if we do not change the debugfs API. The API does not return the errno to us. How about just zsmalloc decides the name of the pool-id, like pool-x. When the pool-id reaches 0xffff.ffff, we print warn message about duplicated name, and stop creating the debugfs entry for the user. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org