From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA44C61DA4 for ; Wed, 22 Feb 2023 04:04:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 156A06B0074; Tue, 21 Feb 2023 23:04:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 107186B0075; Tue, 21 Feb 2023 23:04:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F10006B0078; Tue, 21 Feb 2023 23:04:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E22F36B0074 for ; Tue, 21 Feb 2023 23:04:10 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8CF3E40215 for ; Wed, 22 Feb 2023 04:04:10 +0000 (UTC) X-FDA: 80493585060.23.5925CBE Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf24.hostedemail.com (Postfix) with ESMTP id B85CE180013 for ; Wed, 22 Feb 2023 04:04:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PlCZNxI6; spf=pass (imf24.hostedemail.com: domain of stevensd@chromium.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=stevensd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677038648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Yt/rtAUjC8oE//IhVQKInejbXflDY4md7Xx+ezyrLY=; b=HwdxVICC+9bRyBooggIRlcPpndexNjjifSNw6f6dXGjj8suROCHPFIeA9rkfWFfMaNgbId KWf5LrW7LnMPOHesNEzVATW6jJdbHg87p0b5KJD6mTusqza9QzI3IQY3jE6f3exShO4sxa Jut7ikuQfL+o1G10YFCqgcpVMZyRH8w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PlCZNxI6; spf=pass (imf24.hostedemail.com: domain of stevensd@chromium.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=stevensd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677038648; a=rsa-sha256; cv=none; b=GyXUUc5ed73K59A9tJfl4S+PN3hh8oMfmLz0Ws/1VDhlEUYUPY8f9USLVFOzIJRLVE3B8u oi5KUmUyGkfuZOfwbw2ORxDfUPd4Y2TrN5E1o4GexYZ53qv8IlLb9KggK5IjBjs823w5X/ zBePHRA0yosDd1/qtDTOs49B6f8LFQs= Received: by mail-lf1-f50.google.com with SMTP id s22so8296320lfi.9 for ; Tue, 21 Feb 2023 20:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2Yt/rtAUjC8oE//IhVQKInejbXflDY4md7Xx+ezyrLY=; b=PlCZNxI6YaoiNHUimwzbfONmZvR3sfewbs0X07QALDVOrrxpCUFYZsoOhBAOI6wa74 qGIZyVqEkF9Loyx7H3H9ZH8O/m08FrEGlDX6iP31P2VKJIixcgaVqjWx5PkDEaHo2GOd QWdqEo6qaObAubvJSssFXGDcKGgi/kFMrI/4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Yt/rtAUjC8oE//IhVQKInejbXflDY4md7Xx+ezyrLY=; b=6cVfPa6SQq04De3oiN8NRe2v6DfDwoNI1s/kzvpY2EODfCjUF06fcBRC4akWWK0j9s CRjOak42x91Q4DvtKh3WLF5eTJUNlfA7PVeB6QA+kCrYUUJGMIxhok5W0LQYt+/L5SPS 9RIi9HluTapzDEMW0mAW06QTT4s1DmIv/F83aMYiEVdXeJ1bbXJ9zjZITxxpBhlIpq1V VGl/nHcaG+G55IdnbmIKNnRq3i6HQqCSIVbeeLAB1eLjI2YXHba8L6C2kPcRxAvHbgSF dD1RRZ40ccelzRO/QejDWp7u9Gxy0N7LxrI17K1v+mBMyEIwfYZzaHqM4jqN8yVUP/pt jJtg== X-Gm-Message-State: AO0yUKXx6qpOV0npkUxjrJA8JJAXlNAdJm9h4itKyYM9sBsILtUnxOtD FWswqG2HZjyqHuSA99VItqeWNsVvwRCkA6mmuDTS4A== X-Google-Smtp-Source: AK7set8y2i/Pyooxg/uGB4gmq0f1CWgV03knLK+LIWN1PjLs9XMWKgkHNXYCRaI11gv0/HSn9Wh9/Q0yJf7QGtRUCQ0= X-Received: by 2002:ac2:46db:0:b0:4d5:ca32:6aec with SMTP id p27-20020ac246db000000b004d5ca326aecmr2399509lfo.12.1677038646988; Tue, 21 Feb 2023 20:04:06 -0800 (PST) MIME-Version: 1.0 References: <20230221214344.609226-1-peterx@redhat.com> In-Reply-To: <20230221214344.609226-1-peterx@redhat.com> From: David Stevens Date: Wed, 22 Feb 2023 13:03:55 +0900 Message-ID: Subject: Re: [PATCH] mm/khugepaged: alloc_charge_hpage() take care of mem charge errors To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Yang Shi , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B85CE180013 X-Rspam-User: X-Stat-Signature: 7atkjj9nt9fagdc5dao7sdor9iyre9hk X-HE-Tag: 1677038648-272804 X-HE-Meta: U2FsdGVkX19WIvvpbHB8f5drXp/Dq/SjjanTEvVqjhn+s+yCgOVA7BROcgN6uS6cXdomIDIWIdfU5kI4cTKak7dKrdeBMlcpTIK8UHeN08po9Y8k3Qu+FpbN7uoaI4k4CmdGXZZCa5jxmKMJfMyMizzfCQjb30+tteavH9XmQ2e1bzfCkFxX7WVegKO6pknNRcwUt9BijaxV2L3IOdW5bagah7xaOhLAYrrGOAzoo1OhtB4EW8lJTC5IT69vmYifwM8T3MLk+j8sgEO1ZuECtMWKWAcDZdfgal5cCSgDG4pbkak8x/LsJmrBy2/vJf6IgdckRCZaSZO+/MpfOnG5b7ave1KSWBgWXR/k8iWu6ySEvgiADNXXKHiXvhSwYpGprk6SET3jy9xeaAG5bDs/u9NcY2PpzDjdXMUnXNQ7+3d/L000dJyph13P+hQ/jDmYmACctoJEcvkrONVs2C8absU/Qo8OjSotcy2H9xLfnIy61Ql8Q/mN0XjYn7DccX+2TvVsOrnSTHcF33q3y74L2FPhzHLsHVk4KpWAdNY4GJoPFRCBvBB8kVEXjk6GraVZbUy8tHPnWJuzmvpug/4esUgMq1JdGS3KTv5jrM2qUlbnQjYkY2bhMNhnLCvxg7YR21PASUHOWWtZETRBlIDA84V9skQyBuNz4KT16k/2LFfodUkPxKjKvloCRurwS1L0OzZxJf7FyXSTrVXD6fgU8NXfj5RLXG6hVPROjOTc3JB3ZMKn/o7U/VH+UB9AQ4g4t8YZqNuN/Y0RmKkxVY8zdyEifKnzW5J1p4Wo2FtDS+0d6jKvD2/gX/B4RHP1EhkPekKlYZ8NjOCRgl2KTiZ+OMBLZZq6Rqruz4dynC7nwR3mTtygApY02+ztV5lqkrWH6nY8Fa1A0UgC34IG4SNoz0ZQR/QqTUB3Bds10CXZBl9liw6jR9OubJPtHqaPW5fY0UyZtL8ZI9TmThYt4Tp pYOKO3cJ IxaEomUfSCtohHKgPQTWPGdwUvniT/NUuZoL2HYq5CxGXegYkwoqaBwPHkkYUYohqmtOZhNPgXFKnNipKFFLUeur6Rdn3YDKin64bNsbmRg8w31OyozBKQuNUEIh0CFmybeeb1OjJF16616R5Z2MYqnVmlMUMGNjUeWSnXwlXm3NTW7J1ysGAZV2CRYPBoTWRwMjN/iKVEU7qrvNGOuybDTTl6nUOUtO87p63/rUXRkfY6OCyNHB4LSy6DdEicFeOeNV66J1dcdglZyI+UbUv6GSYwdGmInL95uSB6qrMtyAKoikkcO2b8+vncQKqMn/A7XaEca5an7bFRb/BL+RT0x3hQIOP78AP0adV4Mm6d8Rg+3FnSvx0lGSceVInVIL0yvh8PeFDdTKXqUQVQxli/DtKpKa3S/+l+t1pIyf7ALzovi3DVS2cjF+IbZD/8uh7rUiSCJLWKDDoI3Qc6Com2mIWZILeqVCoru93z1/T1X79kdNtmCQL8LQoDoXSBlrk7HYjd9oLqGRuT94= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 22, 2023 at 6:43 AM Peter Xu wrote: > > If memory charge failed, the caller shouldn't call mem_cgroup_uncharge(). > Let alloc_charge_hpage() handle the error itself and clear hpage properly > if mem charge fails. > > Cc: Johannes Weiner > Cc: Yang Shi > Cc: David Stevens > Cc: stable@vger.kernel.org > Fixes: 9d82c69438d0 ("mm: memcontrol: convert anon and file-thp to new mem_cgroup_charge() API") > Signed-off-by: Peter Xu Reviewed-by: David Stevens