From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD13C6FD18 for ; Tue, 25 Apr 2023 14:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95D36B0071; Tue, 25 Apr 2023 10:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45AA6B0072; Tue, 25 Apr 2023 10:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90D486B0078; Tue, 25 Apr 2023 10:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7CFB36B0071 for ; Tue, 25 Apr 2023 10:20:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 384E580107 for ; Tue, 25 Apr 2023 14:20:07 +0000 (UTC) X-FDA: 80720122854.04.6DEBF02 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 2DCF540009 for ; Tue, 25 Apr 2023 14:20:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O/yFgzZ+"; spf=pass (imf17.hostedemail.com: domain of dianders@chromium.org designates 209.85.166.176 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682432405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s4HG8lg/OG1ovZC1iXgiDy5NkPoWvsd+DP5aQJEJUcA=; b=rECrl+AQ3TT1E6EjxQUFZbds1fgjdUpYNNDdRhVMI/KKo/v99BPrA87fZ2rSgVTDNzEllp ijwczIR2j0an1JXjIlgrMcjyl0Zd0AWHBIfpb5VzZxU6mQkUanMIkECictzfNvIIXHQNqP 2asqUubXArCq+XpxugQovKimN6D7Y5k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682432405; a=rsa-sha256; cv=none; b=FjwGxzBtB0ERphSlkTU8jlg04/hk6NauuLr2u5tYG0pYiHy+RobF+mZTOhfHRrDvoM5Ct5 5z7J+s3DR77TotEudDlzAx4lW8ly7KrSvQYKOCxvof36GiSWfjgITpbZJkVyyo9Y6MOA1d wwaPmOUt0h5X6a62cejAW2zJkbC1fpM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O/yFgzZ+"; spf=pass (imf17.hostedemail.com: domain of dianders@chromium.org designates 209.85.166.176 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-32ad0eb84ffso15042865ab.3 for ; Tue, 25 Apr 2023 07:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682432403; x=1685024403; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s4HG8lg/OG1ovZC1iXgiDy5NkPoWvsd+DP5aQJEJUcA=; b=O/yFgzZ+TimXH0TNtdRcVxEng1cKXDdMiizP1hvu0WMAxiQXkd+5sXrC8LyEh0FYtC tVQXv8fhZW8h8gWllWx6hawMmR2KRmsnjDILD0+M5plN17720JeJCYw+OihjXdIdxTyS r/EL2M7dcLPthEUPp2amJTPaLLEA00L5tfwyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682432403; x=1685024403; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s4HG8lg/OG1ovZC1iXgiDy5NkPoWvsd+DP5aQJEJUcA=; b=jn+CH1bvzo4K+82wdRWy9ZXsxSeJb8L1T7rV2Mbw0pMGjdyu+/VTaqPwuVlUUiykPF ycLKau/lDNluCPJZYS2B7FQzVb6h6CLHK1kiuWMFU6YJ+w8AnKDiQ6O0Ep3ZCozkUsov zjODP9905e46/+pb6ChFgaA50ac/Hau9E6xR8eVv5Vpk0NO0M5hScOri1N0B8gH6cxhE SohUfMNRmNiOcUlBf+6qPIl0PTY+r04HOiHy8VtId4uBpcRsk96QktrYty6XOC7wsmys LKwwp7P3FGhpzdBQnekOXNu3aankPAYh/yV76ZB0LWh1TOBrX7y7KnRSK29sQit2pP9L LA8g== X-Gm-Message-State: AAQBX9fhWgWIZShRHK/fKE1IIhftdOOhhmFdxabEOO49GnRdxwHOQuz5 Bq3aS2XoFWddVOZlVBDE5WoMfh3NYA73Ihtq/gI= X-Google-Smtp-Source: AKy350Zdfi/YMHA820RnKd3V/jwcEdWU+W3aMVQn7XjQIEcOKEkOdfYJhmWWG/jyTAEnrZIubKl5Cw== X-Received: by 2002:a92:c94e:0:b0:32b:12ee:3f16 with SMTP id i14-20020a92c94e000000b0032b12ee3f16mr6659410ilq.4.1682432403033; Tue, 25 Apr 2023 07:20:03 -0700 (PDT) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com. [209.85.166.172]) by smtp.gmail.com with ESMTPSA id f5-20020a056e0212a500b00325df6679a7sm3731860ilr.26.2023.04.25.07.20.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 07:20:01 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-325f728402cso80235ab.1 for ; Tue, 25 Apr 2023 07:20:01 -0700 (PDT) X-Received: by 2002:a05:6e02:1d17:b0:32a:db6c:d51d with SMTP id i23-20020a056e021d1700b0032adb6cd51dmr331586ila.12.1682432400610; Tue, 25 Apr 2023 07:20:00 -0700 (PDT) MIME-Version: 1.0 References: <20230421221249.1616168-1-dianders@chromium.org> <20230421151135.v2.1.I2b71e11264c5c214bc59744b9e13e4c353bc5714@changeid> <20230422051858.1696-1-hdanton@sina.com> <20230425010917.1984-1-hdanton@sina.com> In-Reply-To: <20230425010917.1984-1-hdanton@sina.com> From: Doug Anderson Date: Tue, 25 Apr 2023 07:19:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] mm/filemap: Add folio_lock_timeout() To: Hillf Danton Cc: Andrew Morton , Mel Gorman , Alexander Viro , Christian Brauner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yu Zhao , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2DCF540009 X-Rspamd-Server: rspam09 X-Stat-Signature: jej8dcr4sbqzzcpw7re7wibww6nhrqbq X-HE-Tag: 1682432405-405350 X-HE-Meta: U2FsdGVkX19WJzoHOOWzRxhUXZV33d/YKkrrxLp7AQZmGrsq45MzpOwtPgbSQxBZluJfWEOv1Klsbet4nl/1XkcwEy+TkLECjes11kF736IBf5zYmBfmH/lh/oPSb2iPHuxwOvnLhP+hCE/X8qJ8RoVHnptPkzdl+kiHJJPgpTzp4Di10Hq5WMqAK+WaLPskxVkvLsOQSdZjNiDFeXz+X60oQ27+9ANpUsLShZj5EnF8dxRsMOc6AtlHLuwDw6d7B2htJpE1jrYWoA1r8nKdbbAmMr2YZ7/0plo3BBlOmVeslBIfIRRp82NahbWdet9AuenHaSlPkCvLGr3Ngaztt5UpSllWXYqL1kisFj4YkxlaZTfINuLR+iqaDN4AyTMI1/hmwbXXyjbBOcvfnOoR/1F3yw0wtIc5eL2Q90I//8X+FJhjxzwTYXVGmGhlxEBnTkzvGm4lmHkDcbwAMh+V2IyQbBj36gBLLJlWDfzcDQDbZ/A3M5HkQRV2u5jVqQxlnMws8VGTrEUMgp+iG7wS+99rk03stvXvDqdzC7PH6MicSuuOPkX3RlebkZ0Lxev9XTK5RC/PEhiP/2l8bVO0SijOy2JrpSXesIl9/DAWfTA6S141n0VsBTUkh9Aw+vSafTZG+UISGlm/tqeCBd2xGB08KgWgwlyYAON0VSDsHOdGuV9qGCV7uRRcwCtck9EAU8jM2aupP7z4snOGKVH0ztXuvQUEJHIeCJgUBGgI0+LrNN+dzHs1St4Rm1Gslomo301/Tr0ImNGELyAT0/UUmXrtQ1ZJ4Aadu7/KpnABMZ5/g1aV+qhNUpEzs9ahmoNtxv6vsgvgjKY+rbhkRrrjFSJdKULg+t46dG1Ldek3LqNZCW0A6fnDmEYSejlggZt1UJ8Ut+8YqcHMOdG/FZkQlA43YPdQqj1C4aIuL6A6c/Vle4U3H+uRESmj9N9n9UBThqr/Ajj0FXbS7c15tDD 1HMvAaQr 3NobJw42aG50jAtA+QsqLloCZpdv1V9jRt1Ce6LXg3irAQYE9y7udZmT+5eaLNrzclPhZQdqtjna1yyQhOBp7wxsg+5Q77qH3sKwYo4y5H536BFqeHsXdUIHfVLScux/JKr1TLXzJkecTlh9Cd6gTrt5+aHkau/ANttVz4yzT/OeIRUhUXPSySMyY3csvEI14aCOipv1Rb1o4kx+87HxawGePaazIhWfE/AEd6X1BPBn6DPalWOVIPx5hK5apFVUsqRwk4TnGrkJCeRd47kFnuUs+1jBRXJihfrJyqDDlZ2WRmQO6/PW6+JFpydnEi5bvNiVt5HPKUOGhvuRVjYpEtzX7xs2ue1IjPHcmJa0MlhM4wTMo6J4PBE9dsgFp3ZLgdf6zMp/CkeYDaB/NWEYJRFNw96/OaEaUvOwVqmLYdFFzcm3VKSyyvvaXlEZ16IlZT99/oCLeL2U9wUOYltJ8Y85u/4zUIyyYNsA9naBfV8ONfDbo+mI4crL+GcCUiBDqX0VQgTU9jFT/Nud/TVz6TKFgr4tTgWGcYh9ROapDNgfDNjU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Mon, Apr 24, 2023 at 6:09=E2=80=AFPM Hillf Danton wro= te: > > On 24 Apr 2023 09:56:58 -0700 Douglas Anderson > > On Fri, Apr 21, 2023 at 10:19=3DE2=3D80=3DAFPM Hillf Danton wrote: > > > If kcompactd is waken > > > up by kswapd, waiting for slow IO is the right thing to do. > > > > I don't have enough intuition here, so I'm happy to take others' > > advice here. I guess my thought was that kcompactd is explicitly not > > using the full "sync" and instead choosing the "sync light". To me > > that means we shouldn't block for _too_ long. > > Take a look at another case of lock wait [1]. > > [1] https://lore.kernel.org/lkml/CAHk-=3DwgyL9OujQ72er7oXt_VsMeno4bMKCTyd= BT1WSaagZ_5CA@mail.gmail.com/ So is this an explicit NAK on this approach, then? It still feels worthwhile to me given the current kcompactd design where there is a single thread that's in charge of going through and cleaning up all of memory. Any single pags isn't _that_ important for kcompactd to deal with and it's nice not to block the whole task's ability to make progress. kcompactd is already very much designed in this model (which is why SYNC_LIGHT exists in the first place) and that's why my patch series was relatively simple/short. That being said, if people really don't think I should pursue this then I won't send another version and we can drop it. -Doug