From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082CDC48291 for ; Fri, 2 Feb 2024 16:24:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97EFA6B0085; Fri, 2 Feb 2024 11:24:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92D926B0087; Fri, 2 Feb 2024 11:24:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F6786B0088; Fri, 2 Feb 2024 11:24:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6BC156B0085 for ; Fri, 2 Feb 2024 11:24:41 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D37C807AB for ; Fri, 2 Feb 2024 16:24:41 +0000 (UTC) X-FDA: 81747387162.03.460E1F5 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 1DF17C0017 for ; Fri, 2 Feb 2024 16:24:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZyMEpV6u; spf=pass (imf22.hostedemail.com: domain of dianders@chromium.org designates 209.85.208.173 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706891079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tHbpeNpyu3wqI87Qy7h1gmd0YJLbzF1zOL2R+Rngvbk=; b=GEQld+eAYNfDp/XX8OukPYQ4yjUMeeiTNBJDXp2T+KC18Fra9x0KfO+fSEI17XLchfxawl yr3GK9ATv9v9eieovN9LvrCkYYxVycoG3XJGFR+mKcv8kPfhsn1i3UgdK3EQYG72B4rIfB lz5/A8U6tuJfaww96lwfmzspEVhtdQ4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZyMEpV6u; spf=pass (imf22.hostedemail.com: domain of dianders@chromium.org designates 209.85.208.173 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706891079; a=rsa-sha256; cv=none; b=nrWQRoQ3x0+6TQXQOIgVu2s+rM2ePdz6S8WnGsIuMpp+cYHgWO3BtSGeiFx4EBif6pR/0i TnHr97WS7UpXe/aGVPkUXIaQJB9fjxOyM2jWaCSF5eCVSXe7CSFgE/DjC0AjYZ6YrExhsz knVK6cTcE2Q2F7reZkGRb6wFrPQxdKQ= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2cf42ca9bb2so25004471fa.1 for ; Fri, 02 Feb 2024 08:24:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706891075; x=1707495875; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tHbpeNpyu3wqI87Qy7h1gmd0YJLbzF1zOL2R+Rngvbk=; b=ZyMEpV6ul8iYOma38MIjsq68IPmxd4vC5BuKB47jHCnSmq69U6HbHoYeN4Lm696aWn VbTASss/1IZMjPLlbjhntNSpGKGI7g5qycW8j5mS5Vcdc0j+7yCq4pjpE+uOyzagtiUw 52Ve///nst/UPPhULCVMy8GtVlFtht0OYatg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706891075; x=1707495875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tHbpeNpyu3wqI87Qy7h1gmd0YJLbzF1zOL2R+Rngvbk=; b=r71HmNjLnHjTcUBebAfspdzRvb7PItj1cNqAYQbSoVgAcnyedGz0J8IAx7vwhhrBPO c1+MFG+CZgAfFkhr6BERybTGw9vnyPHzoUykAMT2jIOxT/Mf2gbwHMODubNg5nP2qLs8 D+LW5SEyYGUlZVExPJkXzfg9WZlgJMBSXhq1SOR++2f4v//UNp6W0PwSv0/DS0YSq5eV WMDrBGtZi79aImlUeg2KDnkyi0taYj2N0euErBUzpSl4o9MTYfe4e+Yev4xy6NibtGie ceNtn/sH8e8FxPgugFU4VvQr9gIHR4Uk61Mj9mQpIzYHD9LG6PBBUDuCUVQ2fV8bAGcg yBPg== X-Gm-Message-State: AOJu0YzTFZzy/Tqnz6Pg29Ii8jdrOV8nzMd9KeGEycd0hkIe6tyjX9MW 4IJFiVSLmD3jx3QzlcuVCLM8nG7x4MEZYz4hR37gvQ5WyrDM51dYW5drmX/0acTWY5d+zxVyYFB BN24O X-Google-Smtp-Source: AGHT+IFwmk7DaHp+wPpmxPSxEkrq5PzgLvhDLIpqMsgNLuFrBfSm8YLBP6TbbIomo64PcvjUkFJUxQ== X-Received: by 2002:a05:651c:205a:b0:2d0:6364:fd73 with SMTP id t26-20020a05651c205a00b002d06364fd73mr1552089ljo.33.1706891074903; Fri, 02 Feb 2024 08:24:34 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU7Np/JDvP+ByMSzPCWBZxWL30LFgYu1Kd4UUwfMdXBBByumGxDRPLUzp1lJj3W+U2T57OnlDkPzR09Gnhf90TJ2Nw= Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id es27-20020a056402381b00b0055c60ba9640sm943131edb.77.2024.02.02.08.24.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Feb 2024 08:24:33 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40fc5e5ed44so48795e9.0 for ; Fri, 02 Feb 2024 08:24:33 -0800 (PST) X-Received: by 2002:a05:600c:1e1c:b0:40e:f5c6:738a with SMTP id ay28-20020a05600c1e1c00b0040ef5c6738amr8421wmb.0.1706891073620; Fri, 02 Feb 2024 08:24:33 -0800 (PST) MIME-Version: 1.0 References: <20240201171159.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid> <20240202012249.GU2087318@ZenIV> <20240202030438.GV2087318@ZenIV> <20240202034925.GW2087318@ZenIV> <20240202040503.GX2087318@ZenIV> In-Reply-To: <20240202040503.GX2087318@ZenIV> From: Doug Anderson Date: Fri, 2 Feb 2024 08:24:17 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] regset: use vmalloc() for regset_get_alloc() To: Al Viro Cc: Christian Brauner , Eric Biederman , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oleg Nesterov , Catalin Marinas , Will Deacon , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1DF17C0017 X-Rspam-User: X-Stat-Signature: neqf33hdi776nwzhwxi1b63kn8iqmo1s X-Rspamd-Server: rspam01 X-HE-Tag: 1706891078-5890 X-HE-Meta: U2FsdGVkX19B86d83nJ2vd9S6Urvru5sCF4FH37/kWhWCdkAtcR8WFmSt5sXD4+3U7H6MWPGzRRZgF7fvHCGcRgj3pb2lHXcoOc1fDm2bf6lC0y79HijCJlWPEqdpYUYKsGw6jek+ofLSUo9XK3opMUBdLw1w/F8rhnmA70U0xO6L8a119kNEDgFgx9DFObFolI4HmIsfEwQ/3yjyFSqX762Jgd2sJ3XI320S+Xp4LOavxadoIKGoIjk2G/I91769bJNywgs8tU+JrYAypS0BTYqIKKwWgGRxjqTyXkyw074q1BxDbjcvBOZ3BIlaIWWV8+ciwlDbCrzyhK/xORzoIpTRvFUE7k4DGUiTrcxfux+5NPQeYsxLqBzvF7Nhqv7HygEjmThYdO7gZs9avKlLUzrKQ/uW/izc8jPl8W99eSffXYiunWCoYm2uuCnurkaGNwQfLDHLal0JlorNErI8kaeC7uGYz13YTY3XIIh7Av3O4OyWtQsFlyvf56zvNqd1D0RjOmdywwSOVqL+jWMH0pGdta0fhpD2+7EJgS6HlMMj9ONPQUO21HPDCEf03yTHHwSWswui/Bf8zsSmOgzqgdcpbknxOzvBgs6nI7UHPZ2FXcmrocGCTSGo2gFj1V7p4reP7H4Knifm1UVWYOLMa8wI82HS2yJPLBwynAQQizBgCQ6EdFhxvcVhMJ+V8qvm+P33S62+li0uZdPOfLrYRqvZWAJhXeWB36S2W9DkgtUzLRi3Y/t8DdFbWjttlvVIWerUoJtkJmwHLt9m27Ak3JvB0EVPUdY9/EY1iD9oQL78qlnMN5BipU2eqpu3q4s11Yef6bs8HZ9CPxnj4m+LbIdnqkYMK6Bwu5eeJA/j0l54fmQt4Oym2lcv7rZa6CRvx5xLRvRYoyx4F6+5NTLJs2O5h860pQhf4bbDMHKt1D2ZHHJnFtkAth2qmoFAPOsuFWAHYY9xRek/k9siUF exHJIECU julqMTs7kqN3sq5AWeQBTIJ1Zo0JsWiQKJki8WSASaGTuMBK5cdOWAUHUv9666oBI20J7lnS+ObpOT/A8hlFUW3ibvQg/zLOLEq5ze5f8B8VFeajYqUE8dDLAF0LbVeBcoTcrtO9jlh6LuLA8MnmlAvxQ+phgpvn77yWJE3wc40X01ArmycgrOmZrSWRPQOFisqdPIYwPiXuEq7RHZzpm3erk4u7AyHTOk/TAAj5NrnWEzSKKBuPFa6ohHNTEQVQhdcoWF2vcYq5Ho/OBwnTvTfq1ZqifDBH84kw5zIGaQFrSXagP9Lx8KS4z5aHHX+Q67d48aJ79mrJApOFzTAZA6Aly4HE9GoSzgmDId+YttDTYGS+G7lkd0MOKJupKka0CJJFGUl0ARfrhfsH42q3BK/vV++NTMcD/5n7o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Feb 1, 2024 at 8:05=E2=80=AFPM Al Viro wr= ote: > > On Fri, Feb 02, 2024 at 03:49:25AM +0000, Al Viro wrote: > > On Thu, Feb 01, 2024 at 07:15:48PM -0800, Doug Anderson wrote: > > > > > > > > Well, the next step would be to see which regset it is - if you > > > > see that kind of allocation, print regset->n, regset->size and > > > > regset->core_note_type. > > > > > > Of course! Here are the big ones: > > > > > > [ 45.875574] DOUG: Allocating 279584 bytes, n=3D17474, size=3D16, > > > core_note_type=3D1029 > > > > 0x405, NT_ARM_SVE > > [REGSET_SVE] =3D { /* Scalable Vector Extension */ > > .core_note_type =3D NT_ARM_SVE, > > .n =3D DIV_ROUND_UP(SVE_PT_SIZE(SVE_VQ_MAX, SVE_PT_REGS= _SVE), > > SVE_VQ_BYTES), > > .size =3D SVE_VQ_BYTES, > > > > IDGI. Wasn't SVE up to 32 * 2Kbit, i.e. 8Kbyte max? Any ARM folks aro= und? > > Sure, I understand that it's variable-sized and we want to allocate eno= ugh > > for the worst case, but can we really get about 280Kb there? Context s= witches > > would be really unpleasant on such boxen... > > FWIW, this apparently intends to be "variable, up to SVE_PT_SIZE(...) byt= es"; > no idea if SVE_PT_SIZE is the right thing to use here. +folks from `./scripts/get_maintainer.pl -f arch/arm64/kernel/ptrace.c` Trying to follow the macros to see where "n" comes from is a maze of twisty little passages, all alike. Hopefully someone from the ARM world can help tell if the value of 17474 for n here is correct or if something is wonky.