From: Doug Anderson <dianders@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Saravana Kannan <saravanak@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Eric Dumazet <edumazet@google.com>,
Johan Hovold <johan@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Frank.Li@kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
alex@ghiti.fr, alexander.stein@ew.tq-group.com,
andre.przywara@arm.com, andrew@codeconstruct.com.au,
andrew@lunn.ch, andriy.shevchenko@linux.intel.com,
aou@eecs.berkeley.edu, ardb@kernel.org, bhelgaas@google.com,
brgl@kernel.org, broonie@kernel.org, catalin.marinas@arm.com,
chleroy@kernel.org, davem@davemloft.net, david@kernel.org,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
driver-core@lists.linux.dev, gbatra@linux.ibm.com,
gregory.clement@bootlin.com, hkallweit1@gmail.com,
iommu@lists.linux.dev, jirislaby@kernel.org, joel@jms.id.au,
joro@8bytes.org, kees@kernel.org, kevin.brodsky@arm.com,
kuba@kernel.org, lenb@kernel.org, lgirdwood@gmail.com,
linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mm@kvack.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
linux-snps-arc@lists.infradead.org, linux-usb@vger.kernel.org,
linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org,
m.szyprowski@samsung.com, maddy@linux.ibm.com, mani@kernel.org,
maz@kernel.org, miko.lenczewski@arm.com, mpe@ellerman.id.au,
netdev@vger.kernel.org, npiggin@gmail.com, osalvador@suse.de,
oupton@kernel.org, pabeni@redhat.com, palmer@dabbelt.com,
peter.ujfalusi@gmail.com, peterz@infradead.org, pjw@kernel.org,
robh@kernel.org, sebastian.hesselbarth@gmail.com,
tglx@kernel.org, tsbogend@alpha.franken.de, vgupta@kernel.org,
vkoul@kernel.org, will@kernel.org, willy@infradead.org,
yangyicong@hisilicon.com, yeoreum.yun@arm.com
Subject: Re: [PATCH v4 0/9] driver core: Fix some race conditions
Date: Sun, 5 Apr 2026 15:43:34 -0700 [thread overview]
Message-ID: <CAD=FV=X6DRHV6k7G=p5Mno22na75G-69F-EzMkisSxMoxuvJcQ@mail.gmail.com> (raw)
In-Reply-To: <2026040539-sponge-publisher-2b42@gregkh>
Hi,
On Sat, Apr 4, 2026 at 10:28 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Apr 03, 2026 at 05:04:54PM -0700, Douglas Anderson wrote:
> > NOTE: one potentially "controversial" choice I made in some patches
> > was to always reserve a flag ID even if a flag is only used under
> > certain CONFIG_ settings. This is a change from how things were
> > before. Keeping the numbering consistent and allowing easy
> > compile-testing of both CONFIG settings seemed worth it, especially
> > since it won't take up any extra space until we've added a lot more
> > flags.
>
> Nah, this is fine, I don't see any problems with this as the original
> code kind of was doing the same thing with the "hole" in the structure
> if those options were not enabled.
>
> > I only marked the first patch as a "Fix" since it is the only one
> > fixing observed problems. Other patches could be considered fixes too
> > if folks want.
> >
> > I tested the first patch in the series backported to kernel 6.6 on the
> > Pixel phone that was experiencing the race. I added extra printouts to
> > make sure that the problem was hitting / addressed. The rest of the
> > patches are tested with allmodconfig with arm32, arm64, ppc, and
> > x86. I boot tested on an arm64 Chromebook running mainline.
>
> I'm guessing your tests passed? :)
Yup, all the tests that I've run have passed. I also threw in an
"allnoconfig" compile test just for good measure.
> Anyway, this looks great, unless there are any objections, other than
> the "needs to be undefined", which a follow-on patch can handle, I'll
> queue them up next week for 7.1-rc1.
Thanks. As per the other thread, I'm happy if you or Danilo want to
apply it, and I'm happy if you want to make minor fixups when
applying.
When I see the patches applied, I'll send a followup patch to address
the "needs to be undefined" comment, unless Danilo makes that change
himself when applying.
-Doug
prev parent reply other threads:[~2026-04-05 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 0:04 Douglas Anderson
2026-04-04 0:04 ` [PATCH v4 4/9] driver core: Replace dev->dma_skip_sync with dev_dma_skip_sync() Douglas Anderson
2026-04-04 0:05 ` [PATCH v4 9/9] driver core: Replace dev->offline + ->offline_disabled with accessors Douglas Anderson
2026-04-04 17:11 ` [PATCH v4 0/9] driver core: Fix some race conditions Rafael J. Wysocki
2026-04-05 5:27 ` Greg Kroah-Hartman
2026-04-05 12:02 ` Danilo Krummrich
2026-04-05 22:43 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X6DRHV6k7G=p5Mno22na75G-69F-EzMkisSxMoxuvJcQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Frank.Li@kernel.org \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=aleksander.lobakin@intel.com \
--cc=alex@ghiti.fr \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.przywara@arm.com \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chleroy@kernel.org \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=edumazet@google.com \
--cc=gbatra@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hch@lst.de \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=johan@kernel.org \
--cc=joro@8bytes.org \
--cc=kees@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=leon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=maddy@linux.ibm.com \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=miko.lenczewski@arm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=oupton@kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peter.ujfalusi@gmail.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yangyicong@hisilicon.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox