From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54ABC48286 for ; Fri, 2 Feb 2024 02:55:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4664D6B0074; Thu, 1 Feb 2024 21:55:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 416C06B0078; Thu, 1 Feb 2024 21:55:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B72E6B007B; Thu, 1 Feb 2024 21:55:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19E976B0074 for ; Thu, 1 Feb 2024 21:55:15 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D119F1404E6 for ; Fri, 2 Feb 2024 02:55:14 +0000 (UTC) X-FDA: 81745347348.30.770F98A Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf01.hostedemail.com (Postfix) with ESMTP id C2FF340007 for ; Fri, 2 Feb 2024 02:55:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d+5Y5NiQ; spf=pass (imf01.hostedemail.com: domain of dianders@chromium.org designates 209.85.218.51 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706842512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z13JQPf9sQwxso1j5bT0m3SolbFlWDJreVTqe//zgDY=; b=dla82f41Xvq7k3iRMqT+NzIrIVtU1yS8HHuTgIY5R4A69VSSEI5PsP/KdfhoxU6uEsrQ4D Ic78PL8P2qAwiFpiSaIXO5a4yDBg5TXwBSVgL/REFnQYCf4dvub24VGTKcaKBUOjTvuIvB eNdj1QAeBwvUgkEnUFNjstgrnsxTZT0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706842512; a=rsa-sha256; cv=none; b=Tw9oqE9ZtWYe5QpdpND0mlANxs1Oq5wmI/MHm9uc7ujUMN01NYlxddiP6cpKSFj3vIcTkm frEQvTjYPtK2zOvmGIp+YfdBHAqFaDu/fUmJWLVTp7Ny4Bu6tswyNurZFzot2dEO2/LBao WYz14ubDylmPAvEQy9loUzBz5uqOZxk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d+5Y5NiQ; spf=pass (imf01.hostedemail.com: domain of dianders@chromium.org designates 209.85.218.51 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a3122b70439so228665566b.3 for ; Thu, 01 Feb 2024 18:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706842510; x=1707447310; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z13JQPf9sQwxso1j5bT0m3SolbFlWDJreVTqe//zgDY=; b=d+5Y5NiQyYdVt3YRoDEuinzCszxKG9TAZyWtTh276HHimGkubKxXMC89U31F0eAqmA TtZQqhNZa4vfBLdQNQiPnu9ysIfJkplw2UByFOd7KNdYSoETCpKmHnF7WTyNm9ohLZ3Z BIqqmFv2v+BtGnHbY90GAP1Mv/jGLfqzGYimg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706842510; x=1707447310; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z13JQPf9sQwxso1j5bT0m3SolbFlWDJreVTqe//zgDY=; b=G4KtLcLi408sESbTGCwMZWI3gmoME7GRa1XSHl5UKGuEnaYIQQ7lnnECoddaguuncE 9IpVsdxUhLT3LnZ8gS4oQK1HpYTM1g1wpQTmnMIPyiTXZSACpAu5o4uRM/Q9fHGYJoGa Gv14aUvWE9iHfRFiKkR4wDK5/WKbbY3+ClE672tloXrK0Z7X+jnb0hPXK4lRAlVh82Yu CtkOOpriX9x2zHya5J0n7HMOhoWPkfv9JJuK7cWYysd5fv5751QWWjr+gEgXnr39yDDL aEzRzS0m9LAzWXx0pc9A/Ho3pF6VbWRP60ewrnyJ1ljx7ystiwGOvHQ2GEpXcEYvbjDe t8+Q== X-Gm-Message-State: AOJu0Yz2R5dasq2x6mmV6KnU7rv5ydZX2CLdBCL6U/AyFAokqJWsa3WG S9yR358miL5fUz4s09qrsUal7s4K2cTSXdqetXOOWA1mdKjPgLPu0kJXDNwxMaCprvtI3oIaq5/ mMQ== X-Google-Smtp-Source: AGHT+IFv7hsfmM4k465a4Tl6dQwh33wd+bHi3caZr+stNLsKPzlhtf34Xc/by2dOBrXH70VcbG2JPw== X-Received: by 2002:a17:906:1c15:b0:a35:7132:26d5 with SMTP id k21-20020a1709061c1500b00a35713226d5mr4535949ejg.63.1706842509485; Thu, 01 Feb 2024 18:55:09 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU9tO1OtyDW9MdFLQM11TBwG11k1xj+sk3iQQJ5KFnYwWi40QTmEo6ib8nrWAnrnraly1sVxcqtp2UdDhUi8fQtaho= Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id h13-20020a17090634cd00b00a36ed37683fsm376474ejb.215.2024.02.01.18.55.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 18:55:08 -0800 (PST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40f00adacfeso15735e9.1 for ; Thu, 01 Feb 2024 18:55:08 -0800 (PST) X-Received: by 2002:a05:600c:500c:b0:40f:c537:9d5 with SMTP id n12-20020a05600c500c00b0040fc53709d5mr30164wmr.5.1706842508094; Thu, 01 Feb 2024 18:55:08 -0800 (PST) MIME-Version: 1.0 References: <20240201171159.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid> <20240202012249.GU2087318@ZenIV> In-Reply-To: <20240202012249.GU2087318@ZenIV> From: Doug Anderson Date: Thu, 1 Feb 2024 18:54:51 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] regset: use vmalloc() for regset_get_alloc() To: Al Viro Cc: Christian Brauner , Eric Biederman , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C2FF340007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u6py4wp6pyy4w6fxedqmtfi6shgu47xs X-HE-Tag: 1706842512-932423 X-HE-Meta: U2FsdGVkX1/9qlwv0SzpKRCferbm7R3U3xiTMA/KGb6NMUHT+ND6UZDuzkHIBaL687xXBNwesO0hQXmC7XasVYqEQYd7A+AwZT0hs2e1UNlegVvDF0cG2YfaZAY/HY+6aVFQxcr7wBCX133Pt220Ic0EUh6IXpPJazPP3CFCC08ebGPr597Iyg3uYDym2Qv9pLuGg2v+eMU3thasUY9q+WV4dsUipzRSttkaSlhNFcwmtufxwyRaA7nk4mQ6sn759QLzFGwgvidjape+UZVZ4OpY0YyOCbWTQqmyCenFTogTnsPtwMzDqc7vFvOrOJPeeqVxBjxf4aKLlZKdBeFUqkE21O3r2ypjnPExgXAz/mBAyv5OKsCJUhQDni3o04L+fP8W8qn+TRh6gMpyM+PCt43TufxwcA41JTmvGNoTitf/8/THz1kKb4QANnaOThzCedRGDILsUiZoDXIFMfjeRkbNH78ckGC1JcZb25UkjVd7l3EQZWPqMCTAG3wxJ0OVcX9DDqcSMTPc3yCubkGPxSJlgUKweMlabPjJdg0+VSTrm6HgJIet8k9hJ9s1PDbf3BnhOqAky73bD+mrVKL/EgXcTP+bJysiGLIw/L/RQh9zyrQOgST0iHBJs+G14I0FvgyyU2etHRwDx5xcNqbbV6H9+QmKeDsf1Ux/jaCZZrlO/eY5Km4o7x5jv1hh2j6ak/KEZSWd6fHrSRIqvE1DrJOk5mgwfDVxfYHFqZ8Ws1tBPD+a5pUr1Jkhld3f/USdGStiKkKBiwomxROzSS63opqSX3wObnH6B4dftmF9o4X51e3O6686FS68AZwZqPwhFOm5AdJBR3vUIsb0/qheOCQ1SudqemRq39AlAkrMLlIksHJECYOXeCdL0VpTOGdmOpoqLEBIfS9v4SylQkJy6bjya5SMjt66WaqD9e9+FCIqBM4Ox1KKC8HcbZZUR+xJx4dm/ktLniEswmHYsbj Nwvzti8d InKHb6NhHK3GXTasbddV2BnhSN9lsRtfuKj2WtCNK8XHmMjorOHZB2JcL928ceaiWpqB38NA/TRgqnHHnl2j3DxUhU3Q+upccBPRfASQ5QgWrLMMiO2qz0od6ddF3V5XAee6abYKoYfT/xCCeFjmU++6OSfbDzFh/YrRBs2IijVLnsRSkg3K1zSMHPUiwUhJS7o85j8Q4fD0Ek+7fBQbh1uYllg3Ui4CfIgmM23X0hSdPEQWeJ70lqfZ9QfLneZbI/CKvnR21yTcOGAbVq9icz+26TNnl0l+Rx+dCpB580AK4XKNTuVw3a04ctsZLn1RS2p5PGjEugpdnbmT5WjJXGTphhkT03RhW5If7qGSHkats9qu2lzmWnQ/IyY/RYzbUNwEZArfASVTCtB6adWsybkJ1Ww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Feb 1, 2024 at 5:22=E2=80=AFPM Al Viro wr= ote: > > On Thu, Feb 01, 2024 at 05:12:03PM -0800, Douglas Anderson wrote: > > While browsing through ChromeOS crash reports, I found one with an > > allocation failure that looked like this: > > > An order 7 allocation is (1 << 7) contiguous pages, or 512K. It's not > > a surprise that this allocation failed on a system that's been running > > for a while. > > > if (size > regset->n * regset->size) > > size =3D regset->n * regset->size; > > if (!p) { > > - to_free =3D p =3D kzalloc(size, GFP_KERNEL); > > + to_free =3D p =3D vmalloc(size); > > What the hell? Which regset could have lead to that? > It would need to have the total size of register in excess of > 256K. Seriously, which regset is that about? Note that we > have just made sure that size is not greater than that product. > size is unsigned int, so it's not as if a negative value passed > to function could get through that test only to be interpreted > as large positive later... > > Details, please. I can continue to dig more, but it is easy for me to reproduce this. On the stack is elf_core_dump() and it seems like we're getting a core dump of the chrome process. So I just arbitrarily look for the chrome GPU process: $ ps aux | grep gpu-process chronos 2075 3.0 1.1 34075552 95372 ? S