linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 7644/8126] drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'?
@ 2024-08-30 10:17 kernel test robot
  2024-08-30 14:15 ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-08-30 10:17 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: oe-kbuild-all, Linux Memory Management List, Douglas Anderson

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   985bf40edf4343dcb04c33f58b40b4a85c1776d4
commit: e0cb0c785250d0565c19ba17fc95bd7ab97670ba [7644/8126] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const
config: openrisc-randconfig-r022-20230730 (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408301813.TesFuSbh-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/panel/panel-visionox-vtdr6130.c: In function 'visionox_vtdr6130_probe':
>> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'? [-Werror=implicit-function-declaration]
     255 |         ret = devm_regulator_bulk_get_const(&dsi->dev,
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               devm_regulator_bulk_get_enable
   cc1: some warnings being treated as errors


vim +255 drivers/gpu/drm/panel/panel-visionox-vtdr6130.c

   244	
   245	static int visionox_vtdr6130_probe(struct mipi_dsi_device *dsi)
   246	{
   247		struct device *dev = &dsi->dev;
   248		struct visionox_vtdr6130 *ctx;
   249		int ret;
   250	
   251		ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
   252		if (!ctx)
   253			return -ENOMEM;
   254	
 > 255		ret = devm_regulator_bulk_get_const(&dsi->dev,
   256						    ARRAY_SIZE(visionox_vtdr6130_supplies),
   257						    visionox_vtdr6130_supplies,
   258						    &ctx->supplies);
   259		if (ret < 0)
   260			return ret;
   261	
   262		ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
   263		if (IS_ERR(ctx->reset_gpio))
   264			return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
   265					     "Failed to get reset-gpios\n");
   266	
   267		ctx->dsi = dsi;
   268		mipi_dsi_set_drvdata(dsi, ctx);
   269	
   270		dsi->lanes = 4;
   271		dsi->format = MIPI_DSI_FMT_RGB888;
   272		dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET |
   273				  MIPI_DSI_CLOCK_NON_CONTINUOUS;
   274		ctx->panel.prepare_prev_first = true;
   275	
   276		drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs,
   277			       DRM_MODE_CONNECTOR_DSI);
   278	
   279		ctx->panel.backlight = visionox_vtdr6130_create_backlight(dsi);
   280		if (IS_ERR(ctx->panel.backlight))
   281			return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight),
   282					     "Failed to create backlight\n");
   283	
   284		drm_panel_add(&ctx->panel);
   285	
   286		ret = mipi_dsi_attach(dsi);
   287		if (ret < 0) {
   288			dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
   289			drm_panel_remove(&ctx->panel);
   290			return ret;
   291		}
   292	
   293		return 0;
   294	}
   295	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 7644/8126] drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'?
  2024-08-30 10:17 [linux-next:master 7644/8126] drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'? kernel test robot
@ 2024-08-30 14:15 ` Doug Anderson
  2024-08-30 14:39   ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2024-08-30 14:15 UTC (permalink / raw)
  To: kernel test robot
  Cc: Neil Armstrong, oe-kbuild-all, Linux Memory Management List

Hi,

On Fri, Aug 30, 2024 at 3:18 AM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   985bf40edf4343dcb04c33f58b40b4a85c1776d4
> commit: e0cb0c785250d0565c19ba17fc95bd7ab97670ba [7644/8126] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const
> config: openrisc-randconfig-r022-20230730 (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 13.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408301813.TesFuSbh-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    drivers/gpu/drm/panel/panel-visionox-vtdr6130.c: In function 'visionox_vtdr6130_probe':
> >> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'? [-Werror=implicit-function-declaration]
>      255 |         ret = devm_regulator_bulk_get_const(&dsi->dev,
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |               devm_regulator_bulk_get_enable
>    cc1: some warnings being treated as errors

Oh! I think when I added devm_regulator_bulk_get_const() all those
years ago I didn't add an inline-noop version. Let me post a patch
now.

-Doug


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 7644/8126] drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'?
  2024-08-30 14:15 ` Doug Anderson
@ 2024-08-30 14:39   ` Doug Anderson
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2024-08-30 14:39 UTC (permalink / raw)
  To: kernel test robot
  Cc: Neil Armstrong, oe-kbuild-all, Linux Memory Management List, Mark Brown

Hi,

On Fri, Aug 30, 2024 at 7:15 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Aug 30, 2024 at 3:18 AM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   985bf40edf4343dcb04c33f58b40b4a85c1776d4
> > commit: e0cb0c785250d0565c19ba17fc95bd7ab97670ba [7644/8126] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const
> > config: openrisc-randconfig-r022-20230730 (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/config)
> > compiler: or1k-linux-gcc (GCC) 13.3.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408301813.TesFuSbh-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408301813.TesFuSbh-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/gpu/drm/panel/panel-visionox-vtdr6130.c: In function 'visionox_vtdr6130_probe':
> > >> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'? [-Werror=implicit-function-declaration]
> >      255 |         ret = devm_regulator_bulk_get_const(&dsi->dev,
> >          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >          |               devm_regulator_bulk_get_enable
> >    cc1: some warnings being treated as errors
>
> Oh! I think when I added devm_regulator_bulk_get_const() all those
> years ago I didn't add an inline-noop version. Let me post a patch
> now.

OK, I've posted:

https://lore.kernel.org/r/20240830073511.1.Ib733229a8a19fad8179213c05e1af01b51e42328@changeid

That should fix the issue. I assume having that go through the
regulator tree ought to be fine, though it will mean randconfig on the
DRM trees could keep hitting this failure until the DRM trees rebase
onto a kernel with the fix.

-Doug


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-30 14:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-30 10:17 [linux-next:master 7644/8126] drivers/gpu/drm/panel/panel-visionox-vtdr6130.c:255:15: error: implicit declaration of function 'devm_regulator_bulk_get_const'; did you mean 'devm_regulator_bulk_get_enable'? kernel test robot
2024-08-30 14:15 ` Doug Anderson
2024-08-30 14:39   ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox