From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B80C3271E for ; Mon, 8 Jul 2024 17:55:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06FC36B009A; Mon, 8 Jul 2024 13:55:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020556B009B; Mon, 8 Jul 2024 13:55:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E03136B009C; Mon, 8 Jul 2024 13:55:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE7366B009A for ; Mon, 8 Jul 2024 13:55:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4905941497 for ; Mon, 8 Jul 2024 17:55:00 +0000 (UTC) X-FDA: 82317336360.22.69F361C Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 3622040009 for ; Mon, 8 Jul 2024 17:54:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dT8v2sEy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of dianders@chromium.org designates 209.85.221.174 as permitted sender) smtp.mailfrom=dianders@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720461265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUxVyXvmH2ZHRP4WWiJD1IGEJI8jwRuhGplxULpfTlQ=; b=4FwX0at2+q67cKI7nZZEaZM0BGmb81juQIozqr95MV49eFw8uWl6Aflp16v7Ti0vCzbTxH s+cTTKYdKnX9Op4/Nc7ceWx2i3E0354qRErVRSYSFXwsKGkiyIHNCTXTPc2QHnyh7Cgo46 ugejkVpX9uTG1tVia0hi1cDZ8gaKqkQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720461265; a=rsa-sha256; cv=none; b=DwuyMuLJlcQXGmEbR3psfNw2QIsOEpkEqL2bugWVe0LFa4Y9ZRLB2D4mV1fLULSdrcNU0L YcT3Z+kZ/KxE6lrIwMHA0OtwfNiJSibz2yv8Ey0FNrOcxzpGMdG6tSZKzl5tP5euGdTEmR 0uvEc1m5AjMXQvaqNf/CukrKf8mk+b4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dT8v2sEy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of dianders@chromium.org designates 209.85.221.174 as permitted sender) smtp.mailfrom=dianders@chromium.org Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-4ef76f04977so1309397e0c.2 for ; Mon, 08 Jul 2024 10:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1720461297; x=1721066097; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XUxVyXvmH2ZHRP4WWiJD1IGEJI8jwRuhGplxULpfTlQ=; b=dT8v2sEyYfY/PNtXK19i8im5Q77o5REr05bylF7eX1rKp81goZTpSU0Yz65ruysozN /5pd9VOxaeFypcyuF7A6M099KvfHOVGdi0V0vy4pqcf4plMQK2vJAh3inNu57Xb7Yt+e 6gGFuuwZjzsUDKhD37T8YD+tQnlx8WdhyLQf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720461297; x=1721066097; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUxVyXvmH2ZHRP4WWiJD1IGEJI8jwRuhGplxULpfTlQ=; b=kCAFdtGeGKxb/1ZNB/DR3kMEi7ZUCfEkJU8tCHjfQOOJIDEtInQkq3lA2VUtBMuL/V 8v4Ni0hizWryZhCvjRXKRydC3R359EwcI8l/KVpp/NvHh0zW9WQpl+9rXeILAX4zxgMd qqtAzFgxnsrrgR0JFoqulFOmQV4mBsLYBvmqjfQ5yqmYE/OfIHlxGDOxvvTN/arWHImu lCRvavzStVXCItpwJNM0xDzTOgMCkIXZcD0gqPTSeVn0TGSX87qX0wJCTtvPEy92NZdE RlAo6swAfVGiXIABtEINefabAiDrR94VY8FRxsIERKqLwwdio5o4HE9lippYzZ+2Gt6R 81Wg== X-Forwarded-Encrypted: i=1; AJvYcCXPMtrPHgFIh2yD7z4pq+tDebSVZjPpTRaZdIpgGx3nMIGP5L0kqPWjNfodoFROgBGEcFBlAa35gpexXA5/Wm2IAqU= X-Gm-Message-State: AOJu0YyRy+Ju+0LHMEOv8iHJb0VrYvlHbR9GWV2nzY4rzzp1jYy+rj1Q JvMPfaL3xIyDLCp7P0+ykfVGikpqAEJrDe/clOSWUodANz88tPQxsdzZoy30cDQfG2JC8tnx8HY = X-Google-Smtp-Source: AGHT+IGXHYN7VzEvjBsUZRvoUt2cMI3IUns+WWb5l/ABxW6f7r5qIf07gqfInVg9HhlfFBfAKjxIMw== X-Received: by 2002:a05:6122:a03:b0:4ec:f8f0:7175 with SMTP id 71dfb90a1353d-4f33f2d3ed5mr352480e0c.11.1720461295198; Mon, 08 Jul 2024 10:54:55 -0700 (PDT) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b61ba8f797sm1454546d6.110.2024.07.08.10.54.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 10:54:54 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-44664ad946eso21671cf.1 for ; Mon, 08 Jul 2024 10:54:54 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWuE9JZduXaeYpecYpPFWoWp9ZCKEqRU0KZoNMS0oQkS8I6yfmBSHvhl2D3lIT6cv0Sh5zTjxXW/wqlEjq4v8Brgxs= X-Received: by 2002:ac8:5158:0:b0:447:e393:fed1 with SMTP id d75a77b69052e-447fc292838mr25411cf.7.1720461293738; Mon, 08 Jul 2024 10:54:53 -0700 (PDT) MIME-Version: 1.0 References: <137ec596-b946-4076-a0c4-30f3b3285e36@suswa.mountain> In-Reply-To: <137ec596-b946-4076-a0c4-30f3b3285e36@suswa.mountain> From: Doug Anderson Date: Mon, 8 Jul 2024 10:54:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 4298/8232] drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c:366 sharp_panel_remove() error: we previously assumed 'sharp' could be null (see line 365) To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Neil Armstrong Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3622040009 X-Stat-Signature: 3eu8jjmg9xmirjy6prctb5c39e8pfa61 X-Rspam-User: X-HE-Tag: 1720461298-332545 X-HE-Meta: U2FsdGVkX1+FeEsCA0qMqicpbytMJ/Of8nrwy1WexDgLdXoiJNv7R6k28VFKX4uPOBoagtn8inJTWiS+9EwVkGkbDkgRx8P9Y0ulqvlFMO983Hlr7l7RFOxb+iOaLXWnKDaB+ftgjYWRHDMcu3mSE01ujK+3EgYnXkmJi/iQjlqIcO0rZGq4Hi94pNdHBtAN8huXm11JWJuqGSToWe3sNRn9vRBSEyGc/v5YJY4VpDxaoApUbvCvecrbjigNujuTpmQRTlRky2NoMbSmlqfKFNjMqOOKhgyoB3skjPAFFn2SQlnCk5e/iBnl5f2aIFauae7PetTjQPqxXQRHG6ZIbUrtmJtwUiXHaQ+u2JxINiaxoi0Rt0SqdI0MMNd/nFw1xTCKii57dhc682D+ZMT1Dk4NYIsmWPLToV0DEtuwIIE37jU1goKUxE6o3KWWrisyGNsxIq9E0AUTIhHLXDOMQ7z2L0UnEYs1qTLkj/3xy+LzF4nIY3ld90WuxLzb4gR5myALlB0HGbUDgKlsiNdJgrr5/Yrzxujb6CNp3CSVKSClfnpNCPqhuN8Hvl4Ygj7N/EdxHFqGXWc0QHSbE1d7mESb1/iqg7/IVLqAYawS3aBxjucLZ/Xq5/i+W03Dmu2yNLLDcZpB3fbdVdPjI0cZj6odxuHjdqa7ubALQzI0Quo7ACW0I/R/r/mA8HfLjiHuNepaebo72H+rs4M8Fy0gLz91g57AEu8Y9ikvH9tIKF+kvsqHeaFvamP3uEza3BH1Qy0bRIlGeumDWftRbe8jdgj9br8vcfz8lkh9eagvKSOosFNgX+6SjhdzhYvUzZCzAx/GlicmOJ8S9DiLfCElNmIDfhMGRMEs2LXKtKOt1B1YqLK4YWTlZbPd0JS0QSBHwxYbGKo5ZjWYGbNu8A4m84BWV9h8VSSatmk5RARRXMj3XaGTaMDfgYiIXiWVU/Esjp+sBMjRBElyHpnaaHy hjIbKmIe k+dYVdR470WsUxBTFHESFHw+CKUWO4JUjtN7+Ubt8QZrsQKLxvychab0+FlwNOXxt/cYX1Gw1S1zXb5VKkSYasPf0/9jo+8OxLdfnEkgV+NBecAC6Tgfs477HvpJZGq/WlQaTAPTT+jKAClpKKwdB4rj4kDMQSt4CVYgHWkupXDVkjKIu7EeXUnLJZGMExiTcrEu7cEu7PR3DqyNERp5WNhfsq4P4NLlDzO7/8uG8KGrQkUaslMQJPKt7UogT7roN2FoKLYQDaBBAcAoYIAfeO9aZD6q29csrpWEoWQ8rFbnqoftKpgz42goHzLjbebgYx06Br0DPv2sA7TdeA+3qU6dS+819g8BD28IwNheiNlPudrdTyTIwnbBLa8pGwTrHLBUSNJwKn5GjWFYyI4H8L+ZLDZtXH/hWRcGDYcwziyWZtCzphIMdmMnceErW+NVMH7n9NmvDkyNooaTlkp1ZmMyEoyHuwE3+dRyXXHkSratwi8yeZ4OUZyPsQyV+d3vGWnpcJY50WByWCMTLcBS8Oby3kQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Jul 1, 2024 at 8:45=E2=80=AFAM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed > commit: d7d473d8464e7b9931c0b19f68ea0df807e01b4c [4298/8232] drm/panel: s= harp-lq101r1sx01: Don't call disable at shutdown/remove > config: x86_64-randconfig-161-20240626 (https://download.01.org/0day-ci/a= rchive/20240626/202406261525.SkhtM3ZV-lkp@intel.com/config) > compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202406261525.SkhtM3ZV-lkp@intel.com/ > > smatch warnings: > drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c:366 sharp_panel_remove() = error: we previously assumed 'sharp' could be null (see line 365) > > vim +/sharp +366 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c > > 79abca2b399009 Uwe Kleine-K=C3=B6nig 2022-07-08 355 static void sharp_p= anel_remove(struct mipi_dsi_device *dsi) > 1976dbca047ed7 Thierry Reding 2014-08-01 356 { > 1976dbca047ed7 Thierry Reding 2014-08-01 357 struct sharp_pane= l *sharp =3D mipi_dsi_get_drvdata(dsi); > 1976dbca047ed7 Thierry Reding 2014-08-01 358 int err; > 1976dbca047ed7 Thierry Reding 2014-08-01 359 > 1976dbca047ed7 Thierry Reding 2014-08-01 360 err =3D mipi_dsi_= detach(dsi); > 1976dbca047ed7 Thierry Reding 2014-08-01 361 if (err < 0) > 1976dbca047ed7 Thierry Reding 2014-08-01 362 dev_err(&= dsi->dev, "failed to detach from DSI host: %d\n", err); > 1976dbca047ed7 Thierry Reding 2014-08-01 363 > d7d473d8464e7b Douglas Anderson 2024-06-04 364 /* only detach fr= om host for the DSI-LINK2 interface */ > 1976dbca047ed7 Thierry Reding 2014-08-01 @365 if (!sharp) > > Reversed if statement? > > d7d473d8464e7b Douglas Anderson 2024-06-04 @366 sharp_pan= el_del(sharp); > 1976dbca047ed7 Thierry Reding 2014-08-01 367 } Indeed. Thanks for the catch. Fix posted at: https://lore.kernel.org/r/20240708105221.1.I576751c661c7edb6b804dda405d10e2= e71153e32@changeid