From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6101C433EF for ; Mon, 24 Jan 2022 21:43:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAB046B0092; Mon, 24 Jan 2022 16:43:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5A7A6B0093; Mon, 24 Jan 2022 16:43:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B21CE6B0095; Mon, 24 Jan 2022 16:43:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id A5DCF6B0092 for ; Mon, 24 Jan 2022 16:43:21 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6E1A390950 for ; Mon, 24 Jan 2022 21:43:21 +0000 (UTC) X-FDA: 79066507002.14.659A93C Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf07.hostedemail.com (Postfix) with ESMTP id EEEC240036 for ; Mon, 24 Jan 2022 21:43:20 +0000 (UTC) Received: by mail-il1-f174.google.com with SMTP id o10so15175869ilh.0 for ; Mon, 24 Jan 2022 13:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bwyi05nr6wT2ZFWR22PTFFEqIa15MbmZhLkPDJsvpx0=; b=RHC6VLVvqaubbaCRsVngcmpEX70I5qMnda30/M7WCCZwC5f0cqpQ3RymomMsBkULmw nf5/S3hSqeRVgjITKXpsUWSCPJ1zSs0WErq91oJeo4EwKAl5NWPxbZD95UmjUoLTZfxV UKqLgKCXjmYxAMpQTBGbu1bs6koOmgR3YMUPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bwyi05nr6wT2ZFWR22PTFFEqIa15MbmZhLkPDJsvpx0=; b=AHtZ4oxG3Dwth1aEMfzPjdhkT8fcZ5Cn2UG4pLRQJWCv/G/PbUAmFoQxWYfcE3cO0l efjrF25EF2Xp4FgrYQ5pPzeUMLpc5vSOxF815egDL0Tvv4qS4+rSZHs+o0cebHIEnD1q 8cg3/SEpgi4M2TivgSLB98O+9he5SKKLYdr7A1lN2G2iBtF4bBdg2TJS7qwOijD2syBb RlIzw7WxrLkmHEA15oMmXBF1nQJa40bsfM0tnorKMLMLCunB2NAAY4K8ZUZ9XRB1Eo9k 0YKpe1tA4cxDGVMDqSvqsETyvoYHdzm4kFYMHzwK1dFDVYjf70+ljDC5T5gaVYS+LP5v 12hQ== X-Gm-Message-State: AOAM533ortTQLrzMMBt9v1urL0JZ1YBOxo82GSzAy/ODi1JSaXXavQWf UN52MEC5POG60XS7MkJrALLGN0znLjnIfQ== X-Google-Smtp-Source: ABdhPJwsPz/Ckjm6J70BJ7hBFAx2mOcnJMTslV2dkvL2/de+C2Hx5IcEgc+CmNCDvJJnJgCIHJMmAw== X-Received: by 2002:a92:b306:: with SMTP id p6mr9720613ilh.127.1643060600057; Mon, 24 Jan 2022 13:43:20 -0800 (PST) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com. [209.85.166.51]) by smtp.gmail.com with ESMTPSA id d16sm513773ioi.51.2022.01.24.13.43.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 13:43:18 -0800 (PST) Received: by mail-io1-f51.google.com with SMTP id q204so6727880iod.8 for ; Mon, 24 Jan 2022 13:43:17 -0800 (PST) X-Received: by 2002:a02:9043:: with SMTP id y3mr7723156jaf.263.1643060597485; Mon, 24 Jan 2022 13:43:17 -0800 (PST) MIME-Version: 1.0 References: <848d857871f457f4df37e80fad468d615b237c24.1643015752.git.christophe.leroy@csgroup.eu> In-Reply-To: <848d857871f457f4df37e80fad468d615b237c24.1643015752.git.christophe.leroy@csgroup.eu> From: Doug Anderson Date: Mon, 24 Jan 2022 13:43:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] modules: Add CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC To: Christophe Leroy Cc: Luis Chamberlain , Jessica Yu , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "kgdb-bugreport@lists.sourceforge.net" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" , Jason Wessel , Daniel Thompson Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EEEC240036 X-Rspam-User: nil Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RHC6VLVv; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of dianders@chromium.org designates 209.85.166.174 as permitted sender) smtp.mailfrom=dianders@chromium.org X-Stat-Signature: yd8fnkhaf7jy9coi5kpyyck4ion6bcid X-HE-Tag: 1643060600-864315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Mon, Jan 24, 2022 at 1:22 AM Christophe Leroy wrote: > > --- a/kernel/debug/kdb/kdb_main.c > +++ b/kernel/debug/kdb/kdb_main.c > @@ -2022,8 +2022,11 @@ static int kdb_lsmod(int argc, const char **argv) > if (mod->state == MODULE_STATE_UNFORMED) > continue; > > - kdb_printf("%-20s%8u 0x%px ", mod->name, > - mod->core_layout.size, (void *)mod); > + kdb_printf("%-20s%8u", mod->name, mod->core_layout.size); > +#ifdef CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC > + kdb_printf("/%8u 0x%px ", mod->data_layout.size); Just counting percentages and arguments, it seems like something's wrong in the above print statement. -Doug