From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98E4C7618E for ; Wed, 26 Apr 2023 04:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B056B0071; Wed, 26 Apr 2023 00:55:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB126B0072; Wed, 26 Apr 2023 00:55:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 292A16B0074; Wed, 26 Apr 2023 00:55:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1786C6B0071 for ; Wed, 26 Apr 2023 00:55:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C937B80132 for ; Wed, 26 Apr 2023 04:55:55 +0000 (UTC) X-FDA: 80722329870.06.F4B2AA3 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf26.hostedemail.com (Postfix) with ESMTP id CBBB8140010 for ; Wed, 26 Apr 2023 04:55:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VLk8VpQu; spf=pass (imf26.hostedemail.com: domain of dianders@chromium.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682484953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z77Lp99KgcT2Wl/yW+5859xGJbOMQeZV3ZO2k95WTCU=; b=wAH962NSW6L33pL1XrMDDmsGWrQ+5zuJphqMIaFrcyRBqDTUeQJgoouHT7SFI8A4cQMLUV atuK/D64q6xcw1j0ZE4XOrirhAch4Bv2J/pYJaJNANkczzgCyhgbrF/ZGSZl1ub7EG64Q/ ybTZQJZ7oajjJspPW2PnpdZhSs2GG5E= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VLk8VpQu; spf=pass (imf26.hostedemail.com: domain of dianders@chromium.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=dianders@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682484953; a=rsa-sha256; cv=none; b=U91PMFJvYN1ApjnB3wFnvuaQkTYPIaiJgV64/yLl5uEJS+I/9fMYlUdb6Yimwq2hrIIglM JpTyJiRQC3+UL+Y96vi7NbvF7wCg5Y82XWaxOlgP2yM/P5JmeWjuIj5sDUGbYkvlQgKcDg fZrHOmcS+mzWZd+imUPv10fwNcHem1M= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-329518648ebso53400065ab.0 for ; Tue, 25 Apr 2023 21:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682484951; x=1685076951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z77Lp99KgcT2Wl/yW+5859xGJbOMQeZV3ZO2k95WTCU=; b=VLk8VpQu6VEqBB7XqGIgB69IlX3h8NQYLDTRFECqcCsPskaZ6J1TJrMxr1f1bUHXhu k9LdOLzuHBz8iR+3f8hu8vok/4fA10PLqQaqqQA6otP71gVO4bO9oAv+H4HwhYRBUv+q t2EMkIu9qSlgL1MnFJGN5XFv/vsoGgCrF1uTE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682484951; x=1685076951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z77Lp99KgcT2Wl/yW+5859xGJbOMQeZV3ZO2k95WTCU=; b=Z5vWnsY3XWXtJACDrZ7wRpj20ISYx6fYECSDe2jfReKO8t5POp6BKs8C/HNK0rcuw1 fQFH5NI9yorwEYtQkCtaI72unNqLgTR5CLA47mv3uDFiZl54wrbogxDi5iWR0zdvlIIq thoFej5gHzyIZZyOW+ZbOuNmM5dp0hr1hoh7TPv/g41xnmGsOjf25I20PPRgIF2c/pXA B69bNFRJo0Vk192AdIDzJBzWWCmVEp5qNxm3VZsASLw5PmVRdPiy2RjZNK93WNp+bWre UPitxOAbgBysVKYJe9mn0P9mM9AaP41zX724K5RG/i52fEkEc4LLfqZquS9RhLhcMfK3 9N7Q== X-Gm-Message-State: AAQBX9c0mieDlqvfO9/k8eM0429kqRya5OxFL1IlSfbfLH5nhh1QVZ5+ iCwMOY0KYXWFIU72v4cVNTAfmcgkWduWnyVisaI= X-Google-Smtp-Source: AKy350ZDPlHwpNqU3gqtITu3cK0NN5GEY4EIXknW5mnDprb897sx1o2s5M7BKDPHH0d4p11xCZ62Dw== X-Received: by 2002:a92:c747:0:b0:31f:9b6e:2f60 with SMTP id y7-20020a92c747000000b0031f9b6e2f60mr8213843ilp.4.1682484951264; Tue, 25 Apr 2023 21:55:51 -0700 (PDT) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com. [209.85.166.173]) by smtp.gmail.com with ESMTPSA id b4-20020a92a044000000b0032b0b3eceddsm3961027ilm.57.2023.04.25.21.55.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 21:55:50 -0700 (PDT) Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-316d901b2ecso200675ab.0 for ; Tue, 25 Apr 2023 21:55:50 -0700 (PDT) X-Received: by 2002:a05:6e02:1bc3:b0:32a:db6c:d51d with SMTP id x3-20020a056e021bc300b0032adb6cd51dmr192042ilv.12.1682484949689; Tue, 25 Apr 2023 21:55:49 -0700 (PDT) MIME-Version: 1.0 References: <20230421221249.1616168-1-dianders@chromium.org> <20230421151135.v2.1.I2b71e11264c5c214bc59744b9e13e4c353bc5714@changeid> <20230422051858.1696-1-hdanton@sina.com> <20230425010917.1984-1-hdanton@sina.com> <20230426044207.2378-1-hdanton@sina.com> In-Reply-To: <20230426044207.2378-1-hdanton@sina.com> From: Doug Anderson Date: Tue, 25 Apr 2023 21:55:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] mm/filemap: Add folio_lock_timeout() To: Hillf Danton Cc: Andrew Morton , Mel Gorman , Alexander Viro , Christian Brauner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yu Zhao , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CBBB8140010 X-Stat-Signature: hmbmtwiwsgas5zqjii3rhjsstj9q9ejf X-HE-Tag: 1682484953-897876 X-HE-Meta: U2FsdGVkX19x2y2Y7NZofoISh3bGT+LfC/is7jSh8CHLzcEqa/SImUic6Ky/adRdYV5y45kA7ZdJfskrpt/GD7Sm+5CPVVRE1LdCWzZ8XikNI2r4IN3paWI2t2Uv/nH6nhr8v4YVX566v+UY8iLjyH1F+LhoTSsxMpaiTre6tPtwmPosEt83YmxniQ2h/d8j/taWfJb5f9uAcEHVAH8HTtrbnVxnNatVMWDCpAgVUdArqc+zrEycOMQBHevLjWgGkiVX52oh9Gz09AUerhaq/gyrKEi0tqj/VeDe7QprYMBFFktqyBCTYoruc0LJqL6/eA+ate2s4K2TXleobcv0895GYhuoRDASXVzUVcM0r1sMB+cx3KRK/rxcu6agF6in2633Nc3LYKEa8awi7gX1PdkvR1+1NGO8A5l4dGzPKC/3VoMZ8xVtFbOwEgZRwaSoIgM6ds8oyBZISKNb3RXyBg1UxpfCBKpMo23N0iay7y16fsVd+bTDFO+3bdek/kuXDz0t0PeaS6118JOY+EwnEggmWVGeanQKXDY5TMefG07LDpF4JA6BP1I/huRMcG1EFMxzxrWpXMBKIXvGze+Yy0V3LeoIl70ymuM0m0cLodFkTrh53LAFcBaTbDPSYXsEUjjxaag7UeUy/z60x+GRKVb48IimHBhxf/eNddz83QONJ6fAN/5sYG4wf8IkkMbhWYHvJ2KdPOHD2UDJFCmUkwUQYeBlWtwxdOoym+9SpBYxuIIYK68+lwAIz/X6R4Dya7YaXf5pgBpEkZR5RfM5L8S9pgAUowp67TSwKu2l4zc3XZjsnvtWYwzdlz5hW5/6zygpz3n4AQhpC0KbLPtjorR8LReqh1gI4Y0XZPP7ngdfCllFsTL1h9aiGd3WO0ImEaLnj0yUJcmTD9EljF0yLWocMXH3yKXtACDGk5xyXQHC6O0Xk3JPj1uqE8JCodlxKCPBklGUPf4oN9zXHxz VPU8xvxx k3wN25e5a293ZgSd7zefZln1tPSg/kf82333GHQcyT04x5atG4DeS5OaLkTooSqkjesFkQHGIeCjihehvjcDqYmMbdMM8eoJPjOaher71+GyYb0vRpmrn9g3p0+Wk5ubKBqFaI0Y7Em1pOsnzUp3dcDb6gNeX3FNPTHw4rVtcPtZXhRtjxdS7LGc0hwGM9ZXyLChxz4zCoxDqLdVQq2abhWd+r5rEnrgZeGb2UqCeWo0moXSo9uTD9KeVhkze0ex0EPXthHQ5afGTqLirHuw61aH7rDRWuxO4aGLid/o7kqeLgm23812XZp4BXIzzCw+KINW/jcRHgCIox9QxEurv7/QUOU0bg01kmK1TCv6E8GeolxNJDjkwQK1GfuoMnH1t/pV4mvsELgQfdLPbpBywmfAH8lAFIqHA3czfAA7QCvxvaCre0ML2y6sp1eupzpO5I4tKvF2+pxgDsrcIFbwVIYQ86w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Tue, Apr 25, 2023 at 9:42=E2=80=AFPM Hillf Danton wro= te: > > On 25 Apr 2023 07:19:48 -0700 Douglas Anderson > > > > So is this an explicit NAK on this approach, then? > > Ah I see your point. You misunderstood because I dont think NAk is needed > in 99.999% cases, given the fact that 1) your patch will never be able to > escape from standing ovation 2) every mutex_trylock() hints the straws in= mind. I'm afraid I'm still super confused about what you're saying. You think I should abandon this patch series, or that it might be OK to continue with it? -Doug