From: Pengfei Li <lpf.vector@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christopher Lameter <cl@linux.com>,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mm, slab: Make kmalloc_info[] contain all types of names
Date: Tue, 10 Sep 2019 08:52:40 +0800 [thread overview]
Message-ID: <CAD7_sbHV=tXrZaBuQuifVznFMUf13hs7t_QcgFVmrCdMHT4Ytg@mail.gmail.com> (raw)
In-Reply-To: <3a95d20d-ccf9-bd45-2db3-380cc3e0cd17@rasmusvillemoes.dk>
On Tue, Sep 10, 2019 at 2:30 AM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> On 09/09/2019 18.53, Pengfei Li wrote:
> > On Mon, Sep 9, 2019 at 10:59 PM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> >>> /*
> >>> * kmalloc_info[] is to make slub_debug=,kmalloc-xx option work at boot time.
> >>> * kmalloc_index() supports up to 2^26=64MB, so the final entry of the table is
> >>> * kmalloc-67108864.
> >>> */
> >>> const struct kmalloc_info_struct kmalloc_info[] __initconst = {
> >>
> >> BTW should it really be an __initconst, when references to the names
> >> keep on living in kmem_cache structs? Isn't this for data that's
> >> discarded after init?
> >
> > You are right, I will remove __initconst in v2.
>
> No, __initconst is correct, and should be kept. The string literals
> which the .name pointers point to live in .rodata, and we're copying the
> values of these .name pointers. Nothing refers to something inside
> kmalloc_info[] after init. (It would be a whole different matter if
> struct kmalloc_info_struct consisted of { char name[NN]; unsigned int
> size; }).
>
Thank you for your comment. I will keep it in v3.
I did learn :)
> Rasmus
next prev parent reply other threads:[~2019-09-10 0:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:04 [PATCH 0/5] " Pengfei Li
2019-09-03 16:04 ` [PATCH 1/5] " Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka
2019-09-09 16:53 ` Pengfei Li
2019-09-09 18:30 ` Rasmus Villemoes
2019-09-09 19:48 ` Vlastimil Babka
2019-09-10 0:52 ` Pengfei Li [this message]
2019-09-03 16:04 ` [PATCH 2/5] mm, slab_common: Remove unused kmalloc_cache_name() Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka
2019-09-09 16:54 ` Pengfei Li
2019-09-03 16:04 ` [PATCH 3/5] mm, slab: Remove unused kmalloc_size() Pengfei Li
2019-09-09 15:07 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 4/5] mm, slab_common: Make 'type' is enum kmalloc_cache_type Pengfei Li
2019-09-09 15:08 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 5/5] mm, slab_common: Make initializing KMALLOC_DMA start from 1 Pengfei Li
2019-09-04 19:27 ` [PATCH 0/5] mm, slab: Make kmalloc_info[] contain all types of names Christopher Lameter
2019-09-05 0:40 ` Pengfei Li
2019-09-05 12:25 ` Vlastimil Babka
2019-09-05 13:51 ` Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD7_sbHV=tXrZaBuQuifVznFMUf13hs7t_QcgFVmrCdMHT4Ytg@mail.gmail.com' \
--to=lpf.vector@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox