From: Pengfei Li <lpf.vector@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Uladzislau Rezki <urezki@gmail.com>,
rpenyaev@suse.de, peterz@infradead.org, guro@fb.com,
rick.p.edgecombe@intel.com, rppt@linux.ibm.com,
aryabinin@virtuozzo.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] mm/vmalloc: do not keep unpurged areas in the busy tree
Date: Thu, 25 Jul 2019 22:21:34 +0800 [thread overview]
Message-ID: <CAD7_sbEGno-o=zh=VJQOXPZ=ppcTF3h_UWAXo6dXFnBJcTNTrA@mail.gmail.com> (raw)
In-Reply-To: <20190724193637.44ced3b82dd76649df28ecf5@linux-foundation.org>
Thanks.
Signed-off-by: Pengfei Li <lpf.vector@gmail.com>
On Thu, Jul 25, 2019 at 10:36 AM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Tue, 16 Jul 2019 23:26:55 +0800 Pengfei Li <lpf.vector@gmail.com> wrote:
>
> > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
> >
> > The busy tree can be quite big, even though the area is freed
> > or unmapped it still stays there until "purge" logic removes
> > it.
> >
> > 1) Optimize and reduce the size of "busy" tree by removing a
> > node from it right away as soon as user triggers free paths.
> > It is possible to do so, because the allocation is done using
> > another augmented tree.
> >
> > The vmalloc test driver shows the difference, for example the
> > "fix_size_alloc_test" is ~11% better comparing with default
> > configuration:
> >
> > sudo ./test_vmalloc.sh performance
> >
> > <default>
> > Summary: fix_size_alloc_test loops: 1000000 avg: 993985 usec
> > Summary: full_fit_alloc_test loops: 1000000 avg: 973554 usec
> > Summary: long_busy_list_alloc_test loops: 1000000 avg: 12617652 usec
> > <default>
> >
> > <this patch>
> > Summary: fix_size_alloc_test loops: 1000000 avg: 882263 usec
> > Summary: full_fit_alloc_test loops: 1000000 avg: 973407 usec
> > Summary: long_busy_list_alloc_test loops: 1000000 avg: 12593929 usec
> > <this patch>
> >
> > 2) Since the busy tree now contains allocated areas only and does
> > not interfere with lazily free nodes, introduce the new function
> > show_purge_info() that dumps "unpurged" areas that is propagated
> > through "/proc/vmallocinfo".
> >
> > 3) Eliminate VM_LAZY_FREE flag.
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
>
> This should have included your signed-off-by, since you were on the
> patch delivery path. (Documentation/process/submitting-patches.rst,
> section 11).
>
> Please send along your signed-off-by?
next prev parent reply other threads:[~2019-07-25 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 15:26 [PATCH v6 0/2] mm/vmalloc.c: improve readability and rewrite vmap_area Pengfei Li
2019-07-16 15:26 ` [PATCH v6 1/2] mm/vmalloc: do not keep unpurged areas in the busy tree Pengfei Li
2019-07-25 2:36 ` Andrew Morton
2019-07-25 14:21 ` Pengfei Li [this message]
2019-07-16 15:26 ` [PATCH v6 2/2] mm/vmalloc: modify struct vmap_area to reduce its size Pengfei Li
2019-07-16 15:58 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD7_sbEGno-o=zh=VJQOXPZ=ppcTF3h_UWAXo6dXFnBJcTNTrA@mail.gmail.com' \
--to=lpf.vector@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rpenyaev@suse.de \
--cc=rppt@linux.ibm.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox