From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16482CF9C69 for ; Sun, 22 Sep 2024 09:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44D0B6B007B; Sun, 22 Sep 2024 05:26:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE446B0082; Sun, 22 Sep 2024 05:26:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2B26B0085; Sun, 22 Sep 2024 05:26:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0E13E6B007B for ; Sun, 22 Sep 2024 05:26:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 84BBA40CA1 for ; Sun, 22 Sep 2024 09:26:23 +0000 (UTC) X-FDA: 82591843446.18.CED32D4 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf15.hostedemail.com (Postfix) with ESMTP id AFAD4A0004 for ; Sun, 22 Sep 2024 09:26:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ERWkeGmA; spf=pass (imf15.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=snovitoll@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726997065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v26B5rb0HebxXVZ1o6iq7edGSSdE/AhTSaSIaBxYmhw=; b=Y7yEJF+ZKRxYYi5ETzprUJEoVU8+cHIRHnZAYIpIn2LlPv1mwEw6VPi+23lGDp9YCMHfEo +PIO259jPEYV7bWw2OMesFPt/d0gQ+3+Qg4UOVifnS05hxnow7H1+1b0td50d+ROdHuvRW GoFb6dXyCGmhO12w/5z7pcD62s5pDc0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726997065; a=rsa-sha256; cv=none; b=bVfwSWLsVavUzai76nwArQaWmmBlZsOsMsXlWHccIEUfXJp3TIUfMM1p4t/hBxBJN1Rs3m txO82cVMz2ABkM+gstxXcsU4wZrLX6npXgPZhG0EvzjDFtPKXtAQJ2iBF04Uh6SqSEldFF YSK01FSpeurmC6uoQuqeBVh/v6Q9JZE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ERWkeGmA; spf=pass (imf15.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=snovitoll@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5c4226a56a8so4135474a12.2 for ; Sun, 22 Sep 2024 02:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726997180; x=1727601980; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v26B5rb0HebxXVZ1o6iq7edGSSdE/AhTSaSIaBxYmhw=; b=ERWkeGmApvwZ1QqZb3gI/3W2fHIbkDFELlA8spx6hrABZr3NwuFaCBbjkmB+EFgfCZ 9IJnBEiMos3ozSOgFNc4R9XfkEJ1eaG9ayrNYZV1pecUeujhqOs1PIrNkDtcl8oHEGgL woEMPbei27Ytax0+TeOlBK//NQkPucnuZIZP5pKmJk/lbI+75yOn1gagxs+NfoXlllkW XUMsNH85FzxWmAW6Cd2XYo39c7hp9p2L2jv8LTh9qvNmaer8RZx2HAZDsdSxGyfQi3fO bzY5oGFdpZZzZqt9U762DSUHae/M9iB33SdiPaECd0GDwNsMf5RUBgLw79Rx6XvQFzp6 qEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726997180; x=1727601980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v26B5rb0HebxXVZ1o6iq7edGSSdE/AhTSaSIaBxYmhw=; b=qB03x23YVHoeuVxRmYAYwXCjcVtZj3DegKr6uDm1ZzUP4tO+bCxybcOGj7/q8Wywif aruABi5E3sEoyevfJu7gHV+y/GZk/ubyiT6Q0Uz+od1C5D9K5qFW7xVOVwjTHTnX4SpK 5ch6NKS/4d+p5pV27ZQHRGz/Ba9c7XP2a6H7IDIi+veFkNGgMS59rFLEuPi+HcQnloYc sPgcEtGK/3TGXZKdNT5C+/pW5RDibLOZj2mQKkBaD4WR06rWA+H2CihnleE3uHETmBlx 0DEAkK6BlCAFLJn506Ljzvcstz4IFICWUMwyajlCrAobXVjHOhyIrylTPLMUt79rQNzs of0w== X-Forwarded-Encrypted: i=1; AJvYcCVPdZCVnUCmDZYybZd4L2RjWm4Y2mSzJT19cvLrEjs6xkWCx9pKeqyTce0V/Uv3FThR30GSFQxeyg==@kvack.org X-Gm-Message-State: AOJu0YzKm3PHJ8RILWQMc3VDBO6zGVyo/NrWYuUdAmuKmCV2EVhvY9i9 yZ44x1IYfhrKnvtgCuK4Lzb8bdb4AavM5NJS7mD5hYXRPREFbADTc282HdkgB+0LM1D/wbox+vl 52HpJmKJAELNfKIcICDyLmaK2wRk= X-Google-Smtp-Source: AGHT+IFpnZ0j5qe8qoIl4KNiJhsXbz758howSU6U8kdKpqsm6OzX/nclcj2AWWjGN+hxBzUALHmHh52w0qcxYzwJyWI= X-Received: by 2002:a05:6402:520b:b0:5be:e01c:6b5f with SMTP id 4fb4d7f45d1cf-5c464a7f4f4mr6878449a12.33.1726997179864; Sun, 22 Sep 2024 02:26:19 -0700 (PDT) MIME-Version: 1.0 References: <20240921071005.909660-1-snovitoll@gmail.com> In-Reply-To: From: Sabyrzhan Tasbolatov Date: Sun, 22 Sep 2024 14:26:54 +0500 Message-ID: Subject: Re: [PATCH v4] mm: x86: instrument __get/__put_kernel_nofault To: Andrey Konovalov Cc: akpm@linux-foundation.org, bp@alien8.de, brauner@kernel.org, dave.hansen@linux.intel.com, dhowells@redhat.com, dvyukov@google.com, glider@google.com, hpa@zytor.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@redhat.com, ryabinin.a.a@gmail.com, tglx@linutronix.de, vincenzo.frascino@arm.com, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: og1kceke3bjii1tw8ngc7o9baaiw3wux X-Rspamd-Queue-Id: AFAD4A0004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726997181-45679 X-HE-Meta: U2FsdGVkX1+8av222ESFmZc4KVu7J42RR2h41foAQQl/oBtxoc9h2PGlOLzoAWTrDUBlzHM0hYCbIaG1hxFT3p8SdbjlZ0mACHDhnYwMydRzZkc29mzJfBiAnwJGh86daXqDCgCvr/GFhqm64o3s22+/4ahyOxoBum5MAnX6zmRlvAikRtM+q5XVOnmBjnlWsiT2Z3gJKrQ4r/Bo8v3szyQyBZTFmvRWHSBSo3mWduMxn6HGlaX7dG9KBoMKBIsDZbrEdFhiAebjh6g7LF15PQLZRQFisU4dgOyYnMpg9N6KkNa46DG3kv22gdFmc31TcTuInHgAeyxrG0zFiERhocOBu7aaySoal/gedeqqXSTYHnK/caEj9vngApE3eZzJdd8eBQGGHLAn912HaN4jGheD9IM27rHHRb8ILmQKfzfEqZnj4swt3eWS4UYOQbUUEJtt0b2coslpBU0hdLLFpmW45SgPS98kboEwOKXI6BpX7SU/wymNi+d5AMuzgXCZ7qP5PF+bV9nx8kIzhgoSnb/vEy4OEPfAJz03JUte8pA81+S1+RGg3ZlN1Q/6vaueDMwgkhIwM7vuFoIG9D5pd50AQZCjgo1kEVzzBoEK5xEw89GkOi44gWt07BWMCfpag5uXLpGizzQAbcovKpq4hbW3hnwRDy5QRt/3zGq7CfuGDgdGFVxCfV4hgzVHgM08QMZKCgbLf7/ITMsFRSG0C3D2v5+tsCy8Rsozm4RPQZZTfIRMV+OrAbuaBgRe17mvNCfhHtlfqZhtnwcVvoICB7/ZCb3xTknQzQqhQWADQfyK1x1EMPIiOvVL+5XXXyNjzNSwRetEpJBwoGPH+fZfoc5p6gkMATPvNJ32lpIgePJoThKevcTi+CGfEaDlhiGn+AeuWFpATpLfCSG8s0zLbN4+382RHEG5WMUzblL/Qg4ZpuTsdSB5jXzJv9JDgamzmD8qigUrircXV3ekmcI gZRMlYGL qAZxExQMfNe/X3ovxgY9SyGf6eCdT1lLbd5sr4nJ9rMoGjk8ySly4j0nzVhq88FBkfSU5VJcmcN6YPSa+aziLqAhxJE1XUijJM88ONq5dY4ysChihrlbY/iMcExI/A7/DIKtvzsY770vYBBIbPNz8NDNyUIA3/aLuaW7YIL74+YaJq3AmqXNdCyMu/a0WZgU7SwVsoBv95z7jpN9AYX1Qgtf8cQ4IcHoUIGMAuQCpdr3yIGIVYIsdjOe/BHan0t989IqmSG9JSJONlB2hIeNwN1exEXIQyQlrZ+O2TrHLzZXiuOadpzEGIqnm1EEgovWeL5SgeX8Wqqy2AZVLO4+74sVQBbQRgfzvm+C5G1rHguCOJqC4ghr2D1QwU8sy3jENx5XkIinJHIVahyNpy3sg+df1KgcdfsIh6ZmQW9Q2vShgfVrA2/mDpYIvoY0FTvFr9r/eawFyoYkdvjVrr6YPnlltDNckdLBYvfM73zWV1xkJ8u3dU37eb90Nndyg0oqj+fu8MYjQTQ6puFo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 22, 2024 at 1:49=E2=80=AFAM Andrey Konovalov wrote: > > I tried running the tests with this patch applied, but unfortunately > the added test fails on arm64, most likely due to missing annotations > in arm64 asm code. Thanks for testing it on arm64. I've checked other arch and found out that only s390, x86 are using header with KASAN and friends in annotations. is in arm64 and x8= 6. While the current [PATCH v4] has x86 only instrumentations for __get/put_kernel_nofault, I think, we can take as an example copy_from_user solution here: https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/uaccess.h#L= 162-L164 , which should be a generic instrumentation of __get/put_kernel_nofault for all arch. I can try to make a separate PATCH with this solution. > We need to either mark the added test as x86-only via > KASAN_TEST_NEEDS_CONFIG_ON or add annotations for arm64. > > With annotations for arm64, the test might still fail for other > architectures, but I think that's fine: hopefully relevant people will > add annotations in time. But I consider both x86 and arm64 important, > so we should keep the tests working there. > > If you decide to add annotations for arm64, please also test both > KASAN_SW_TAGS and KASAN_HW_TAGS modes. Please suggest if the solution above to make a generic instrumentation of __get/put_kernel_nofault is suitable. Otherwise, for this patch as you've suggested, we can add KASAN_TEST_NEEDS_CONFIG_ON(test, CONFIG_X86); to make sure that kunit test is for x86 only and I can add arm64 kasan-chec= ks with SW, HW tags in separate "mm, arm64" PATCH.