From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD93CEFC42 for ; Tue, 8 Oct 2024 19:41:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA95F6B0092; Tue, 8 Oct 2024 15:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B327D6B0096; Tue, 8 Oct 2024 15:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D2FF6B0098; Tue, 8 Oct 2024 15:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CF8F6B0092 for ; Tue, 8 Oct 2024 15:41:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B6F3F40B4C for ; Tue, 8 Oct 2024 19:41:38 +0000 (UTC) X-FDA: 82651454760.05.BA3EACA Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf20.hostedemail.com (Postfix) with ESMTP id 3E1F61C000B for ; Tue, 8 Oct 2024 19:41:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CkW/mTyk"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728416398; a=rsa-sha256; cv=none; b=QQ1BzTetmPKmAac5e98yWQLFDQeCfrqF2jvxrrA68C1EsNMVDOYwwQfMbVCjVjgtV23x2o TFfAKZNyyAZogSdsBoT8lrr+8hExbuzav9mTqpFMZNCwbaZb/Fqv6UQ/XYbCHMqlj27GPI JcLqH8pdsDT4vg8eBzEqJ17BLPFDbvc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CkW/mTyk"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728416398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ubbmBflcQYl2zP8nv9YP3haRuCtPw16r/0MycKENL+U=; b=1S3TVRQYpKYfPMMVMflVrrnrKhJAeMydI/gKMub49exwzIMqnB/3NSvC58vAwo+sZ5Bxlg WFXzPQIybD88ltjyqIjG6+Oxb1dXjTD4HZcBtDljJ/EBB4sj29r+v3i9pX6/GxlnaUVmHM XlaRV0ZqWdwmrEXRrc6DlKoq/8dQZ84= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5399675e14cso7029767e87.3 for ; Tue, 08 Oct 2024 12:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728416496; x=1729021296; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ubbmBflcQYl2zP8nv9YP3haRuCtPw16r/0MycKENL+U=; b=CkW/mTykL7VAWIRQ8xf+mgrpWRi0A87kpxlN0EljLsrbEp6YwtRGa5V47ld18NIwwM Y9DPXz1y5my9bP+XuOWVhe/N3EB6xSM0dLQtInQpRGRb4EwpxHjovHQPcgNhBlrtbS7p 3Y7BghGByV3eHBaJA+YVo1dCEp4Vry7ZW0IZ/y7Z8TLHZWbSjQbAcU9Fi3QLvmMjb2aL //p3e+y/Xctrbwo2eHf5nZjH3qBg70lD2ZBKt3ymrujaeU7cb97N/Ngbn1iXvz9yC/l5 EjNQ0P4jjVWgkT9vEls6tAdp27l190v/LLxLEsASRysNjT+qODy0YyGyyfqphO+Wxhz0 4sbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728416496; x=1729021296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubbmBflcQYl2zP8nv9YP3haRuCtPw16r/0MycKENL+U=; b=oAAMVtRlArVotXaBQJNegGIJ7zvM7RC3WOxroeBT7Xz+SGCQ6yJgg2Fm3M1CbxqTEt yjtMQOXzIIDMLyqPlIMaaOS9GAvNea3brbzyJOkZydi1c8u6hGLsF7gQC4F1fR16s2Gz xtUt0ENUEhwiQ40rxCwRE+jqJUBZECKngBDPFHKhjaD5y7FPPpCNLXSEvoE/9Da4GQj4 FqbpHDfuR6XB5RzIz5tNXLa6FfXe9R7oFvspLp+c4N4fbNPDiy+fYdoos1zjuh522dTb aOgLvR87MhW7iYEn4g6vVTtfi1lR0OkzMjF473raWuaeW0eRFy8yEXm5W8TX3hQOqoT2 8v1Q== X-Forwarded-Encrypted: i=1; AJvYcCXs5ju2x7L8NL1xGP74ZN/fkmDKinX5GIVQ5xYk+p2isCO+0kkn8CUw8o9IIzWjMM9+WVwYoDeKTQ==@kvack.org X-Gm-Message-State: AOJu0YyKHTUT9UKWpTOE+b7onceiGvMWxZUfnWiRag7JaD8Bcnz1o5Cx N3rs9CzCDVNriTel4lK47GU5jK0zhyaIS2aMOvoUkA3fjKPmSXGEKU80HzEBZprfut4TLJfMUU8 Z80E3J6ZdGFSDy1CMBLBHpbtqAJo= X-Google-Smtp-Source: AGHT+IGqIxIVzVAfRF4E8lIehQu2QDm54fmsyMsTO2KtX3X0XxhDyaqYworH63hJ1HFcE0ofa436QIXdupAQ1EQQi6c= X-Received: by 2002:a05:6512:ba2:b0:536:9f02:17b4 with SMTP id 2adb3069b0e04-539ab9cf41bmr8639804e87.40.1728416496101; Tue, 08 Oct 2024 12:41:36 -0700 (PDT) MIME-Version: 1.0 References: <20241008192910.2823726-1-snovitoll@gmail.com> In-Reply-To: From: Sabyrzhan Tasbolatov Date: Wed, 9 Oct 2024 00:42:25 +0500 Message-ID: Subject: Re: [PATCH v4] mm, kasan, kmsan: copy_from/to_kernel_nofault To: Marco Elver Cc: akpm@linux-foundation.org, andreyknvl@gmail.com, bpf@vger.kernel.org, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryabinin.a.a@gmail.com, syzbot+61123a5daeb9f7454599@syzkaller.appspotmail.com, vincenzo.frascino@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3E1F61C000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: orc7qxyzs6akxixgityu3zyutusy5k1q X-HE-Tag: 1728416498-338679 X-HE-Meta: U2FsdGVkX18qVMDjq9Xf7znmQd2cwYtlp4rFJcLs8EP0V8hbc4ftyt0VA8tnIx77Pgn8OculdpV0b93O0LR8Hdx8V6nDJMrSy2heGC5VfSoFrLCo3+4DTWW3ulYWZJefuax54PJjphqhpX0muEuQ89Th1R7vGNtPMP6lxP5oKH/vB3XIYaZ6a1AFtsVdi4Jk7VmsxU4r72NsQD/7Bjd0Dh2borvVByZIpRiiCThmWEXIx8q2ZtgZ7tO4AzxXifqJ9cdhGds2RF6eFNP9NrDL7gmcHVpucAC5YeicRoI/f5wA+R8GyDYFKGYuVYgPvy0xFBNvrmWLK5Y7o4ZJ+WnKcx+S4rwTERC9OEyNt4uAL20eqRHS/1PH6HBvmVE7rCaPGRNTWhFzj782SF8IzaTxPREHxGw1fvbo1bDfBeNH9iisv8oyXdKQrldXMEtIKsowkD7WZSkQnChk4DzWzYlFFRXGWLjzwEjaW7fT/0cM9QrhtV/WgmJU0bEufCrn0ITCN+CmJ+VptmX9XVRmpfJcq1/JF29KLPdEagJLumlq4ycR/HMx6kPYjA2sHU4vzPyQDOg0IWotIYZ7IZp13v4zqfHUrqeLMUFAiFAxGSp4fzjNhNR4Se2l2Bw4k/eo1SskaO5u9LMxxere6yn6ZUbPddgortxBChHuxkk3sioOIjTgDqvD1CNT7NiPdc5Rm2wLO0WkDVtgTEq00hYZTFju8Ra8QSvlzk8A9QcQCebLP1FY+yZRc26y45zxvO+bH0FVRMc/eoHj6OKNzpEtjE4XISwAloV0w1lzhXipAGyh0gvNOwgsrwWperIErG2bq2sHQX3N57/1tIsvulyoVev9KISCXortVaraS9jnreLc/I2f9Yd9PnEXLuuqdkqZmzSOH485opBjAZzJkpLXsgxbyUrzV1Y791E02WOhB1gzYbsseyVgwR5ot9nw2OvY9SISKggVU4V2mFg/BHErh8F EJ5ChFWp fqpp2vRpWHjbuVNUcNfrbgPxjDYBfwf6rpRkHdZtmhl9l2eRNKmNCRTjfmCZ9GIbXA/L1qSs5lF3DG52LhkCveLMm3o5rtTTWi2tOQN5Anp39prEhjqlGemXhAMlgeB7O1dLiY1jC3xRddQ7OlJGI8qmCaOyeArNsW99sBs9QYTdZJo60AiZ8j33pVMWYoyPtfmfks3WTSzDwXRavdD/fYPIhUlA9Tmdmfxqe2/aRVMl8Ca7B3sx0HUTRQea3u4rxgtQzEW5p+B1ss56IGIIbM4De73FU1xzrBzxwbx5KOwKi87UDJpt/R1wXlxIYpNqgDqckbJbYGxjE/8Uq78hwSdGdKFmj3uV6K5OFIrBra5LbVAspvo0eEIhjDCRgpkNpX8Bh2OFHrjDj6jOua2osOOhYPlWBEycC5Bn8pz62v+xXmDGoKyBXXz2q42J2vgWUy7luy5IdkMz8piPkvmYhFmTSIewIIa8xEL7e14/x9Lk6xp/vHnk7gnvp8GCqKv2paZC2kyWrfG9MSW3maj9C/60dTJoFmBtv6cXVvO3Q0vBP8ZXygDZSqJB/vkPZNcwittobZv4DtEOpk8H2atjSh8HntFE1h3OcRtfkaVLqwGG9J7gff33Qf5/PhjTL1XiTbW86E+EN51c3Q6SWtFS27SsnlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 9, 2024 at 12:34=E2=80=AFAM Marco Elver wrot= e: > > On Tue, 8 Oct 2024 at 21:28, Sabyrzhan Tasbolatov w= rote: > > > > Instrument copy_from_kernel_nofault() with KMSAN for uninitialized kern= el > > memory check and copy_to_kernel_nofault() with KASAN, KCSAN to detect > > the memory corruption. > > > > syzbot reported that bpf_probe_read_kernel() kernel helper triggered > > KASAN report via kasan_check_range() which is not the expected behaviou= r > > as copy_from_kernel_nofault() is meant to be a non-faulting helper. > > > > Solution is, suggested by Marco Elver, to replace KASAN, KCSAN check in > > copy_from_kernel_nofault() with KMSAN detection of copying uninitilaize= d > > kernel memory. In copy_to_kernel_nofault() we can retain > > instrument_write() explicitly for the memory corruption instrumentation= . > > > > copy_to_kernel_nofault() is tested on x86_64 and arm64 with > > CONFIG_KASAN_SW_TAGS. On arm64 with CONFIG_KASAN_HW_TAGS, > > kunit test currently fails. Need more clarification on it > > - currently, disabled in kunit test. > > > > Link: https://lore.kernel.org/linux-mm/CANpmjNMAVFzqnCZhEity9cjiqQ9CVN1= X7qeeeAp_6yKjwKo8iw@mail.gmail.com/ > > Reviewed-by: Marco Elver > > Reported-by: syzbot+61123a5daeb9f7454599@syzkaller.appspotmail.com > > Closes: https://syzkaller.appspot.com/bug?extid=3D61123a5daeb9f7454599 > > Reported-by: Andrey Konovalov > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D210505 > > Signed-off-by: Sabyrzhan Tasbolatov > > --- > > v2: > > - squashed previous submitted in -mm tree 2 patches based on Linus tree > > v3: > > - moved checks to *_nofault_loop macros per Marco's comments > > - edited the commit message > > v4: > > - replaced Suggested-By with Reviewed-By: Marco Elver > > For future reference: No need to send v+1 just for this tag. Usually > maintainers pick up tags from the last round without the original > author having to send out a v+1 with the tags. Of course, if you make > other corrections and need to send a v+1, then it is appropriate to > collect tags where those tags would remain valid (such as on unchanged > patches part of the series, or for simpler corrections). Thanks! Will do it next time. Please advise if Andrew should need to be notified in the separate cover le= tter to remove the prev. merged to -mm tree patch and use this v4: https://lore.kernel.org/all/20241008020150.4795AC4CEC6@smtp.kernel.org/