From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by kanga.kvack.org (Postfix) with ESMTP id BB2016B0190 for ; Fri, 18 Oct 2013 18:16:32 -0400 (EDT) Received: by mail-pd0-f181.google.com with SMTP id y13so5386851pdi.26 for ; Fri, 18 Oct 2013 15:16:32 -0700 (PDT) Received: from psmtp.com ([74.125.245.138]) by mx.google.com with SMTP id ln9si2498371pab.73.2013.10.18.15.16.31 for ; Fri, 18 Oct 2013 15:16:31 -0700 (PDT) Received: by mail-vb0-f53.google.com with SMTP id i3so2142052vbh.40 for ; Fri, 18 Oct 2013 15:16:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20131015001826.GL3432@hippobay.mtv.corp.google.com> <20131015110905.085B1E0090@blue.fi.intel.com> From: Ning Qu Date: Fri, 18 Oct 2013 15:16:09 -0700 Message-ID: Subject: Re: [PATCH 11/12] mm, thp, tmpfs: enable thp page cache in tmpfs Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Hugh Dickins , Al Viro , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , Hillf Danton , Dave Hansen , Alexander Shishkin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hi, Kirill, I have reviewed the current migration code and seems huge page will get splitted during migration. Since our current split_huge_page handle file cache as well, it seems not a problem for us? We just simply not removing the __GFP_MOVABLE flag? Anything else I am missing here? Thanks! Best wishes, --=20 Ning Qu (=C7=FA=C4=FE) | Software Engineer | quning@google.com | +1-408-418= -6066 On Fri, Oct 18, 2013 at 11:24 AM, Ning Qu wrote: > I guess this is the last review I have for this around, but not sure > what's the best solution right now. > > Kirill, do you think it's OK to just split the huge page when it will > be moved. Will look into how thp anon handle this situation. > > Then after this, I probably will post v2. > > Thanks! > Best wishes, > -- > Ning Qu (=C7=FA=C4=FE) | Software Engineer | quning@google.com | +1-408-4= 18-6066 > > > On Tue, Oct 15, 2013 at 11:42 AM, Ning Qu wrote: >> I agree with this. It has been like this just for a quick proof, but I >> need to address this problem as soon as possible. >> >> Thanks! >> Best wishes, >> -- >> Ning Qu (=C7=FA=C4=FE) | Software Engineer | quning@google.com | +1-408-= 418-6066 >> >> >> On Tue, Oct 15, 2013 at 4:09 AM, Kirill A. Shutemov >> wrote: >>> Ning Qu wrote: >>>> Signed-off-by: Ning Qu >>>> --- >>>> mm/Kconfig | 4 ++-- >>>> mm/shmem.c | 5 +++++ >>>> 2 files changed, 7 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/mm/Kconfig b/mm/Kconfig >>>> index 562f12f..4d2f90f 100644 >>>> --- a/mm/Kconfig >>>> +++ b/mm/Kconfig >>>> @@ -428,8 +428,8 @@ config TRANSPARENT_HUGEPAGE_PAGECACHE >>>> help >>>> Enabling the option adds support hugepages for file-backed >>>> mappings. It requires transparent hugepage support from >>>> - filesystem side. For now, the only filesystem which supports >>>> - hugepages is ramfs. >>>> + filesystem side. For now, the filesystems which support >>>> + hugepages are: ramfs and tmpfs. >>>> >>>> config CROSS_MEMORY_ATTACH >>>> bool "Cross Memory Support" >>>> diff --git a/mm/shmem.c b/mm/shmem.c >>>> index 75c0ac6..50a3335 100644 >>>> --- a/mm/shmem.c >>>> +++ b/mm/shmem.c >>>> @@ -1672,6 +1672,11 @@ static struct inode *shmem_get_inode(struct sup= er_block *sb, const struct inode >>>> break; >>>> case S_IFREG: >>>> inode->i_mapping->a_ops =3D &shmem_aops; >>>> + /* >>>> + * TODO: make tmpfs pages movable >>>> + */ >>>> + mapping_set_gfp_mask(inode->i_mapping, >>>> + GFP_TRANSHUGE & ~__GFP_MOVA= BLE); >>> >>> Unlike ramfs, tmpfs pages are movable before transparent page cache >>> patchset. >>> Making tmpfs pages non-movable looks like a big regression to me. It ne= ed >>> to be fixed before proposing it upstream. >>> >>> -- >>> Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org