From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5332CC43457 for ; Mon, 19 Oct 2020 15:36:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 61D0122269 for ; Mon, 19 Oct 2020 15:36:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="OPuMySIm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61D0122269 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DFC96B006C; Mon, 19 Oct 2020 11:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F6D6B0070; Mon, 19 Oct 2020 11:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A4FA6B0071; Mon, 19 Oct 2020 11:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 280E36B006C for ; Mon, 19 Oct 2020 11:36:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AAD261EE6 for ; Mon, 19 Oct 2020 15:36:37 +0000 (UTC) X-FDA: 77389077234.28.crown68_3907d8127238 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 833046C04 for ; Mon, 19 Oct 2020 15:36:37 +0000 (UTC) X-HE-Tag: crown68_3907d8127238 X-Filterd-Recvd-Size: 5127 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 15:36:37 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id dt13so14489264ejb.12 for ; Mon, 19 Oct 2020 08:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=onrZ6MqKZQYugiZRhPrx/puGjm6VAH61dsZd9uPcrso=; b=OPuMySImIzUpeT8yCTc/Aia2vCvoCADJQwDpCr58eGthIOkm364cQWp/rjc11N2gbi cc0uPqqyN0G3ct/1MrbEoQ1mcQPONcsNTnUO5EnqPb5hctESG8IajT3lVlehFDfZ+Qjy AkCNNUA5QEbQJ+Z63sgfMzU1pWPnK58gVZjT+Xf9hVXs1gCMls6uuOnACWkIP6SqqEDp orOVYHtiJrcbjeTFCoNh74ne2DXVR88H+y3byp36bBc2/d5CVkgSywu5PHVreR/xQeX2 zH9cKpbeVw302v+KNseGKRMnLAn65U1zv16ZlKfFfiILV4RLj8Nf1ep/X7HOitwUzOFU b8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=onrZ6MqKZQYugiZRhPrx/puGjm6VAH61dsZd9uPcrso=; b=HFikzHNObTWEFxapvKqYdCANJHludS1fOt8BVckKT4LJOCCZzdHRiCoXmjcYv9BGPf V2vr5xh+5mvypglqUFe2tAe/JE2MOPiDoxM0ItBzkewqqwr1Xa93M4YkuDTt3+banokE RCkZangN2s15tellLiUg8lnTHQ1/dHACq4iHW9BOklgWJ4MRSrkM4nfjF0PWBog4IIGU q9H01y85+bHWLuxzJ+E3YqCCihvoEEjNXHBSzgGwc0sr+1SdcoAJ3i/xhDaYDTLkhybL 4x7ieDc0ecT7/VUPXiZsecWTeup4u+MKG8m1sG8V8TT2dpYU6c3yu/i04W2G6J2HunU9 GxZQ== X-Gm-Message-State: AOAM532Y9o3eiwp7TZ2ejctElbV44yh4evx0/JqB5jvwCGLIZCemKcYH gYKdCa4QNOwqHfAYENLrl4bYNmhBFdJApvzHNQAR X-Google-Smtp-Source: ABdhPJy54nUonyqqCOK5mdNhg9zY84T9Kb140pAqyMLAa7eDgYbnzLJ9e0DwZsI3NYNgojGdE10rlVM0G95DnNBQfoE= X-Received: by 2002:a17:906:b087:: with SMTP id x7mr442447ejy.1.1603121795803; Mon, 19 Oct 2020 08:36:35 -0700 (PDT) MIME-Version: 1.0 References: <20201019145623.671-1-xieyongji@bytedance.com> <20201019145623.671-2-xieyongji@bytedance.com> <20201019151418.GT20115@casper.infradead.org> In-Reply-To: <20201019151418.GT20115@casper.infradead.org> From: =?UTF-8?B?6LCi5rC45ZCJ?= Date: Mon, 19 Oct 2020 23:36:24 +0800 Message-ID: Subject: Re: [External] Re: [RFC 1/4] mm: export zap_page_range() for driver use To: Matthew Wilcox Cc: "Michael S. Tsirkin" , jasowang@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Content-Type: multipart/alternative; boundary="0000000000002bda2f05b207e15d" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000002bda2f05b207e15d Content-Type: text/plain; charset="UTF-8" On Mon, Oct 19, 2020 at 11:14 PM Matthew Wilcox wrote: > On Mon, Oct 19, 2020 at 10:56:20PM +0800, Xie Yongji wrote: > > Export zap_page_range() for use in VDUSE. > > I think you're missing a lot of MMU notifier work by calling this > directly. It probably works in every scenario you've tested, but won't > work for others. I see you're using VM_MIXEDMAP -- would it make sense > to use VM_PFNMAP instead and use zap_vma_ptes()? But I didn't see any difference between zap_vma_ptes() and zap_page_range() about MMU notifier. Could you give me more details? Thanks, Yongji > Or would it make sense > to change zap_vma_ptes() to handle VM_MIXEDMAP as well as VM_PFNMAP? > > --0000000000002bda2f05b207e15d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable --0000000000002bda2f05b207e15d--