From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BED0C27C53 for ; Wed, 19 Jun 2024 05:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C14966B015B; Wed, 19 Jun 2024 01:25:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC3706B0160; Wed, 19 Jun 2024 01:25:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64136B0164; Wed, 19 Jun 2024 01:25:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8132B6B015B for ; Wed, 19 Jun 2024 01:25:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 336D6A018F for ; Wed, 19 Jun 2024 05:25:59 +0000 (UTC) X-FDA: 82246501638.27.EBC35A5 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf13.hostedemail.com (Postfix) with ESMTP id 65C522000E for ; Wed, 19 Jun 2024 05:25:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sZM+c76k; spf=pass (imf13.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718774754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwQGsaeVkR2wdQtFm/A8WK6CqmtUyAoP0AL0lGKk5Q0=; b=AceP9TdOkzry7kGK9zHWoCZHW2N/pUy26Nrv+cW+bPU7Kl+frxos5gH2shXvloeEXUjVMT ZZTltxIqOxLQmCoxkPl2FQxt8zcTN3Kxy+35oi5Y9maUZ/796e/d7jDbb5r2ex/cEmnjfj ls+GSn3CnDmy205PCzpvklc/dCdoOkg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sZM+c76k; spf=pass (imf13.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718774754; a=rsa-sha256; cv=none; b=ZV6B6FFUfnC4ZS0FKU9VWRPsTU9N5fJHrBrCb4fXcKKhxNCifrtj9wC+A5yG5jZFcK23fp LCitB5+ABhZPD18fBQEplhrL0lVMp86dx9Gpk9JD2P30cqUoAfuTEDRBpwZuvoftLV91QC 26qXtbe3Sb1VVH/sCIZvGQ5CRoIenxg= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-421b9068274so55724175e9.1 for ; Tue, 18 Jun 2024 22:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718774756; x=1719379556; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uwQGsaeVkR2wdQtFm/A8WK6CqmtUyAoP0AL0lGKk5Q0=; b=sZM+c76kqc434QW6kl3YkNo2+n3Il6gDJj4d6yfFaEMFRbL8zugJoS5e4kBw5J7Ffw jSvEH4sezT7MTWpGyYi53I4CM16PwVJDJ/wIP0d2LuCnfwFAM9nMdONRdIPP2gIBHlON Q6uKDYXp0gL0ucLDDzTeb86ZAC8jAwUbb4tBbtrSZ9XkLiiv5kd4hXMn4uUGpx4FK5vD YRXGWItgolsjaezD5VwIlpilyfoPF3E29/SVSK1pPRgiO9BiIVsVJMJvY3N4bTYsHbSR 4yqmzrTbxBfDTecPsOfjwqjiUyLOINEtzXgxYqK6u1XivG1Umq2IkJCVt1r4d3hLf6A0 DiXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718774756; x=1719379556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uwQGsaeVkR2wdQtFm/A8WK6CqmtUyAoP0AL0lGKk5Q0=; b=kUacfbv+JH0m/8mSwJ59xQF1+Toyn+Y4mzPM/znB1N2frdC3IgVSevSxlIJjDVBPto r1VRYJTBTYHsWS2I2nSi3HlOMabnOt5GcEQMNUT5xcRpA7gsQsGQsviep26bNrlMLOB9 R+6lzMfKRLVi6ol3qvk90yr8my50eJ+pJ75go2gBsyk4f90sw/6kBa2+Au7AeAAks4Rn 4uKLso4+zhJOb0ZWCjPtvM1x5U3b3wDi3SAIqEmIjwscMf/srBc40oSukiUq1ijebbkI WEbyuSZgTlL9XGT2iDim+zmefy1l2h7DsbM+QGdkoCpu0YvPdPh7p2ONpdA+3tqMui1o PPVw== X-Forwarded-Encrypted: i=1; AJvYcCUBn7sSE29z6fEnb0nCsGRAwhmjE30yzO7bQ7nXWI9MqpevXnTyaw7BS50sMlvZcsGBck1BwuozKpCFXwjzQf77CiE= X-Gm-Message-State: AOJu0YzCdG1AYHWV3DaJwQUmP/UEHh8UKYw74uPTv5DDGQguesLj5MtR kS8NN68zE4fEW7IzzlByqfCAb79xvGHZIPEDiZKdE6joH/6b34bDOI88MFoCge+w4no3neaF+rc CNmKxNqz0RuvjQTDiGOzqSNsV94lTsieoL3RI X-Google-Smtp-Source: AGHT+IHIJAsmZ4zkrcutJrcSMRBI2Bt/fiEgHmTrXDGLrPqmD2yvGF4Y0K9pp6S1TS65bsqrBUo/eSG0vK+aIBsGNDQ= X-Received: by 2002:a05:6000:144:b0:360:746b:6015 with SMTP id ffacd0b85a97d-363170eca2bmr1114580f8f.11.1718774755356; Tue, 18 Jun 2024 22:25:55 -0700 (PDT) MIME-Version: 1.0 References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> In-Reply-To: From: Jiaqi Yan Date: Tue, 18 Jun 2024 22:25:43 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages To: Oscar Salvador Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 65C522000E X-Stat-Signature: ticrda1d6861b3g7tm135114wa8xxtsn X-HE-Tag: 1718774757-306336 X-HE-Meta: U2FsdGVkX18PRfyI/2Fd+oRjv77Wic6laR8q4n17BDNS1Ff6qsDO04xxrGDWqmjV2JjOGqCfSmPFFidHD417Z/9oBPHpa0kvUXyE/I3slwPhXtjnsCRk7f9p+kUB2vCzOyWiXg5X4wq9uLEzzsEIpyos069Alc806b3eyDdiOt4bSLuNHag54/tQol0P52aN7lfneWjp7pfO94ThekgdERgSgCBaFbdj4OVzji8ydiNivpFFDAF/XnnNQMDkbIA+oe2B2HBetlGHDRwL5X5ol6uy5C+W0XazUljrQux4RFwRqB7XPParMza5vXYkFp2Hg4KUoB7CK9rd0Of0tzwOsejEYQ1jEQ62/ygnmC4bnHVlFrGdc4GcWSniI6hmY2LIG5OLvidGBVbldCjHBk2fYVSkGn/xm4NKjKFy55UkcqmAhiTYq4SMWjLPdKkWdXSQz/Qv2O1wIedF7t3sIeUXGKXlPvJxD4M8uMRcyweDOiTXSuyWPGfmsEo2kIjJetHgZ+DbF0oE8lrd4OphowCIO+Ts+6d/a+DRGowdWMLYFJIaBdLoiBVxnZWTxsH7GY4sukI7AULhkrUTQ3l/IErhpoBNYGpz0fyB4YeJFscmKFb+kMYbKnSs75L6ThrcZPcsjAjD9JaBCnyBfOi76y24p+HcWog/UOaxetZuUKEBQNdweDsT4JhGJsPvHeQqMvn+QK+eZlxO5jJ+cIa4THodWjswbC2wQ9UIA3JpCe/6XtgFy9HoCv31cUXRvnBdlwkusp2SqPU6e5Tv9b/610wAz8406MtNLIDKFqjD9WdG98JKUu3h72Lzg2GWMkQ5BeWtE7Fmz0T05+0GncJj57LWBwVHz47QqVXe66E05pbHzHg7rxzj7hAJ+UMs7H77SCuPSxXA9oqS9AXY9V6h43FeAaQwKMfYYZFJ6Lnw302xP8pSgwlEjLoHMWJ33G9K86thCbv3U1KHIoVTOjjdJKj E084kPny mjpdWGJHyFmSzMAK+JyaNLYyWumcPHiP4r4+3RDyTCuwcDlbpIuLw1WNC+2o0f5IYOHkRF42WqKpXr0CXsk+7mWywNY6Y/dLrK53RKDw/z9LToxqZRuZo8y6NA6LuCs2TvOjfoGyj8lcZD0lSAvZP+PJA6nXwTY9fn8AdP1ARSKOXNIjg8OGUpKX1qr5pHsNtDweu5LgElc29+tI+aUCoLeepoaFxYBBHM8DKY1p2/GbtpoGSHPmLq+OJmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.023661, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 10:03=E2=80=AFPM Oscar Salvador = wrote: > > On Mon, Jun 17, 2024 at 05:05:43PM +0000, Jiaqi Yan wrote: > > - * Returns 0 on success > > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event > > + * Returns 0 on success, > > + * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > > + * -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline= , > > * < 0 otherwise negated errno. > > * > > * Soft offline a page, by migration or invalidation, > > @@ -2783,6 +2795,12 @@ int soft_offline_page(unsigned long pfn, int fla= gs) > > return -EIO; > > } > > > > + if (!sysctl_enable_soft_offline) { > > + pr_info("%#lx: OS-wide disabled\n", pfn); > > + put_ref_page(pfn, flags); > > + return -EOPNOTSUPP; > > + } > > We should not be doing anything if soft_offline is disabled, so this chec= k should > be placed upfront, at the very beginning of the function. > Then you can remove the 'put_ref_page' call. I think if MF_COUNT_INCREASED is in flags, we still need to put_ref_page(), right? > > > -- > Oscar Salvador > SUSE Labs