From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D5FC54E65 for ; Wed, 28 Aug 2024 16:10:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 290FF6B0083; Wed, 28 Aug 2024 12:10:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241836B0085; Wed, 28 Aug 2024 12:10:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130796B0088; Wed, 28 Aug 2024 12:10:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E92986B0083 for ; Wed, 28 Aug 2024 12:10:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A66201C214F for ; Wed, 28 Aug 2024 16:10:52 +0000 (UTC) X-FDA: 82502142744.06.4AE2EF8 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf06.hostedemail.com (Postfix) with ESMTP id AB544180004 for ; Wed, 28 Aug 2024 16:10:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Voxa1Y1r; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724861362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pUxW3H51tdCti7975tz1MGr7ixTkv8/Vj6O0jDTq5hM=; b=CPBaeMqNR8vNWdzryL92awpeW+Ui95tRwxmZMQz1QBZZb8GzJAA7CXe6iVrPNOxVc9Dz56 S25P0Z3C44A9yPhRO/K4eMjdxF1sRp165uW+o5IdKCRwuzq8+t5OmiSl6j50mQr4/2P/Nh 1meoNuAUaKnHSEQV5PfpDYFM0Db2RIg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724861362; a=rsa-sha256; cv=none; b=msUe/iryxbaDydbv70+X3IdwSQZJ7nfbOmnw3pZrsI+ZnQzmIeQqHy8x2qoiQLd/jXGWWF ctIHr1vdEHnJFarwtSPAo58t3YEOYtuwDta50RxLVRS2QWdPrMkTLdefXV07sFPxsSNPNK Q8HG9mlBj8WKSXUuvtoKDhNBS1ovJ4o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Voxa1Y1r; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-427fc9834deso70745e9.0 for ; Wed, 28 Aug 2024 09:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724861449; x=1725466249; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pUxW3H51tdCti7975tz1MGr7ixTkv8/Vj6O0jDTq5hM=; b=Voxa1Y1ro/KPoaXs1G70v8zUQsqfZlJTJX+qGdSWq+zl8ffJ0nDaYnmiNQt/gLsQsZ 94V5GNKALzVtbUYZdRYjwINhwRHM38gxm7eDUYoMT5SEA6QI5ACglSjHwFvEhQoOcVzo 9FWnVo3MbIjrUZ7nckntaDySekzGmxqQjxn10jpSdczRdo/bjCF3si9ddbZezGUBxqJ7 720TQw5o/UsgMYKiwfPhdm+GY9XQXBD5FHjkkSzkfHJnMwKzKPYGuz3KClbaPa0yBNXi OuoIyOrc/oAcb5Oh7+J0lkfzCLQ3AoV/QKCPY6j56q4LOMdoUtwzhDzVGrbDQ5ie7zqB PBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724861449; x=1725466249; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pUxW3H51tdCti7975tz1MGr7ixTkv8/Vj6O0jDTq5hM=; b=HI8De7gIP9ewzv6ajWprrSq9CSTAIk7ORyS1fzHQUKQ54M7NQEpxYuxrNwijgoUB2X Zbu8MKgmzLiOw/bdny7PF7Fj+hPLT+Kp44BRtjyqWEfhHQOnELHaRLWRrotTc16zjU1I w4vKYQcXmaM+/FtsFljSRO1GSiWCPFmYKm7S1PWUPXx5eiW3yPvw3gKMX7x+a5GUQwNr a0aL9rhEPdTaI8XQelIPqn6FnZFgb6Av2iBdDozhG3a/qqqyKNUy+lLmFkKrlWAaY4ZX mlyPDW2kgndp3wnRz7Ces9f5jJhM09RXOyZ24WwcbSboeAhGCFpXXKXvWRKTh6kuzaCc 4epQ== X-Forwarded-Encrypted: i=1; AJvYcCWlDfGbKRPp+GD/A9yW3UhCAtcOkxAslkRGeg4kxIatfap6MIe9YxN2trSxddDRsLV2OcFSOS30VA==@kvack.org X-Gm-Message-State: AOJu0YzubWyV7THvyQ3dnbEA1bouz+JyL3FylIZzsUY67gMESwi7h7ML 44oJa1Y8LSZPRon3nathUxnHimxPQ95lhrqDYLagOJrtXz1EiZK8o3kBHubg66IpIrZrR568kUM SO6DHknkHBcMZKIF235Rbd/DniRYpls9yseCb X-Google-Smtp-Source: AGHT+IHtbZb6lBm6dWZvdL70hryO/pm9b4DtbL7TjizNJ7LY01ZIlDL96COPc9v/E4sIswiSF687/R0RG3k7W+e1uXo= X-Received: by 2002:a05:600c:54d2:b0:42b:a961:e51 with SMTP id 5b1f17b1804b1-42ba9611004mr714685e9.0.1724861448603; Wed, 28 Aug 2024 09:10:48 -0700 (PDT) MIME-Version: 1.0 References: <20240826204353.2228736-1-peterx@redhat.com> <20240828142422.GU3773488@nvidia.com> In-Reply-To: <20240828142422.GU3773488@nvidia.com> From: Jiaqi Yan Date: Wed, 28 Aug 2024 09:10:34 -0700 Message-ID: Subject: Re: [PATCH v2 00/19] mm: Support huge pfnmaps To: Jason Gunthorpe Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Borislav Petkov , Zi Yan , Axel Rasmussen , David Hildenbrand , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xpkh4k1xzbig8jp3bzsrajppbg553oaj X-Rspamd-Queue-Id: AB544180004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724861450-434923 X-HE-Meta: U2FsdGVkX19vf07M7H40Ca9Jl4WH/hYsnc1DwKjU6XSzYV0iNrV05EtAQsU+Kk41XiUw0N2qdXHyTyixTwvHI61hUHa5RlOE1jmVHIo2iqnxd0fMZxBDVLfzriW3XgRnP5ORUomxOEjcbVwjhEZcaM0/BfsXkb9LGIuzoovEoBCV9qK2b6qn+QVa51AkHZmVzbUZd9veSihGti9IXth9HJDD+OUZCu8VTTHA/EM9A8o5wbhxWt4Z80VjgbBX25nAum9DGmJsxi3veMIgTKUEsm69QkMUrCg6ua2YTJJPpGKMt3ATgyBLl/9DNTIOhVarA2VHsgg6bhl1K1pk1ze2BhAe83QeaZdqfjJSDED4DOrSjQDS0XP62CQ0BNW9Tqmm56H5DWrNznmIw372u/OLB/jJBOA6VOwGSsq6jVHCoyt3w1dCRN5FpypP2qg4exCgXax2YK0/R412Tcl9y2yjBaAPVDWzLxqgk+F7kWST9NfxbPbgGjpkIboDX2zBPkYoJ21vSuoAYt+62sTp7CQGF2Jdgif3cgI17ST7jTzqEH3g1uJulMsIypjZMJglk+oVqN7wEP3L/Y5FmxnFoe3OMY64w1FF8MLS2ipCymNiDCagrajGzCiilPvxSn1Y46HKUFnP815+xMHs26fN2pDlPMEOtyUOpVtUqIiV1W8/6DnaMgDNBT/oTNM/DcyOMRRU7R8F5QgoH0fEFKgoGixRWNrhw8RHYDGh7tTeNEMagClEfUY1ZI0FdN0zkZJ0VjutLhdg12BNDFCpo+8/A/WBKiMGVLLe/asURBt+iKsDwIV14BawQ9TtjBuyxXnu2yk8iGRFHLFNYnsNFhSF8VeXBdNcc8TQ0kGhf+omfnOyD9QyKlvXMbM3zKDV1LYEbAhPMAXMnBbcbLnO06RMJ0ovCrzPLlXEMf5GHCa0irP2zCyQNT9ebnRzH+UmnbFxGi2+9bnGCpajS1Vd8zk1Iir 7FIc/jGp HWDf72VRGd2VGQt0QizI7i8ywuVB1ksOODj/N0vAa9JBDLNYsnr3dJZ26eil9CACPb7bJE+y4wTFVa04JTwgST2oYyTutYB2BDrQP+2FmJnvvx80vRADy1HWkbtPzkGJhWSd2xMD4nIQLisG7+lXKsClr3eceOC9QNliyskkfCvjC7aI6ADj0Z34PydH6DWT3Y46e5ARjUVOFppGPnt70skZb4NZapE0oYFPie+m4eELGMxyb9o2P6c4JBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 7:24=E2=80=AFAM Jason Gunthorpe wr= ote: > > On Tue, Aug 27, 2024 at 05:42:21PM -0700, Jiaqi Yan wrote: > > > Instead of removing the whole pud, can driver or memory_failure do > > something similar to non-struct-page-version of split_huge_page? So > > driver doesn't need to re-fault good pages back? > > It would be far nicer if we didn't have to poke a hole in a 1G mapping > just for memory failure reporting. If I follow this, which of the following sounds better? 1. remove pud and rely on the driver to re-fault PFNs that it knows are not poisoned (what Peter suggested), or 2. keep the pud and allow access to both good and bad PFNs. Or provide some knob (configured by ?) so that kernel + driver can switch between the two? > > Jason