From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF61C38147 for ; Wed, 18 Jan 2023 23:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB0F96B0072; Wed, 18 Jan 2023 18:05:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B61E06B0073; Wed, 18 Jan 2023 18:05:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A28926B0074; Wed, 18 Jan 2023 18:05:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 943166B0072 for ; Wed, 18 Jan 2023 18:05:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 60DD540A37 for ; Wed, 18 Jan 2023 23:05:35 +0000 (UTC) X-FDA: 80369453430.10.71F1FAC Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf30.hostedemail.com (Postfix) with ESMTP id C5E0F80009 for ; Wed, 18 Jan 2023 23:05:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Gj+MbZUm; spf=pass (imf30.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674083133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Aye52hH1QLYe5LfSoLP+D35F2Id/hdIegFuGnHzKETg=; b=ub0udZMD6eWDZoL9BXZ1e6hqyZJJAZwF4wX8aLhzJjI9mzO7rdvyN6y43YESLkm3Wao2YH 9l15WQjMaCk6jM5JPqPj52Q2AKnvn2HUvvztvNJZiNlzR/3Hkkovj6VCR8cz14hbbP07b2 5IrL5UOtnFK3S+fFoocDXlfqYvrOz20= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Gj+MbZUm; spf=pass (imf30.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674083133; a=rsa-sha256; cv=none; b=1fL1km7uIbfnMtNRUmFVfwPkkC3ENw4u4IWh0IjAofO6G5AVwKBKDWiUgVw0KqpiIvW2W0 ZczVTBgwQdRxLR7g8f8fu0dFmvJWUCjGESCaQFVDjqoyLtWlamZNdLkhPWYt5JYW3f80ql Y/rJlUxnIkpL/uc6TjwlD1KZCecQ5Ew= Received: by mail-pj1-f52.google.com with SMTP id s13-20020a17090a6e4d00b0022900843652so4074433pjm.1 for ; Wed, 18 Jan 2023 15:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Aye52hH1QLYe5LfSoLP+D35F2Id/hdIegFuGnHzKETg=; b=Gj+MbZUmxsMoUm9sYlnsyl3/46WNF3OhboIdPgEdZXBMc7tQYb3TCXsw4Yur/Vro/8 0cKXwVB7Nmu9qkTXpGRkbIvdnZuX4mNd0pPab/4wnQ2Y0UuUi68FzYEJg+D3ylKZjd0Q O/ohmm3skG0RKYfm0QP8TTgxX0GWeN0P4DMvdueaVWY06BDMp47XPm9hLtHLFPKIud+n OSW4R8HxnhxOuZaCf3b2ZR9uLZYD4PymJ0Yk8MvqMJG3p8TRkky7D7/uFzjO9/zO9c5j sKjagO2ewcIK9yiF5TkYzpJAqpOItFlc5W+4oHk1RIyU7rcKvSjxdSvGLFy631EYNfUC BvMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Aye52hH1QLYe5LfSoLP+D35F2Id/hdIegFuGnHzKETg=; b=e+T9xkw8+h2yEydR6Ln4Jlg3EDzA+KPuZF204UK7SVQbw2eIS0oSHoQ6tiTWEFjuvf 58ELBpUKGUPm+bTqcQbOxgG1I5wm/NEoVQ7l6b1uB3zv0rvqu9lezzceMoj/Y3j6Eql3 JmJAD6iSh4JRVkPr21yoXjLjlEWC5YZAeWGBYpZQ2Bh1w0Cmvigae3EByoWAQRLvDinB TsWRf1CSRoOqqmncObaVcOjmpHckW8qBZJHv77u4LDOoz5U9XjTTaTvVL5+kGV2a40ia zNBXD8D+THQG6Q76P6ZbTMD5Dj9eLfAD25Sf9X7+r4+sAsxLEH3BvILLWJhH8pkNoNuY q6qw== X-Gm-Message-State: AFqh2kqAxFkEtElWTxyEhiUV1S34tvckLt41UQTptZMGjyVYg+TP3MMV KfY047/2WxIRWjaZkyG4+p1PJr9ytce79cLn2dDvCrsCuLvBpe9N X-Google-Smtp-Source: AMrXdXsK33ZNLfQ+e2LvdT/S1qwFZJUIEIW3zDgHxRkWLONM5U2JOs5t9WujfaYCajDeS/n8QQ9vP+no2LZ0hv432Vk= X-Received: by 2002:a17:90a:4d09:b0:229:7ffb:24b with SMTP id c9-20020a17090a4d0900b002297ffb024bmr1021053pjg.95.1674083132244; Wed, 18 Jan 2023 15:05:32 -0800 (PST) MIME-Version: 1.0 References: <20230116193902.1315236-1-jiaqiyan@google.com> <20230116193902.1315236-3-jiaqiyan@google.com> <20230116121613.234145e82988ca3e602dfce5@linux-foundation.org> <20230117090349.GB3428106@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20230117090349.GB3428106@hori.linux.bs1.fc.nec.co.jp> From: Jiaqi Yan Date: Wed, 18 Jan 2023 15:05:21 -0800 Message-ID: Subject: Re: [PATCH v1 2/3] mm: memory-failure: Bump memory failure stats to pglist_data To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: Andrew Morton , "tony.luck@intel.com" , "duenwen@google.com" , "rientjes@google.com" , "linux-mm@kvack.org" , "shy828301@gmail.com" , "wangkefeng.wang@huawei.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C5E0F80009 X-Stat-Signature: d8z65ecr1d7s5j5ec96o9xk1tzk5hrpy X-HE-Tag: 1674083133-919515 X-HE-Meta: U2FsdGVkX19YSgjP+SYIMn1iH3IsI6LMqUHaODNoKY2YfBWAYp28l0iitpIUywg8yXytfPO6cAdzulu2t9upwHRiha/0v1u7/JlWqMEYa3fWQSgY+zzKl4V4EaUyaksM8+9GPpP49jz28PKfWdZp+lSyJ3a/GVusjieiTEpsnLjiLfgiSKfCyLxoP7ajyMWTAiS2vd7UJJQ6oBFab4K2/syJJcDv0smbQG4/FtrZHCVWhO+V1stfIA3pyma9AVF+tl+jz+b6YsEWV13tJmRR1Qy0maL+vOraboW72AgLP0AqoxViUTIhhjqh/9H3gfVLJTWJIksIyHFk0EYQcL64MY7gIIgRw0WxhHd5by0QVQazu6ekX6XAeLPTcEFgt8FlS1MokSQxYrsIXPr3SBJWWkmvl+o/i3upx2pYDSXqzNMgrsjugBZf+ZSDzmUUajR6DzEzz9aIBFJiazC5w/2b1N/YTQYGziraWob5LSk1cXkYPcTPadOYpNzWEc3oIJcWGncSL+d87hHRAhwRD+fyIqh5Rv3lvjcoPlFamK+1eDbd60qJP7q1kydJGCYV7Z8B9iZq0a5GVtcZ4F+Y9F8Ut543jXDLJDn1AJY0xPlvWxseCNwJlk9hLOIQ+FXZn6FTMLT6at72GpqXtr3UeQ914iZa2WggWn8HBM44MAv4ylT40pGh8ET8uZV23erjjc4XKlyYHAvaDffp0ekmeF7/QkH3blV+mZ9O/59TMPORRFj7M0KzguLooesn8jDR2bXpoTu8l1NMXI36xPIEv4meLKE4xJsjWHyODGd3Gq+Y4R3jwceVok69laLoI0tHrE99RmqKLt6Vr1H1lCiqEP2sAhhaKumHBIHZtMTmiKIRi24MscahIrBZNkrVs4G5RDNZ+Ay+kQ6MmskpjmBLjqscQFx8YIt67hSr/zB5FTwf7KdL/lhgUCEmvuJmL3ixOn0aLHwYtfU5ymMFxntlTrh VXY9WtDd /ApLNrPEwszgrCF/CuZUs8C4KH3rA7epYlBRFuct4I1IGHCEZFi4m5ZOglQwTP27Mwr1mA9oagLTX4jqA4Wqo1rQWPTlU5v919EN1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 1:03 AM HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80= =E7=9B=B4=E4=B9=9F) wrote: > > On Mon, Jan 16, 2023 at 12:16:13PM -0800, Andrew Morton wrote: > > On Mon, 16 Jan 2023 19:39:01 +0000 Jiaqi Yan wrot= e: > ... > > > @@ -1227,6 +1227,39 @@ static struct page_state error_states[] =3D { > > > #undef slab > > > #undef reserved > > > > > > +static void update_per_node_mf_stats(unsigned long pfn, > > > + enum mf_result result) > > > +{ > > > + int nid =3D MAX_NUMNODES; > > > + struct memory_failure_stats *mf_stats =3D NULL; > > > + > > > + nid =3D pfn_to_nid(pfn); > > > + if (unlikely(nid < 0 || nid >=3D MAX_NUMNODES)) { > > > + WARN_ONCE(1, "Memory failure: pfn=3D%#lx, invalid nid=3D%= d", pfn, nid); > > > + return; > > > + } > > > + > > > + mf_stats =3D &NODE_DATA(nid)->mf_stats; > > > + switch (result) { > > > + case MF_IGNORED: > > > + ++mf_stats->pages_ignored; > > > > What is the locking here, to prevent concurrent increments? > > mf_mutex should prevent the race. Since we are only incrementing these counters, I wonder if it makes sense to convert them into atomic_long_t (encapsulated inside memory_failure_stats) and do atomic_long_add, instead of introducing a struct mutex? > > Thanks, > Naoya Horiguchi