From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86656C2BBCA for ; Tue, 25 Jun 2024 15:49:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAB766B00D7; Tue, 25 Jun 2024 11:49:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C34206B00D9; Tue, 25 Jun 2024 11:49:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AADE86B00DA; Tue, 25 Jun 2024 11:49:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8879A6B00D7 for ; Tue, 25 Jun 2024 11:49:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2988C1201F8 for ; Tue, 25 Jun 2024 15:49:04 +0000 (UTC) X-FDA: 82269844608.06.8394C62 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 56241120015 for ; Tue, 25 Jun 2024 15:49:01 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=np3kAib9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719330524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxb67F0epg0WUcpjIVopItAKW3yTsqHV0EkWYkb6TKU=; b=x0zELSX6FlUaKRLJ4OgMRbwvJtqRSbu81upP5X/9zDyY+OpitE5pZUYyo7HOWPfGpFPrq0 6d1W1IGrjlFlDNDj3GoF1GQ6ptr1DXIA9cOw9mfzm0uAOoJFoqKIoj+1y2iW55z528btgf nDo2CYxcnfEBGKnq4BD61SJfr8qvOqY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719330524; a=rsa-sha256; cv=none; b=JvBqT5ulWDulwLDStF6UsJpFeREv96v04mWIzQ7z79FClBYgx4OmslwjOrrq+ZabxShfX9 YRURz84uBBmVjlHajWM6VS+qHsrCwv0Q4IqljJ5gdN07moLNhmdekqcEJ4Fqo37eKwQGiO cGYrXfyej3tkkXB3OG5ERLUgHaqJg/I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=np3kAib9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=jiaqiyan@google.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52cdf4bc083so4917975e87.2 for ; Tue, 25 Jun 2024 08:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719330539; x=1719935339; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vxb67F0epg0WUcpjIVopItAKW3yTsqHV0EkWYkb6TKU=; b=np3kAib9jOYqz2byLb7FqekhovEFYP/+/BPAzzDRLUiUcJz/toV1pOd2mWUNX6CsgM NLKV87taMzSN+LWrAAc2TG/SeKUH7scJku+Z3Khnv8cKjEU2/bVsGc7swCUD0AyQTHWv WPK+f+Mran4AdLwVABgzvJbiTS08EwJNiv927DGBKJZCjuzShNcdKsGwSXK3opaK6ERr vAdOUF6hbGhdUj2qNFHQptgJVLf/lkufjSdlvAiD2GVikSk1RqrdZ/45ipWGp9mzxKVt Ei3uiFOrSDHCLShsqWmb9p+dOKl7d5k7BwnY6/OmApvWnsRf2ePArblkaUZnQ+G0bqVR LhHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719330539; x=1719935339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vxb67F0epg0WUcpjIVopItAKW3yTsqHV0EkWYkb6TKU=; b=cdLjpdNxnaGR7uS2w4ZWD3RJnmTiJmbDczussnwVHOALrJ61jLarKqg5tihRiVtj7p kOTfNR/3pQztpql6E5Xzo4jEC0hG0ZNmZW4ywEODa/IFsyCwFCWnoEDFSlyXHXSQXYA1 C2iz5635olcOzuDIvivqFxMLoU0VfFIL/jUgJ67JRoRtUq/8SFOvk7Yoj82cvR/cBwSG 7717unA5Al5RP0GsEn+9HjBcXF8yeuIvOAMtJqNj2LoYI2Jr0KX65FoeY70ELZOnxk6r i/UyDxN15VOZk93XCPcrM4UzyQ7bGh6waz9Exw5iSEUcIp76O5JgWrcghk9pkxtJntLU NVBg== X-Forwarded-Encrypted: i=1; AJvYcCWNI7Oh/s16T2Sft6amJ79GW58OdR/4kAupW/IeTHkAh24KIE+oPsYjPk6fJf3Im65z4uiJAvUMGdC2JjThJLEdfas= X-Gm-Message-State: AOJu0YxvmNRGBK+0mlDRwrKgeEaLV3cz1m6jOWTQp9d/C+8aTGGWw8fS VOy7uMNCjzOATA1vjcavevllvO8XfdbAWzKVhKs9l5OujqDM0MIpiGyqwMavKcOwR7g594nYBUb EN10N85c78SN4bAPLZtBjn4CKAsp22SlhMA4X X-Google-Smtp-Source: AGHT+IHcWe8Q/heq47iYVyRVbt/goSPcjLABzSqKs/piB9Ciz9feIfIDC39cZFwoe7e1yt7HahE0jpTztGd58ymd0zw= X-Received: by 2002:a05:6512:348c:b0:52c:86d7:fa62 with SMTP id 2adb3069b0e04-52ce061b1femr6166980e87.23.1719330539167; Tue, 25 Jun 2024 08:48:59 -0700 (PDT) MIME-Version: 1.0 References: <20240624163348.1751454-1-jiaqiyan@google.com> <20240624163348.1751454-2-jiaqiyan@google.com> In-Reply-To: From: Jiaqi Yan Date: Tue, 25 Jun 2024 08:48:46 -0700 Message-ID: Subject: Re: [PATCH v5 1/4] mm/memory-failure: refactor log format in soft offline code To: Miaohe Lin Cc: muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, osalvador@suse.de, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, nao.horiguchi@gmail.com, jane.chu@oracle.com, ioworker0@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 56241120015 X-Stat-Signature: sme1zz451b3jtgsodpcpmbs51ys47c4f X-Rspam-User: X-HE-Tag: 1719330541-459235 X-HE-Meta: U2FsdGVkX18uUVMv/k8o5xhKEpI6MX+H10KhQ5wZSTYnPZAsuPk7G4iXI96tlpCIn/g8px7w49HrD6arZB2MRyJ2lOh0+EL0AfTqELhSHO49WRDXvR890r3QB60XwOnIWVwR4uVuv2LdsLwlS5738t0yXsZ2OIVA0/GGbOTSWjnjQMvD+XDOT/KDScOKgAjLyaKiH9eoUI0PPiLrJ8Jq8sAeGxU0mtykJXrYeNQJPrBU8F4TRwPgfRfldRIOSJVzOR8/GKA/WtZ1c8omiX11X3GQ2paeO6okXlp0TJ1ZZingUC70U3rXk1mOvRCyhiiealy0lcUX/3DIFNb717Ej48fu1nKZGSVtNFKhO/ufzpFW2RZXP7H5CDb4NtVyqMIgZRl8FYUeeKXsG36sKPiYEj+tVWk6x4A0ybtozzP/lWNPs+AS2D+02C50BrDj1wVBZQYkVj2owpl0sBqxf3hUaHj69WgV2FDPiQlhcBnSHk6fTspOG0G8rlROn9D9mvsveGq7zx8BELl9K1XMu7oU3Cb/9OvC18kmtq6STfegMg0/Glfi+wR+gxpE7+b8vdeo729pmqQjG3Oe/2IZutp7GKfDebSlNCH0XURtfLGsxaCx2jMtgS6xKSAU5oMPaPdi3yrhde2RIwFnO3RArjvBWgs2aPwHtCQDbD4s2hMY1qZeGEJM9hy8RU2nF9OAKgIeA8ahVqHplOTGuu+rwS0/RSd9OXbibfezwO4HSX6Mi+wvpHdFEI76+zx1a/ODBMkKRCYlfgTn/XwgT+ZpGZwEzBSyhJDgxq767zNZ88JHvq/T0Ws1xezYNjdYPtqY/VRvRJ2wy9eG1kIlyF5mx438+STSZO6XVL464P2THRpXcwY1JFvo8mKb0uFUwRRmF3ZSn1A0PxeC6vG5EOZxj1nLGxIy4sMN1My1I2rubVsEenHylxSQ3tiOIS3wuBs+6YiEVgd5u/40/WJvZ2ugm2X XRhe4SrC NvEBYoxIVH4ifqSCEUO//DYemQ2zyRdqI9TveYnK0ghLcz9nCiomK90d6rOTcJU7fhG+eU0iYk/0Li6DDSVBvRvRHi7qadSsyB2KwBMAzLbX7/OPOQYL+46RRxW7uL++PLqb/CctV5id8MBHnAhMxmj7gj97bfZEU2VYp5PL7OmHyvbyfhWh2S2TTz7Ub69x21PWA6egiyb+rzE4E7XtP/p8deOHWj6qXyiLDH0HfRJgza7zcnY3QTix9Hgh6SZnaTrw0vAQsP3iF++g1iVzvwiCxxpf/EB95ZhIN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 11:41=E2=80=AFPM Miaohe Lin = wrote: > > On 2024/6/25 0:33, Jiaqi Yan wrote: > > Logs from soft_offline_page and soft_offline_in_use_page have > > different formats than majority of the memory failure code: > > > > "Memory failure: 0x${pfn}: ${lower_case_message}" > > > > Convert them to the following format: > > > > "Soft offline: 0x${pfn}: ${lower_case_message}" > > > > No functional change in this commit. > > > > Signed-off-by: Jiaqi Yan > > --- > > mm/memory-failure.c | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > index d3c830e817e3..2a097af7da0e 100644 > > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -2631,6 +2631,9 @@ int unpoison_memory(unsigned long pfn) > > } > > EXPORT_SYMBOL(unpoison_memory); > > > > +#undef pr_fmt > > +#define pr_fmt(fmt) "Soft offline: " fmt > > + > > static bool mf_isolate_folio(struct folio *folio, struct list_head *pa= gelist) > > { > > bool isolated =3D false; > > @@ -2686,7 +2689,7 @@ static int soft_offline_in_use_page(struct page *= page) > > > > if (!huge && folio_test_large(folio)) { > > if (try_to_split_thp_page(page)) { > > - pr_info("soft offline: %#lx: thp split failed\n",= pfn); > > + pr_info("%#lx: thp split failed\n", pfn); > > return -EBUSY; > > } > > folio =3D page_folio(page); > > @@ -2698,7 +2701,7 @@ static int soft_offline_in_use_page(struct page *= page) > > if (PageHWPoison(page)) { > > folio_unlock(folio); > > folio_put(folio); > > - pr_info("soft offline: %#lx page already poisoned\n", pfn= ); > > + pr_info("%#lx page already poisoned\n", pfn); > > Again, it's better to be "%#lx: page" to make log format consistent. Ah, I missed a ":", thanks for catching this! > Thanks. > .