From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA22EEB64D9 for ; Mon, 10 Jul 2023 15:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 647CE6B0075; Mon, 10 Jul 2023 11:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7F96B0078; Mon, 10 Jul 2023 11:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C0DA6B007B; Mon, 10 Jul 2023 11:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3CB4E6B0075 for ; Mon, 10 Jul 2023 11:12:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CA37AAF913 for ; Mon, 10 Jul 2023 15:12:04 +0000 (UTC) X-FDA: 80996042568.06.082B0DE Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf19.hostedemail.com (Postfix) with ESMTP id BD21E1A0022 for ; Mon, 10 Jul 2023 15:12:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OCZR7YY3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689001922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DbtJOk8oTaRo7QZmrru5UgrEoVaoodoQOwpqijk7rkE=; b=dtV7eB59J4yMpAvNPMi4nhOeY/tBHaz79+em4Q5378iA4py9VRWLa80i7K5AncJOle7YOR 6JC/l/Na0ReDvbnEb3hdZ6C1rIQxQOWd2dsPIUmj1nD5B4ZHTnzWdCEBal40R04jHvshqB CP1vPLTgQw19HqYMWAmre6IXd9zcwJo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OCZR7YY3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689001922; a=rsa-sha256; cv=none; b=sGIAxctZBontaFNkZ4JhiBehLy8SOf5tdsNNeC8dnyxI6D3SMya4bbColtO7mlhyp+r1Nh HueVfqq/rnS4r2goIbbaHJS+t0NWzPCuPBDVESFGpvKVseajGFLr8pGQc/WJddQGHarYKY UKsfXd7KpOz9R5c8S5KfQbXFxY6Nd3o= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-577412111f0so59741937b3.0 for ; Mon, 10 Jul 2023 08:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689001921; x=1691593921; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DbtJOk8oTaRo7QZmrru5UgrEoVaoodoQOwpqijk7rkE=; b=OCZR7YY3GpEWLPtoiP+d4HgsNcOxlVeenS/tO1VyPMcZbIYCxNkMj7bZRHq9Fm02gr wGiH0XUkNQ4z12lmjCKTyNZEi99k0AfGGTekQrgm/tujQlpLU3on9vbNpE06DFA640XH VNZk4K44KuIKN7pyt73/G9qwFwGuS/1d9duELH/X7dAMazCuM2XghOAb9JGWGNrCUvne hw+1S/+v9t/LNZzxAJ1fBuS7bdkUXms5zRKM7pzbywBgLJO0tDiwU+A+WDQYPaVNLw3j XDO0jSPvTSmIDmus2dLCF8sc2GdyZiUhFscKU5gAiB9MgdHPMDvhPlBpb6oFB4AtpI6h YRAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689001921; x=1691593921; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DbtJOk8oTaRo7QZmrru5UgrEoVaoodoQOwpqijk7rkE=; b=kvARwoA0H3vXYQUzu9Yd5ERzGe45jeDkGr69rAhI54lgpN6R4+5i4HsntlD5j4DNa3 HaG3ba5co346WMz07YNZKC/6E2cFon9GOo/DPwbxQuE1fRD1Nf96A6kEZYG94zTwR6Ee JDD2kf4jkV0240qHdf9Ix8J2ME5WETwHmYekvv0nWQMWxpTi4mEDnP6MJV3hjWc2nze4 OPgisy1B+JHspsWExzynR4uqxKbDH/VfPlhZ/yG/KwMSVD6/VC6zxiAzN5/OXRC+5epB 00fVfF4nvoUyK8hqzYOEfx9P6zWuHauNGTyXnK8HAq2J44TkVnvRynrAz7/9Tf9U/24/ kEgw== X-Gm-Message-State: ABy/qLYjWxvZWVjijfqlHD8suF4/idcn4iI2bgwkgnlrOAs0GZmQszKh bK0y/ku6p8tSes2hjf6OvIZ2TIlhyeWh3ifySxJi7Q== X-Google-Smtp-Source: APBJJlH4FQYpOEQ3A+1can3H5jmu7RtXcq5Isl9pvfprIvZbCeng7GFvtjUk+WPcMCXUrOipfG5gVdSdLgpX4ZvIl3o= X-Received: by 2002:a81:6646:0:b0:56f:fa68:2e34 with SMTP id a67-20020a816646000000b0056ffa682e34mr14854021ywc.35.1689001921492; Mon, 10 Jul 2023 08:12:01 -0700 (PDT) MIME-Version: 1.0 References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> <20230710002116.GA1578139@ik1-406-35019.vs.sakura.ne.jp> In-Reply-To: <20230710002116.GA1578139@ik1-406-35019.vs.sakura.ne.jp> From: Jiaqi Yan Date: Mon, 10 Jul 2023 08:11:48 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON To: Naoya Horiguchi , Matthew Wilcox Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BD21E1A0022 X-Stat-Signature: 7jk4tdttb9bct15bh8zp1ddas9cn1p8k X-HE-Tag: 1689001922-11009 X-HE-Meta: U2FsdGVkX1/WV0L2yDi72s5123LkA28IYswNOQob7jA2874cerw6fPiWyt47N/haPDdpfscpZbxVYl/ugxj6yA9fptUoc64+eu341XgPZUWS8ex2GblRgUKB8psc9IEtNrp+L5lgI1RvLBoDR/1/skG4bEY+AZXtEjEgk3wY1z/pRRmbptg3zcjej+G0yIxQoCQP7tpF/fM0eE0rxQovpul/7BRfaOJrzJ/UuRBwJ2u/h9JArya7h07xezot5jlfjYDLcFaeHXPro4SigdflHtYlzsW1vjGn14uBVSWvLCs/AXOt0qsYVC1xVqL/bSEzfsNy7X01wGXHtHriAjw6pSj19qc9/rHfyHjHhhKAeWP6kLWZATOZT89BaqLv2PWUcKxnNqCiaozcnSy7C+BcMr+IIoOdpKMqGXhi+mkEvqIFhKmKQMSBNKdHIsZqacX3P12EhSHk+pZA7FnlJuz9eF5W6UtAEs7wjV1O23HgiLRdYnQMQ6AwLRceeaahIxn+u/0ywok7Ew5peLL9lO53tchexMRYsY0c+MUWh/BjrtuZ4WoN8sE7nhGdv9iDmW0Vc+ALtdw0GvT1xPQatF8Y4I8r2J2oD+g5J9JG1yfzHZEgtQ97jJIRpLjzzMijEgcSSZEZKJFO0LefG30efSXELqcNh3D8nSpAvQc7OE/FlDyHtQpiw8IjJNYNRdSu17Fl7mOiZpZg9x9Y3/F3sLygB84Ps8j01Q/rEvsf4hMyLQQRWDvLWPhCGzAiCjJzsZ/RcuCA3JipmqSWt6MW3BJGxeZJLaLsxiQGhNFqNkECkwxX8rnLTKky/ZfprEBNKBIYWozhQLzFa8smUyLj12/0rGdiO/hoeLlciHGMEFGslu+fjIjr+7GR2FUnbk4kfi4Ftll+N4WoLehD+EmrMWofhcEmvHrrc/6nYBN6nIb8ofM993Kt61KXwsMByij91FFgGIt9U+iviSDaFRZULol kdPMfqa3 749+tdQTpe7/Q/oVvwTPS9PhXoXT4GhSsSZdAu+/cP111qxlPsHPdWdNGj/egXTvvkoGZ4TX6mLbk8DJd6TYA7O8mY80Dmky1C2N0XAbBKbG7VTdA3CH7L1i2hvUs2gXCO4JdCkcoWCYLAx/DPyhqA93/cMn+KMoLUSGoJ9ltl2mE2m9Y5mPWLCtaERmLvKRe7e+UGuLoOpYBAUL4ZBW9HXTQfoouWiDnj4Dn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 9, 2023 at 5:21=E2=80=AFPM Naoya Horiguchi wrote: > > On Fri, Jul 07, 2023 at 09:31:39PM +0100, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a > > > > This is incorrect naming. "subpage" was needed before we had the > > folio concept, but it should not be used any more. We have folios > > and pages now. > Thanks for your comment, Matthew. > I think we can address the raw hwpoison page by the offset in folio/hugep= age > to eliminate the concept of "subpage". > > > > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. > > hwp is already used as an acronym by acpi, intel_pstate, some clock > > drivers, an ethernet driver, and a scsi driver. > > I originally introduced the abbreviation "hwp" to avoid using a lengthy > function name such as "folio_test_hugetlb_raw_hwpoison_unreliable()." > Therefore, I prefer using "rawhwp" instead of a longer form like > "raw_hwpoison," although I don't expect any confusion between "hwp" and > "rawhwp." These are names in my mind, what do you think? * is_rawhwp_page_in_hugepage * is_raw_hwpoison_page_in_hugepage // I prefer this one * folio_test_hugetlb_raw_hwpoison_page > As for "hwp_walk", another user of "hwp" in in mm/memory-failure.c, > we can easily substitute it with "hwpoison_walk." In this "hwp_walk" case, I also prefer "hwpoison" than "hwp". I can create a separate renaming patch. > > Thanks, > Naoya Horiguchi