From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D888C636D6 for ; Sat, 4 Feb 2023 23:21:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B29D6B0072; Sat, 4 Feb 2023 18:21:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1624D6B0073; Sat, 4 Feb 2023 18:21:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051C46B0074; Sat, 4 Feb 2023 18:21:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA3E86B0072 for ; Sat, 4 Feb 2023 18:21:17 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B9BEA1C60E2 for ; Sat, 4 Feb 2023 23:21:17 +0000 (UTC) X-FDA: 80431182594.11.6737B7D Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf09.hostedemail.com (Postfix) with ESMTP id EB8BD140003 for ; Sat, 4 Feb 2023 23:21:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=COwx4McR; spf=pass (imf09.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675552876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hr4fMfwOTu/N9rUGHjciisqAA2ecKJWf1dnTkYAyHVo=; b=PTs02J8FDanpC07WpL6y2wRuh3rn0vbpZEmlfuSksfNyGGIJt44ZvWR7nhZzY11QNdstt4 ZVGA3l8B8F/GL1Im/A3+bPo8c8V1bTD9h8feYyxszwHv5ZTNWWgwVE2mXeRJ7KRvvfmG14 CX7DVgyxVomh9pEeH3nhOOh3E6qI+Ow= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=COwx4McR; spf=pass (imf09.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675552876; a=rsa-sha256; cv=none; b=azw87OAVYBEKiOPiAcISq9nDK2oYW8jow0wYR+CreRGeszhQUe+nNof/T9W+fL3/NmcwIX yGc1EoeuxRJu7Ab9zU75mzNeZ1FRlK+yXj1PizOA9jRoYtVnns4cdlDwZuXjlFIM5koe4M QzZVCWgSYSauemRyv7o31Qho6+Zewgg= Received: by mail-pf1-f181.google.com with SMTP id z3so6111543pfb.2 for ; Sat, 04 Feb 2023 15:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hr4fMfwOTu/N9rUGHjciisqAA2ecKJWf1dnTkYAyHVo=; b=COwx4McRl7X6+Z7hLo0rn78qb5+fYoAlFOwSGKKrpf1Lc2f2/zwfbUa8ZsIz1B/OAt f9+OOtG/cT7ZDNLJebnH/g0JkoPDqj7vif6DKXNTAi/CNXNa4JGrR4jGx1LDumk1NiEX f7iAIz5fMgbtqh3Y/MKuipKyyiXmpmIQw+VdnS/AD/TOEspSL8rTCGG9VXAbEY/tzYAw 5HAmgtgZFJUe8XPeV7C3euNzCvnLYT7XUIwKFfvCedzk78r+eZ6TBzMVjoDre3eWs/Tj VwfPrQT0Q9cghJyNl/96hcs0kS4PmoOcMdwsshriK+49qFKwYAiBvjfCpUSKYJdB7M+O fQ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hr4fMfwOTu/N9rUGHjciisqAA2ecKJWf1dnTkYAyHVo=; b=6kGHiVd1RLA9I7m8SeV3uWy1QvW246wnv3Lv6/bMTwfoTQm1u/x7W6TvNgzCzDmGt7 y+u3MZchds9kfLGsTa0Y90PmAfCqT1UQcQiZm2ZmvmznlJqKShADGkie7xtuS4a1uVHA PdKU9mv58STWPtAgkQHAfdlxyOXYUZASkk6tOQkJd2G5s9CwAbimX8TyauEIJOws4snk Sn5mkq1cU2B5oMH4broNXrXvHBMUKlsPNpSXASR2c+IRVVtEoYCRUxyj2cB9VOIthOEM XS2C2TOgZmwNup8cIGJRcpMstmZQ7iqRloMXfZOwSjblMHXJ9UwLGuvagnqB91usNDWn ETig== X-Gm-Message-State: AO0yUKVDnHI9PCaQE8Pnn8yHC0LerOcBlQr2xasHRF/9VJkqD7WL6+cP F7pSaf3/sjQIY5Pej+d6KgKE8ihWKUoNI6kQPXejTQ== X-Google-Smtp-Source: AK7set9tgbGR8SANii/2gE4h7AP9cpnW5mMHv3+NsrnUHBrExwD9ZpJCBQvbPzFxaPT1IdDpU4nMB5z8Pgp5fukqzQs= X-Received: by 2002:a65:6097:0:b0:476:f69c:2304 with SMTP id t23-20020a656097000000b00476f69c2304mr2487645pgu.77.1675552874360; Sat, 04 Feb 2023 15:21:14 -0800 (PST) MIME-Version: 1.0 References: <20230120034622.2698268-1-jiaqiyan@google.com> <20230120034622.2698268-2-jiaqiyan@google.com> <5b505753-0eae-1718-b87a-1293a4ff5291@huawei.com> In-Reply-To: <5b505753-0eae-1718-b87a-1293a4ff5291@huawei.com> From: Jiaqi Yan Date: Sat, 4 Feb 2023 15:21:03 -0800 Message-ID: Subject: Re: [PATCH v2 1/3] mm: memory-failure: Add memory failure stats to sysfs To: Kefeng Wang Cc: tony.luck@intel.com, naoya.horiguchi@nec.com, duenwen@google.com, rientjes@google.com, linux-mm@kvack.org, shy828301@gmail.com, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB8BD140003 X-Rspam-User: X-Stat-Signature: ub953ioo59e6yegzjmstxfm8anb9yk9b X-HE-Tag: 1675552875-287112 X-HE-Meta: U2FsdGVkX19h3ufiaJKemQqMbKdksdnY/1LTozmaqUQZjQCVcjAVUP1C6mhOnJfa8tY+mZPB/BetHiN8EbtYW+8EwFowYYPtX6IEU1bnCwU2BrW2/T4CbAPMWOcuSHS5fd/AXMXfSjlrVZFBnnjefMExDDWSJyKNsB1AXh9L+OdIKce7lTaM8IxkrQy/DvQe5iBsMb9rh1TKQsWY84dC57GAuPsOE+ApwWWZnR3BLrHC8QshwAgsXXIcCn+fvgJIRy0jzRa3SBzkiKW2j1HMBiLRhM4L2C+wheJinSBKa9XX98iV1p5rTyoC9tmnsxXdGctg6rLZfeNZooU2UUzPaK/CeiA+iUDJBl1QGSflSekrz2Mb9ZLgezPgMJK2e56CUHSfpETodnqCR1hZYEMP7lLZS/1/QF1tBC39Wdu/XGbBZ+XEK6K4yyuNv0Rql1CPwJ9DzoZ2GHYdyMI1MgdxLc3j5G+M4oDL8nI0fk+UxfXZX6Or5Ngpc1UtPHpp/+D31AdUD45rZwoKeAslLL8zZeu/uvq/Y9ZK1gsx/NOwUE7PMkelBxUVGnR5Eisb5cTPNplSFu5Is7Wn2Z3zRWrYMm/807bHaJxBokB7JMvwq+vGVnEij0qAE7eICIZL78CqIxv4p3rnGfTjQufwfuOoikqs+AZclomMcbZcyKJFW7a9nPRVJRh7VLGrKXRuVK7MxfgS1LYPpnTH9kYO1+bXTKbKU2Gf+gWKkCMzRw7LDZgcJFDyuIih7VU7jdnAivbM1wLDj1ujZgqYYuvBBGyki8vmRq3HmeJ274qX1c9UGQ91Tno5TT1BWKW5lyx0uHey7oCrgjwsZ96Q/MPTSrBPr/uUhToxwakYAtk8SXeEt/biYNfELZCTl/1OFxoJQlgfxdqtQ/Y8UrlHuyqzA7J4WdXWp8EWb0FJILirBwyDP7gmicFR9A/tDN0hyp9vl4RLmhDlYFln8rSqMzEheVm mlFZWPXP +/N3Lhc8qrxgvbOg2coW3IW2FCQ1P6yoVuMkCAdC2oXXa3QdHyG3aS6Ci4o9MZ2xNONTaKgaGetTfyO/SbkBiODUsmspN3kPOI4aOXa8ebPxzICQQhjs3Xbm1ovy9ZaQ5DvtjZ+8/u4Edr6s2POdjbAqZ0t3iq/TiiHpUKcTLHtH8ufpzet9QWJ95VXpx5D9HsbSVXJs6SHWyDD6Qw3TbpdlJyEFsK0hudOc0qu/PHAnWLlarg8W1ugqL30+2QRiKixg82aPrLWrY9NaMcIlxKr1PhPwJbUjuwmwB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 1, 2023 at 10:54 PM Kefeng Wang wrote: > > > > On 2023/1/20 11:46, Jiaqi Yan wrote: > > Today kernel provides following memory error info to userspace, but each > > has its own disadvantage > > * HardwareCorrupted in /proc/meminfo: number of bytes poisoned in total, > > not per NUMA node stats though > > * ras:memory_failure_event: only available after explicitly enabled > > * /dev/mcelog provides many useful info about the MCEs, but > > doesn't capture how memory_failure recovered memory MCEs > > * kernel logs: userspace needs to process log text > > > > Exposes per NUMA node memory error stats as sysfs entries: > > > > /sys/devices/system/node/node${X}/memory_failure/total > > /sys/devices/system/node/node${X}/memory_failure/recovered > > /sys/devices/system/node/node${X}/memory_failure/ignored > > /sys/devices/system/node/node${X}/memory_failure/failed > > /sys/devices/system/node/node${X}/memory_failure/delayed > > > > These counters describe how many raw pages are poisoned and after the > > attempted recoveries by the kernel, their resolutions: how many are > > recovered, ignored, failed, or delayed respectively. The following > > math holds for the statistics: > > * total = recovered + ignored + failed + delayed > > > > Acked-by: David Rientjes > > Signed-off-by: Jiaqi Yan > > --- > > drivers/base/node.c | 3 +++ > > include/linux/mm.h | 5 +++++ > > include/linux/mmzone.h | 28 ++++++++++++++++++++++++++++ > > mm/memory-failure.c | 35 +++++++++++++++++++++++++++++++++++ > > 4 files changed, 71 insertions(+) > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > index faf3597a96da..b46db17124f3 100644 > > --- a/drivers/base/node.c > > +++ b/drivers/base/node.c > > @@ -586,6 +586,9 @@ static const struct attribute_group *node_dev_groups[] = { > > &node_dev_group, > > #ifdef CONFIG_HAVE_ARCH_NODE_DEV_GROUP > > &arch_node_dev_group, > > +#endif > > +#ifdef CONFIG_MEMORY_FAILURE > > + &memory_failure_attr_group, > > #endif > > NULL > > }; > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index f3f196e4d66d..888576884eb9 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -3521,6 +3521,11 @@ enum mf_action_page_type { > > MF_MSG_UNKNOWN, > > }; > > > > +/* > > + * Sysfs entries for memory failure handling statistics. > > + */ > > +extern const struct attribute_group memory_failure_attr_group; > > + > > This should move under CONFIG_MEMORY_FAILURE Thanks! I will move it around in the new version. > > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HUGETLBFS) > > extern void clear_huge_page(struct page *page, > > unsigned long addr_hint, > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index cd28a100d9e4..2c537b31fa7b 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -1110,6 +1110,31 @@ struct deferred_split { > > }; > > #endif > > > > +#ifdef CONFIG_MEMORY_FAILURE > > +/* > > + * Per NUMA node memory failure handling statistics. > > + */ > > +struct memory_failure_stats { > > + /* > > + * Number of raw pages poisoned. > > + * Cases not accounted: memory outside kernel control, offline page, > > + * arch-specific memory_failure (SGX), hwpoison_filter() filtered > > + * error events, and unpoison actions from hwpoison_unpoison. > > + */ > > + unsigned long total; > > + /* > > + * Recovery results of poisoned raw pages handled by memory_failure, > > + * in sync with mf_result. > > + * total = ignored + failed + delayed + recovered. > > + * total * PAGE_SIZE * #nodes = /proc/meminfo/HardwareCorrupted. > > + */ > > + unsigned long ignored; > > + unsigned long failed; > > + unsigned long delayed; > > + unsigned long recovered; > > +}; > > +#endif > > + > > /* > > * On NUMA machines, each NUMA node would have a pg_data_t to describe > > * it's memory layout. On UMA machines there is a single pglist_data which > > @@ -1253,6 +1278,9 @@ typedef struct pglist_data { > > #ifdef CONFIG_NUMA > > struct memory_tier __rcu *memtier; > > #endif > > +#ifdef CONFIG_MEMORY_FAILURE > > + struct memory_failure_stats mf_stats; > > +#endif > > } pg_data_t; > > > > #define node_present_pages(nid) (NODE_DATA(nid)->node_present_pages) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > index c77a9e37e27e..c628f1db3a4d 100644 > > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -87,6 +87,41 @@ inline void num_poisoned_pages_sub(unsigned long pfn, long i) > > memblk_nr_poison_sub(pfn, i); > > } > > > > +/** > > + * MF_ATTR_RO - Create sysfs entry for each memory failure statistics. > > + * @_name: name of the file in the per NUMA sysfs directory. > > + */ > > +#define MF_ATTR_RO(_name) \ > > +static ssize_t _name##_show(struct device *dev, \ > > + struct device_attribute *attr, \ > > + char *buf) \ > > +{ \ > > + struct memory_failure_stats *mf_stats = \ > > + &NODE_DATA(dev->id)->mf_stats; \ > > + return sprintf(buf, "%lu\n", mf_stats->_name); \ > > +} \ > > +static DEVICE_ATTR_RO(_name) > > + > > +MF_ATTR_RO(total); > > +MF_ATTR_RO(ignored); > > +MF_ATTR_RO(failed); > > +MF_ATTR_RO(delayed); > > +MF_ATTR_RO(recovered); > > + > > +static struct attribute *memory_failure_attr[] = { > > + &dev_attr_total.attr, > > + &dev_attr_ignored.attr, > > + &dev_attr_failed.attr, > > + &dev_attr_delayed.attr, > > + &dev_attr_recovered.attr, > > + NULL, > > +}; > > + > > +const struct attribute_group memory_failure_attr_group = { > > + .name = "memory_failure", > > + .attrs = memory_failure_attr, > > +}; > > + > > /* > > * Return values: > > * 1: the page is dissolved (if needed) and taken off from buddy,