From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350E2C2BD09 for ; Mon, 24 Jun 2024 16:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A80CC6B039A; Mon, 24 Jun 2024 12:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A306E6B039B; Mon, 24 Jun 2024 12:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F7F46B039E; Mon, 24 Jun 2024 12:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7163A6B039A for ; Mon, 24 Jun 2024 12:19:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE80440F32 for ; Mon, 24 Jun 2024 16:19:12 +0000 (UTC) X-FDA: 82266291744.15.5337F49 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf06.hostedemail.com (Postfix) with ESMTP id 14FF518000A for ; Mon, 24 Jun 2024 16:19:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3vnRt0yR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719245940; a=rsa-sha256; cv=none; b=7CWzEsQfb+KugLUMYFRZzAT8OR/50e16EEPpTESvwMeMUCPgH+c+hDSS+SzmPe/jiFYLQv FByOCyNvdymgV3kX5Fco+LJbPML/pptVOYsRQyeFO0fX2/QceWeEFBm3O+B5Cu/fQZnZDl 8tik4VDN1DnNaHYWthVcJNuP9e/flHU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3vnRt0yR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719245940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exDolX4nznB1E5gtLAh07wVpA+L122DNFPurXAqZ6H8=; b=lvYexL+n8t6O98jTUoGTwB5CU47CX0de0saft31hey76TLX/GKOMvi5lZkxixM0t2enNrg 3ObaAivxeFxVohMFBg7wuHOb/EH1Y1AN5QyY2EJ+rK2H+McrEmT4rIA6Vr5+cmUOpa42pS LKxSdpC7ZhtGD1++9nUS415VpkJOYZc= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4217926991fso39998565e9.3 for ; Mon, 24 Jun 2024 09:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719245949; x=1719850749; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=exDolX4nznB1E5gtLAh07wVpA+L122DNFPurXAqZ6H8=; b=3vnRt0yRsMBGZr86ew0bYsteHPgt+trtkBxfS3VhyCTYKJyQO2ScK0r4R56Q0CCwwl 4Wi0uBBLppWnvxP50U2u/tSSKxhCdALiK6yerpcn4vwlOm8gGFqIhOoI43RKzt9HbSC5 34XS539TYocvKjzJQ+f1+DH9oVOihyMkx6r+GtJc0uOrtg5S7DZyMu8qfipne6SwE8Kb xym/9wqcepTgvMs7fSsTI8J9ORZVr7owe81dsZDhzjFvK1ola25LDSWBMoYaWSJi0XE9 O/AYj358ImFmN8p8DTr6IK+nCBUyVwm2ivGDFzYV1GEDNlrvtmNAYb5Oj9GsTJtzgBYK fFjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719245949; x=1719850749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=exDolX4nznB1E5gtLAh07wVpA+L122DNFPurXAqZ6H8=; b=iB4fXyFSNrVZIoE7RkQA6ptQn0HPJpGo/0bANaxAPsNs4BjuuaaEmT7PhmFCYKulpn YDXaqiDRPiNunkEtkMvhxUXsxGiBKnoC4wqNT7dm7gJ4uBiDyy7a90GmY0iu+oXeC8AM hFP0Amgp9W0Jz22RT8M3QZ288gVzTVaqG5RwcY1cIF3+OBDVKCyVQn0RqIF75zc/CDJ2 4M2UW7FbA33vGsnc8DQw4UGsUuZAY5gmprL2SJ+cK4vky8Fle5vA/xxAOV3GI+3yAaH0 c7vCk8QwsO3+hKbcwkAirNrV/lBS1yV1apL3BMjr/EAgNbxXT2Xt73KTZzQ4w8wF2Ca8 9zlw== X-Forwarded-Encrypted: i=1; AJvYcCUbv/w3QpqcbwBSGu/i2K9v/9szhQGJgd46BC0lO0Po8pbpVfjJwupeGvgfLsZGjqNO3lYRDfIWSD2guyp9oYpnnUU= X-Gm-Message-State: AOJu0YxbRsOVOaJlcgNGJysQJ93Rdg2ffT3gnz9yEaKu+jtej8qAjvKv CaN1AGKicQVxacRKeftuv+VfbGWH7Jn3a2ZemIoUgJ862qj3n6jhgtHlQVHfp4tAAzq9/1CaEb9 S3PfrsBrg+EKfUs6ju5tsA+MqB3Fzpi7pB6yM X-Google-Smtp-Source: AGHT+IGSVw5qqaiDJoJAzv1QgeYc1bbCjN8cj3oSXD+wUBpbm1EzCyUsNE5BXJsde0s7ePDGMdkvsVzOvReKFpqIj9s= X-Received: by 2002:a7b:cd91:0:b0:421:9502:3f24 with SMTP id 5b1f17b1804b1-4248b958d46mr33592405e9.14.1719245949267; Mon, 24 Jun 2024 09:19:09 -0700 (PDT) MIME-Version: 1.0 References: <20240620184856.600717-1-jiaqiyan@google.com> <20240620184856.600717-3-jiaqiyan@google.com> In-Reply-To: From: Jiaqi Yan Date: Mon, 24 Jun 2024 09:18:55 -0700 Message-ID: Subject: Re: [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages To: Miaohe Lin Cc: muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, nao.horiguchi@gmail.com, jane.chu@oracle.com, osalvador@suse.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 14FF518000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xrtqx1zkm8riiydkbteyfh9pw9sfz1mm X-HE-Tag: 1719245950-173245 X-HE-Meta: U2FsdGVkX18N8mvA3cVnp7k8DEmqMaVuE+aI+Kg9EBD4A63bwHa8uFlD3J5mkU33gmykayRkKpANe4JofkySpaOdEhAQC/mW81rhe5maKXBF8AZ3jJoJZwHpQ60PS2XnK+e6nUc6s375qhHBCaJP+zbguoR1XCJ4kPKsIEhU/p0G5+J3d/MITL1PMuil0Lc2b40AteqEWo3oUafhr2LbN8saCJ7UXwWkJb+w4kwhx6cMHYKz8b6NZtxQilh5hED3msOz7dEoH1kfOwDEr+ZwgEXtwaJRWP3ZeJCmS4T60k0tUrzVgizKSGs6QjZJtssw0euaBw6Tq4BJuq8EZ2JhSYhgKyRkL1fmKH4Ozyn4wvbfakKOw7UCzaI7mJuOvw99S65EoFNN6/QwSKZjDVkfpiIqqLYlANGCx0w2fXncOJCmkiYfCgUnk/YfnnG72CIklC8Mcu1NRstV2sD25g69/MgyaQHrISZrqCG4sBhQhRDa/jUBAb0TJr0reXK/zlWt779GdK3MANx9yALg2FPlssIEChLIY5NzdHKLgVleuM/duA3uYwKuPxVHg/DkDtLJ4vO8joLV22IEesgrqrZ3QVYBcrYYX5tIqaKwfvz0SrYQT/wYkxG/eol8WMeO2xCYs3KvJqn8yEVKxOjx5e+bgeeia5rQRppKGVKamDzMJ+oldBlFNZZIKMQAVIa3nv/qZ4EutlmRoef09RhQByNQv9EF8jWEpeVqjKjU+NE9iezlEwWV+f/6hDdgZP+EHx5czFvI5rXcArHqEHf2iV0x4IcZzW2ZPNRsFu3yS4KNNSIbuScRNtgnFspH923D0yoEdPeluUS5h6Y5U167XkM1N4eYw4uD2+03YrkcjrGcaSoEGJjAHmJFIneUJ3Z88sXzjvUpx0FYeVGnF93Jw//jni3EHCZYUbx8kv4ABBfYSOoO9yB3DBNsHFkddkAklTkK/DIsaZFSnI82+3mbxTU BzyeoTlo M3V6Z26bQ+rCxKdyJ9zN1VzG3JGCdf/dORNMfg6w9N1O9u/CZrKlMn8M8SzMe1SrooEAynQNF5OQmksl/Bp0m443DEMax2YA5fKSk/u/ChowT/ixlPCgqkW4j168AVBeO9P/18ybtFgf8xyEMf0jfG+p3XSsdK5q2OLhfcqPIV207dDAugIcYJLkZYooKavlMoJBQosgfhzoZdI+OgxjjYXFkh5AN22dU4PDVKB5/AlCTkiTdIyEh/lieaKetJEc4pBQ9Qrb9ykO0tAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000341, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 23, 2024 at 8:41=E2=80=AFPM Miaohe Lin w= rote: > > On 2024/6/21 2:48, Jiaqi Yan wrote: > > Correctable memory errors are very common on servers with large > ... > > > > /* > > @@ -2749,8 +2760,9 @@ static int soft_offline_in_use_page(struct page *= page) > > * @pfn: pfn to soft-offline > > * @flags: flags. Same as memory_failure(). > > * > > - * Returns 0 on success > > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event > > + * Returns 0 on success, > > + * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > > + * -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline= , > > No strong opinion, but it might be better to write as "or disabled by /pr= oc/sys/vm/enable_soft_offline". Sure, will update in v5 (which is mainly about the kselftest-related change= s). > > Acked-by: Miaohe Lin Thanks Miaohe! > Thanks. > . >