From: Jiaqi Yan <jiaqiyan@google.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: muchun.song@linux.dev, akpm@linux-foundation.org,
shuah@kernel.org, corbet@lwn.net, rientjes@google.com,
duenwen@google.com, fvdl@google.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
nao.horiguchi@gmail.com, jane.chu@oracle.com, osalvador@suse.de
Subject: Re: [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages
Date: Mon, 24 Jun 2024 09:18:55 -0700 [thread overview]
Message-ID: <CACw3F52XdxHJhDDyz1jM9SEuLYO21rvyCVZdn56-h2k=XaKiQg@mail.gmail.com> (raw)
In-Reply-To: <a272d16f-fb9a-48df-c90a-e848f2d44210@huawei.com>
On Sun, Jun 23, 2024 at 8:41 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> On 2024/6/21 2:48, Jiaqi Yan wrote:
> > Correctable memory errors are very common on servers with large
> ...
> >
> > /*
> > @@ -2749,8 +2760,9 @@ static int soft_offline_in_use_page(struct page *page)
> > * @pfn: pfn to soft-offline
> > * @flags: flags. Same as memory_failure().
> > *
> > - * Returns 0 on success
> > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event
> > + * Returns 0 on success,
> > + * -EOPNOTSUPP for hwpoison_filter() filtered the error event,
> > + * -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline,
>
> No strong opinion, but it might be better to write as "or disabled by /proc/sys/vm/enable_soft_offline".
Sure, will update in v5 (which is mainly about the kselftest-related changes).
>
> Acked-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks Miaohe!
> Thanks.
> .
>
next prev parent reply other threads:[~2024-06-24 16:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 18:48 [PATCH v4 0/4] Userspace controls soft-offline pages Jiaqi Yan
2024-06-20 18:48 ` [PATCH v4 1/4] mm/memory-failure: refactor log format in soft offline code Jiaqi Yan
2024-06-24 3:08 ` Miaohe Lin
2024-06-20 18:48 ` [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages Jiaqi Yan
2024-06-24 3:41 ` Miaohe Lin
2024-06-24 16:18 ` Jiaqi Yan [this message]
2024-06-20 18:48 ` [PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors Jiaqi Yan
2024-06-21 5:08 ` Muhammad Usama Anjum
2024-06-21 14:43 ` Jiaqi Yan
2024-06-20 18:48 ` [PATCH v4 4/4] docs: mm: add enable_soft_offline sysctl Jiaqi Yan
2024-06-20 22:53 ` [PATCH v4 0/4] Userspace controls soft-offline pages Andi Kleen
2024-06-21 23:53 ` Jiaqi Yan
2024-06-22 16:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACw3F52XdxHJhDDyz1jM9SEuLYO21rvyCVZdn56-h2k=XaKiQg@mail.gmail.com' \
--to=jiaqiyan@google.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=duenwen@google.com \
--cc=fvdl@google.com \
--cc=jane.chu@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox