From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD170C27C53 for ; Wed, 19 Jun 2024 05:27:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 647496B0164; Wed, 19 Jun 2024 01:27:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F79B6B0166; Wed, 19 Jun 2024 01:27:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E6926B0168; Wed, 19 Jun 2024 01:27:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2ED3F6B0164 for ; Wed, 19 Jun 2024 01:27:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E0DB940D07 for ; Wed, 19 Jun 2024 05:27:14 +0000 (UTC) X-FDA: 82246504788.30.2263694 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf28.hostedemail.com (Postfix) with ESMTP id 1E158C0013 for ; Wed, 19 Jun 2024 05:27:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AwWSxJ0k; spf=pass (imf28.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718774828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UMKzlr4YMJj/i6AQp9On5aFVd7CtHU1kUwtqMK4CQp0=; b=67RWbe0BPFskxVp/gXtu/TqwvsHET6Xx63Ep5vwleeLZuELj/1jZmvcvDPQHykJ7oxaGv4 hrzbEgPwiARWv6Jp+ksy7KUmcIzBAwvukn4+fg//ai5F2jx/VuPWyZRtUZyGHJ3HfuE7jW ZGnJfLwIXK5aetUcWWUClJDnauUZ/Lw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AwWSxJ0k; spf=pass (imf28.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718774828; a=rsa-sha256; cv=none; b=ul5VSCqoIZyDYkdWnvlTHT1hluFjf/o3j7iQaa/yJgblGunD7ESmYCq4fXnQZB4FgV5ZKs FCeVGHg7ls/RUu1fVLSsj/XTa2uE+Ici1AgJ93xcozJurgkaXNlEy/5LPS/97ziS9qu+5W RsRPvSdT4bgscwVl87zeaBrPJ0an3O8= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-421cd1e5f93so44480805e9.0 for ; Tue, 18 Jun 2024 22:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718774832; x=1719379632; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UMKzlr4YMJj/i6AQp9On5aFVd7CtHU1kUwtqMK4CQp0=; b=AwWSxJ0kdRfgohC+zRlUExgF1T2PVamubCPHxR3BRmS/D9pWw03LS0K1G1MPsn2GCJ yoE6mDG22yVxrn6G7QSscjISqyy0Dwv96Rk5F8ZbqcY6sd/mA6XikarIQK7XpTZvwzW5 fpk7xff0goGQREs2tGTwOyTLGFXpxPd01FdRbrDBLiu3vDJS3vh48q9aLcU7lzxVDCo5 gCr7pkKEKvmQRyHLFJiM5VJrMSght+/8oZjxkZsc+oIyQgkPdQCqF7pz34sjuS51o22E DSHPZw0PlI6VZAgPNBYFb79rnLf608YuTL/OGRtJnie0Cu2ghg0k4UDbl5w9v+TwNNOE w5PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718774832; x=1719379632; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UMKzlr4YMJj/i6AQp9On5aFVd7CtHU1kUwtqMK4CQp0=; b=eh7IYteS4DGhlb58pGmC2mRDVGxuDgQUCoostHt5IQhCEWS69CGEfCAxY0VX2XpLBa 247g1d2OnwlyCg9AJk9Y+3WQukW6f8IEuBjMtARy2m1KjECXj1RQ/WRcFNX7hcZxWCOi S18Oaa63ta9/A3lzy58nh0+Q9ES0M9hdw7rbMkmuZ1DOdNDgJtfo7Ksfx8hZyu2q0f5w j4qR0F328S+BMq93bhhJSz3L2IDSbbTI8ftOauWbRlchUfU0HFsXln4aimtaAyceuoAS ABa99kP6LBKVfhDhPBn9y1dzl/TYGIe3vPSEPTNA8uyY9nGI7D97k7RnKSllgG41YN8Z xxPg== X-Forwarded-Encrypted: i=1; AJvYcCVwrX6VCU702n/KMlHGXc/ThtTRozCy0nwhdWghY4cTmO/yLLfRkBnRJkFUKbcKqdqhQGIfRneSDAMuF+TTrV17waM= X-Gm-Message-State: AOJu0YwsFCe9byiU8MCevNQ8ikptOCmkTHdDcoU6l1CkmhzxYkMbuqf4 eZUpT2FjT4mdj1fPrPXltGdil5hFuy2hN53sUy9eitspyE9hpacuZkeopQ5zbnHntnipWQRo4Jr fmtnpAOh0b8xmB2VhSYSJSu/aEe0KLoHA+Aak X-Google-Smtp-Source: AGHT+IFJQWZ+KHiN/+sHKwZP16by1QOEq1WGoR1DxEL2A3UFRInhIe7af0qptcWZ7wTRqX0VaIgipvW1b8Mme6mmrZQ= X-Received: by 2002:a5d:69c8:0:b0:35f:2635:5b61 with SMTP id ffacd0b85a97d-3631989352fmr1085996f8f.51.1718774831425; Tue, 18 Jun 2024 22:27:11 -0700 (PDT) MIME-Version: 1.0 References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> In-Reply-To: From: Jiaqi Yan Date: Tue, 18 Jun 2024 22:26:59 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages To: Oscar Salvador Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, ioworker0@gmail.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1E158C0013 X-Stat-Signature: x6mwun3c66y6spxrxcii8xmwa59u91ru X-Rspam-User: X-HE-Tag: 1718774832-41824 X-HE-Meta: U2FsdGVkX1+JNRYfDe3btkgPcZOQDjrA7zBIB+8Of9hUaNtJE8ko7gKogGIspMK9JmGYCwjBpk+yrtbmEUDwNKGqFoiMoE3vgNNCD5BcaIVVat3Tz93pkqmu938xRij1S4OeV2Z5oGaz2aKj8DHPOv8aRbU/wuushP9zBO8w7vWGOur+jLJF5O81bnT9QKb771m3hyhyw6e4KmtwcyL2fFKpDK6BJ/3pHNaV/96RCDMLYrgx+qwROvg0vP2tZWr0bS6Yehlv0MsntMLN7mGahtHf/1uiGv9OuNZW/S+GHA2Rb5dejbrM4tOvQO40HEp4107K+ez6Jx/llP6jns3ZSvIhTVCnagAZghZDYndxcSUndDphZU+dYJNXtjvbRNE1e7/bN1OpD/XC+KSQMpd+UYx5lX7whfi53udyq83/Ws1Leh7jxJV5hWcGShLrxr5HtClkUNRcRifVT9vvYmhvAxW0BEFAXF2drnXiJg0+moX/Ulpdg500M/twEP2gPu0j6WX4fV8Ow7n7xEjNZ3AGILYTJyTsWjl+CHkas4BFGosc84jvJZ7jOQS27NDz4DHwbhJrP8qxhVFMCdVrFtY7govU6pnTjlHAq4R2wbio+jBQUmKd9EGAzL5sGKoZzn+Mee3tMOu/6AbRsuMYXg33a0YbNjS08/xxyxUkRHtraMzhd0LWjvnw9Dx3a+ir6I1WDRMyHH6L+vPVwgguKqeko9Tr24zQYF8PRMQr7xOyViJFEsk8KNeSwPRfIleYa1oscD8xvgFEL0lKECctbNKNm1Cj8blbydYemh2q0SkwLo7mFCtOfxm4fuvb8lTjGrZGulRTd6m+dNqhySEzCEdv2pyiE+aYkyG8IToBZ5EQVuc0IjaW13lGvYuUUbBjQBuQsvsw9sN3uiXyJXTIlt0Wv7X/PBZyYa8+NT3kS6OdyCNtDPyCfs9YvYpNPq1c1XbLros5bvyVXT+loBHwPzo 1luroIVa itUM9dQbXXFkuBu7ZKWDb1wbS8UjspYVyR5mQYRy+uDNIq0AnG3225QlENkANXOMlX/gLcdnh2Bz6Kk8rKsps9P7zkkp18+1g5TQnr14LGW+lHD/fnUYgxNP/MmobKp6IrCuX2/XW97kLZNWYkUAmXcCT5FfBrTF8PVgvvcu3nfsvg/9FIm8rfk+2va69AhgWMMbt7z870Hy9JIN+V5TxXLffgD4v5YBII5Bgb0qjodDdjH/ONfdeyKJ0eA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001932, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 10:13=E2=80=AFPM Oscar Salvador = wrote: > > On Wed, Jun 19, 2024 at 07:03:46AM +0200, Oscar Salvador wrote: > > On Mon, Jun 17, 2024 at 05:05:43PM +0000, Jiaqi Yan wrote: > > > + if (!sysctl_enable_soft_offline) { > > > + pr_info("%#lx: OS-wide disabled\n", pfn); > > > + put_ref_page(pfn, flags); > > > + return -EOPNOTSUPP; > > > + } > > > > We should not be doing anything if soft_offline is disabled, so this ch= eck should > > be placed upfront, at the very beginning of the function. > > Then you can remove the 'put_ref_page' call. > > Also, I would go for a pr_info_once here, as otherwise we can spam the lo= g quite > easy. Nice catch. I will do pr_info_once in v4. > > -- > Oscar Salvador > SUSE Labs