From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B6CC27C4F for ; Fri, 21 Jun 2024 14:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0FF8D0176; Fri, 21 Jun 2024 10:43:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 890C76B0111; Fri, 21 Jun 2024 10:43:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E30D8D0176; Fri, 21 Jun 2024 10:43:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 44EB26B010F for ; Fri, 21 Jun 2024 10:43:38 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E3072A1618 for ; Fri, 21 Jun 2024 14:43:37 +0000 (UTC) X-FDA: 82255164474.14.4292DAD Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf02.hostedemail.com (Postfix) with ESMTP id 156E78000A for ; Fri, 21 Jun 2024 14:43:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNIpy5vm; spf=pass (imf02.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718981005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R5g6cVCLX6JMDoyy8Jad2HKl/F+iJNHQJt1nOcWgC3Y=; b=Mg/nvoKMucqaMqwXPWbXPpFCkePD5V1L8axBB/YBXIEEE+z5pLJXol9a6h9Dc9/M2ikmfV dW3NP475omyyA/ZzwJcIb7tpY/tfGdNediEVgBrHFW5Er3vhJEnf41it3EkNUGJ49k4+nn 1S3s97mZiDQNdx1No5HLXGaDvhNwB6o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718981005; a=rsa-sha256; cv=none; b=Fonugv/iUv9SlSDLZ0ZhZqwSdcBiYr2HVKKszk8cxmWsWmDk2TbwI3Z3C1/AdGqk6nmY/9 TXDcRyoI6i+1JcSebmiy5187YYy+HUrFMTQum0eKH70j9nBZ9/HPXE/qlzzEBApX02QIUn W+tbkSihsCjW/LQxgGyWf2r/xXrOFMM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNIpy5vm; spf=pass (imf02.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2eaa89464a3so25483131fa.3 for ; Fri, 21 Jun 2024 07:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718981013; x=1719585813; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R5g6cVCLX6JMDoyy8Jad2HKl/F+iJNHQJt1nOcWgC3Y=; b=VNIpy5vmbVD+RjpOZmjN9mEJp5ejDSiWPhDhYDLhoDHCeYmP2T09AKB1lRc6AVfh6a JL9K4PgXSHijkMiP7c6/BeP1Zr0flPyo+kUXk4at4xW0p7k0vW8m0a8CJLN6ZDIysdZ6 lBTqPDMyljRzt69Oh3HJLNHDvGgBH4ajVUZpJPrioKMgPCYg5BfzJ6VjRLRA8yj37/HL De0PViMf/a066otaqRsmVmsJLj65Jzfu3RItouJHJIgCgh8q/u1pNjoMGPHbpf37OvhE JClLskkqtjXKSteJG11PyjAcSJfIiHm0IKydyZn2DlYTA26bG60vkRkTM8ALOZkfKisU XQtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718981013; x=1719585813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R5g6cVCLX6JMDoyy8Jad2HKl/F+iJNHQJt1nOcWgC3Y=; b=VWnrnTun9kqA+QhgmCrZ4GThKh9MItNbDcj0GVBAisWGr2YwmJlKFtSh54BI/2iJE9 Ye8K2tLbv+hH+xQH1z+Lah6vxaRPx1DjtG9rSKcyRk7gwgrGsjvDoJMcFhWJ19LufElq LFB6021wGNC/VWeksszmJevIxK6086mTMSpUZljoAIq6QYDU2X6uazMRuE3vszzeg/5o R/XVHqW3us++JoTOW442PfAikV4+j9ZOZlRM5/ZMk9uHqT63zMTT6anzMQ1HFPYmeadL BSeeqXFKv0EodOEc8DJ9XKJtR8g94UGRJnRtg0VArxixFxrWs7A4cc1LtOaApI2gADGY J8iQ== X-Forwarded-Encrypted: i=1; AJvYcCW0Cl+jRe+hPWu6qFmhkT+c9LKk7RaD+0enR8tlKffgPv8wlqEbkHfsNOc5gPxwtiseeYBa0WntYO6F/RSabd7yFBQ= X-Gm-Message-State: AOJu0Yy9GjryfP8D7+GAGN6suSBhN612yfnv6jojFi9ZHxzmw7q6OiPd 8cUEzeEu1VXWD2QLAumIwYWFB5bYwQfC+llrRm1ENFG9vexbi4pF0P1DVKSuscaK7596iXkbGfE Ycpb+5sK49yph+HGQ5ZRnbxQsfPlbc7qCaLF8 X-Google-Smtp-Source: AGHT+IGuSyGxky4loefW/M/7lSHf8dCMC14rFygG6Wo59hUV8p+ArOn+9K5FhkHmJFIES0QpoJxsfg1eWpdP+1EpdKI= X-Received: by 2002:a19:5e4e:0:b0:52c:db50:c026 with SMTP id 2adb3069b0e04-52cdb50c14bmr575208e87.39.1718981013077; Fri, 21 Jun 2024 07:43:33 -0700 (PDT) MIME-Version: 1.0 References: <20240620184856.600717-1-jiaqiyan@google.com> <20240620184856.600717-4-jiaqiyan@google.com> <1591a354-d999-45b4-aff2-357fa7612634@collabora.com> In-Reply-To: <1591a354-d999-45b4-aff2-357fa7612634@collabora.com> From: Jiaqi Yan Date: Fri, 21 Jun 2024 07:43:19 -0700 Message-ID: Subject: Re: [PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors To: Muhammad Usama Anjum Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, osalvador@suse.de, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 156E78000A X-Stat-Signature: ijc6oy9f7ojdb56j3d7wgdtzk3ugnwwd X-HE-Tag: 1718981014-596794 X-HE-Meta: U2FsdGVkX199m4xILQOdwO8TFWJ3uwVE+jVQ1SXH2+nC/HiRVZl6kuM3ihEZifuTkLSL1qjMYRheiPylW4fXB/fgi5kq6TYCPYQIl3LXAZf/fPlCjM2ZYeMOHbM5tWqBE/SgONDxialYjj8f1d3O32S7zMVc0TYJRQGezS+cNGiyz/pVhFWyCP5Hjx8nmaDhDT/e4v/0PrOo/ZUdRmqEGhb78SFPCWu7beVXJxlIaiirM48+bSKpqsy5eGRoBBgTUM2FLVEQlO05AF1aNxkZfVU96MCYZlv2QRRF//0QLVLK0u3KZPwu5/QBlpn6yKGgWTX8LmnTzNHvUY1j+iOYJqij9hp3mpcS7fMajhuhi1YjG6JT8D3ITeGczFXkFQjpUPqpY0TktEiq0H8SGaR5A/scUjdqDKhS/BCu/Jp0vIJfGqQ0td7utBwo8/jhuaL4+Bute0Rcjsz5GDTj2Gd5nKVHpYR35/Yo3xj9jYQsmx/KLFZtMCdhyV1knK9t2RaD56gm8REaqppAUSFR3jk9cQAY9J/Nvh1YdWRQpPY6NtMY7B0Ck3EMLdZBgFIV8DFk0p2Wa27Us8564NhIwS9xLmvboyxPW9Kf7qlRDGbwSjI7mO1S7QymDg47guodO/R18LIiNSe6mQT8Zfp1nWV3FygbptYP18ZBoihr3bIVtIe3A6aJ/3l2viCRGWWBn7QqUSG/BvTnPlsIV6gr9faGG9ds0XB6rqKmyS8hqcyILZiFyrPS2NouHRrKqxsq1WN7KPFkHVu5fNDQai2UFbiQKeyVRjfY4z9Cq856889ttztHLWIi/cOxV9PmN+E6HHmUeFbTW6BQXINEYbx8sTvHuE48sKv5abA3+1bwl0Vb7CFuAk63/hMiIss8l2IBMDpXQ+omY3kxZlX5uUF/ORZaU+YaPNG/kLvGpc/ePlq1eJZrxIroawT54/7i9Ra6U4t4P16Y5vCkl9Z1PWoIYFg qMg3eJAS 151u9jk0m6EHSZqWss0cw/YgMYOoVgONNiczZ96kHdTMyQ9MV926KkBTddlBomMYBBst7cL/vaEzWcvoloGpQkqJVQIIsexf7uDQMuT1rrUuoie0zxFh7gExJq8ei+7yEOal73mD+qh3Nn/4Oa6dn9Q7aZHva3LHbEF7Q+I3YOD49+w+CoTn7PNcJnDMMN7yAV9qPT2lHis5kFVYGowvFXlEjmp7EfDDjnh5nHi9ibzBiBHWp8FrOkQi+57D+Jtuq+aQFTvcmpVz5vhRuBsurglzMGV2zeKfUIL+KMMP5veQDBiorwWd48lQ3oHQFjM7y5KvS5NAldsoRwo3RV0EhRv4ASBLYur/ne9g77cIFsORRh7yc/y1Ffi8vCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 20, 2024 at 10:08=E2=80=AFPM Muhammad Usama Anjum wrote: > > On 6/20/24 11:48 PM, Jiaqi Yan wrote: > > Add regression and new tests when hugepage has correctable memory > > errors, and how userspace wants to deal with it: > > * if enable_soft_offline=3D1, mapped hugepage is soft offlined > > * if enable_soft_offline=3D0, mapped hugepage is intact > > > > Free hugepages case is not explicitly covered by the tests. > > > > Hugepage having corrected memory errors is emulated with > > MADV_SOFT_OFFLINE. > > > > Signed-off-by: Jiaqi Yan > > --- > > tools/testing/selftests/mm/.gitignore | 1 + > > tools/testing/selftests/mm/Makefile | 1 + > > .../selftests/mm/hugetlb-soft-offline.c | 229 ++++++++++++++++++ > > tools/testing/selftests/mm/run_vmtests.sh | 4 + > > 4 files changed, 235 insertions(+) > > create mode 100644 tools/testing/selftests/mm/hugetlb-soft-offline.c > > > > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/self= tests/mm/.gitignore > > index 0b9ab987601c..064e7b125643 100644 > > --- a/tools/testing/selftests/mm/.gitignore > > +++ b/tools/testing/selftests/mm/.gitignore > > @@ -6,6 +6,7 @@ hugepage-shm > > hugepage-vmemmap > > hugetlb-madvise > > hugetlb-read-hwpoison > > +hugetlb-soft-offline > > khugepaged > > map_hugetlb > > map_populate > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selfte= sts/mm/Makefile > > index 3b49bc3d0a3b..d166067d75ef 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -42,6 +42,7 @@ TEST_GEN_FILES +=3D gup_test > > TEST_GEN_FILES +=3D hmm-tests > > TEST_GEN_FILES +=3D hugetlb-madvise > > TEST_GEN_FILES +=3D hugetlb-read-hwpoison > > +TEST_GEN_FILES +=3D hugetlb-soft-offline > > TEST_GEN_FILES +=3D hugepage-mmap > > TEST_GEN_FILES +=3D hugepage-mremap > > TEST_GEN_FILES +=3D hugepage-shm > > diff --git a/tools/testing/selftests/mm/hugetlb-soft-offline.c b/tools/= testing/selftests/mm/hugetlb-soft-offline.c > > new file mode 100644 > > index 000000000000..5701eea4ee48 > > --- /dev/null > > +++ b/tools/testing/selftests/mm/hugetlb-soft-offline.c > > @@ -0,0 +1,229 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Test soft offline behavior for HugeTLB pages: > > + * - if enable_soft_offline =3D 0, hugepages should stay intact and so= ft > > + * offlining failed with EINVAL. > > + * - if enable_soft_offline =3D 1, a hugepage should be dissolved and > > + * nr_hugepages/free_hugepages should be reduced by 1. > > + * > > + * Before running, make sure more than 2 hugepages of default_hugepage= sz > > + * are allocated. For example, if /proc/meminfo/Hugepagesize is 2048kB= : > > + * echo 8 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > > + */ > > + > > +#define _GNU_SOURCE > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#ifndef MADV_SOFT_OFFLINE > > +#define MADV_SOFT_OFFLINE 101 > > +#endif > > + > > +#define PREFIX " ... " > > +#define EPREFIX " !!! " > > + > > +enum test_status { > > + TEST_PASS =3D 0, > > + TEST_FAILED =3D 1, > > + // From ${ksft_skip} in run_vmtests.sh. > > + TEST_SKIPPED =3D 4, > > +}; > Include ../kselftest.h and use macros from there instead of redifining. > Also try to use helper functions from same header file to mark the test > pass/fail or exit the test entirely. You can look at soft-dirty.c how tha= t > is written. Thanks Muhammad. For sure, I will wait a couple of days to see if there is more feedback on v4, then refactor with kselftest.h in v5. > > -- > BR, > Muhammad Usama Anjum