From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BEBC27C4F for ; Fri, 21 Jun 2024 23:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06A788D01AC; Fri, 21 Jun 2024 19:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F34FF8D01A5; Fri, 21 Jun 2024 19:53:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC4358D01AC; Fri, 21 Jun 2024 19:53:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ADE6D8D01A5 for ; Fri, 21 Jun 2024 19:53:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 624F81C0725 for ; Fri, 21 Jun 2024 23:53:59 +0000 (UTC) X-FDA: 82256551398.16.8ABE834 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 922A2180003 for ; Fri, 21 Jun 2024 23:53:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T6saKN1D; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719014032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q6xesaMacZace3FQ+zqQcgYnav9DuFBRmm+vK92q3yQ=; b=8BBRdsk7CACOsF4C7+Dm5JiXJtc2dCkJc8dJl9yH2tE+6PuzK5agfUAQ9UTmJmifTL7ppx qw9783WGZnhLV8L1hkqm65aGRR0+dbvxDxK3CIv41fcGu0EcuXnH4eFUcjjO+/+CFAArlA EgM0cxYXnb3iLZUoguwncGJBhn8p55o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T6saKN1D; spf=pass (imf06.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719014032; a=rsa-sha256; cv=none; b=iScbf9UX3BPqneCK72b7cEfW1608day//QwSgxE+H0zQ2mo97gifiUaKRkqzikHpyt5Iyg NCIj8dziTljkZYzMQh6kWCdbQMgbjmsWzELFC1rwXBaVc1Gh70EAqUMDRrpF+cYTK3ez1Y wvREOoSA8wWuKJiA5CqnN+ekLRieIE8= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4230366ad7bso29276575e9.1 for ; Fri, 21 Jun 2024 16:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719014036; x=1719618836; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q6xesaMacZace3FQ+zqQcgYnav9DuFBRmm+vK92q3yQ=; b=T6saKN1Do+z03p4UV9EBiSl8JfREJog8X+HZWrVsVQuuKNAY8nZSDvhocFYXc2nhbK J1x8PChc7GM0I6ftuRa1/GJmSdjKxPRJQp2lrLEozZzwCt3PA9x2bi0uF6sjsW7peSBP NE2cBruXOexYWbEBW++Wy0PO1r7DnOMzykYEHiLWts6utFtUyieXO4TlUlaTJO6hAlR2 6cEi+Do5/gc92tqt4n6ILW1ObHR+0Vt2Zrk58VVuFmGuSj/dXKxFJjn5XKOpi0iCRPHK Ro8g6K37z5r7h1JLr7C4MOskzqmw7iHeFXqfz/OhrVuOtcS6GUfSan6HIW50y/Nz9ksP 5b9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719014036; x=1719618836; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q6xesaMacZace3FQ+zqQcgYnav9DuFBRmm+vK92q3yQ=; b=ghwGp0nMjB6WZ9vVVjZlvuWCdad1wB+XTsYT8+ff1wIewncB3QmezdNhDWMlIhSyaj 3QFOnxkZGu45xZvsM50xh8L6XGnh7wNh4tdzsA6fPRfxB6laOJ/ft+5XBHjb3jwXJvMK dj+WTld/qZutrIk8BUGy8+QyVKf+RZ0b2SDC67c5s2Ub48XL1FNXXaSnxO5zSbjlojD6 CvsHbOfQeRtPKOQS3zvBCSi+MoVq9iL7HESHK7Z5hb0yjEPrrlQSAVKBUqgVmDiVKM3F PA6AuZkiyZACruZOM7XdfaHPhCegstFsdWeLbUUeA9d7u4pWGXe/GRUbGpP7KVUqB4I5 genA== X-Forwarded-Encrypted: i=1; AJvYcCV4Zoj7j0S1qlcoMzNdw2sXZO2VN0PnTBLA9iKt/PIUp1DQngjie4vKh1j2mLGk5QzObeQfy54We4AeATeamEuDIz4= X-Gm-Message-State: AOJu0YyVlnUMlwOnCW2dPwx/OTI+FrX4ItS7rJm3V+XB3nLUnmjmYetT DY5+ftrn/r+qGvmzjKHqxo+HXNBfzcflnEYFSgIV4KJ46PnO+ktlkLFs+wSOb4H3ue9J9BH1jbL LEN7cBQ5GUrLv4lDMXVUdSVfRoVXAL8VHuy1D X-Google-Smtp-Source: AGHT+IEbWjWelzpZFY63Cou53ZgSpdbbIsCKPdXNcVkLJoDwJ5in2IsqHIXIjhgjpWdIZEdefuzVToe3fpWD1sP9vtQ= X-Received: by 2002:a05:600c:4f4e:b0:424:80c8:dc08 with SMTP id 5b1f17b1804b1-42480c8dda6mr38434615e9.12.1719014035702; Fri, 21 Jun 2024 16:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20240620184856.600717-1-jiaqiyan@google.com> <87msnfusyw.fsf@linux.intel.com> In-Reply-To: <87msnfusyw.fsf@linux.intel.com> From: Jiaqi Yan Date: Fri, 21 Jun 2024 16:53:41 -0700 Message-ID: Subject: Re: [PATCH v4 0/4] Userspace controls soft-offline pages To: Andi Kleen Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, osalvador@suse.de, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 922A2180003 X-Stat-Signature: 4ngrr9s5zyxks36wgg59w1ujze3riup6 X-HE-Tag: 1719014037-914930 X-HE-Meta: U2FsdGVkX18HjgoZ0cNdxErMTxx/Vb9iH0AHp826jNRV68J9YfqfagecA8eI3YzKLwIHjyVA3Bia0heo3NrT1bL2whg6WdvvsVn5wJRLu4iFIzaFBWyOo7Md5J6p42/WOr/T8+md9T0bHVcMtMx20kG077lFMZO+flCYfqPdnxEYfvYKBqppHt16IRG+dbZ2HnPyf6Sfz759DQDzvOUESOxgQGx/L7Ahg/4OK5+4dk05cHueplwftHgknELSzRaKjYVSfUju4wUhTOSQYAi7nmbNQPAq+Ltu9VpM6qaogmnISyhNjMGwlZFPsNOgXYo5TY04tDULOSJAiCZk7EFiluBnoYTE8x0j2UJfmIlWHxQ86IrCo/rJnV8JSrSas4LCfbHVGE25G2K7t6ZlOxL5lASjDdR5eNg4ra/WtPMEV974AtHFu/0Abl0OJhUgH/vmOF2nA98nmAvNoOfrCyU/MQQYb5VAc+8Eq9QaYRnqbnOpyw5UVNB7gkpzqzdRMBINX1gNaYm/JwrqDXoT94JOInQzCQkG/Lmtxh55oA5cXE9F1lahpoSgtTQQ1egxxSHkGPvYM4brWctqgEpH3Idr/+fpZSLyPTdANWa/bzr8Z+NyMIkZIKRQbK5qQ9UW/ZX5PkY5gffoEYABbOXnaoldVxWjFM7/fQeGJeg6yRF6qa+s7FEcciwzxGMfb95xgrJN8lwLDg+4CK6sk81YTu+miNfXK2JsGnDIvoHCK+Z5TD1iuUpPUmIuWkfgRCUPYEAPxLxrtZdRpedE8SmA1AWrKMGC65kx8/d5TIktcI3RLw+wfygCwlq9ElfpOPprIIVssYC7FjwdC12Gf3BTs6rDs3YR3Ozto/rGtmf1NrdD4LAYXtC+lQM19dYyjtSh00E3zxAHz94lu7njZQJf+RYB+k0WZvNjNBiQ98ouSpUpOAYnMUIO6p270JgGMB1vovRPBChLz+Ad1adiYy9TVEq ESgEWkbK jQvOgYv4wkskC/BQECcNvknkPEoqQtT/4NX4WGwbwzF0wbt3a15g9ZDD3GJ8AvvUYR6ddCc/s7k5oqvqh6iV/TGN8X0ijDAlTD/fl284gSc+vqXUGDTw/AAYsxLQivPdVXQtf7U6tzD7o37Ue40PBKUz/pFdNUjqPMx6HYoI9jeSKU0w24yspoRdw4km1kl0PN13V1ARWP201RIDXVcGh1YDJDYKU4jHmCmzZ43I4m5Hf8ztsubSTmjAZqIkJKDV9Sg14iccLC81A+VcLvos9JVgbTlHEIUoIVZuW1Pn4PvXExI17oO6o69dPd7QgYhaFLDMqIeonIakcClmHQoySXkhXjZEBgYdWSnU+qqRKRc1xhXG/31PbpCNIJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000372, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for your comment, Andi. On Thu, Jun 20, 2024 at 3:53=E2=80=AFPM Andi Kleen wro= te: > > Jiaqi Yan writes: > > > Correctable memory errors are very common on servers with large > > amount of memory, and are corrected by ECC, but with two > > pain points to users: > > 1. Correction usually happens on the fly and adds latency overhead > > 2. Not-fully-proved theory states excessive correctable memory > > errors can develop into uncorrectable memory error. > > This patchkit is amusing (or maybe sad) because it basically tries to > reconstruct the original soft offline design using a user space daemon > instead of doing policy badly in the kernel. Some clarifications. I don't intend to reconstruct. I think this patchset can also be treated as "patch some missing places so that kernel doesn't soft offline behind the back of userspace daemon". I agree with you (IIUC) that the policy for corrected memory errors should exist in userspace. But the situation is that some behaviors in the kernel don't respect that (they either have a reason to not respect, or just forget to respect). enable_soft_offline is basically the big button in userspace to block these kernel violators. > > You can still have it by enabling CONFIG_X86_MCELOG_LEGACY and > use http://www.mcelog.org or an equivalent daemon of your chosing > that listens to /dev/mcelog. If I didn't miss anything important in https://github.com/andikleen/mcelog and arch/x86/kernel/cpu/mce/dev-mcelog.c, I don't think /dev/mcelog works on ARM platforms where CPER is used to convey hw errors from platform to OS. In addition, again taking an ARM platform as an example, I don't think any userspace daemon has the way to stop the GHES driver from soft offlining memory pages: https://github.com/torvalds/linux/blob/master/drivers/acpi/apei/ghes.c#L521= . But of course it is not a problem if userspace always wants soft offline to happen. > > -Andi > >