From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B291C004D4 for ; Thu, 19 Jan 2023 21:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1396B0071; Thu, 19 Jan 2023 16:17:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA1D66B0073; Thu, 19 Jan 2023 16:17:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90E86B0078; Thu, 19 Jan 2023 16:17:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C55366B0071 for ; Thu, 19 Jan 2023 16:17:00 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CAB112040C for ; Thu, 19 Jan 2023 21:17:00 +0000 (UTC) X-FDA: 80372808600.17.1AF1E07 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf15.hostedemail.com (Postfix) with ESMTP id BF79EA001B for ; Thu, 19 Jan 2023 21:16:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Q2GYjWWv; spf=pass (imf15.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674163017; a=rsa-sha256; cv=none; b=4HOLz/1C26CYd3MpsPpCcKeF7b8SvOe/6yWegwQk/P6Em+R4wY97Q2An0UEyb/XqXuUpyY RSlVTuVn4rHdeOlOsKtHt5BmL7A/odcuv9g7kH7DxyxyLX6FO8CTnFKRvgD6E1Od2l+1Lo r+BE1Qqerg0MZIcAojJ/7L315O88ywo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Q2GYjWWv; spf=pass (imf15.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jiaqiyan@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674163017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BlsHxkXOpYmRVQtzWwLeId+yNJcUl3Gc0etmNhW9DXQ=; b=3MvDXS4mY2qsakbGxNhpni+L40t3S9MRLtNgtCrm0D71mO93jewU7jKFxLbBQIeqBSM+Gj BMJCVR3ynOWBtroAIBW2zqCw6F1G/hMmHkFhUxIxGL/Q6vsiLg7lUH+fZo1ec59Dip3pVa DcORBVLbdZtlEEzc+SO/M/uDNBpL9m8= Received: by mail-pj1-f42.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso7124412pjg.2 for ; Thu, 19 Jan 2023 13:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BlsHxkXOpYmRVQtzWwLeId+yNJcUl3Gc0etmNhW9DXQ=; b=Q2GYjWWvceXZ+upaAJbRvJ3cc3PKDoQTpTRwLw4u4qtfGWyvpGZ5eSaZAw/NLe3aP8 oULTd+bhxfG037urXVKSKaGvBtZNh4o1ZxvGRxsybj8lwc7z60zhQw8UbC1ZM5dyh5K0 EmEI3hUpgVeUb8EdRw3iVRUjvT19OWCsWie/UaQ+9TDLZlPTLd6mSBwzIFhdPAj8Fg2+ 2aKm/OkwgN52LHr+pNU46oQ8pMT3b8eI9b8/IXe8bRMrzRs+9TUTjj5DCT5UyF3ybYho 6LEt8bNuqXvZXonIUwKmopTX3xoXBtWH412HOrYB8EIMsspbaDPJzKZV6k/JO76ngYZK R0Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BlsHxkXOpYmRVQtzWwLeId+yNJcUl3Gc0etmNhW9DXQ=; b=2gXEmT2xQcRIw7NIPogKdjPxjMWFugOxsyS04EB2ZZlCDg0fwyQ+bXQh8uL+zFrV05 rDU+yH5rQ4wu3PanevdMC4zyhri0BAXlTFkiTcAdhyRSQDx4PuoOgWNSLu54TCYH03et ypfeTiqSIQw6YnaXpHrBzmTlEQStJ1JmzEQV1AsLNIxNDWNMawff1RLjyKRQtmUqZljM GZvQgSP82ZftlY6mkMqv0eAfxaTl7mGSYESBX1ZR3oyiwrcZGUJPjVatVSbLW6DccF9P nqxiOP4CzNgo+uYmOU2ofpceAzTbh6Ps8BV2VmayrpHDJWIVcYbFA1COdq5F96YmOaq2 cFrQ== X-Gm-Message-State: AFqh2kqL/fWFWFRDne15r6QpcWR09dPPsOf3iRVNDNM7fBXMcLzOQky8 25/562WtSXoQxYeBSzv/dFdCx0jpdsDjaYV5LvX6CA== X-Google-Smtp-Source: AMrXdXsSM90U/g6DXOgFm0Hel3tt36UVsH1iHey5ow3SvxrP6F8KLBRqwIWHmcyWISnzoSu8KESfkP4A1rXIGDCoRQg= X-Received: by 2002:a17:90b:a0f:b0:213:d08f:a483 with SMTP id gg15-20020a17090b0a0f00b00213d08fa483mr1250059pjb.21.1674163016429; Thu, 19 Jan 2023 13:16:56 -0800 (PST) MIME-Version: 1.0 References: <20230116193902.1315236-1-jiaqiyan@google.com> <20230116193902.1315236-2-jiaqiyan@google.com> <20230116121533.2a8755f8c91b5e2978a1726f@linux-foundation.org> <20230117091453.GC3428106@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20230117091453.GC3428106@hori.linux.bs1.fc.nec.co.jp> From: Jiaqi Yan Date: Thu, 19 Jan 2023 13:16:45 -0800 Message-ID: Subject: Re: [PATCH v1 1/3] mm: memory-failure: Add memory failure stats to sysfs To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: Andrew Morton , "tony.luck@intel.com" , "duenwen@google.com" , "rientjes@google.com" , "linux-mm@kvack.org" , "shy828301@gmail.com" , "wangkefeng.wang@huawei.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: BF79EA001B X-Rspamd-Server: rspam01 X-Stat-Signature: nsabyy5b5n8mudbi8x8cbbgoccwb54g7 X-HE-Tag: 1674163017-460694 X-HE-Meta: U2FsdGVkX18XSFik2c2kdM1Wpd/xeFUgeKVE+C0KT1rFkyicoGaP66Ze1wJyhInWNybtGG5fbe820feX1LfOEVZBamXAzsV50AVxqe69mAlNZQpNjk676q39AI+/RR2i2yadsibWbCJ4rDj1KqavLYf6VfVUbik7NthwZPsLqAJeQ5HLf4xJvp/AW3w1DxZQ8JeKVRcqkWYTo8UwJftBpmzItMm0yHXUyykU513xFzzhA7eOu6zx/NZ1lTKp9M1QgBWDlxlqrgRGogJGKzfsFJMKCuMATX8/mxui02VN3umAiGnTmccQTMOM5CLZQiNOEwzfnrENDt8FmKxEE5p+kGngY04Wb9tFgTCZuz6x2PdNilTfItUZweSc5q8ZlFrXvVPiANO365cLxuH+y4GP7svhIOQ32q4TcHjojC60M0oY7hL7gDcrXNAEosrpMLXXE6UjvfEtdP6NCJSiG8xjBHv0ZkZzc0I3Iuc9T6OFMQrXfN3yQCySv4Lh0v+y2t8IbFtG/DZg8mYkr4ljHlWJAS7VffZJqkO0evSPYDLrFeJfXIudEFK7acFIggwQ0zAiVq8lxkbc5f/xsME+Ayso4rGmN1cxVj9slCRtpE/OPKi9r4qh+mhw0xzeEBjU+omLk568rpkd/drncuw7boCPDrokLjUDsZE0djJZweyztykgHxmN1OWHojrNsR+k9dwfwetSJ6KXb9AIiE44S0sP2yOn6odQ/VWbam5f2TcrYv6Mpn2mCM70uXmlfzugHhNtCJC++aKpNI/v6mWhhg913Kmhb18j1EppdM7BmZYLbCAb/E4Isq2FnhlSL1l57PSsZFQt1/ivtKMIimOy8Qsx6kqau2jviC6f2O/NHH6c7zBsUodHNLExGgXYY4F5fV/IKNbPeyXrnX/xKPVuH7xGbT7csDHKdtj+waschaRbTn7o61nGFaX4Q2WuDNL2V7NTw6kNJC9uf65ZmeqY5Jc Wd3t7p3e jGEeI0rOOAabTq9e5r88FWDTRrkV7ZU9iN5fHxXe6W+XNcJicf2xFsKiiQIKUD5mAW/3ByMhiyTVUKHQMP9WbOk+nf1EGMahVf0sFwqBA71xNwhx01nN2lNlaKBWW5RNlMo2rFYJMOrF5tRjmXp6i223QQG1YB5fw7LuDDgSESqssuNl6DkfUDxK9p+Zoqk9Lrgb46rsNm6vk5WKgKu1+SbXnql+RJdCp/29j8DEZQpH+TC4UzjZSxFlkujhXBMTp9H8GS7E7hhonVfMBpw5nqStgUAjfRtSpKrzjeK1HAUTNn7G80UYeaLVNxHkznrOa7pv5OJyX/WPp4/A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 1:14 AM HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80= =E7=9B=B4=E4=B9=9F) wrote: > > On Mon, Jan 16, 2023 at 12:15:33PM -0800, Andrew Morton wrote: > > On Mon, 16 Jan 2023 19:39:00 +0000 Jiaqi Yan wrot= e: > > > > > +/* > > > + * Per NUMA node memory failure handling statistics. > > > + */ > > > +struct memory_failure_stats { > > > + /* > > > + * Number of pages poisoned. > > > + * Cases not accounted: memory outside kernel control, offline pa= ge, > > > + * arch-specific memory_failure (SGX), and hwpoison_filter() > > > + * filtered error events. > > > + */ > > > + unsigned long pages_poisoned; > > > + /* > > > + * Recovery results of poisoned pages handled by memory_failure, > > > + * in sync with mf_result. > > > + * pages_poisoned =3D pages_ignored + pages_failed + > > > + * pages_delayed + pages_recovered > > > + */ > > > + unsigned long pages_ignored; > > > + unsigned long pages_failed; > > > + unsigned long pages_delayed; > > > + unsigned long pages_recovered; > > > +}; > > > > I don't think the "pages_" here add much value - a simple code comment > > saying "everything counts in pages" should suffice. If you're feeling > > deprived of columnar space, maybe just remove? Or not ;) > > I personally feel more like removing the "pages_". And I feel that the > main counter can be renamed with pages_total or total, because it show th= e > relationship among counters, and the structure name "memory_failure_stats= " > already implies that the counter is about hwpoisoned pages. > > Thanks, > Naoya Horiguchi Thanks, v2 will 1) rename pages_poisoned to total and 2) remove the "pages_" prefix from the rest counters.