From: "Kanchana P. Sridhar" <kanchanapsridhar2026@gmail.com>
To: Yosry Ahmed <yosry@kernel.org>
Cc: hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
senozhatsky@chromium.org,
"Kanchana P. Sridhar" <kanchanapsridhar2026@gmail.com>
Subject: Re: [PATCH 1/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool.
Date: Mon, 16 Mar 2026 11:21:02 -0700 [thread overview]
Message-ID: <CACpmpocu3XFnvu6m7frp1MH8_9QxHd7uZXX4QSqCPNij4P0gSg@mail.gmail.com> (raw)
In-Reply-To: <abgckU4DPI0hb6LV@google.com>
On Mon, Mar 16, 2026 at 8:07 AM Yosry Ahmed <yosry@kernel.org> wrote:
>
> > diff --git a/mm/zswap.c b/mm/zswap.c
> > index bdd24430f6ff..26de0468e33b 100644
> > --- a/mm/zswap.c
> > +++ b/mm/zswap.c
> > @@ -242,6 +242,20 @@ static inline struct xarray *swap_zswap_tree(swp_entry_t swp)
> > **********************************/
> > static void __zswap_pool_empty(struct percpu_ref *ref);
> >
> > +static void acomp_ctx_dealloc(struct crypto_acomp_ctx *acomp_ctx)
>
> Nit: If you respin, please call this acomp_ctx_free(). It's more
> consistent with other naming in zswap.c
Sure.
next prev parent reply other threads:[~2026-03-16 18:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 5:16 [PATCH 0/2] zswap pool per-CPU acomp_ctx simplifications Kanchana P. Sridhar
2026-03-14 5:16 ` [PATCH 1/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool Kanchana P. Sridhar
2026-03-16 15:07 ` Yosry Ahmed
2026-03-16 18:21 ` Kanchana P. Sridhar [this message]
2026-03-14 5:16 ` [PATCH 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources Kanchana P. Sridhar
2026-03-15 0:11 ` [PATCH 0/2] zswap pool per-CPU acomp_ctx simplifications Andrew Morton
2026-03-15 3:30 ` Kanchana P. Sridhar
2026-03-16 15:06 ` Yosry Ahmed
2026-03-16 15:09 ` Yosry Ahmed
2026-03-16 18:22 ` Kanchana P. Sridhar
2026-03-16 18:20 ` Kanchana P. Sridhar
2026-03-16 18:30 ` Yosry Ahmed
2026-03-16 19:21 ` Kanchana P. Sridhar
2026-03-16 19:24 ` Yosry Ahmed
2026-03-16 19:31 ` Kanchana P. Sridhar
2026-03-16 19:32 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACpmpocu3XFnvu6m7frp1MH8_9QxHd7uZXX4QSqCPNij4P0gSg@mail.gmail.com \
--to=kanchanapsridhar2026@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox