From: Chris Li <chrisl@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kasong@tencent.com, baohua@kernel.org, nphamcs@gmail.com,
shikemeng@huaweicloud.com
Subject: Re: [PATCH 0/3] mm/swap: remove plist swap_active_head
Date: Thu, 2 Oct 2025 09:23:25 -0700 [thread overview]
Message-ID: <CACePvbXiReyjsxc9tb-Pcq9G+kXrR_k0-1xguL0_bgKZFe2UPA@mail.gmail.com> (raw)
In-Reply-To: <aN55dzagMDhZEAQV@localhost>
On Thu, Oct 2, 2025 at 6:09 AM Baoquan He <bhe@redhat.com> wrote:
> > Can you please clarify what is the benefit of remove plist swap_active_head?
> > e.g. Does it simply the code or make swap code perform better.
>
> After series "[PATCH v3 0/2] mm/swapfile.c: select the swap device with
> default priority round robin", plist swap_active_head is only used in
> swapoff api to scan it to find a swap device according to the device
> name. It can be replaced with scanning swap_info[], and there's no
> efficiency degradation. And we can remove field "struct plist_node
> list;" in struct swap_info_struct, and the relevant handling code which
> is unnecessary.
So the benefit is removing a list. Thank you for confirming that.
BTW, I think I found a race bug in your patch 2/3, I replied in the
patch email thread.
Let me know if that race is valid or not.
Chris
prev parent reply other threads:[~2025-10-02 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 4:34 Baoquan He
2025-10-01 4:34 ` [PATCH 1/3] mm/swapfile.c: remove __has_usable_swap() Baoquan He
2025-10-01 4:34 ` [PATCH 2/3] mm/swapfile.c: use swap_info[] to find the swap device Baoquan He
2025-10-02 15:59 ` Chris Li
2025-10-03 2:38 ` Baoquan He
2025-10-03 4:50 ` Chris Li
2025-10-03 5:29 ` Baoquan He
2025-10-01 4:34 ` [PATCH 3/3] mm/swap: remove unneeded swap_active_head Baoquan He
2025-10-02 8:33 ` Chris Li
2025-10-02 13:42 ` Baoquan He
2025-10-09 3:26 ` Andrew Morton
2025-10-09 7:47 ` Baoquan He
2025-10-09 17:09 ` Chris Li
2025-10-10 2:56 ` YoungJun Park
2025-10-10 1:28 ` Andrew Morton
2025-10-10 2:14 ` Baoquan He
2025-10-10 2:34 ` Chris Li
2025-10-10 2:33 ` Chris Li
2025-10-10 2:52 ` Chris Li
2025-10-02 6:04 ` [PATCH 0/3] mm/swap: remove plist swap_active_head Chris Li
2025-10-02 13:09 ` Baoquan He
2025-10-02 16:23 ` Chris Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACePvbXiReyjsxc9tb-Pcq9G+kXrR_k0-1xguL0_bgKZFe2UPA@mail.gmail.com \
--to=chrisl@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox