From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8791DC3DA45 for ; Thu, 11 Jul 2024 14:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDA686B0098; Thu, 11 Jul 2024 10:08:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8A636B009B; Thu, 11 Jul 2024 10:08:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2BBC6B009E; Thu, 11 Jul 2024 10:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B25516B0098 for ; Thu, 11 Jul 2024 10:08:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 409FC8066E for ; Thu, 11 Jul 2024 14:08:54 +0000 (UTC) X-FDA: 82327652988.12.56FD5F1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 3BD0A1C0004 for ; Thu, 11 Jul 2024 14:08:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JxIVo3Zu; spf=pass (imf20.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720706905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cg2KkphpzKER0cp0pswf10wFUZViB55K1jgWXF/jZ3Q=; b=FnYURmQHiH/DL09vSIm6+VCXktyiMmOhgkIHUv4/jP0XcZnmSg3jzvHzZUd/qpgCbRzGdZ 8vtkuaF0qYIKwMgxxOrt+/3IgF8UlEygqIKuqTE0GaOZ/2tGGsEm09NvY33K57EmocFPV8 o6YI/0uvjD9U00ZthAGNIhtTVUbomfo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JxIVo3Zu; spf=pass (imf20.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720706905; a=rsa-sha256; cv=none; b=69vyjllaOH560YkM0n4hr9nxtEriLMxRyPe2pwpf9NEEvSlAsMImqYrncqBs1mvlNkBWNE LbcIhp51BLSVRLlmQqBdRH6B0jWYh3dnM7H53TK7FRvjP268VdHAxh7PdbFQX87LHh3Mwi H5F2TpHcRJotPARv7vofeUOt9bEV2mc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 386B361D51 for ; Thu, 11 Jul 2024 14:08:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5830C4AF10 for ; Thu, 11 Jul 2024 14:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720706899; bh=Jb9JnMiieeILvb3iq79QDI4ghaEx9ENNV87tSbXIO30=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JxIVo3ZusX0rtXH16yosijmPc0RYiPMnR3w7xpHuDYV+ww1WbIpkZ/TRSis2rRoFx cy+npKZrw///G6PjhK6BqlDLTLC6vvNlw+HayC6ifwXcLIo/we3/sN2FX9lXEFHi03 WEPNMB19P+XCusTTAmgCZVVesEYxm+jT0ckJfismAq68gri0YPFqjfTY4CsqzBlT6i B4wR7aVO292c3fqe8NgCluSqWt3pYP0cCyY2gvpFU1pKblcu2ToRSFgBVNe0mPlJMs T/Y5nfK+aHa3muyk3FMt0DWXqPRVCAWSwA8siF+HL0pf6gmmL3ML5OLNK5sAbynFnI 6j9mJTgxG1wAw== Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-64f4fd64773so10535477b3.0 for ; Thu, 11 Jul 2024 07:08:19 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWmfJAaYNoRQN1W5GztY62RDb9PGsjd4sfO7c2xInHfiaEYR0ylvGoWVNj3AxK/XZe9TBv2jQWi1nzhLnziCLS/EDg= X-Gm-Message-State: AOJu0YyVnWdtoXKev1LhtsacFYZRBCESelLe0SmJAuMkofDTkArsWACT yYJ2mzRi+pzCVWIOTZvRZ+ut7JzS/McmknuQF7r8X0XFXr8Mwj3tkNQmc46HQUr8pZzAtyan0iL Tk5fvWT0cvkcVn+D10uMpjkO1OUV6KaoqAg0E+w== X-Google-Smtp-Source: AGHT+IHLoq/PTQeo3FQR4YjukSl2GTGwepIgYGhvIjDE5lql7zyOsHBtLjiLNAk1bE2UcXtQlFM7ZTdzXIb2GOt5kMk= X-Received: by 2002:a81:6982:0:b0:627:a917:bae7 with SMTP id 00721157ae682-658ef43fb82mr85019617b3.30.1720706899028; Thu, 11 Jul 2024 07:08:19 -0700 (PDT) MIME-Version: 1.0 References: <20240711-swap-allocator-v4-0-0295a4d4c7aa@kernel.org> In-Reply-To: From: Chris Li Date: Thu, 11 Jul 2024 07:08:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] mm: swap: mTHP swap allocator base on swap cluster order To: Ryan Roberts Cc: Andrew Morton , Kairui Song , Hugh Dickins , "Huang, Ying" , Kalesh Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: oqikbjym4wuzm4ynnrtppo1jxz4c6ge8 X-Rspam-User: X-Rspamd-Queue-Id: 3BD0A1C0004 X-Rspamd-Server: rspam02 X-HE-Tag: 1720706931-764484 X-HE-Meta: U2FsdGVkX18YXFlGF369Vq5B6H+RdrzRvDR0/Vq24CDtyDFBkoYkkmGhxKw83QnsDNE+MX4D0aOr+RocaXZPAXhcYwh5DdtyFLeQ3lk0pFxTI8bZ+1t87Qc4QRRlibxWTkg2MNTyGmVZA2ALQiGNH9GqHgf9neL/yJE6qPFMmOg4Z/IGHW0z6pEwV/y1QmLp4p4xWdWuVmfbFcXdSj2hjEUDIkXFzQoVUaxLdQkFA5b2AqkIiWEBVTQIeHo5Yuty0xU173zQeIRV1FwtGjoo3U9cRqM5bXuJs2/k6Ks2hriCrlwI/TjEd0zmWXGxO8fyGXu/nEbJBaR1HAuvcgaOd/ZeOnBhxjvSsUOhpIpaJ0XOCiXWTlyD6rNZw9gDUf9IOR1kAZqFZ94m0gEjccO2W2FoIUwfGVrLmqRuxejlBiKvGW1ZaWzFzsY3VtWDxcFWuiKzVxHvijMBWTxBtqTF7x+JO0kSTXqIeaTOHlINCR6QhX7H3/Gn8ZsiQqwibn9Mk4lAUvLR7I2ZSyyj0zXrrmxt3qpW/B8S5r/addXtc/BqK62VmlDX77lmmSVwU9jOwsOui8j/3SXBNp7WNRip/oAUB1mJYfvn7nZmlbd9rzvkGKbPN5gyCXaDzAWd31Lld3PuRiTpzVFu9lG1St+LDsHA7XJ4sE1kc9I2qTh5b+mjst5FMfz4hWAta6JUkq1sbvYqDg5c2/17DeER+wgW1DCNdZUq8k+EnqHTTWRaZzEG8XO8STPD1p9M7KvWDtJIIC0MMUYWRVjInSaxBPNNpdoxGoIZhEF5TxafImpF7gc1RJh8JptE7tIg1xzIk2z4wS2No2oBe/GRPRXF6+TNzxnJO43WGCqjQyFelhmnuroup7l+jSMRolCvUIlUTRCzHk7KdexZhSvZgeur+25kU16kGSw+yeNlW3z2RvcpwIHrKaLNjhG1i2di23GaW6IaEiOhfOcxpO1k1nlzG2w NbpLmo3p D6YNHc6D2OnUkIFyq+hlWwnPgq3lpiOnbPmK1b+HnDF23vZHHsY3/v+azzDxJ7E34cd9f30KbhRT7lVKMKF5hOupkO5IpR29KgAu+P+Fmc8PE9/TxhoFiDUR/K8ciY7rJA5n5uh5KkLaTqPfTsjonhyuGuA7UZkdpU2hv4XwUS7uqMweMgxkS0cXjveeIxCHwpDRdx2sALuCGvSD/WW5aLmOFGnjLxtb9XxpidbBhLVher4vyeKoyGnqUy0qy/bGxYgPmB8MY6Oxi7oCY2lApUW/OqCwCoAbfUE6FekcHfSEytaEAoOaZ47braA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 3:02=E2=80=AFAM Ryan Roberts = wrote: > > > Kernel compile under tmpfs with cgroup memory.max =3D 2G. > > 12 core 24 hyperthreading, 32 jobs. > > > > HDD swap 3 runs average, 20G swap file: > > > > Without: > > user 4186.290 > > system 421.743 > > real 597.317 > > > > With: > > user 4113.897 > > system 413.123 > > real 659.543 > > If I've understood this correctly, this test is taking~10% longer in wall= time? Most likely due to the high variance in measurement and fewer measuring samples 3 vs 10. Most of that wall time is waiting for IO. It is likely just noise. > But your changes shouldn't affect HDD swap path? So what's the reason for= this? The change did affect HDD swap path in the sense that it did not need to check for si->cluster_info any more. A small gain there. The wall clock time is more than double the SSD or zram. Which means most of the time the system is waiting for HDD IO to complete (wait is 98%) , there will be much higher variance for sure. At this point the wall clock we are measuring the wait mostly, not the actual work. The system time is quicker, that is good. I now have a dedicated machine to run the HDD swap now. The HDD is very very slow to swap. The point of the HDD test is being able to complete the run without OOM. Because of the high latency in HDD, there will be more memory pressure. It did catch some other bugs in my internal version of the patch. > I'm hoping to review this properly next week. It would be great to get th= is in > sooner rather than later IMHO. Thank you. This new code path is much easier to work with than the previous SSD and HDD mixed allocation path. I am able to implement the cluster reservation experiment in the new allocator much quicker. Chris