From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5F9C3DA49 for ; Fri, 26 Jul 2024 05:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BC9F6B008C; Fri, 26 Jul 2024 01:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36C8D6B0092; Fri, 26 Jul 2024 01:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DAE6B009A; Fri, 26 Jul 2024 01:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 016396B008C for ; Fri, 26 Jul 2024 01:52:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA6EB4158B for ; Fri, 26 Jul 2024 05:52:18 +0000 (UTC) X-FDA: 82380833556.23.1B30D69 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 204032000E for ; Fri, 26 Jul 2024 05:52:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rEmm70sJ; spf=pass (imf13.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721973070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LyIGt8Lr5hneIWjwy92OQdXEiuACjjfv6rxddKsD9zI=; b=IhC0hpyvrPKaTd8Zxpsd8+pJFabk1r15A2n++hWOD54F9FoIZvd/929P2d43J/axIkiOuo TzlOCWwpaKU356YwPGExaoZWlh1DAR6co0QulQRmejk83hL/BGuzL6HmkecrpPhCsjmPM5 OFPqaXptQqa/hn8Ux+It3XY/op5I2hw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rEmm70sJ; spf=pass (imf13.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721973070; a=rsa-sha256; cv=none; b=E0NlQCX/f9ebwHjHiXsjdcrOT/STa2mB2XBu2Q30DtQoJZerUffbmcgvTm3laCQYom0vlL rVUYTQq90WQAuBnhStzkWnPhBisc6kG90LCq2wiMUzM6+9jEY+6LwyePGYo7Er5ARiOAnM G4rGo7PAjITr6ptGvRJWOxQ8MuFDkwY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 01221CE126A for ; Fri, 26 Jul 2024 05:52:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36AF6C32786 for ; Fri, 26 Jul 2024 05:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721973131; bh=55MZc/wVm8UcZqrdQXwtWT6wfPW4QnzsGMf95xAMunU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rEmm70sJ6l+2BjQxqwvqmzrFV0qk8hjStgKQlpxHLlUqmvv+OInu91efyqCBNo19j wKwvT9/J6L66NE5RpNsfAA2MxTKuSSNiW1hZelkXIj0G4ozlCdmBrzBPFYMn9EOinT 245PXIuXwgOTTJ9MIjcq97nOEcjPPXnKq25Cm3ywwyB/PH/oaf6f/elORzeoiXyEGK 5jM5Kq71Y11vaw76bf0KyHt7G8d/x4pbDd6nLW47Si2Wx0tW6zVCPKk+saWS7JtEVY znaLr7tKLmUXe7sZrBux2JIigvXLU1Uqx4D3VI5QSAq09rM3InDTzVv+pyV1Q4NC1K xAxEY/3JTEUKw== Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-66a048806e6so18545257b3.3 for ; Thu, 25 Jul 2024 22:52:11 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUP1fpwvsnJfIW7vf2QqCHGq7yBadigjfvKRwkRJiE3e3ahSQkOVkU4GU8WZOq38KzFknPxJK6h0j5wsOEE6ULKipA= X-Gm-Message-State: AOJu0Yxfvs+WFHYajHXNr2HyDeARtcCRH6yof+zoFd8KnyzZ+o/HxO2T arHDCWcQyKQCakiP4p0W7CN3gUF05kJZ+gESmgMHH6kZ4q2VFQmrhDUXJX9AzbbqD99S2im+MyN 5OOTnWfe/OUasaiONO14Eq5JHYIMDBh1oVSpQbQ== X-Google-Smtp-Source: AGHT+IGvBUT1tDhncfh91DJY1WlS37LbkBfdz6tgAtI3DjY9RI63TBM0254gjG1YiX6EVVRc4wN1MxoCXIYwlAT/+iI= X-Received: by 2002:a0d:d002:0:b0:62f:a250:632b with SMTP id 00721157ae682-67510dee934mr55444067b3.8.1721973130523; Thu, 25 Jul 2024 22:52:10 -0700 (PDT) MIME-Version: 1.0 References: <20240711-swap-allocator-v4-0-0295a4d4c7aa@kernel.org> <87cynbxn8e.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87cynbxn8e.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Chris Li Date: Thu, 25 Jul 2024 22:51:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] mm: swap: mTHP swap allocator base on swap cluster order To: "Huang, Ying" Cc: Andrew Morton , Kairui Song , Hugh Dickins , Ryan Roberts , Kalesh Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 204032000E X-Stat-Signature: irp93uan9qt4nmamcyak5uxdt96p74od X-Rspam-User: X-HE-Tag: 1721973135-518674 X-HE-Meta: U2FsdGVkX18boVZN5CktNRLe+LDltTPRLZwNGAIBIiRRxM/EK8bSIUI1Nu2hqzcPeF4kGou09VufcXvHdG3gmiRZn1j964jsudUov9e1HWjbO3t5hWxtbKMz1vTKFdWC/Fct6Sujb8ehbVF3wKa0DUgHqEzwdbd0Ie9yWf56yvgbYoCcWxumTd2F/fvkw6LViaJHmssBA8jpNmTAVRtDHU8zQjdGak7elhJUtyqhbBqMPUu1icOKRek92cwgIeBE8WXy09sWyLLvENzRnbhBgmwOaCKmNA8ArXUL7QOV99eWwRRvgRclaJCk9iobzM8lkEjWX/Rak316aNY6d+IRoSVNPd3cLq163EhCs4TjbUiED52ZHVoJc3GqHqsUb84u2sIYRevggs4Td+G9EDZW4SiDuQPUWoB3q8MR0wXvvTg0hLnIEHAYVx/pNE3pSsDuy0RqJ5mAaG+qRcwW0S+834zxk/OAWCPJ9sIoci09y4maBfHGqzEH7HXaJEMRF+mynRd3PD09974/oCI0JGJkqEPS891C6FGF9Ovx1dP8QUVvJFO/uLnsEhk1IkvMSN9TQubWFbGbK3YQSCXHlRLS2A70fZzw4ju2qEf0yltxza21dBgiUzMBPOsw2x++qbiSZK07i1mGpMKVsE3Wkppyv20el81x/LYi3FC/Mb6JPar5BOQ0qzzi3y3G9K7YQYbD1O/Tfxq6PRB6iR4du7SbCn0BK4Wcg6j4rocflb9d2WiIF8FGRLYaiwwo6rXlh6w9RDeenOkg7vUwPREdVkghPZluvm6C2/J3QjUXGc35FNKoCqjNcAkL2ZWciQz/uFesrYoYYqH3UALxXZ5pyNOU3B8iVm9EAfp0DzrU9x6BfafJIuxezrxWowd47hCz6u00ixZVG4NJQIE9RtywianEtDuR+aKQ3vcQ2RI8R+xBbkHy662GnfEdXC71uYxorDd0mv+cDumDhPVNaZ8BNeR wi/jrjpM pv0NY3xBIclr8LeQOVtdS4uhMVYHZ5NjuyjCdmxAXJ/aBvoUGKmWb2xZ4IAmsITn9/mr5NQ+GM9EBnIrsCsdyvNsFdf6qVjXF+SoTXBkww8rFN+YWrZbvf4OtUsWRfGNs+Dgt+1KHvUYWjQi4tVam6J4EKOllEbYxi4rpwMQ0GokLzbX04tP7HacfeuVgyvQsezKbFH9wqcJio2WcO1BFFAzj4tADOKzGblRVjCuSnYEEbAh8H/48/2P2Y/jrAzR0f0CEaBbvVTq0hfOrIx1RuamqAU2eNwfynNoak41jCwn9u+0M2DwE4NiJ1xLmAbLHqkbEGYv0zgHZynaWKWsQ9WdbKtlltaRnrZ5u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 10:54=E2=80=AFPM Huang, Ying = wrote: > > - HDD swap allocation does not need to consider clusters any more. > > It appears that my comments in the following emails are ignored? > Sorry for missing some email catching up. > https://lore.kernel.org/linux-mm/87bk3pzr5p.fsf@yhuang6-desk2.ccr.corp.in= tel.com/ Will reply to that. BTW, V4 already reverted to the previous SSD behavior and allocated a new cluster before nonfull cluster. > https://lore.kernel.org/linux-mm/874j9hzqr3.fsf@yhuang6-desk2.ccr.corp.in= tel.com/ Already replied to the renaming in another email. Chris > > > changes in v3: > > - Using V1 as base. > > - Rename "next" to "list" for the list field, suggested by Ying. > > - Update comment for the locking rules for cluster fields and list, > > suggested by Ying. > > - Allocate from the nonfull list before attempting free list, suggested > > by Kairui. > > - Link to v2: https://lore.kernel.org/r/20240614-swap-allocator-v2-0-2a= 513b4a7f2f@kernel.org > > > > Changes in v2: > > - Abandoned. > > - Link to v1: https://lore.kernel.org/r/20240524-swap-allocator-v1-0-47= 861b423b26@kernel.org > > > > --- > > Chris Li (3): > > mm: swap: swap cluster switch to double link list > > mm: swap: mTHP allocate swap entries from nonfull list > > RFC: mm: swap: seperate SSD allocation from scan_swap_map_slots() > > > > include/linux/swap.h | 30 ++-- > > mm/swapfile.c | 490 +++++++++++++++++++++++--------------------= -------- > > 2 files changed, 238 insertions(+), 282 deletions(-) > > --- > > base-commit: ff3a648ecb9409aff1448cf4f6aa41d78c69a3bc > > change-id: 20240523-swap-allocator-1534c480ece4 > > > > -- > Best Regards, > Huang, Ying