Re: [PATCH v2 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c

[Chris Li <chrisl@kernel.org>]

Hi Barry,

Thanks for the patch.

Acked-by: Chris Li <chrisl@kernel.org>

Chris

On Sat, Mar 28, 2026 at 12:58 AM Barry Song <21cnbao@gmail.com> wrote:
>
> From: Baoquan He <bhe@redhat.com>
>
> Codes in mm/page_io.c are only related to swap io, it has
> nothing to do with other page io.
>
> Rename it to avoid confusion.
>
> Reviewed-by: Nhat Pham <nphamcs@gmail.com>
> Reviewed-by: Barry Song <baohua@kernel.org>
> Acked-by: Kairui Song <kasong@tencent.com>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Signed-off-by: Barry Song <baohua@kernel.org>
> ---
>  MAINTAINERS                 | 2 +-
>  mm/Makefile                 | 2 +-
>  mm/swap.h                   | 2 +-
>  mm/{page_io.c => swap_io.c} | 2 --
>  4 files changed, 3 insertions(+), 5 deletions(-)
>  rename mm/{page_io.c => swap_io.c} (99%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 16874c32e288..bb7c1031886d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16915,7 +16915,7 @@ F:      Documentation/mm/swap-table.rst
>  F:     include/linux/swap.h
>  F:     include/linux/swapfile.h
>  F:     include/linux/swapops.h
> -F:     mm/page_io.c
> +F:     mm/swap_io.c
>  F:     mm/swap.c
>  F:     mm/swap.h
>  F:     mm/swap_table.h
> diff --git a/mm/Makefile b/mm/Makefile
> index 8ad2ab08244e..a65ac900096a 100644
> --- a/mm/Makefile
> +++ b/mm/Makefile
> @@ -75,7 +75,7 @@ ifdef CONFIG_MMU
>         obj-$(CONFIG_ADVISE_SYSCALLS)   += madvise.o
>  endif
>
> -obj-$(CONFIG_SWAP)     += page_io.o swap_state.o swapfile.o
> +obj-$(CONFIG_SWAP)     += swap_io.o swap_state.o swapfile.o
>  obj-$(CONFIG_ZSWAP)    += zswap.o
>  obj-$(CONFIG_HAS_DMA)  += dmapool.o
>  obj-$(CONFIG_HUGETLBFS)        += hugetlb.o hugetlb_sysfs.o hugetlb_sysctl.o
> diff --git a/mm/swap.h b/mm/swap.h
> index a77016f2423b..161185057993 100644
> --- a/mm/swap.h
> +++ b/mm/swap.h
> @@ -214,7 +214,7 @@ extern void __swap_cluster_free_entries(struct swap_info_struct *si,
>                                         struct swap_cluster_info *ci,
>                                         unsigned int ci_off, unsigned int nr_pages);
>
> -/* linux/mm/page_io.c */
> +/* linux/mm/swap_io.c */
>  int sio_pool_init(void);
>  struct swap_iocb;
>  void swap_read_folio(struct folio *folio, struct swap_iocb **plug);
> diff --git a/mm/page_io.c b/mm/swap_io.c
> similarity index 99%
> rename from mm/page_io.c
> rename to mm/swap_io.c
> index 70cea9e24d2f..91b33d955e63 100644
> --- a/mm/page_io.c
> +++ b/mm/swap_io.c
> @@ -1,7 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - *  linux/mm/page_io.c
> - *
>   *  Copyright (C) 1991, 1992, 1993, 1994  Linus Torvalds
>   *
>   *  Swap reorganised 29.12.95,
> --
> 2.39.3 (Apple Git-146)
>