From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2005C2BD09 for ; Mon, 1 Jul 2024 17:58:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A1C36B008A; Mon, 1 Jul 2024 13:58:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451916B0092; Mon, 1 Jul 2024 13:58:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F1EA6B0093; Mon, 1 Jul 2024 13:58:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 103BE6B008A for ; Mon, 1 Jul 2024 13:58:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 75164141415 for ; Mon, 1 Jul 2024 17:58:57 +0000 (UTC) X-FDA: 82291944714.30.9656AA1 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf09.hostedemail.com (Postfix) with ESMTP id 9DEE1140006 for ; Mon, 1 Jul 2024 17:58:53 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chrisli-org.20230601.gappssmtp.com header.s=20230601 header.b=RvAwfVcv; spf=pass (imf09.hostedemail.com: domain of cli@chrisli.org designates 209.85.128.177 as permitted sender) smtp.mailfrom=cli@chrisli.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719856712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9StUTNhxwCy/pDRuf8/7L71MaUer3QRVVlv9U1S2xNU=; b=GE+GAVc36qh6ipA0tqbFvih37/FrvZPGXkJY6z1nqLXYxdVFZ/abW2IBPL/YnmD5OndECz Sl1em1N0zTTj6MctaPFM1ys5bmJPPO0n8kQmQjuZIfxNGPnmKoq0UvTzfPHEqUKkSeYsCV ARMTQISoYwXu3BY2l35jDH3b4ND+l74= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719856712; a=rsa-sha256; cv=none; b=n/sh4Q2xpOR3HC4R9u9HLG1CNnBZAiTq896BqwDkGMXLgRwS/wI9SnvG+mnvmFwmmCR+4h xQNqyzTIhdFvx6XYlOr1V23/c3GaqYk9+xdwrQW5b4Dd7Genehy/1rSul+74vilZGuJWOH egAQ6/enVmPvK8N8TZsKnVTTJ2MJSmg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chrisli-org.20230601.gappssmtp.com header.s=20230601 header.b=RvAwfVcv; spf=pass (imf09.hostedemail.com: domain of cli@chrisli.org designates 209.85.128.177 as permitted sender) smtp.mailfrom=cli@chrisli.org; dmarc=none Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-6439f6cf79dso25027427b3.0 for ; Mon, 01 Jul 2024 10:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisli-org.20230601.gappssmtp.com; s=20230601; t=1719856732; x=1720461532; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9StUTNhxwCy/pDRuf8/7L71MaUer3QRVVlv9U1S2xNU=; b=RvAwfVcvw/x2AmEEFFw1cFc8JOOcpUmdBzuz9a8UpPv7NpCTODLYsPzYGCLpoiE0dI zBqHxis4hWS8UMM69MOqtFfhg00qK+3g7c0CUL574GWeqoPq7KfaNDb7VtWgKcFCFSLU GB+in/LqlsbyG3PElEgHdyp+dYU+A/iBt66/BzJmnPSxQ4aqFWfZAGJZNQlycEk3rgGz zTAzv/+TdNc75XLc3lMegEpUGYA9uFkd0HfiKtlF2+xazE6ZgxljYhIsLZKmDZPkVfeW qrvJ+eNXsXvr3GN5ICFYb9/7JiKB+ZuQ17gpHltgMUzbQhfuCAhCoZH3jJmxt1DTeQC2 clLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719856732; x=1720461532; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9StUTNhxwCy/pDRuf8/7L71MaUer3QRVVlv9U1S2xNU=; b=S2qSi/doC0DbxrTORBo6pV/O2eyMrQg3h8oz6DAprXszQ68mi4C6CNL0O+iV46SY7U ZWEBvH3dZwwHGvRCVgxzWrqQQIpFtCnTgkf/lpJfaKtyS3zvEu9JunfiX/EQNapkI5PE 3rM7sNBLSM0rmUvFvt4wL2wFTBai0zM5Qq8vav7xfzfcX129peRrTJ1934e75ei3JyLU IM2SjUQ1drnwqnOuhsFtSLnepx3QOb38DcEGIeRLC8eG21Vm9RFdukJUvmyF/Ktrkao8 2BtnNQvmED3NPNCDtw2rF0nbR36RW0CejsmUqsE2CyYnVFk3wckXhQphgQ9cHF5M5yE6 2tKA== X-Forwarded-Encrypted: i=1; AJvYcCXZXhPLHPnv0zM+ilHSz38pL2U4z6nQG/TXABAPmWkYnivcvKIXVW/06wvUcLYPjUzjbFTz7eXcQbJS7osu2P3Y6cM= X-Gm-Message-State: AOJu0YwZSMzmmOM1XDv3vUUEFIZxTGvulbCuGovKzw02TBWQpIzAe8YR eG28G9Tm0rTwwFLIdmm3AdbK34rh3IGICVYupwCubvIO/6EDnrMnk1B+ZJv/ryhseA+UA9mBrJK xCy4bvyXCQQvpbvqYR94UW5L+HTFP2a08XbQrFg== X-Google-Smtp-Source: AGHT+IFJluQuwD1WcAotSkbFXZSCdGFCSEJsz0a4V4lxTs2mfUgp3DWk5Hz/0vqUyKZs3Prk2hk7RE+AVR9pUzOtbpY= X-Received: by 2002:a81:ab4c:0:b0:630:d0a3:d2e6 with SMTP id 00721157ae682-64c73bde7d6mr59684427b3.49.1719856732638; Mon, 01 Jul 2024 10:58:52 -0700 (PDT) MIME-Version: 1.0 References: <20240629232231.42394-1-21cnbao@gmail.com> In-Reply-To: <20240629232231.42394-1-21cnbao@gmail.com> From: Chris Li Date: Mon, 1 Jul 2024 10:58:41 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: fix zswap_never_enabled() for CONFIG_ZSWAP==N To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Yosry Ahmed , Nhat Pham , Chengming Zhou , Chris Li , David Hildenbrand , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9DEE1140006 X-Stat-Signature: 3z8k18uekb7ico7n9eqscuqj3fhzj7cb X-HE-Tag: 1719856733-570012 X-HE-Meta: U2FsdGVkX1/TN6+ug63ri1Ybizb5UweeY8QQ0sg0MN4uzL/PRtS/OSXrIVexV60IpNAPowKMAcbMvsFu/Q5X7UIgyJ3Vz/bS/kyIrBIXI3nqBo282Td+uIKLe5r5Ton8gXZdtHx50jY1kt6AP6P2ed3bz5I3lWrujP/xm3xLVSWnj/x/lAu/ecntxrbPS166VqchyIPdP870WQ0d4pNNJd0V6b5adkYfWK/qV0OE9YSq+/7CCUEWWjfsS1bMGXS8noffgH9tm4j8fweaeNLe/aEq18Un7R5frsXs3M/nlavvnY9sl4L6Par+nIKyyAc6W7eKFrapLbDFQXVHuYGep9yoGDl69ousIWkmNBcqW5RzlU9/i6c5MUoCriCIPAEMJB37EBUIELi8F2S+EJcClknkPW+7vwMvPiRGrtvgYdl7LWpXaWA29dbDO00x7O0uoX/+XZvMFNQaA0UR9vV2vhy2BTWXWCJvR9FgwvGUFRJqaa0+vVqL9n5cYDlXafZJHVkArJWZtYFwBWvJ8Plsf4vCtsafhI6fUPBj8KD7Dr7jOH7nbHQ7vu1JYKuxTUkuuzBRK6M8szzC2i2+hcB5H+SdiW8uY1JiH7ix/7HH7RpCMflfleLGnhhRJR04bE1QtQrV2CqKxkBDVf8tZueuFbEICpkFuJ+2EcZjgkd6VZoXo4Er8jnn9YU+Bcohkp+7vxBjSCA4StinssrZInrfDQaht6K/4dHqS8qg0vnrTRri7+6ziq0cJCHxj19XvWupzk/Hyxpud2dFTZ3ynXqiqp4LcfTlNLCmMDb6/jb1EPjRb1Y8BlqWhHe23HyVSsH6Wu7FHf9FpwnaTBR5rqEU2Np2YqcOMUwwTbfiK17zMwffHubdO+6MjOs9SYLa0V+kJ96UUrcnQJ8Av0hpaf4QmdHuGwsUGXubv17T0hD/iRup+ETa4vk4PKG3wNGKedy+EWD4thIIkF4voT/gv3l jOUxrR8N XMcbVrs+WjdSAQc/5DLaeOcWeOVQ5JgOPLOO+eywE/oVoxy21PuBOvwCbqGe/kmCYjAuh7vcf4/2p9kVuW0b6ceLqVy5TR03UIFGWmhIrGz4PXlqbeqt6biiVW5Z3vxdnc6hrLTaNrOzJF1Hmu+EPqP93JV6GeM+TJcRTqaXRW9/IIt0gHbHF6UG3yxOACivBN2g8SgcUzT/Tcx3M/GGSv+6ZeiFEzmetbQj4hHOIUsqTKH5B2LYwb7Z29o2FFHkPd4wx6QGOOiXLhchyre2PO+NakV1n4/eUAJQfGyLOLImUZEsXKe5lGlrY+JmLKM9kmm3W0gMFtu7jgOV0eFpkEPmfOUr9Qw6T5vYIlJBHvDPo/yxmGmpu6nnkRMLRpB7FllsAj5VJqUq5IOxNXoLLAvwGS3TxGPMxbO7WYk8SsC6XmmocD1zMxwyWsm/CGRPSliZ6cu4dP1YDFxZGyXEqYWTil1WnrY+msGn5LPgpJ8ZnR4VIuVaqq29Xtli8ulmi6WraVwDcPM41v/n0VdLtAH5BgeCryoczlYL91gKgyTcq+75qCV5QJrLsUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Acked-by: Chris Li Chris On Sat, Jun 29, 2024 at 4:22=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Barry Song > > If CONFIG_ZSWAP is set to N, it means zswap cannot be enabled. > zswap_never_enabled() should return true. > > Fixes: 0300e17d67c3 ("mm: zswap: add zswap_never_enabled()") > Signed-off-by: Barry Song > Cc: Yosry Ahmed > Cc: Nhat Pham > Cc: Chengming Zhou > Cc: Chris Li > Cc: David Hildenbrand > Cc: Johannes Weiner > Cc: Matthew Wilcox (Oracle) > --- > include/linux/zswap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index bf83ae5e285d..6cecb4a4f68b 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -68,7 +68,7 @@ static inline bool zswap_is_enabled(void) > > static inline bool zswap_never_enabled(void) > { > - return false; > + return true; > } > > #endif > -- > 2.34.1 >