From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB893C3DA4B for ; Mon, 15 Jul 2024 18:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D6FC6B0085; Mon, 15 Jul 2024 14:15:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 487316B0088; Mon, 15 Jul 2024 14:15:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39CED6B0089; Mon, 15 Jul 2024 14:15:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19BEA6B0085 for ; Mon, 15 Jul 2024 14:15:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C25EF1A0147 for ; Mon, 15 Jul 2024 18:15:00 +0000 (UTC) X-FDA: 82342788360.01.760F57D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id C91DE180014 for ; Mon, 15 Jul 2024 18:14:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sEwxHEHZ; spf=pass (imf06.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721067261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NZApIlD7ssYyOqXECa9K8Vw+gpZFeckSQnqRM+QfYCI=; b=sxv69WODkjX50GyjXR4p+4ZfTqI/6qwyfE7G5eDF0krcZdmp+DdlzHusMfrANh55qJL6Ai EYDwQuyzwMPqyFSaCjgZ7XHoixNo2tta7UfaYntkDoej7ATeHkeLFCsR+m6XvzSMavo68F CsENd+ypnYDVH+BTrg97ytBzYUZdMPM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721067261; a=rsa-sha256; cv=none; b=lLDJ+Z4aMsDW3GHNnB9lVy0CD6IECPWXzHPOvEic3Es/uXYPCZsv7LyrS4s+8JM2w2oZ1L 7nP9vD6yffmAy+Kjp9eB2p+MoLOzWyrXFVWkaPFHfZJAA29Se4Qlrc7p0mfnruAf43fGF7 djbDc8iT9DBmTMS2t0/K8i+IBs7LHb8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sEwxHEHZ; spf=pass (imf06.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AFDE861228 for ; Mon, 15 Jul 2024 18:14:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83BCFC4AF0F for ; Mon, 15 Jul 2024 18:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721067297; bh=pkG7Cs9FXIoXw0oST5k8OaEYVti3bYwd5melFbuPCFY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sEwxHEHZno6EWtsRypvMBn9TitxsBAigzrfFrFmmIjEadcW4OBnqJMlzFCkY8g/L6 n5glmxExyaYc9P4zJ43Zj2c+RruuAvOvA34tNG7TVwioZDuucWlQiiff5+eUBi4FgT CmY1k6PIqYIcbtH3X8yGQxCm3prdKg///4GEGPyXmLVR6jf3eSMjrp93lokyhLRdjT kkQCco0qP1/H+FkA30beIkVA4uelF5rSgFgsbTh47UEsWNNnlJVRRMX5nPLCI1q5og xgIBieb751oPpjx+aMvf79DKmWLzx820HyQs7nGWu9pgp32GWr3q9v6BYPOjj0YlFJ 5E9GzNcakiN4Q== Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-65f9a79fc82so19132077b3.1 for ; Mon, 15 Jul 2024 11:14:57 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXr3kjglXgSd5bdmqAxrDlJ4XOT1gDWaLYY9Fc9bOC8XBtFPWeu0VqXwmQrGSrrfJlymvMfCZAWx7d3BxdtOu3v1/Y= X-Gm-Message-State: AOJu0YwIy6qX+Dwp+svwWPpGlr2nk/QP1iDPT1sMLnaJiqnFRgDAe+SQ VvLS8p2mE1xFA0BW4X11eFUHjYnm9ZEQ1gzxbYem21NUyATsuQ/VAXMhU4LdqRw5y9WF/X6ftjW hQGSsu/V9S4IWqjzV4ZVr7Hw+MBs5LBwaw0LQ9g== X-Google-Smtp-Source: AGHT+IHN6aB8kpFHIkwT0wmPtPe+KZzaSCHN5poijt1JLe0tZYufOAZaDskX/p7CIDQSZEPTg9FznNilUurHC4QVIN8= X-Received: by 2002:a81:c248:0:b0:644:2639:8645 with SMTP id 00721157ae682-6635497ab0fmr3301967b3.26.1721067296826; Mon, 15 Jul 2024 11:14:56 -0700 (PDT) MIME-Version: 1.0 References: <20240711-swap-allocator-v4-0-0295a4d4c7aa@kernel.org> <96965a23-49ea-41f5-a4b0-9b5296dafe00@arm.com> In-Reply-To: <96965a23-49ea-41f5-a4b0-9b5296dafe00@arm.com> From: Chris Li Date: Mon, 15 Jul 2024 11:14:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] mm: swap: mTHP swap allocator base on swap cluster order To: Ryan Roberts Cc: Andrew Morton , Kairui Song , Hugh Dickins , "Huang, Ying" , Kalesh Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C91DE180014 X-Stat-Signature: 4bjj3oaji4r9ep1mbajpenj5pzfozip4 X-HE-Tag: 1721067298-790278 X-HE-Meta: U2FsdGVkX19Styk77OEpDSugetP1/rM2PX95bETSWWDX5/s78svtkPsC/+Nh9w+mhpraOFUw3RyxArIOjef0rrqY3xjo8ytRPGLlAJZ+5VcTJ7eshp4+aHh1NOnXJ4T8VCIO7fdHktKCm0fCNPqXzEtpaFL5j5bzdqvFVVAorh6C5YglFzDWzbiLNU0Blu7IpsHCRwrHoFBaNkyZdFQgIJp4dQVnkomnArl+pyxCMglXy08fd8NpEPXjCWb0ubwzkG9Spu+EMF89fN2GNGyARKQWiCVH4Xjx2SaPcV4yrmUKWi+UWllu65K/lMWZ9muAeWhUzj3Q2Y7HrapL0Y14xaPNAGshiND82c9kOEahVZE422/4WgNmBvXgYt1eDhYrSEw2YJpYAxQUfGzfQcrqCYv0ZCNlypxTrDDq1ehF117pjvD2eeNUBjpWQYcrH9++fKoImtfF5C8RJCCTdZTAs/kwg944QBlPxTZ2l3kFxVg8p2g0uj7EcstNIlr5dqf5K3icE0bPWM8681rN8Ab9fyOFMOTP/+KCPGJIDz3cR4BFq5QCfqymFbaq4IkaAjbqFWsZ6FB4dATYakrxxB04wAG45BttUo/PjnyYCoWUrvEXqZ86MWgr/7PfGzYZSVdsP08u9MgHMVlselirZhfvNuZDX3r9IrgPsuRD6CyvMObuVKkK7s6IvfeCli2ZVdAhKK0zLHvJ+6r2GPd4jPgqRRJkaONEBibFGDJdnLzAjFUKG7TEHHvKUJ22u6zezF4Cqwf2OcrNDsr5FUga9J+/fNjAu9CgDuj6r2jTNc/c8oD2mft0a+LApsPAAjYRSvAE/EUVzrbq0oWFPBSaPf8LMG3F0M4zgJ51UfizvgwYPshSGvp4fIdecR6UPCupscQJvDg+mvJ+rCcYxNmh84lweGnLeOW8KFt705ZNbLRO3yLiXWbt/1rZNqZmLMFrmceUB0xeu63GLx4oWSPuLiM St0EUlMb IjQD4s3MXHQVFgUSECHLOi39/0v+j+zkMek3O4I33orAdbgDME/HZaVyvZ7Ib1POFTKhU7BUooOyYk3qon7nbJ1hlfqPTj8Fddb3b8xk5NHS07sXGAnSt3WmXt2Ix4CdYQRmeNLrKokOGEQwU6ajeTCsSQc38QczQtRCEwS+IYEnC0Ly52QIwh4GqDn1tamorlra5dSXNgmToVLeT4zcfoe7tzxLZ7zkxOCwvaAQ+9+c59JQzKkOHw0ZRHzv3TH6bKRMzvhM4HX44fZq3MmzvPK4ji6aNIvl77tfS8TSxuSJc8qpj82nerTnl9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 7:10=E2=80=AFAM Ryan Roberts = wrote: > > On 11/07/2024 15:08, Chris Li wrote: > > On Thu, Jul 11, 2024 at 3:02=E2=80=AFAM Ryan Roberts wrote: > >> > >>> Kernel compile under tmpfs with cgroup memory.max =3D 2G. > >>> 12 core 24 hyperthreading, 32 jobs. > >>> > >>> HDD swap 3 runs average, 20G swap file: > >>> > >>> Without: > >>> user 4186.290 > >>> system 421.743 > >>> real 597.317 > >>> > >>> With: > >>> user 4113.897 > >>> system 413.123 > >>> real 659.543 > >> > >> If I've understood this correctly, this test is taking~10% longer in w= all time? > > > > Most likely due to the high variance in measurement and fewer > > measuring samples 3 vs 10. Most of that wall time is waiting for IO. > > It is likely just noise. > > OK, that certainly makes sense, as long as you're sure its noise. The oth= er > (unlikely) possibility is that somehow the HDD placement descisions are > changing, which increases waiting due to increased seek times. I sure did not change the HDD placement, if the HDD allocation is different from the previous code, that should be a bug. I mostly remove the cluster code path in HDD swap entry allocation. I did the HDD run mostly to make sure the HDD can still take some stress test on the swapping without crashing. Chris