From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0E5C5320E for ; Tue, 20 Aug 2024 08:51:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFF146B0088; Tue, 20 Aug 2024 04:51:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E86DF6B0089; Tue, 20 Aug 2024 04:51:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D281E6B008A; Tue, 20 Aug 2024 04:51:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0E836B0088 for ; Tue, 20 Aug 2024 04:51:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6E174A1908 for ; Tue, 20 Aug 2024 08:51:57 +0000 (UTC) X-FDA: 82472006274.21.986D6DC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 6B3DE180003 for ; Tue, 20 Aug 2024 08:51:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BwkBU4Hx; spf=pass (imf06.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724143836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FvXVRoMnzTgKuTO34vuby1aQR7Zxmnhw/CIqOMIi50w=; b=QPvUg7xz947hY9FGBARgFC8al3xUJB/J+7CsxC3nH6ytfo7M/IuVypFPS71KHdKqGTC7/a fGEIok9tdOPK3vgrG7yWkPmbv0GlBbH8d64o3ey0xUqM9pbWUQaaHkDPW+PpJ8OQF4kGmL 9kCOzIw/Sc+Ttl564Va2e8k6K3a6YEo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724143836; a=rsa-sha256; cv=none; b=qlftzbeEl9VdI/i/ohDDtJgTtNB1d8P0MWOrwnQsk9I/apiz0KiH7VZDqcT/8ld8qUlQyj IyfXSU9hlbIQw+WxQ0kmWolwDeq+cS3JTQ1CqnNk48qGTOiYizIlWe/K7xmKPFpO7+7ISL snQtyrJifvlKiWQk17uxRdyD0TGOTEM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BwkBU4Hx; spf=pass (imf06.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4BB5460DCE for ; Tue, 20 Aug 2024 08:51:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A04ECC4AF15 for ; Tue, 20 Aug 2024 08:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724143913; bh=aRtmfwa41KbvJpBtEG0xyqAIhPLHL0cgBA1BUt6g5nU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BwkBU4HxsXXYdU1DsYJratr6oVrmlL2J54yUo6KJ3tP+TzkrNs3oCrlVg1sDFscZO pQleFa07fQK49e6D/P3wD6pBOHv/EDDGl3R8BerbflISBu921VymQ2+LMNydFiMaMx QYAO0MsEYJzA6uiYgwN4w137YRwlTIdW7o46nEuXpicqLXbhprJSG6nsjFySv6ru/Z dZL9fvaN89kW+1fdQh9BC286KbfiuHu7ddY33XHp39BlTxNk2k9XR2GHcEA5DS7jIm Xfcifbv80vAkGQkPEEI9qUmuT6U0qR2ZiaclVuq4TkaxweZyWttB/DJFhePcvT6bEh nAC0FT8gevCdQ== Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6aef423f80aso48167687b3.2 for ; Tue, 20 Aug 2024 01:51:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX3Xy60qrRqloagksHJ+1CB9/tEZAj7aIFMFM/IzptntG1uacCJ1F4N/eMDnmIKTxWWf0ZmxWnpvg==@kvack.org X-Gm-Message-State: AOJu0YxcVXgxBXJlBgaosuzj7v6op0iuO0S4SOTQXcW0T2ZgHX+nZX7A y03QyQ5uFNosyTk8+Y3NN704WmPB2BioN3eiz9mIre0DH+lr7ckmZ5vL661Dv/C7Kq8sfTtaqDE ahBTKtMTInQzkJukxgtw6QiZwD46KA2dI8yBeJw== X-Google-Smtp-Source: AGHT+IEmmoeqfU/Vmqbo3i0PjsAsSPy53NIgemG+gy7TCNUOV3AIZvu8sh1dimmf/6vMJwpAajg3PCQCOhGk9eJe+cY= X-Received: by 2002:a05:690c:2fca:b0:65f:7cee:43b with SMTP id 00721157ae682-6b1b8bedbddmr121899137b3.19.1724143912766; Tue, 20 Aug 2024 01:51:52 -0700 (PDT) MIME-Version: 1.0 References: <20240819220548.d8f1ea5cf504cfd8feb5780e@linux-foundation.org> In-Reply-To: <20240819220548.d8f1ea5cf504cfd8feb5780e@linux-foundation.org> From: Chris Li Date: Tue, 20 Aug 2024 01:51:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: gcc-8: mm/swapfile.c:863:40: error: array subscript 1 is above array bounds of 'struct list_head[1]' [-Werror=array-bounds] To: Andrew Morton Cc: Kairui Song , Naresh Kamboju , linux-mm , open list , lkft-triage@lists.linaro.org, Linux Regressions , Barry Song <21cnbao@gmail.com>, "Huang, Ying" , Hugh Dickins , Kalesh Singh , Ryan Roberts , Anders Roxell Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: payzi6anjpquwm6e548b7m3rxqrr3hjj X-Rspamd-Queue-Id: 6B3DE180003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724143915-633339 X-HE-Meta: U2FsdGVkX1+vqMzDfYT0hTcSzbqRt9TgliU0ZVJLZ7p1xyQYsgDnhsmzxwjEvSovvcLBEPggBYVOsckm3rtihLxHbD6P1DEGa3mBJe9F3FJjNQOkkMe4NY8kK6RNPA4AlKDYkdrzz0pOXFAcq4tPzzb2idp61p5406FUkoXyckaXBpfmGRFVm8XTFeiVtKA2ePAbwZw9avb61CvOfqO8WHs46bB1r34GTwk0d0lcsJ4ybOMoz1qNL5iTnLYRpw3o13vuxVRdTYgFDn37unttHOxpCvIFKEKy8YW65GhnbKm3+srbabftbgv1Qto91Ca1s4EkU7vKhfyA+dR/SkgJiacfKorzhjtT4jHZGktvb7HCdwXwFD+SiocbkC8PWwVZyFGpTGiEXjalhnOzIlUtwW8jtF+ViDgO1WJRZY/511tRFyrIwSfwyepb5g5W0M3UEfxbGtPQKBvgMlTHm7JmttDr47N2nHahEJ/HFZDsMvP57sOiUET2m2U9lB6hS/iihoPV3IDbSzFY0yJF/TMG+fi1i0eR2ZSwtwWgs09bC0jiqP/D8OpJAB/R9888TY3i19h9dQox2fLrrd3W1GIEunxRz2RQJrzF6zBQBu/V3Dzkuc/xhXRHkpISgprC3hmA2AdUbx0+kIfsHiuRneqOgk9K/cm0WqMe7rfdRSYvmfBn8fdG7hebLHWqBO/JN58NshdwGEHltC2L5Xk9VuQjmnoXkx6AN8YiGsJu8c5cATXNIc+x2vGoPK4oR36Ajy1VWrj4G+y6THmY8fkTm5mSXJU/gcz6EJ4PHKsOwa7AUBV6kSThnlnuUFg1R/Ltqj1FT3YlDReb8qiFiKdTCRN2148QN8RO5yQmCOgs0/rJKhBXVsyhOKD26p1C1F1SkkzETY4jUfAwDrKFxDaUPH/TKpjVdWxSBBfB++II+KWHDci1p7R2JEK7U/w6sSx3/MCXPaXWWvA/0ciTn+096gZ mPZXzlwL FcF0u99AKQCR8KE5RzmkroSmybbWSm5wCrBCPFu2QE/Dx7J8xkEEn34E7JYpfD02oUjtsMbP9vuS2Co8p67g5WwWL5ZmZFkRDzET/77aH3tdIuCJjDOtr4J5UJJRRf7c4+2XuCEH5OYmL/L6MyaZfEvKsoWZw0HJhDC12rj1fVesO/2+Wf70w+1NQQ2QnmAzk0/Kwohh6mIHAcJ7+kCBjFSgGiRyxRr1HxT8zzJ4eVv6XMJUeiBipp75akja0CJjDxFk1kKPc/QrQeMG5iIOpsHlsDsvNzf0hnXnSe3MpfWhkU9Z9vPvkKCWIGhMomGeH98tTxqrJkvMpCvZ5i7bXJpP8d5m7I70kWmjtBPfuDYZBbnaXGASjHXAYV+GuIP3mYXlm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 10:05=E2=80=AFPM Andrew Morton wrote: > > On Mon, 19 Aug 2024 19:44:25 +0800 Kairui Song wrote: > > > --- a/mm/swapfile.c > > +++ b/mm/swapfile.c > > @@ -836,7 +836,7 @@ static unsigned long cluster_alloc_swap_entry(struc= t swap_info_struct *si, int o > > goto done; > > > > /* Order 0 stealing from higher order */ > > - for (int o =3D 1; o < PMD_ORDER; o++) { > > + for (int o =3D 1; o < SWAP_NR_ORDERS; o++) { > > /* > > * Clusters here have at least one usable slots and can't= fail order 0 > > * allocation, but reclaim may drop si->lock and race wit= h another user. > > OK, I got that landed in the right place, but... > > The definition of `o' within the for statement isn't typical kernel > style - I'm surprised we didn't get a warning for this - maybe things > have changed when I wasn't looking. Noted. I did use the checkpatch.pl and fixed all the warnings before I sent the patch out. The checkpatch.pl script did not complain about this. Sure I can stay away from it. BTW, I did a search on the kernel tree: $ rg 'for \(int' | wc -l 970 $ It seems pretty common in the kernel tree now. > > Also, this code makes no attempt to honor our "The preferred limit on > the length of a single line is 80 columns" objective. There's just no > reason for comment blocks to violate this. I was wondering why the checkpatch.pl did not catch this, is there any config for checkpatch.pl I should apply? I typically invoke: ./scripts/checkpatch.pl -g HEAD Let me know if there is a better way to invoke checkpatch.pl to give more warnings. Chris