From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55675C5479D for ; Wed, 11 Jan 2023 13:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E703D8E0002; Wed, 11 Jan 2023 08:59:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E201A8E0001; Wed, 11 Jan 2023 08:59:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F478E0002; Wed, 11 Jan 2023 08:59:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C33148E0001 for ; Wed, 11 Jan 2023 08:59:03 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 927FD404E0 for ; Wed, 11 Jan 2023 13:59:03 +0000 (UTC) X-FDA: 80342674566.16.BDD1487 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf14.hostedemail.com (Postfix) with ESMTP id DF3F510000C for ; Wed, 11 Jan 2023 13:59:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=UmBRLbBe; spf=pass (imf14.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673445542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=80IvPUZGgnxdQ5vyxchk9/UkehkHEp+xn1SQmlNKmPw=; b=1E2mjFI3ni28md3ChK3yJgFEjkzozN6f3KysK5FBZyp2KTegpk/QgrwtroEmCBbR/5pHdD gFzHLZzGQrkvmAsP/VWvW+vN9RSm1WsfujvVqRqH80evuacn2B4EmD65/a/3y9z3ad1MNs 2zu70jhT9SiyWljK05QzdH6ZUkTuIjA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=UmBRLbBe; spf=pass (imf14.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673445542; a=rsa-sha256; cv=none; b=qgPIJ4mjKapvJpSL6o01jWEvT91Yd6Zyfi87qilNu1aRonHTpaxyZq447bjU0fGycYUjxK T5+tkxprPcaWXuKG/zw8prSOnV3TrSh4f/RQGXg0tXRyWXD7oTZOoFKul08n6nXbnpAsF9 AMlKc4mJVxoC601BDwWcfKCgX1ZP7UM= Received: by mail-lf1-f48.google.com with SMTP id cf42so23661502lfb.1 for ; Wed, 11 Jan 2023 05:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=80IvPUZGgnxdQ5vyxchk9/UkehkHEp+xn1SQmlNKmPw=; b=UmBRLbBewTKwSpwZynb6tovxserM7649X+fkSRxKDJFULB1AhLrvWkQazbZLBVzrrf bajZ+7olC+zoh2t3tTTSRBAXdPKxjwa34Yu/QFlv11EWdRhGcJAgbQnduHfU0JFScR4m sJxrp0XcXV4oE8xYFAqMvUz0YzKMqFHm57UQdWg/mng/OKzQAvfo3gO2Ww5Vo2LGlIAF eeGaccHqxGmCxYnacvdCWqSrq5/JOkRJqeb2lXvsY0xB30cs281qrWmAafnhdiLbU/1F B5ilpDNKAgpqVLZ3gZgBZG5WeTIUNhQyp/NVVI5nUDNAzyjf5F0VNyl8iQzwrMrFlEbe z95g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=80IvPUZGgnxdQ5vyxchk9/UkehkHEp+xn1SQmlNKmPw=; b=2xZlCPa9oBjUGf1RUx82mYXuvVh5C1ApL+hdhgtK9CujkIB/sGnne9fff2EtNVlvdF NOJJVLtfTxSbuBfgUFDfNQFr5/YVX5Wm2avtHfbQC7gi7vrpC3RGjIOJC4WNB9CgVTfv QObUCxIhhMcFnmYKDN1k6z18R6J4Yh9uSHtxBkigNn4oo37fiQcygwFFvhXJBU0BgZjO rBrYQiq6TqxpQlF7YcSGI7n9UrZUYC+ixPJ5KNDJOyovjuey7UaZMwC0E8qRaOVp+8xO hevz+EGdgNL6+7neil7+usZNxvEZpUeJBi0rzimh2zotvYtv5ZyrrcovQ9/lgYd9uWd/ Tffw== X-Gm-Message-State: AFqh2kp2PwLGdLLCe7kFt+yR24094t0vEd2knmbjSG9uCoYfmIzyJ6Qw aJvx+pvGh2qHcXX4E7lbKNG34oaAh7HtyOhhgtmrCQ== X-Google-Smtp-Source: AMrXdXvbSfD+90cISa77jCd+cxLYf6fmn2lli1ewvrugTXi++WtDbM72cVrabXz5gOQOn5I/KkUXeKB4S0vRFE+MiV0= X-Received: by 2002:a19:6551:0:b0:4b6:eb4d:4b7f with SMTP id c17-20020a196551000000b004b6eb4d4b7fmr6168977lfj.530.1673445540206; Wed, 11 Jan 2023 05:59:00 -0800 (PST) MIME-Version: 1.0 References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-16-willy@infradead.org> In-Reply-To: From: Ilias Apalodimas Date: Wed, 11 Jan 2023 15:58:24 +0200 Message-ID: Subject: Re: [PATCH v2 15/24] page_pool: Remove page_pool_defrag_page() To: Matthew Wilcox Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DF3F510000C X-Stat-Signature: bsqesquqmj7ucgi41boja3hg9sxuna9r X-Rspam-User: X-HE-Tag: 1673445541-58187 X-HE-Meta: U2FsdGVkX1+2vVzB+sgB3tXgt4LwASNN/HFeQKK+HyOQom7sT6Tb+t1HecPtyTs6rKKS5VyBuBrqjzhIKURdO5mXymDAQ4/JLR8s8cpp0rB3qdDMLx4QWlpPiIYFni754NNouFDvBLpmogvPTxie9E66x3Q+RGO2G4DLo59EazZhmWHv392u5MUmsXVPMg6I25/cZ/JKNireHvSYhzPZq+8aNB95GLLyYunvSvuez0UiT5pupeAt5r49c6gMYJCQxtVIQ9Iryk15rcDk+2dZn9P/rqYUgPq7NcjMXPcdDmIqVXomitHVMgs5gHaSYr6BsaOLryMsaHsNYCgQQ30S2nf1TZacwO+g2T7zoaLn1nViqBTm8sT1F/RRDP6kB+SN8yGdWesF1xJjSOHf25rtVJ/gSsb+eDUvfIUJJUdLWiQVI3Oznln/1y3kr3czXNOSiLgiS4ZjZ5hFNUWU/uyBbpbriNQHWMRoWZ168Hyor4psc7YQvjDxWj+m4qvKA4bZkqmIInM0ulWH/8q7a7qK1UBWOkz2PbM7fITgFOdC3EpxP/0OPyIvWIR+1F+VfFhq3emkJNxz5HoIKe9weDCW5Zx0++umembjOfr1ZGWHXUULC2MN9BjLynISe5mmxXr8rvEBR4bDjByOKiC+PiCn0MwYvxcHyxDio64Vt8bq8XEFyBQWupksLBvlQpkqQDAy9htZKLmhdGGyc6nkMDPPWfupDxWVP0Q9OBzBY/hhNb4eff2j7EbreqfhSHGizbly/HpPlmhy1obFW4K/kF8H3qXq0xPYaYKzALU1KhJqc+vwViWkzGFIneIfZ4SfohY0Gi37XBBu+iLf1l3fqq0PLhiARb9RoRZE9/lmxXFviZ2C+kCviAcFWzyNF6gQhkYDkledJMGdI9X1DqqePoEb1LmYIg0xxaj8+x6ScgVHmw+thEjKm4PE7S9eajDDUyJsWO5LmB+lB1i/B696Ct/ j/d6X8y2 jKWhklrHSuMJmeP7mFrpdrnp37tN5mCIDfjh7RItOx/Tb2Ko= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Jan 2023 at 00:00, Matthew Wilcox wrote: > > On Tue, Jan 10, 2023 at 11:47:18AM +0200, Ilias Apalodimas wrote: > > On Thu, Jan 05, 2023 at 09:46:22PM +0000, Matthew Wilcox (Oracle) wrote: > > > -__page_pool_put_page(struct page_pool *pool, struct page *page, > > > - unsigned int dma_sync_size, bool allow_direct) > > Wow, neither of you noticed that the subject line mentioned the wrong > function ;-) I'm taking your R-b and A-b tags anyway ;-) Well, the patches add temporary placeholders of functions to ensure that none of the patches break the build. So when I was reviewing, I was immediately jumping to the equivalent patch that was removing the function later on and missed the commit log ...:) Cheers /Ilias