From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA4CC3ABC3 for ; Sat, 10 May 2025 07:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E32126B0125; Sat, 10 May 2025 03:03:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDFCD6B0126; Sat, 10 May 2025 03:03:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6596B0127; Sat, 10 May 2025 03:03:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A5B666B0125 for ; Sat, 10 May 2025 03:03:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ECB741A1A13 for ; Sat, 10 May 2025 07:03:38 +0000 (UTC) X-FDA: 83426107716.02.365DA37 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 240638000B for ; Sat, 10 May 2025 07:03:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=V6JwuAON; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.178 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746860617; a=rsa-sha256; cv=none; b=3JzJPE8GRxv6+ryOqzptf+dIgTURtPb98Wki0c/nvfeGdL9Ik7qKrOKN5/TIvgYD8UmxF+ kXA5j7wpBFBef7+qf2FSJ9R4hClvnMtfGkFO3zN22151BxejAbAHrBgjwqrMRZjTcOjGLz TXeN4C7gzVXUgWFAKXK0vB2ni/HJIYs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=V6JwuAON; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.178 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746860617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=esIy1yoJoTXAmmLAi9mdo+nXWf8aN/TLslRpMMWG8TU=; b=WJZou6pqIkhXJfZmtKNnbGqyjlb81LeVzHiWrzpOiZjR0gpl5pOo1ykL1roskgU7lWM19D MEhY8nJS5j+WizyPeW30VQWanQnkC6emSgKVU7B0w+xPtYEGIa39yMZ+bWP5PSeQFRebJN 32GtgHDcUDpguy/gAlhRd8YGv1pGaro= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-70a2c0e7fbbso26384677b3.2 for ; Sat, 10 May 2025 00:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746860616; x=1747465416; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=esIy1yoJoTXAmmLAi9mdo+nXWf8aN/TLslRpMMWG8TU=; b=V6JwuAONhCg3oO5FwwXgfalN2q/Du+iax8Uqx294pj5cFDYZ2KysAtzytdQI5mmZD/ ryWl8bBiisyyVCcm9HEVudpZPPLFckrpuvCWo9EVgHHC2tgPQdxfG9/lDP9mQ1ZSW2Sh JOcCBZqZPuh0ptOUFadWp2QJ8xQpUH/0ZJ+j9AGJYZTt0DAKcU1SX6xS2nPycTLJyYgl 0qhOc72GFIhF2HK+MqPvASnTooyS2U4kcIShN/y1PzOtchXpghZlgSaQzgMu7h8oWuVQ ap44eJu9lc9cArBJfnN3uqvUKrjT7VuuUTFNfRC9+CwV0MbkxIXAA/n49aE6Texm9OpD aFsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746860616; x=1747465416; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=esIy1yoJoTXAmmLAi9mdo+nXWf8aN/TLslRpMMWG8TU=; b=LWyj1Gc6ICtyBvlu3WzKWx1NHRkQwKnZvrWAjnUFH072VdDkkE9Bu5CgAzvCYMHYV+ m7pkW21uG9rYq5KFx/VZfPD8awugQg8Wt35WHg4BdILo4mcg0+YpdB6LNlA7FjbuadPI gibHbYkAryhF09OsgtniVFeQO6A2YRpJdG/6RXiSAdyU8cO2BC7ZAEaw54iw6Pe3tGzl pEZ6+FmhCGeB7nzowXyDpw2J7RccLTcSk2Y9zKB3pTb95L+A6GQ+cjRYcBHQAxUyNO6O v9W/6XfW6grEa0BcFcLBqvegDcwaSZG3QJNl1i1sEgJwvt7H/d/MdRUpT0DmnDG4hJ2k L7dQ== X-Forwarded-Encrypted: i=1; AJvYcCVm4oF1/C6hU0lTeB9cd9cQbUxZ/JVIkxqJZ57ziZaebK4dwn1l5GMG1JIp/91vv+hQtu/cM4GTOw==@kvack.org X-Gm-Message-State: AOJu0YxXjsiWU/ZcyfoGUa110lI53nUUVZ5wRyf8pYlMHTchdTTUZgs/ m4+jzNOzH8dqsj/f0bF3xGWaQSbumq87QvkzaF+7cJmNkG4uPIAcq0ELwECM/TGkKrUpEKoX6Pi 7I5I2mgmpFv7kuWhySdMPw9af0MXRa5PatBLsBQ== X-Gm-Gg: ASbGncvacqdW7xsLnWsQjePhmzpsOMGMwScNJQBU23JFhURJPd8jm+RwOEPz2fz99+d x5Qx3X5710HYTo1OxtMZ0yVlsJHrkoRBsouRoijn/HWUavIugjXs99X5msHeO64gwngLUFYbBnC aRBLyokyeWXeC+i28+SEsKsaxOfJVnQYZW X-Google-Smtp-Source: AGHT+IGOGUAXd2eYucc2l24LwrEQEK6gIw37E5MMB9UU/rZM/aVnHskCdc6S2rR1KxunaQrrcpQluF1iHGaUJOnujEc= X-Received: by 2002:a05:690c:7487:b0:6fb:1f78:d9ee with SMTP id 00721157ae682-70a3fa17f4amr88459647b3.15.1746860616084; Sat, 10 May 2025 00:03:36 -0700 (PDT) MIME-Version: 1.0 References: <20250414013627.GA9161@system.software.com> <20250414015207.GA50437@system.software.com> <20250414163002.166d1a36@kernel.org> In-Reply-To: <20250414163002.166d1a36@kernel.org> From: Ilias Apalodimas Date: Sat, 10 May 2025 10:02:59 +0300 X-Gm-Features: AX0GCFt1hYf3LtiCNfvyCjgHPrAs-p_3q4IUNgEYUKRuXuiWPNp2D6dhxySBkAE Message-ID: Subject: Re: [RFC] shrinking struct page (part of page pool) To: Jakub Kicinski Cc: Byungchul Park , willy@infradead.org, almasrymina@google.com, kernel_team@skhynix.com, 42.hyeyoo@gmail.com, linux-mm@kvack.org, hawk@kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 240638000B X-Stat-Signature: 1t41b8pbxsiu3ngmiwq3w1u57hqyhpif X-Rspam-User: X-HE-Tag: 1746860616-827004 X-HE-Meta: U2FsdGVkX196xfiiDh9a6Ob6S2PleN8TZahRNf1Mp22qRdIH1m44hdcSZRGHUwLtzV7E7lgvSLzELEDj69wqzlUZBhVygRl015n9tcfgHjrVC7L/w9mSVs7Wj9ozxzP9CvZ90VoyUT0/OBcVSzGFAruA1iAgMyMzTbfmY0Nf/xMkO8GmIlnjqNEHG12lb9fJzyjYFLx/GIX0ggTU4EPz2kzG4kEod081Qv/xdyvwUebEH+xxQau31cW1kwM59ekgr6XmYTbkuCWL+PZyVab9LaJv9uTM6P919TYxEooy0LC4/6voGKtiEJeE0YDrXndIz6VGM0K+sr+HcGT+CbiZnvcrUOr3te8nTN11HWLby5iXbeFR2Q8rOUsnLt5B4AdkzbMTXgHLztADMt4Zf1mjszXjKMPTSR5AMf3IB5PywzHPk6RgfdvmHXiVAg6431U8Wq99GY6vOD2MqYrf2FAm0F4QvJZOpT1LHPfRws6mUgDLSyHpXZsGJm9qdhZcrjcEm7Mb3NgG4f8An4RW6Rwll1DfVwLNBxxoFQFMDkwYDHnyFVM0H/dM/EjC8nKrRol/uf9hfbF5UIY3YsTGQTCwnCRa8IAEoey6X8gJ/O+P6Z8/IJdKBCrq+gnEbSbnkkQ+5k8Mi4GjMdcg3SNRksj3ss0wZvvOI2IiHRh73/F3HspdmFrQCa/wvm7H6jEybtxXT++O6I0bmecJAYTtyO03QU/ObU6BBpiiDQ0RvXQKh7k0X+reohiy7BI6ICt8XpQK3nIvsH6rWkY6aqOHwGZpb185lcmvb0VC70Rs83Ya97ZxbZuzQsfbfsKbHxAJGe9zEr24vV0LNgrc5tVoz1PLpZCRWYkovdGS/WuZKYuRNivcYn6wMgKb4stPNjXJ1wy26VUKm7i4xOqi8SDnTraxddUlBH9mObMpP/2DqcGfYbYvcapPVFvhNfiQpTCQVbr5Am+Z6bojZMZ2NUplaUy k4Zw+esy 7bG+EoMfN8GbdYRLz2nV3mmAtNnw8+qCOia118LZq8TsDlGRZ+TIwo2NQYp8aQG9I80EY80Q+czrcRF0snIkkt9qKoNjYQOHi3oo/rxJeMQhiCrc0qkJDTfoJDo799O/T0VAWJfPh+mFaRuYJCTtzwNRlWuYPYnGlOj42rEnTgk7Ops3rj4s/IluPB+doq2s+8MvP/+aP6UdoHwux86hoWrsprX/2MHgzvk+rcRbOxhP/k0rupTGOL4i5ogzV7v3zBBYL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jakub [...] > > > > > > struct bump { > > > unsigned long _page_flags; > > > unsigned long bump_magic; > > > struct page_pool *bump_pp; > > > unsigned long _pp_mapping_pad; > > > unsigned long dma_addr; > > > atomic_long_t bump_ref_count; > > > unsigned int _page_type; > > > atomic_t _refcount; > > > }; > > > > > > To netwrok guys, any thoughts on it? > > > To Willy, do I understand correctly your direction? > > > > > > Plus, it's a quite another issue but I'm curious, that is, what do you > > > guys think about moving the bump allocator(= page pool) code from > > > network to mm? I'd like to start on the work once gathering opinion > > > from both Willy and network guys. > > I don't see any benefit from moving page pool to MM. It is quite > networking specific. But we can discuss this later. Moving code > is trivial, it should not be the initial focus. Random thoughts here until I look at the patches. The concept of devices doing DMA + recycling the used buffer transcends networking. But I agree with you, that's something we can discuss on the reviews. Thanks /Ilias