From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DBAC5B552 for ; Tue, 10 Jun 2025 11:16:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0A7F6B007B; Tue, 10 Jun 2025 07:16:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2936B0089; Tue, 10 Jun 2025 07:16:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8E16B0092; Tue, 10 Jun 2025 07:16:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE5DE6B007B for ; Tue, 10 Jun 2025 07:16:14 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 653221024A8 for ; Tue, 10 Jun 2025 11:16:14 +0000 (UTC) X-FDA: 83539237068.05.2E3507C Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf20.hostedemail.com (Postfix) with ESMTP id 6EE8F1C000B for ; Tue, 10 Jun 2025 11:16:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Dz8DZGhU; spf=pass (imf20.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.178 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749554171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VRYdrxByQfviVMjn3PfJspn+iiLr6NbvXjzKXMXNGnw=; b=IQ65wTHxierxGWXCQOKJY/oVMYnwrZNRaXULy/Vsh228xtAI/iIpb13TXZ1Q/F+N0xYaKj d+PbH0NPA5b3N1dyUcxk7dvIIAia+0ACzY3KjLHXnmE69oNbSVDQqPlU50+kDcUg+VBhuz 2oDzZnl7pyCr1hsPH+8Ry5vGquObJkg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Dz8DZGhU; spf=pass (imf20.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.178 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749554171; a=rsa-sha256; cv=none; b=70qsCyZkDfVVN2g20rZ0HtKsfQc7aBNO0Xd8FaZmFq8A9FO3fTNNDBMClLEJI7Kkucp1pX dMMfpOuIdD65z2CiX8gkgT5Utdvc+E1d7NZx9hH0XZfgZ7wQQGbshUY1qhW8cIbSo9WyTV ypNUFqzWhd+vLuwSdg1/D3D6yFZqZNI= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-70e3e0415a7so50534227b3.0 for ; Tue, 10 Jun 2025 04:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749554170; x=1750158970; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VRYdrxByQfviVMjn3PfJspn+iiLr6NbvXjzKXMXNGnw=; b=Dz8DZGhUO9UIKbDf1yEzY6T8fW9jfkumR/mdJTXw0MtZIXaGFPH86wgQCl9UkeYvuG giArni3OrZCnsZieSgqZAtwJuYdQy0omuA9KUwqeL7xhszTvHjmDp5ivQBIIQFDvbtFF oCWL0pBIoHDs7lMGFimAFjVHq25rQ5jaO13KMX8sL2qRLs8jvt6mvB9TGN297Dl794hd 2pFgB8PVx7v385P2SMfIMU+bIBz2UTlz8ARxpTSdfvOVXj8RuU4IAcn1NEjMpJZhwOaG bpzinv4KK6U/yu5h5Ag6DqFRm8/Mu3rdiZ8GjBm+ddCYQdKSI1PsOmSAVNTRYPxuYYty ViFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749554170; x=1750158970; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRYdrxByQfviVMjn3PfJspn+iiLr6NbvXjzKXMXNGnw=; b=f+q7XyTMBYeHLfXGRo/J535elAFppWPLmfJ1ikWykcwBgmUzFomQwiBU49/zhpf/oM cNyyh3zIYym9gf8ZN6DTWqP61GD5OlxlmOMA6T3K+HMXDGRppI8UOkx1EkiGEqk4mtWX +mbfkoAjaLCEFb8rdCzPq0quDryOMd6t2ErprZHybLlo5zSCLTEzKtu7wU8bLPYxUmBm 8xjhS7MEEFbEw8FVr0agL1jNldOzoP9YgK4feqrUtEAUbF1Sy64uA+yFfXiS+Iek1iG8 T/QnmnZOzJZn5C/OeTuMlyXlgy6SdyXTJI0GND/lAWwr1owq4yZGj+vnn+jQw43AQ/c/ hv4A== X-Forwarded-Encrypted: i=1; AJvYcCVic1m9bsJThnZ1Vs9mOSeH17HyJsl4L7Ij2mcwdqwKP9OpF/EMZg76u0H62ss+50BQnaMuvHk5SA==@kvack.org X-Gm-Message-State: AOJu0Yz25BHuOd534aU5SAHmVlWmMsXTG6/qBKmuyOAtMFveDEjp1PXy LN2EFduEfpiFR6eyNSpbMhkMg8N2Km8louj2J9KiAktXaxUxbG7cLW7Ewoo4jtXomZBq9DocdWQ bghe1ZounBaeEVWyVqNWYcUthlOTzJj4XHtQlNbRAvA== X-Gm-Gg: ASbGncshWL8e7YJdBEzublgYLw8JterUERT/orcmLcUqhJ1qczzw7MJUBj6+kCyVVFY U/yMeQ5XoY0RLyv1VcGl3N5OoauHAHRFZK/Bmg8fN1thKA81AHCPiZbFGmUQUo4ZOqtFvC0jZrg SNryaOSNSIkvbb/od41S0G12ofY0G80TRfsMRtUgCca7xd X-Google-Smtp-Source: AGHT+IFiYu6L+0hOxUKTy81XogIL5OBe3zG8xFQH7UF6Pa7lD69xoMiBUt6KHLP9DHyWMKkzA1qKEvCm9OEUHUfS28M= X-Received: by 2002:a05:690c:9b06:b0:70e:2804:9925 with SMTP id 00721157ae682-711338b2842mr43149497b3.9.1749554170517; Tue, 10 Jun 2025 04:16:10 -0700 (PDT) MIME-Version: 1.0 References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-3-byungchul@sk.com> In-Reply-To: <20250609043225.77229-3-byungchul@sk.com> From: Ilias Apalodimas Date: Tue, 10 Jun 2025 14:15:34 +0300 X-Gm-Features: AX0GCFu56urTmOISlprLwgHXC6db0zVW3wr-lqRXXoQOUbGJ5t4MqPrNUZKW9wU Message-ID: Subject: Re: [PATCH net-next 2/9] page_pool: rename page_pool_return_page() to page_pool_return_netmem() To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 4rbxrd1dgw6t13r9wc5czece5rjp4aid X-Rspamd-Queue-Id: 6EE8F1C000B X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749554171-305155 X-HE-Meta: U2FsdGVkX188hrSJmMeSSzWM66psCra8KU+xEEdqLgi7CUJr1Y7mYLdWGwVZ0TWn9rMx61kmank1kdCkrxOATjT/xTqzREOvtf+Phl6Ntb3H4Iumf1b7kHwuVSOkClq4ubcpdc63CfOIHS+o31NYPpeA89slgE+KGsMyvg19SFXqAt9xU4N+XaiTZhtkH28OH5SyR3R5PcwNmc1rdmclGAcpHmIYZe7sD+QLD4MeVjAsF4x7MvrZ/au9GTsmBjHMaOS59zT8GVCk5cD8JaNzAUW+nUFDKJ4qrdrjwHKvmNvS9oZ7csUBR9FwTbIsifPBUWSew7c1rpdR+hVI0JzQ7cHkHNpBlq9m/Yc+Wyn/AFUgV8dFNqrQX2k207TmiRf1IJA4/HFJBdt+uL1vMuraV50qP0B8fXXfddh7VNF9PZtv5/WlskUXQ2jJFY0u6e6Ph+oxVxczRZKocQW3Ix3kzEoWjzid3BiGWNUBcGsuU09hURivNCgimNZ3NuzroCNhcU5X6k5FT9Zqtz7hq7vrCswJNHL+ETId2PMbtEKx9GsqhfTefFFJWt7HxldBzcxkg05RGlATckvUW0OnNSPURDyM5K1DK4atDCnz8Nc687W5UyiSTv1DeQPWSlDoga4tjOy3SeFz0ADXPLYToXcuXpt/1YdHwpmvqN2ngwaUaeZijV5wGq5fjKpQkePZVIM5gfq133897j/R/TDT+Rb4iKB3x4ohUs9Y0R9Kh7hYpJzIsvkLW6kzaoguyIceutSXHZZKjw7zhAmbJRqcV7hvu9zhMmTv9UtM6xs6aLgf4E+V4UGvJd3G7veH117d7oM7wAFWBEuSB6cSJPaXTRWgpL1NcR752V6lOG2GrbWVeszeDEcNQk34GKHrI8lIVgH6DTy2ez3d91V3nwlTQzcjOR5fZELOmsd9rOH8T59HZp5o2A0cHlV+G5JOOSzq8l5SVUei1NJrsKChYEIHnbB hoqU/hZI t+0SHRmYsvKYRZJK9QkypzkVRtu7BRPkIBvxXS+M0rvaaUfrhuXolhe2ZhRAOOXpHf1VP0Xf4yTYfVOd/FMVOpljAc/e6wbS7EHRnFGrgHiKAnnCLMATsyxbpPoblSDtm+787pOflI9h/6ixPzkH8daqRJuwIZu3lrmFHdWHs3/uhUrIufyWZ+w10ZIqvPWaOc2xMCVsOMm9GulkmfHKUprIn/OHaKEqgqJmRySenBjdhlzEgpuB3zJqBlD4qOGdsGGdcAEEhwuxU5P/dYEzoMs+EdBXAJHSOQmlqjd0lc/piVboJM8HNZXdXTA37CCUnTg1ZzpeSNOmcRoulO5stDF0qZfTPqiV7PbAYcAkheTCMlzaI4ralbVoTPtPP5b6ulUrkyww26DB1lbmVnfJ1X/sJpsC9NGS2GBG/1d6gON1BzUxzX7fy0rjto7jN8Ayvlw+sn0v+ueIYFgLU3bjvkEw+aqq3/o9nn0xlvBcf9TTsVz4dWUpLzUIV5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 at 07:32, Byungchul Park wrote: > > Now that page_pool_return_page() is for returning netmem, not struct > page, rename it to page_pool_return_netmem() to reflect what it does. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen > Reviewed-by: Pavel Begunkov > --- Reviewed-by: Ilias Apalodimas > net/core/page_pool.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 4011eb305cee..460d11a31fbc 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -371,7 +371,7 @@ struct page_pool *page_pool_create(const struct page_= pool_params *params) > } > EXPORT_SYMBOL(page_pool_create); > > -static void page_pool_return_page(struct page_pool *pool, netmem_ref net= mem); > +static void page_pool_return_netmem(struct page_pool *pool, netmem_ref n= etmem); > > static noinline netmem_ref page_pool_refill_alloc_cache(struct page_pool= *pool) > { > @@ -409,7 +409,7 @@ static noinline netmem_ref page_pool_refill_alloc_cac= he(struct page_pool *pool) > * (2) break out to fallthrough to alloc_pages_no= de. > * This limit stress on page buddy alloactor. > */ > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > alloc_stat_inc(pool, waive); > netmem =3D 0; > break; > @@ -712,7 +712,7 @@ static __always_inline void __page_pool_release_page_= dma(struct page_pool *pool, > * a regular page (that will eventually be returned to the normal > * page-allocator via put_page). > */ > -void page_pool_return_page(struct page_pool *pool, netmem_ref netmem) > +static void page_pool_return_netmem(struct page_pool *pool, netmem_ref n= etmem) > { > int count; > bool put; > @@ -829,7 +829,7 @@ __page_pool_put_page(struct page_pool *pool, netmem_r= ef netmem, > * will be invoking put_page. > */ > recycle_stat_inc(pool, released_refcnt); > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > > return 0; > } > @@ -872,7 +872,7 @@ void page_pool_put_unrefed_netmem(struct page_pool *p= ool, netmem_ref netmem, > if (netmem && !page_pool_recycle_in_ring(pool, netmem)) { > /* Cache full, fallback to free pages */ > recycle_stat_inc(pool, ring_full); > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > } > } > EXPORT_SYMBOL(page_pool_put_unrefed_netmem); > @@ -915,7 +915,7 @@ static void page_pool_recycle_ring_bulk(struct page_p= ool *pool, > * since put_page() with refcnt =3D=3D 1 can be an expensive oper= ation. > */ > for (; i < bulk_len; i++) > - page_pool_return_page(pool, bulk[i]); > + page_pool_return_netmem(pool, bulk[i]); > } > > /** > @@ -998,7 +998,7 @@ static netmem_ref page_pool_drain_frag(struct page_po= ol *pool, > return netmem; > } > > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > return 0; > } > > @@ -1012,7 +1012,7 @@ static void page_pool_free_frag(struct page_pool *p= ool) > if (!netmem || page_pool_unref_netmem(netmem, drain_count)) > return; > > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > } > > netmem_ref page_pool_alloc_frag_netmem(struct page_pool *pool, > @@ -1079,7 +1079,7 @@ static void page_pool_empty_ring(struct page_pool *= pool) > pr_crit("%s() page_pool refcnt %d violation\n", > __func__, netmem_ref_count(netmem)); > > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > } > } > > @@ -1112,7 +1112,7 @@ static void page_pool_empty_alloc_cache_once(struct= page_pool *pool) > */ > while (pool->alloc.count) { > netmem =3D pool->alloc.cache[--pool->alloc.count]; > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > } > } > > @@ -1252,7 +1252,7 @@ void page_pool_update_nid(struct page_pool *pool, i= nt new_nid) > /* Flush pool alloc cache, as refill will check NUMA node */ > while (pool->alloc.count) { > netmem =3D pool->alloc.cache[--pool->alloc.count]; > - page_pool_return_page(pool, netmem); > + page_pool_return_netmem(pool, netmem); > } > } > EXPORT_SYMBOL(page_pool_update_nid); > -- > 2.17.1 >