From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC59C4167B for ; Fri, 1 Dec 2023 10:10:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 820308D006C; Fri, 1 Dec 2023 05:10:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A82C8D0001; Fri, 1 Dec 2023 05:10:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647C78D006C; Fri, 1 Dec 2023 05:10:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 50C938D0001 for ; Fri, 1 Dec 2023 05:10:50 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2622616017D for ; Fri, 1 Dec 2023 10:10:50 +0000 (UTC) X-FDA: 81517830660.15.533B00E Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 5BE2180018 for ; Fri, 1 Dec 2023 10:10:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nB975pse; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf02.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.180 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701425448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n8E0QyaHO2zChIxVOU0YYWJPMrzFVG6nS9T0+zfhmyg=; b=BTZU/wUX4CizGAz8ZwP0e4lUuXR3K2iS6G3UfSHvKnQIvf2CFzUeYN8nyZ76irO5Lq/jjk FulUq9W62ov28+njGHZwB0c/oVy09a+pTTDh3hBk/vqWfviaBHh+VA8areFWOfdC9AKddG D97VF+E+ytv76wG9bnp2pGZIRWSur4o= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nB975pse; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf02.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.180 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701425448; a=rsa-sha256; cv=none; b=q0TaNwId0jkxBA4a3DMT2Yz830EKHaAoHDuMDTq+aaxML9Uoug7OiFEBOgwND6eYeD7BtE 1CKt3CL4Nl4wFOARxT/N2yUl3GgyWrTJ0tynonX6Czmd18JvgBwWII2aUYI8HjwwHGNNGZ +oFUT6+BycCzs+NwqRzhKF56ufud5RI= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2c9b8363683so23997441fa.3 for ; Fri, 01 Dec 2023 02:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701425446; x=1702030246; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n8E0QyaHO2zChIxVOU0YYWJPMrzFVG6nS9T0+zfhmyg=; b=nB975psezt8HFrAOjPPr9PLv/vRy9sorBcyAsop4BH1sNR/gu92ECI/HfKnmhJZzxb 9iBJx551g7pBYj7vH0sFKcLprPfRV/oNfT05g95puXhyxDMIuhsLyW7SWhtHiIM53sbw aRF18qK9LEqR9TK8nI98hxiSmDJK5/I35js1cYLp9EU/pTN37y+p4kO3ybO0G5CyzhoM 5N4iR3/qh/0WhE3FJWyiHvzp1i9VeUOhS66+RMr2C+FzaFGTuRl4lQQMXSu/UcQtyERU rVbCyDft5AphRZaSZdoxEnWcdsZtF0NaUNOM30S+pJ5ukD9/G0xIHydIQdUYWGucoije mYeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701425446; x=1702030246; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n8E0QyaHO2zChIxVOU0YYWJPMrzFVG6nS9T0+zfhmyg=; b=hkWWzRLBPBJruspRH5huU0tdsViyd25+1Vd8ooRLnF5Qu/+/IaQ5046iEyUzsu+QcQ hc+370lzXiTbaBY3VWh68vm7KqwTesxTLqseW0VWQXlU85j9jDG/N1JSCrPNdFKj5FZA y3WJ1puZwtxTAsRHbqk+kggpihrmgUjaA1l3i7ARpN540w4MJtVJAH/phrWTgaLFqIhK 5lpUWmvPfAwtes9RtoMfLFR1CzO2UWbklFGJtqaMVKL5Psh+/AlLux0MjGGsMXD8UwEY DhzbZBZrb6CjgF5g7ZdwsShttAtA1BXQnsqqhVMxL1G7y2e2Y9Ovl8KfASh+tiqxb6nX u4sQ== X-Gm-Message-State: AOJu0YxOpDNNDblV0D3sWh/L4OMbBmFSJwgobVGdoJCvq4uVprOF7mW3 YVpdd0v53E4r6ZAS/1grZPj5VY+oipGVOHwoMToiww== X-Google-Smtp-Source: AGHT+IEjiIKL1J883D5OEhe5x4clQxaJAlHkMh9GOJjhv1wGD6i0tPElWfosSDTJz8xNMDxIfxZ61sqNJrax1MKZWwQ= X-Received: by 2002:a2e:8803:0:b0:2c9:d874:6edc with SMTP id x3-20020a2e8803000000b002c9d8746edcmr745747ljh.57.1701425446677; Fri, 01 Dec 2023 02:10:46 -0800 (PST) MIME-Version: 1.0 References: <20231130115611.6632-1-liangchen.linux@gmail.com> <20231130115611.6632-2-liangchen.linux@gmail.com> In-Reply-To: From: Ilias Apalodimas Date: Fri, 1 Dec 2023 12:10:10 +0200 Message-ID: Subject: Re: [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref_count To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5BE2180018 X-Stat-Signature: ofx1bdprnmmsr6nfpjgzj7gax7six5a9 X-Rspam-User: X-HE-Tag: 1701425448-351819 X-HE-Meta: U2FsdGVkX18mRyEOAfo0I7zMXftqUNWq84vC+RzUIm5a073dfhSNtiVqlvGzoMOG8mXyN8VUA70XaTRNQHB7Sha/f+Cg4kllDoiYXfpdowrKpN4WakR3L8bGNCRejl1RvnYuH/gJ6IADMntjHMmVQcKlnB533jqMwaM5aV+LEEiV1qN0M8ZD893zySYNEm7Ky9QwRXDk0jG2JFQGd2cI0GFbTkrJZKmk+r2XpYRL6u8mQJRJ++UmCJhB5ohICKtuVL6vtzp2nS0KURgusOsBRrAsSyhhHDFPZvUm127/YVhJ1QPsKt4P+km/GuP2VRwklGQDpJHMUabNpJtiCQ6k5N/Kgb24GoK21tnN7xspAwO1avZSlMfFIEShpMdnHrRInn9s9RsprTdmUpxGjQVyqOaBlpKI+7/OKRwI57kvQmHvzNgxn59Ic6VWYwzqBRLMzobEXMRHikndVi2Qig1HnUiQO18d3ncJFI730uZdTsg4dortxiRs1t+zN6LNl+vDyfj+nWGXzHY+prQluXlEjMLgx05TxMn0H9HyBtzZ19Tmsc+hc/fxMZCTHtiAOTIDWQYPCQKRrG6t9GUYZTUnZmK2cm4IZXwD0ipt/fQIdxRhDpv1Glyyym8TmH2i8Ge22WkHQPzWOKc8oTPBK6poxhXOcLzCgGU7nTBrGCNssN3y0jrR8jg0hiPmaZBEdB/iejm9KXYhWInUsGZ6J8m8UMiVQZDOR6lz2L6SpWE5IXxl2ldXY2/2CsLNjE/QHE31T5Kni0Ibcr89/UBB3Jso5sR5uOctwKcpP67CUXNKMXBwaVBI7mXnv87L8eIh8AvVBMYAkrhXysfoED50AI/8qc9kAd2LLL+jM2P8ITROcpKWWL7mkQLyIYLKeKI0tSSRhipRjbv38yT7YGjW30TvNBzNKw50Suft3WSNsQ+W8WHBOXuOk0CUHVWUlbvWwCTbE+zK1PdG6pju42xjz6y JpYWfpno JdJYXV8ne6cn1ocVKTK/QCO6G+3T1Vt9bBuCus9WSEO1GZPPHfmEsjCRVaxejcoLp25xL87zLz4LT0CQgGEe/CWfKdYxAP2EbbDaH1ycGYWnjh1N/thhVueJvDgyV5nfXGUiRARYxyAmrOpL71i9GSELejzDnLII9psCtN21EBh/qz1MbLqAQV3reuNxQT0IcadwnhA8ZjcoiGn8IIrule+qyNPebe8JdhIHktdAVLZ3mtrBQA9mGHqFDFeyHG5589MXyQjjUSAsT++6mhQ1LzpVzc+HCKNPrBfvM8qFCplPNt0CU5F9afgFqwPWlaXD+k72exqgIvKBciPChYBheGfB5OhZ4+U/UyglQ1zfdG9s6Sky4rhSkby9cI+C0MPiSveMO6BVpqJLlp/YpmjNlKLXpsnUHN2C3g0kb10pCW7CJ6es= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000216, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: re-sending as plain-text, apologize for the noise... On Fri, 1 Dec 2023 at 11:59, Ilias Apalodimas wrote: > > Hi Liang, > > On Thu, 30 Nov 2023 at 13:59, Liang Chen wrote: >> >> To support multiple users referencing the same fragment, pp_frag_count is >> renamed to pp_ref_count to better reflect its actual meaning based on the >> suggestion from [1]. The patch does more than what the description says and those should be in 2 different patches. I am ok with pp_frag_count -> pp_ref_count, for the functions I am not sure the rename makes anything better. Jakub, are you ok with the name changes or is it going to make bisecting a pain? Thanks /Ilias