From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Liang Chen <liangchen.linux@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com,
netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com
Subject: Re: [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref_count
Date: Fri, 1 Dec 2023 12:10:10 +0200 [thread overview]
Message-ID: <CAC_iWjKBE5s9iiTPKgsoDx5LSWjsSXE-7SSPSk+EVJXLC10-GQ@mail.gmail.com> (raw)
In-Reply-To: <CAC_iWjL68n-GRN7vs_jwvzbnVy8sPh4_SP=wVDq0HkFOmSU-nQ@mail.gmail.com>
re-sending as plain-text, apologize for the noise...
On Fri, 1 Dec 2023 at 11:59, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> Hi Liang,
>
> On Thu, 30 Nov 2023 at 13:59, Liang Chen <liangchen.linux@gmail.com> wrote:
>>
>> To support multiple users referencing the same fragment, pp_frag_count is
>> renamed to pp_ref_count to better reflect its actual meaning based on the
>> suggestion from [1].
The patch does more than what the description says and those should be
in 2 different patches.
I am ok with pp_frag_count -> pp_ref_count, for the functions I am not
sure the rename makes anything better.
Jakub, are you ok with the name changes or is it going to make bisecting a pain?
Thanks
/Ilias
next prev parent reply other threads:[~2023-12-01 10:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 11:56 [PATCH net-next v6 0/4] skbuff: Optimize SKB coalescing for page pool Liang Chen
2023-11-30 11:56 ` [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref_count Liang Chen
2023-12-01 9:59 ` Ilias Apalodimas
2023-12-01 10:10 ` Ilias Apalodimas [this message]
2023-12-02 2:19 ` Jakub Kicinski
2023-12-04 2:39 ` Liang Chen
2023-11-30 11:56 ` [PATCH net-next v6 2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment Liang Chen
2023-11-30 11:56 ` [PATCH net-next v6 3/4] skbuff: Add a function to check if a page belongs to page_pool Liang Chen
2023-12-01 10:07 ` Ilias Apalodimas
2023-12-01 10:22 ` Ilias Apalodimas
2023-12-04 2:40 ` Liang Chen
2023-12-05 11:02 ` Ilias Apalodimas
2023-11-30 11:56 ` [PATCH net-next v6 4/4] skbuff: Optimization of SKB coalescing for page pool Liang Chen
2023-12-01 10:34 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC_iWjKBE5s9iiTPKgsoDx5LSWjsSXE-7SSPSk+EVJXLC10-GQ@mail.gmail.com \
--to=ilias.apalodimas@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox