From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0E1C5479D for ; Wed, 11 Jan 2023 13:56:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7B38E0002; Wed, 11 Jan 2023 08:56:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 596788E0001; Wed, 11 Jan 2023 08:56:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45E6B8E0002; Wed, 11 Jan 2023 08:56:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 365E28E0001 for ; Wed, 11 Jan 2023 08:56:57 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EFD3D1207B5 for ; Wed, 11 Jan 2023 13:56:56 +0000 (UTC) X-FDA: 80342669232.12.7377AC5 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf19.hostedemail.com (Postfix) with ESMTP id 4BC641A0002 for ; Wed, 11 Jan 2023 13:56:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=BUp6f3y4; spf=pass (imf19.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673445415; a=rsa-sha256; cv=none; b=CSEwk7bw2deEC361tir/XxluPqG50O/SEZhlPJ5+SvCakjSzzjd/tE27d7qPbCn+zSpslQ nhOlXxheBd++R0J8S2KXM/UTWz0f9jPX7Sdt0pOI1o8mNLBg/9L3gcntMApdORTBcC6ELm S+X+bqKWhSS7U4EnyIbeUP87Dnc8ywY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=BUp6f3y4; spf=pass (imf19.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673445415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B5OwSRrShELMDRHw2AqTPEjqCDs2lQd6ByoCjom86lc=; b=YZmaQII3mAgpP50CRJPs2EYimiwn3hgwT3S1goDo/6s3+kjJRn6tr5JHAsYUKQ2+fXTAN5 k/Gy9MZeRngrTBzDbLmp4cz/iEp6pcxsEiObDlX1fgdYbcePqWSWy0Az5yREz0bdjcR1FG uhSTeA3x2wzGyZKWlr5NTddvk2u+8Yc= Received: by mail-lf1-f41.google.com with SMTP id bf43so23639053lfb.6 for ; Wed, 11 Jan 2023 05:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B5OwSRrShELMDRHw2AqTPEjqCDs2lQd6ByoCjom86lc=; b=BUp6f3y4KYEOUipcrcrb15l5HoLpgM66vNtQfw5gDsyHt9t1Pe68sa1KPYNaEJA7WC MbKnXqUJbhSOuhDFxM7zHdRPzrw9Bc35T+333hhKszVEsGqI6NcXSeQoLs2U9yyR+dfk 3jmeBbCv3B0pwkH18XFg/xopPEX4vuYd4Nsy+zF2tj6Bq4Fd03+X0NQB6/Yy4oondfLN aYAG8ZQiWWBkda97Ad1vRMX1eZo0lMBd/tujdaOjK0C1DeuiHgUCUMU+0WVmznKeJjUN +Yq8a3brObVEIdM7oEbODDWSYDSgv0MsnIgDyg/fwkrFY9uCp10SrGsY77znNdncH0G6 dj7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B5OwSRrShELMDRHw2AqTPEjqCDs2lQd6ByoCjom86lc=; b=02uSiJPKA8+uuDE9ugQABTwJsFUAtMojvGF6ltj4OUqloRR47/8fsa/UNL76jTZ3uU LZ3wC2KBXXYfdeubPSqui7rm4nCFiKZ9NKBVdN3nWYmnjjj2TR7jfNox0T43XrtvUO+A /Lbjn9tgwX0qG2bVpG/Snp3HDdcBcZaz0anEvvx06/mMe83ycyVEHp6AE65Ri1xPCqYi 3FdPvzridBh3KsRuAEurxC3eZUBnVF8ptdqf2CGB2pElYDZWCP8pKKzrP5yuG6uU3WSJ Dv1lcFUvQ2pKXp15S8JnfmRcJsplxyav1DIbQelYLBESD/fKI3XzVP5fSRm1y/ySAi/Z FHig== X-Gm-Message-State: AFqh2ko0GdsMyLLQfgGXG3k6GbhkXdK434H7DIOvVP7HeKeDmyTPwYYg Y8pPkb6sIpiGLOs/LPpqqtMR577gXgDAwNhIrDfO0g== X-Google-Smtp-Source: AMrXdXtCxd6Nv2QgxP7EOBTb8lhUFCSQE1Ukv2LoL5yQFFKywuU8yWpkxXOR6l7NGB3j9zxYbviRuiN6CjodMeasJoI= X-Received: by 2002:ac2:48ac:0:b0:4cb:4488:7d97 with SMTP id u12-20020ac248ac000000b004cb44887d97mr1277769lfg.447.1673445413510; Wed, 11 Jan 2023 05:56:53 -0800 (PST) MIME-Version: 1.0 References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-5-willy@infradead.org> In-Reply-To: From: Ilias Apalodimas Date: Wed, 11 Jan 2023 15:56:17 +0200 Message-ID: Subject: Re: [PATCH v2 04/24] page_pool: Convert page_pool_release_page() to page_pool_release_netmem() To: Matthew Wilcox Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4BC641A0002 X-Stat-Signature: 8jjunhs3i14fnndo1qhznb5t98tfg1tt X-HE-Tag: 1673445415-145344 X-HE-Meta: U2FsdGVkX1/jv2uegSaYTaEAU7attK8WF/Zxpwtj9qTOod/8OEJJAuCCToVUIHEBQkixMHtLsnY10QxaT9FMnFwbPRnwE4j3kE9TDrrELefKocnH1E+8hzKmTngaoW/k4q5oHZrngR9WGTvkt/jkLNzDmvoHFa3zRiQeRzbBAGHnIpSpdcATXm2jM/JVJCV/bzcTCHFGonX7QRQjVb/4mOJVto3sT3opMs6h3hBSENBWG4zkxG5sWS9NNQL7Ulgw4KC1pNtoEFg1B/jY/n2hGosQB8cyatmbgq5ugN3r0Ij6dYvtqaAT7no3QBO07m0O4WLhFeOSXZAr4ci8Bu6lTbYSHX7nU8hTmVV6HsQXspfekGrislEBBkJBEU2wURdz7OoAlyFT2VZeG14ME02qT7+GyuclZQkPjoSSFmo9KENk452w0/3tsDB3EelyUie/lalg7cfsXJ1Rw/fXHT+gj2dmJ3IYEvcdno8hTuNJ/wJp11rZv2r6V6sQ8Vr9CPCQZ7sErlnqDQYn08i7uRH5nYSMiB4OQ7oT19LI4rGvDGw8yUeNSIcxJVq7E1Z5ZMLFUj3mjYJiD+RTuR76S5mi47+ugkQNi7ExWKeA6C45gZCRxllMz82Up3cPZJJns3FHBycc3GKmL4n4VmA7e2kCVkMZ8RGuj7hmm7OY9gPjSKM+F3Zd5MZgzrdB39vJvcAEOJkTWwAas2g10XEUElsFAwIs998Dk3/27I+UNM3swK/ceIaeyRvGCwBbOp4kNp12QJ7SA8AQadoEz5rahTNZtDUIYJJ+V/0FsgAnXfaw2eVMnckex3O6dgm+3L67NIdfhAZc0xzHf+80hqP9v6A6qWJPwPLOxCSXL8sIb/qosmKGlf8od1h7xZr9u2lHQ9GXqQturBoc4+VmnyKRtuLwPd6eyJ2LyuKX5fQsjS3NBkV4tyz43sp2LFcEim44UKvMgcNfdXc0WbtkFt+p3cb G53UA73l B+fcdiMjQAxvpBmaxGrUnfjVvhAHAq20Yjs2Gv+jmv7d5mxnFAu3ORJPFcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Jan 2023 at 20:47, Matthew Wilcox wrote: > > On Tue, Jan 10, 2023 at 11:28:10AM +0200, Ilias Apalodimas wrote: > > > -static inline void page_pool_release_page(struct page_pool *pool, > > > - struct page *page) > > > +static inline void page_pool_release_netmem(struct page_pool *pool, > > > + struct netmem *nmem) > > > { > > > } > > > > > > @@ -378,6 +378,12 @@ static inline void page_pool_put_page_bulk(struct page_pool *pool, void **data, > > > } > > > #endif > > > > > > > I think it's worth commenting here that page_pool_release_page() is > > eventually going to be removed once we convert all drivers and shouldn't > > be used anymore > > OK. How about I add this to each function in this category: > > /* Compat, remove when all users gone */ > > and then we can find them all by grepping for 'Compat'? Yep that's fine Thanks /Ilias