From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935BBC46467 for ; Tue, 10 Jan 2023 09:18:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CED028E0002; Tue, 10 Jan 2023 04:18:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9D1B8E0001; Tue, 10 Jan 2023 04:18:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B64BA8E0002; Tue, 10 Jan 2023 04:18:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A70DF8E0001 for ; Tue, 10 Jan 2023 04:18:15 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7709BA3797 for ; Tue, 10 Jan 2023 09:18:15 +0000 (UTC) X-FDA: 80338338150.06.C1D3BE4 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf02.hostedemail.com (Postfix) with ESMTP id CB14580013 for ; Tue, 10 Jan 2023 09:18:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=SmLfVSZk; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf02.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.47 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673342293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qEoCk3QhrauPKQfPnLgsMlCCuaqye7yB7TAPrEhAW0Q=; b=EYsv/PDs+VQR5cejUCfC8w6m/XLNNdv2o3HsdceA+3dwxrokOvcVvIxYS1k+R1gpKtXjqo yRe6M3UdGJmGI5XDVQPShZHER50P2oudX53CqDMidG3z1eeiTQplbv83//ddY8gUc6iQKs YHxeJTHI50s6GcX9kPPw6N+UPgV1vhE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=SmLfVSZk; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf02.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.47 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673342293; a=rsa-sha256; cv=none; b=xQ9cDlR0FxBkn9z6RAV7Q9zGpx5ZUjfmg8dG4oJmZb4e6h0WiPcP2j3fe2ZUfmvmRhOLUp TexvoSiWriZhYZddFd80Ojk5mAlczahjsWZv/oIaCWRmZt5Iz97lIClBL8IF4VWLgebVBU Xb/6H4sEvzdLimwKGwgpviYkuBsE6m0= Received: by mail-lf1-f47.google.com with SMTP id d30so12463988lfv.8 for ; Tue, 10 Jan 2023 01:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qEoCk3QhrauPKQfPnLgsMlCCuaqye7yB7TAPrEhAW0Q=; b=SmLfVSZk27DK4OQLCkIGDJqmasEdY2jqL9Do4eojF94chWAOOID7gMTXazEgsOJltf sOytjJxEhG1XvZ/RePiudBCh4y7BTkGTrLcKVQBd3YS/tZ4+0lArj6yqR/5En3QV87DK APg5uqVR3URBqLt6XDOrJ9/cSeQc32UuPFI10onG+7NXMathsunAUc1pR7mCxffYZarj YiU4sw44fCTalcFPqvK2NFDao//m/RJCPauh1XkamMycJ6TvS7odjVLAdpqFpMtYC/Kx s9NInffydzYv12Picrqt5rAqdW7waGjgp1pk9qMUCw5h/dcy6npW9MeC7+ZwFQGOQxP7 ehFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qEoCk3QhrauPKQfPnLgsMlCCuaqye7yB7TAPrEhAW0Q=; b=fcMynhhvYpbaKXcVTwWiVGx7OFnH5GZ3vm+WNrJthMI4dALhuXmSlrQ4HTZR3tgz66 qz93R5QDJ9aJCK4Y8t89f1GoOiWVXdEyTPeoHAmWUIYKdA6wDs2qyWyw55w1tItF0O3a RRyeNK1OUrVy6bl2++jKek9Q9P2BcRXbAc5cW1xkc78EfB2W/s3q7UYfDviUUM6Yv8/c zXghNIkLRf+jhwnklfH7AFr5yveoR3CylipNAYPe0JBfcramQpmWE2f+/slYEVhn5jTG a4gUkiJGwbMM0UTCE8d3FNweWUgtzgnyO/h1NbfaHBlpcIHYvyU8A61ByurPcRIOcLB7 90BQ== X-Gm-Message-State: AFqh2kq7fpI+TeeXV9Adtyy+2rxFaRSh8ZNgfauP24Gvsl7SGONKmfnZ mtKxdfvXnSbLYIF2ZyCYvHbZBjr5kbSP2XhW/4wZaA== X-Google-Smtp-Source: AMrXdXtaPvkJOi7sGoCcfoQkbvLcLycNiUEJvGdIOGo2gFatG+L6ZV/ESPVZGyaIhf7zfsIp2Wr1lO/uPZWeKWDGeGw= X-Received: by 2002:a19:6551:0:b0:4b6:eb4d:4b7f with SMTP id c17-20020a196551000000b004b6eb4d4b7fmr5759167lfj.530.1673342291818; Tue, 10 Jan 2023 01:18:11 -0800 (PST) MIME-Version: 1.0 References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-4-willy@infradead.org> In-Reply-To: From: Ilias Apalodimas Date: Tue, 10 Jan 2023 11:17:35 +0200 Message-ID: Subject: Re: [PATCH v2 03/24] page_pool: Add netmem_set_dma_addr() and netmem_get_dma_addr() To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CB14580013 X-Stat-Signature: aifs8njj5fi8w73j5jefubk8p7i3m317 X-HE-Tag: 1673342293-149044 X-HE-Meta: U2FsdGVkX1+QEzPBOKsddutz2P0PmFBjIJfkOofJHqElljSEpa4f1sRF8BjoqWRVmvNMF/2q6Saxn3Ew2K6IJ4wNWegRCeWavzsatapmpP24GIiOOgJNm/0X1MHmcVRvZyLMxUAYppjkkQIMjbFYwvNJeRltQqwNvp92/261Pc7RtkQPqrr+p3G6ElGnKBm19NTxNmvxTyWbv9SIOBIKaQocySqey78TmwU0EdmcZJzhQz0lteGBmBvRoo39XIIFhXIA0sLEoV1h0+cANPqmeY8VlyYS37VcJZjOwYBaQIAIYhTakGB4F5lBIjfBZY7ZBYDgQnExQ6l8qY3NQXOUczSxTy+/WGoF2NkH6qhx1RzSkTcRbpEmYk7fjKQ6BZiTkf36edWv5FVD2gKF+pjbKENrtuwWOglpzhzk2g/Np1ckipodHeV6rFx3mma9D/zlocKTdZns9Z6s623ST4s6Y+UVa3AW8qeLiJM+D83wpy/4soTEsqnTl6VYzcDx7VelFoifmI7kvk8pLWaku2l/j6M907J/DC5NYLe2ZdPMQUPGGARMkW/CdWj75bZ1Bxhvdvs3I0sF0b/dJcJ1hYETgCSfcVemExu98m/Ede4FIZ9pWQcGWnwUp77h3Jm7/Zxe7VCODPOKjFI8/lM2Ev6c9nbs/dqPJPzAYk3PCZudwCZgt2cGMZK7ruMd3ItreyaeMwNE0o4bODeB+F7D0SwOAwIhgReFU52U5yIEg51VepgfE1CoPh+2As+xtxiRNDZbU3v9JE7hU8Qm4ahRIrQNe1IVPA/X7q9w2KweE+FaAInRxn3t9zaXisfWwUWX1RK3Q6phV1BCR5NWmxKYdZ9he5zo76LPcS7I0wZ3Gkz0WMN0Zadg8yLaydnhDGy0rOcGc6q4tKckmTmT0JLG/8vZi7aB3DYLyRL7HvPeBSBmXFdicNfDLX8EaTihc0bvm3951YatYXqvxBHT/fdZMuK 2eWZ3/EB 8Z2TVCX89cGGA1g8j8unDfu5Ec675fljN87nLSu9PJ57Sf09xBjAyZmFh9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Jan 2023 at 19:30, Ilias Apalodimas wrote: > > Hi Matthew > > On Thu, 5 Jan 2023 at 23:46, Matthew Wilcox (Oracle) > wrote: > > > > Turn page_pool_set_dma_addr() and page_pool_get_dma_addr() into > > wrappers. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > include/net/page_pool.h | 22 ++++++++++++++++------ > > 1 file changed, 16 insertions(+), 6 deletions(-) > > > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > > index 84b4ea8af015..196b585763d9 100644 > > --- a/include/net/page_pool.h > > +++ b/include/net/page_pool.h > > @@ -449,21 +449,31 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > > #define PAGE_POOL_DMA_USE_PP_FRAG_COUNT \ > > (sizeof(dma_addr_t) > sizeof(unsigned long)) > > > > -static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > > +static inline dma_addr_t netmem_get_dma_addr(struct netmem *nmem) > > Ideally, we'd like to avoid having people call these directly and use > the page_pool_(get|set)_dma_addr wrappers. Can we add a comment in > v3? Ignore this, I just saw the changes in mlx5. This is fine as is > > > { > > - dma_addr_t ret = page->dma_addr; > > + dma_addr_t ret = nmem->dma_addr; > > > > if (PAGE_POOL_DMA_USE_PP_FRAG_COUNT) > > - ret |= (dma_addr_t)page->dma_addr_upper << 16 << 16; > > + ret |= (dma_addr_t)nmem->dma_addr_upper << 16 << 16; > > > > return ret; > > } > > > > -static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t addr) > > +static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > > +{ > > + return netmem_get_dma_addr(page_netmem(page)); > > +} > > + > > +static inline void netmem_set_dma_addr(struct netmem *nmem, dma_addr_t addr) > > { > > - page->dma_addr = addr; > > + nmem->dma_addr = addr; > > if (PAGE_POOL_DMA_USE_PP_FRAG_COUNT) > > - page->dma_addr_upper = upper_32_bits(addr); > > + nmem->dma_addr_upper = upper_32_bits(addr); > > +} > > + > > +static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t addr) > > +{ > > + netmem_set_dma_addr(page_netmem(page), addr); > > } > > > > static inline bool is_page_pool_compiled_in(void) > > -- > > 2.35.1 > > > > Reviewed-by: Ilias Apalodimas