From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45670C5B552 for ; Tue, 10 Jun 2025 11:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2EFE6B008A; Tue, 10 Jun 2025 07:12:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D06616B008C; Tue, 10 Jun 2025 07:12:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45666B0092; Tue, 10 Jun 2025 07:12:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A597E6B008A for ; Tue, 10 Jun 2025 07:12:33 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B35380A88 for ; Tue, 10 Jun 2025 11:12:33 +0000 (UTC) X-FDA: 83539227786.29.E05751C Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 63554A0008 for ; Tue, 10 Jun 2025 11:12:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="gTt/V3kP"; spf=pass (imf15.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.173 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749553951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oGJoap/WPosW06fDBcr7SQqlOi1DYaMmMX1oaY7kRo8=; b=RMYlYdhw8o9kKs/K1kDzCTPPkZU4O/ZlTHUY4rzIpgJEYX1fR4KXjnuYXiSyeNZ9NWFgN2 nQ3+EiAbdPEIYiXtAGTAoHBTybIm4TraMDFgG/nfY/tZ5XQLH8ua/WGNvvRLHzWsAzQkfE AGnIGAli2GyJfbQoTp89WZrnCS+6BIA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="gTt/V3kP"; spf=pass (imf15.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.173 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749553951; a=rsa-sha256; cv=none; b=Z8cYyzWgeMaPYFD5oKZ8bX8qxYG/KkKP+Evp+l7QZk9Ybb0t/PdaZoE4MvH6ywdhsJHwvJ lN3VOgbed2flVM1sGGe+pWzwIY55F1n9ZR4utZVFYBUMeJvmQjKaoSNpLpbLL2pVe2urK8 5tFTcTFstBXFAbd2uVurOe/YL0LF90g= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-70f862dbeaeso53609707b3.1 for ; Tue, 10 Jun 2025 04:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749553950; x=1750158750; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oGJoap/WPosW06fDBcr7SQqlOi1DYaMmMX1oaY7kRo8=; b=gTt/V3kPsBF0Y+88/3lo6cejsbFf5W2uRulOL3G8KKBoJiSbQSBlrcKBh8WQSeEVMc fjEb8GtatrBR1Feg0QfQGwIt6Gm9waCy2MzAfCmgQGxUqyqTXfI54EjPWU/+c2HF+xT2 v4sLCgj8rxRwiQaSk9iKYUmgwhi1BqxhQd9npK1NMwab4743KHCriWsxdFepN45jziD1 5VRhMMUtqM5w0j161EY4aX2aXCoTj0PvoV3h48k2kWVodfCjDO8ClrCK+yHdoDu2wLKn tzCcA1DvNqkpG6jFXRo2KtdTy+9vBbBPcQD1vMrFbBocoDD3t8P7aEUHAUifCFBSQjQh m3CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749553950; x=1750158750; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGJoap/WPosW06fDBcr7SQqlOi1DYaMmMX1oaY7kRo8=; b=wNCvDP+LXL6gFAvRuczENibwWq9U/5ykR1Yn1ad+C+Ax7TxwzrowAJ8ZIZvHmCnwIO vsTaY1aVw2pk1EZVGQ1GeV1Y3mgO/wmKE+iaEj4zfGEmRHYwby82Xar2a0T0yKPuzmOu uUHQfHNnbYaXv5xQtjivE/jMH0UreVEjd17HxGTeqW2kzAvnCZ40c5sfC+PTmctocsRR W0zsn7YFnELLxhya5pRANfzbop5LHsBbCG94LuCHNleLUmAayyIRAQDPW/sKXuD2IkbO sx6BnyXs+z6/6BqXc2CzCnGBiQWxHl6mS43sQjdkIT4uM1OOP1VKZN1qA9yjjA1eiR2+ zjOA== X-Forwarded-Encrypted: i=1; AJvYcCVWjOZ8vQCDUPKCg4TyM34PNvVytS2rs7XcbfwJmj0ekl19/dz/UQ6678nVYNycPE2Q5/7k4ibMdw==@kvack.org X-Gm-Message-State: AOJu0YzoWCltxcLTLX+qS79vNf/bOmR+QLK5nm5ESUY2A6qC+GndepC3 IPugQh3f04UyACp46gozYV207N/o+SlcG7OxGyJ73E+8b+7LOu0Ze0lvGv7NYf7xd7h/SudsWY7 cdAfrJdwTcwkzLGr9FF1jGPKGx6xhpdwHqL8tG+E3VQ== X-Gm-Gg: ASbGncud5w6S5PNukhH4LW+R+zCNC+SN6nSuUjDlG5A2ozkGUPAL7o+bZY1nMHmevz4 GK4jZ2oDQ6p/QEqUIYHHqAn/Pzf13D+quJ5U5aen+MGJRT23sIDJr48SkUNDOJ0SLSSJ08vOWw+ lS+h8uIkAOFWY30DBA/LIdNy6FKh8rMtVl4qfwiKMq8klW X-Google-Smtp-Source: AGHT+IG8zsawN3xDkIiHoqtoDeuKT1Bq9JS9Q1xXDw1TdS7PPhQJHt3vukBAJDXQ5rpuyqj39qP+g+huLdHgKtWsHJA= X-Received: by 2002:a05:690c:6d12:b0:70e:2d1a:82b8 with SMTP id 00721157ae682-710f772b158mr238734027b3.34.1749553950407; Tue, 10 Jun 2025 04:12:30 -0700 (PDT) MIME-Version: 1.0 References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-4-byungchul@sk.com> In-Reply-To: <20250609043225.77229-4-byungchul@sk.com> From: Ilias Apalodimas Date: Tue, 10 Jun 2025 14:11:54 +0300 X-Gm-Features: AX0GCFsoN4Lw-oBn0iS9Ed66FhTtsA-gk57hCRDoaANAiIafqJARqdL3Be-QVJk Message-ID: Subject: Re: [PATCH net-next 3/9] page_pool: rename __page_pool_release_page_dma() to __page_pool_release_netmem_dma() To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 63554A0008 X-Rspamd-Server: rspam09 X-Stat-Signature: mtgrwmtmp5c7ifxtzib1ncyxefrssurk X-HE-Tag: 1749553951-9091 X-HE-Meta: U2FsdGVkX1+PsbPiY+0wyk2G7Wtj5zdNRSlDaAe6zQ/BDzUfCo18xP7afAdP/REZphBCWP/Cr6AAFPyOzYU8qKCTJPlE8EesCK99NQhZ7dRjnbcVaP4QddCyiOmcBnYGpahwW0LPrpuRjUDKUaYBMda3NylUQlvE0khN3jaq3nRcHNHFmZfz/9WW/glGCfh/DRrOdNmucqKH0W2++r4kuL7Pk/FCCJIzmdxVgPHt+jE6N5dcS4baB+Yti8rx30RXIN983UxbzfGqahScgC2UQld+DFu3TnFH7ep9Tm0fpIXzn8UnXBHPn1XzEVDPNs+M+CXme0Ks6HuffAa1zh9Ds50eVIqaBXkYK5xiphkub6YoqLYYTLIu8wxmaE/G8yUOR+vzXDhjy3/yviSAUGlyHCI5/kU5uOmUVFo0B4fht16aSBwn44SyHN7Nlq9g6wW2l8xj4Wc0owu66Au1KZ4kuyYV5W0BNq84uq2mWmwmcNQC8jhWzAWbCldsWhUxeoAKsBbqlhpYmkFonSovx0hFKVLHxiBt7DSZOzOmBxZtVb7k6IiEMzLhxbk42bLfXNZqSu2jLCblK5kWlo1XYMfTg5OvMjzqOD2M9JGXQN2R1OEKNCgvpR/NxTuPmLGJYer0CzibylTAaD6w2/ukc7bmIwdTAsF8/xa8nLGx3nxT9TEnvU/6at/RdgR2lfvrk9o6NL+2RhOeQTTdGzek6+5FfHUhSNaN5DV8eS4hroWfJLrGKCdFE078vwstE5BYqujOQq3G2bElXvHFfiUdz9HcF4r7xdU4duxoDSYi55X05wKpYGLncGNlOqimnD+jFLtf6TtAc/7al/LD9ntuJ7E5oxjgVHEVvnpkNlC3mly4hEhx8GqJMEBarKa4HgSWlR74K/v3aBR8FB40Vw3Bo9x7omli9tE/Tlog02xSpeRGXnocYgl339PR2R9+Vsqz3xZAFkPxmIpdREu3v1cZ05e rVLZqutj 3AMwhulPAivGdVruGxMUd13oVsAx0PRC4KO3CV20bycd/hig3blS08QxtvB4HAQir29R1j95/UR8u1k/o17g/ltNyzFaExv00sFy7bTRRYkMTqeXL+qIlJIfld7GuLwy50DJ39bBZX8bnTkrotbzroxE4wBcLUvkofOkgYCxAWTojPSsnGg7eJ70URSAX7STk/cYnWWGpcve6WNE0336MyAQdTOxXtUJmX6Gea3YH874dwHMsFmm45fMT8ztAIjv6RWBg4540KvrLPbU7h+ejANXSsGjmYtQL/3/cXLwW8+/IZmX6Z2Gu4T+76+5Zh6ViohIvnF4iET2AvbqfhFpOR4HkyG7MqdeCkfzdmqg97qeh2L6yntH+KtJ36KFhZZ7qTFQT/L28/ym9ZxHj1CpNvj/ORF7guxvOgGAmr4uuaFg+akoedq2Dkyv0l6XeOoAFxX/b0+3wBneZzxAFUemvZ89tmhcUeM25lzhgO4AKw8lBdb0LUMkk/rfLeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 at 07:32, Byungchul Park wrote: > > Now that __page_pool_release_page_dma() is for releasing netmem, not > struct page, rename it to __page_pool_release_netmem_dma() to reflect > what it does. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen > Reviewed-by: Pavel Begunkov > --- Reviewed-by: Ilias Apalodimas > net/core/page_pool.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 460d11a31fbc..8d44d1abfaef 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -673,8 +673,8 @@ void page_pool_clear_pp_info(netmem_ref netmem) > netmem_set_pp(netmem, NULL); > } > > -static __always_inline void __page_pool_release_page_dma(struct page_poo= l *pool, > - netmem_ref netme= m) > +static __always_inline void __page_pool_release_netmem_dma(struct page_p= ool *pool, > + netmem_ref net= mem) > { > struct page *old, *page =3D netmem_to_page(netmem); > unsigned long id; > @@ -721,7 +721,7 @@ static void page_pool_return_netmem(struct page_pool = *pool, netmem_ref netmem) > if (static_branch_unlikely(&page_pool_mem_providers) && pool->mp_= ops) > put =3D pool->mp_ops->release_netmem(pool, netmem); > else > - __page_pool_release_page_dma(pool, netmem); > + __page_pool_release_netmem_dma(pool, netmem); > > /* This may be the last page returned, releasing the pool, so > * it is not safe to reference pool afterwards. > @@ -1139,7 +1139,7 @@ static void page_pool_scrub(struct page_pool *pool) > } > > xa_for_each(&pool->dma_mapped, id, ptr) > - __page_pool_release_page_dma(pool, page_to_netmem= (ptr)); > + __page_pool_release_netmem_dma(pool, page_to_netm= em((struct page *)ptr)); > } > > /* No more consumers should exist, but producers could still > -- > 2.17.1 >