From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E893C4332F for ; Thu, 14 Dec 2023 06:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1CAC6B045C; Thu, 14 Dec 2023 01:12:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCC836B0460; Thu, 14 Dec 2023 01:12:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94226B0462; Thu, 14 Dec 2023 01:12:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 977C86B045C for ; Thu, 14 Dec 2023 01:12:30 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5FF4880272 for ; Thu, 14 Dec 2023 06:12:30 +0000 (UTC) X-FDA: 81564404460.25.A3DF9D3 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf27.hostedemail.com (Postfix) with ESMTP id 7FD634000D for ; Thu, 14 Dec 2023 06:12:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=T1o7iqLt; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.176 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702534347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QoMtJ3jc9LwNpjNyh0O2VvaOvQmiL70UQU5xKazHWoo=; b=Ut9GK2x2NNlj7kpx83uG0NJ0JIUwTS9n9M1jwzRl959LfzvaUcniIl2URO8bNftvS0aFe/ tnI38CnjkgxtSFpxgiMBLOM4F+/CmKYYlFfkedHe2NMKbQa7I+0zWMwIyl7b7iVBRZb25p X9s3A8RqA8aWUhC5t44rwBwhTXxKfs4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=T1o7iqLt; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.176 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702534347; a=rsa-sha256; cv=none; b=h5gDLxxtWZJG4HKeaF07tMjbcP4dOMDTbY4Tdwckn9CgDVU6ZvG4oIorkKbTlheeuU4esz vEGS2yxZ5KO2pWPk0qhAYkotRQYUCzmFp9KUkTW1ymPzx+cF+s4hJlLrlQENAAmRDbJgel gJAFH33HhLm8G8253IPyRdSqopbDRqY= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2ca0715f0faso107432581fa.0 for ; Wed, 13 Dec 2023 22:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702534345; x=1703139145; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QoMtJ3jc9LwNpjNyh0O2VvaOvQmiL70UQU5xKazHWoo=; b=T1o7iqLtKn6iyD42qrUc3BfrupkpRWOfDgiPVuN2skmbOcNZTWFpuvM4TOOVLMMQ7p 6qWQceEoTg9VqwMXMVXDEY1OXlT1OofTAojmzJl6fo+19VeOAOkySIsNi86347HGXB0I k9QxzGmgwx+xznyOaij3ThNqe3B3l9ivCaVgKb/xri0+f/eKy9HkyI6Eh2hj7iUTclMn zD1mDfMnfcOk9gn9TWkSgHcC/kT7Kim7znF3IgKJ4ihve6dJQ/0mekXE5seflJUTpWYV WulQvY7UQUQIiaEgrwUjNZyEAL/KpQ2XQd6+78pYaP1z4hfQyqbKXwhKLU7cTZdEsdVo J6yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702534345; x=1703139145; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QoMtJ3jc9LwNpjNyh0O2VvaOvQmiL70UQU5xKazHWoo=; b=ndBX8Elvv6/a+Ry3tXWmygIAzv6gm2MaqWjNp3gTmfn/MaFoOMYN4k7G/AqX1c9z1n szRG4plRXYs5qSMZBhWCvfRyZ1uVLMEmrZXlw3VsvZ2aVvYGMRwfDVXECu5cWfJryT6J WEh2uNvDqGz0l0fDJFmlTwPQMijGjnL0s8Kmie9scdQglE9KvhdpjRijxwauPC+rHuSB IYLrxvSIvRoDlplHazgcWIaajKG06mvmzeoJkDB6BO9QvR14wlkP8U1K5Kx3L2QFiyfd PhPf1hc+o9+iVbWTybKTMbXECLvwlSv0aeSyNtehzgBHFnvZ3hLclo9fB0Ng3tu1WTPq psnA== X-Gm-Message-State: AOJu0YwKQF9Db7+H5A53dQAqdenjIy80Z2gPMGm1PFlGU32x3ioKJQaL dzpcKlIS+2+N0rTtgeHuQ+btctk1PkSZn0T92Qn/0w== X-Google-Smtp-Source: AGHT+IHHfOj8iCF5VPFr9VjmnsfbVHVZaA2lZst2Zsr9YsfG0dTo8uUZ4LtGHxa8PAWCrALkDyac2fECzljy1/4B0xo= X-Received: by 2002:a05:651c:1145:b0:2cc:1cc1:586a with SMTP id h5-20020a05651c114500b002cc1cc1586amr5175047ljo.19.1702534345503; Wed, 13 Dec 2023 22:12:25 -0800 (PST) MIME-Version: 1.0 References: <20231214042833.21316-1-liangchen.linux@gmail.com> <20231214042833.21316-2-liangchen.linux@gmail.com> In-Reply-To: <20231214042833.21316-2-liangchen.linux@gmail.com> From: Ilias Apalodimas Date: Thu, 14 Dec 2023 08:11:49 +0200 Message-ID: Subject: Re: [PATCH net-next v10 2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com, almasrymina@google.com, Mina Almasry Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7FD634000D X-Stat-Signature: n7s4kuc578ttoe4w7qeakh8rg4emey3u X-Rspam-User: X-HE-Tag: 1702534347-220776 X-HE-Meta: U2FsdGVkX1+x9oEMQ1C9QNa/l/va7Ce0ZAPcqOh5zvX4a9738FZulP4Tv3lVwXiCn25DC5zFo0E2RvqYMif3GW3nhjF7/cOnEi63HPu+J5Cf7g8pVVaykmbYEdoB41du89SCb4X4GngalCWq6oJLaazjrA23rH0JqD5WF6aRWzs2VyYoMrgVP5gnFzMQ0soHHZfuLcMutIYv7gs72sSQZ3mfcUNAWi8Jaa+A/9oHusyW16klTPxVA6Cw6lOIcGYawLtvnJmHSxjSPu7IDuIxJkjjk3+AEq61dBAADAIXo3+33HfjM1pAslh8O6Nq4MvGej2A7d4E0jGSoi5da3jlxAEtRdBePYfeMmp/an65AT6y7WnOlaTC5OpB6yJ45KFNnYtQ8MmXQ4yOBNTjpyc8PbzsRY//0tml5VkXkQ1BIY8QjbEjwzUtajQaQMfCROg7T366/ECWYSvQBktReozk4bF2BGZfIjWGDtTDTevo4dn74FO4ESmgkm3ycy6xWjo3HLzANCZZm70drlPo5IxueuavqLLw6O8nA2BA86NY9UyswUsYT6hHv4E8AGfuzIrfcwyFbCnGzRikqD8kLUE5HoU49WYgTvnr57i0FA37/piaCIXsavhpfP1VuxwjKXq3ezBclfg6gdp8l6eDZf2ggijaBPiTz+nX+yUcEFwon7BcOkv5sa6xOftEvFIUbg+7EG1Q3ZxwyTy1GJvDs7t1z7ynyef6D5H2198izFI+Ldg1iVj5iRRDMaakR0Twe8ALhgf+tv6I89IS55hj5mAjbZD0S8MTJJg/9zRhTEbi63A6a0S8gJ5tb2Ikwncp660bHNgs+zexH4rlyVG4ZXayuMzRs2J1D5rv8hMGuLHKAwFtw1wcWboDOtFt8vooGzYUg5hc/6TDt0LtmslCoEPWYwbmlJpBn6GK3c54RGloT/j/zx0kTejMkqJXptg3MkcpdXfJa9IvugJUl3R2/VA oYku7/Xc fF3hmFh5x5U42twkHQC2AYwBlxZRZcmaZeRXWtpy/XGyOSZWYk6UhgDInik1qYu+cGXj6s12Z/9cDu9oZN8VYcDmDJctDQ+svq0YxPSMO1IbP6MMe5f3dJfMU+jK9dRcFAyfPAyOk7q0HdCrwvbxlLPm5/rRTaAzhv4VR2Ds2MEBeHzA+0JQ8xekTLu5j/j7qBmBYszCHrjRo3hB5sd22dTv0OIbDSlExj6v/x7NkDciBQDo+MdrrJ+j81DY58PYLr9GGtKt1t3ahQ3vy2vZspiSvrGbUHWEDdHeAECCv+7ftIezaCPYhOFReU7beUQu7sDSKKeZxeD3FE3MhGQS39HGu16CMoFpSGd7TSwblnRwfhV4k1ww/bi3clVx8O48KYxh/5Wbg+WGV/WeUyrTvGMTwaszwqSmCX1avkhPBz1vDQyJ0DKCezTsTlayEtAmsX7om4d2COF+qfHIWUTJJ3RngMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 14 Dec 2023 at 06:30, Liang Chen wrote: > > Up to now, we were only subtracting from the number of used page fragments > to figure out when a page could be freed or recycled. A following patch > introduces support for multiple users referencing the same fragment. So > reduce the initial page fragments value to half to avoid overflowing. > > Signed-off-by: Liang Chen > Reviewed-by: Yunsheng Lin > Reviewed-by: Mina Almasry > --- > net/core/page_pool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 106220b1f89c..436f7ffea7b4 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -26,7 +26,7 @@ > #define DEFER_TIME (msecs_to_jiffies(1000)) > #define DEFER_WARN_INTERVAL (60 * HZ) > > -#define BIAS_MAX LONG_MAX > +#define BIAS_MAX (LONG_MAX >> 1) > > #ifdef CONFIG_PAGE_POOL_STATS > /* alloc_stat_inc is intended to be used in softirq context */ > -- > 2.31.1 > Reviewed-by: Ilias Apalodimas