From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5701DC3ABC3 for ; Sat, 10 May 2025 07:26:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3577E6B0129; Sat, 10 May 2025 03:26:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 306BD6B012A; Sat, 10 May 2025 03:26:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6426B012B; Sat, 10 May 2025 03:26:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 007216B0129 for ; Sat, 10 May 2025 03:26:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07F47120E47 for ; Sat, 10 May 2025 07:26:40 +0000 (UTC) X-FDA: 83426165760.24.5D60C6E Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf04.hostedemail.com (Postfix) with ESMTP id 2B7EF40005 for ; Sat, 10 May 2025 07:26:38 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zn7iZSm6; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf04.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.219.179 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746861998; a=rsa-sha256; cv=none; b=mZEOX34DtjcgNDGbuonDsbgdkUyktmYBZScT1ShfS8DBPjhCnY2Yxsrr05Yvf4XSaMEVSh ucXGojgXOiKHE+RCTGo1oGYyhuN4Bf3RvsFqNLUgTrsbkLhb9n7dzJm6I/zSIzf+7GP1rO mAMgKx7lT/JlJh2gK2ayRJGt18sn/Yg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746861998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zSts27GOHs7qkbKGSUS9YSDd5Z671TY7T7HU1jkBF1I=; b=7d6jbNfRjB60D7tGOyqZ3r10C7985A+/9AHttp/LZh7h1vVZZrN1mZvXDZG3Pv35cnCq6w b3l07yMcvJQFcg1CjZeDRbE7WrBFU9Ajwd4mbE2h+dz5aITiGBz+H4QPgEU0rNrFNbFpmo XDEABpYutY1iOD1dsNRDXII1dzrxEzs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zn7iZSm6; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf04.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.219.179 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-e732386e4b7so2937247276.1 for ; Sat, 10 May 2025 00:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746861997; x=1747466797; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zSts27GOHs7qkbKGSUS9YSDd5Z671TY7T7HU1jkBF1I=; b=zn7iZSm6Ww0vOMcKxv0baFvZUSu3uLlN4HT5/GAYCz+IFB+ZxiOLuI+ItVKKrZ0Liz 4PwS4J3Lyz+pTzqWDzhaFpbXOE7sNe9p55Qo1dgzUuP4dqLoutAWyCetIA/G0fPmWJMI X/J1aSRppRU3qKrZJ38j6pr8k5VDs87RQORVodTNNiGas++78GHVrcGRK56W3KQUofRp W7X/V8kMiY+bUx/TDf9A9OfZhlxab2uWMljleBda7QBnBvU0Hpo8WDI8g5V3EL+KXdjN T5yKyu3V8g6wP+Z5jfhUk4fICcMBfv1KmdJKfV9V0zcYJBvB4o8J2NG2SM8B0xCN3dnu fPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746861997; x=1747466797; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zSts27GOHs7qkbKGSUS9YSDd5Z671TY7T7HU1jkBF1I=; b=wOQbV62lCqAqlVEN18pj/JdYDqWkqMfsRoc/ZodHP6zBWohcS3XjlCFaxWrsfZqQZD dn8dRgn7PImoG4F0Sb/OguaI1u6EFFo95guCR08prWv+rwhmrLz9mlDpuCscwtFNaB7M wu9BNBLpWP6XYmetfoXvEbyGjA/8Jj+0C3qlkatgblupTW96ELh9gkQL34uhX3UZ6GWG Jw7VUwRyCcUPfoFMiKZcwAIEu9Y8Iu2je8bDytOLcKEQjzoBNCaRurX/B83Jd0C6XQxd A3FkPSV3TTlccWf0nmdXA6DJDc7WrMCCoKHipAA/lbxphnGCMUqcSfg3hDN1XXfm9JVx /PRw== X-Forwarded-Encrypted: i=1; AJvYcCUl6EkptdwIReOVCijWOymYcvMvwqX4t6/vLakbRlOFMCsDYfIG81DfG2GQrkz/g4SeU2j2+nHLHQ==@kvack.org X-Gm-Message-State: AOJu0YyAnIvA752dBs8WZPsScGYEtHiN6MYTwhlDHbS6rF2DQqvLl8gL L39t6XlzIhRlVllJVFA/EJWmzzl+xU22QmC2YN43WGROniaE3No8d1MS44LvSQy1aCTcaYq07II HFERa/bE7yGZLaoqFU1bm6z+79HMMeBahW52Gvw== X-Gm-Gg: ASbGncs4bwlVnluzkuHfFpN1/UnJJbWLf0mIGzudz1xaGjFJZoop/YhRQ6bjlkwdLK/ oXYHKUrSpM4xH9uC/tDpg3139Z2l6vlFwL7D35aNbIJ5P74ozzx76Wq6McNXMPWOG/cwLBlD0Rk H8nbHPb4b9FOjy4LM2Ms9oC3Rn6MrW231s X-Google-Smtp-Source: AGHT+IHgBd4y9JeTiyphse47nrob8CWwmAtJD/GkOKCnuv2yJ5ga46vbAkHETH7rfV5vl6KLnxpaFgEyuxCKBcbzPao= X-Received: by 2002:a05:6902:1009:b0:e75:bea4:5eab with SMTP id 3f1490d57ef6-e78fdd612a4mr7925554276.43.1746861997224; Sat, 10 May 2025 00:26:37 -0700 (PDT) MIME-Version: 1.0 References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-20-byungchul@sk.com> In-Reply-To: <20250509115126.63190-20-byungchul@sk.com> From: Ilias Apalodimas Date: Sat, 10 May 2025 10:26:00 +0300 X-Gm-Features: AX0GCFvyCLf2YkLqAu7ZNrSMk-Tgd-w0sQTqK105Q5BnOqCAJU2n8_lO-l0LyAE Message-ID: Subject: Re: [RFC 19/19] mm, netmem: remove the page pool members in struct page To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2B7EF40005 X-Stat-Signature: zhc1q5pu85r3j8txt9m9twyhzqk7tqcx X-Rspam-User: X-HE-Tag: 1746861998-213054 X-HE-Meta: U2FsdGVkX1/BwxyOnL3+xBtLbSaOufY7Rt2zGcwqMoRRKBW9NLMS65R47HVhed4j0mjdnCX4fJHsYhw+7Axl5Uc4SHB74mQVYgG7oPt5Ocw86xSDVezYuT10xcLTV8mgCQP0/eblkotKeBaEE4i/S4fd6jCylRH61SevQi4TXi72dtoHtm3qfs8F8Hb8Lot9HTLUN4Net1vCqZmFNGv+SUVBTlh7f7krufzTwB6P7r+l/19JRoioRmhRlytlUnZRBFT4Od3rJ04tSMDb878TiXbVhJ+zmT85KlEULd4MwJj/eioPhQzrrWGPJ7cFwcdVF9P5yKfDxkaO9Qp5U+BBqYTBQ00QGAuHQx3WrgJb5UjzqCq4+fGQ7Tdnz+ExVaECTF/kD48sPqC+wanpv8p0HAbVds7bOq3E3KhKwDMVoBHknNVYAHYRW234zRZSCbHi4INehWvJqWh1G8ZYa3cVYcxfLc29AkarG2KpDJbPn9xW+W4A3c3jEfLa150kyMU7Wwl7ZzDYx2nzGzMqIVeDBWhU86XrEwCOhH8sTT+wVFtPzR2AtuUx1+W4oxrtRbskKk04cz4yT2B9taYFwCruoZ4bGN2ydyW4TFx68NF7ed25Kg4ABSf4SI83b3V7WcWrjWSBZpnmxOofjFlfqvD9DVQbYr5hbdWvDGoIecqyGakBYQ0eIW5LIxOFx/K1D9IW0sAy30UKWtPvbGiqzcNmvEhPp+RDulh6Z0J+1o9b2WJ/eXVsLD69Bu3SyLb58UJmbbd7dO5McWj9V/4rL2nHD3UGNeGAgfnlQsVj/ggaAS7v5nfq72WTGNzP1C5ECe2X6BkFLm16mfOlj/Cl9WCzU0dexdoqUYUzeq6oQ9ZWMIZsibRh2xFxk/3KxwoxhIPayoUSpKERE+xPepIYPFBC9OcZL/tRS3Q6hSyu03zvJS5a6ytM5CQmXhcGY5pFM6oAT6JKNjbEAYkzxxyJ2nS SBeUgIZc IFcNrHUMcFlZqTwuVaDs6KWUrBjQH5KXgjP5PWp9y74a4Ttq0kJ0iB2RiVkv27AWZXEqFN/3q9Xx3LJBPYHbaeaCp8fBGl2sdEGmLzs+5RCn+RxhqWmu40jBhvXrFVBRltlvWlWRDep+FCJ1SVlBI9qfVPUI3SJaJ1Vh/q1T2TFLS9y/sCYSBGJvGc4xmwxpqqRoWYTvuH5eSvCHCKo6ZOJRahqldCpoBvAosNuFk2mc2iv8qi94ZaXbHO1qkrRD6j5/yyiDBAkKXVTIEQ20OTm41u+BwPoCtZmb0ni6QFraIQBG/YHrKuAKlzdXM42SA7ssQjYKcej2stJuUandyeeRnnYqOhkhZhi451SL1pHXwNgYRH4Kq+P6feW/z1hg9Lb2BPlocDWoRMv6LegNPOJHzduTPuF8PBhSAy8VQJe1Wll1BXRvXEY8ulQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Byungchul On Fri, 9 May 2025 at 14:51, Byungchul Park wrote: > > Now that all the users of the page pool members in struct page have been > gone, the members can be removed from struct page. However, the space > in struct page needs to be kept using a place holder with the same size, > until struct netmem_desc has its own instance, not overlayed onto struct > page, to avoid conficting with other members within struct page. > FWIW similar mirroring was intially proposed [0] a few years ago > Remove the page pool members in struct page and replace with a place > holder. The place holder should be removed once struct netmem_desc has > its own instance. instance? To make sure I understand this, the netmem_descs are expected to be allocated in the future right? [...] > - > static inline struct net_iov_area *net_iov_owner(const struct netmem_desc *niov) > { > return niov->owner; > diff --git a/include/net/netmem_type.h b/include/net/netmem_type.h > new file mode 100644 > index 0000000000000..6a3ac8e908515 > --- /dev/null > +++ b/include/net/netmem_type.h > @@ -0,0 +1,22 @@ > +/* SPDX-License-Identifier: GPL-2.0 > + * > + * Author: Byungchul Park Shouldn't Minas authorship be preserved here? > + */ > + > +#ifndef _NET_NETMEM_TYPE_H > +#define _NET_NETMEM_TYPE_H > + > +#include > + > +struct netmem_desc { > + unsigned long __unused_padding; > + struct_group_tagged(__netmem_desc, actual_data, > + unsigned long pp_magic; > + struct page_pool *pp; > + struct net_iov_area *owner; > + unsigned long dma_addr; > + atomic_long_t pp_ref_count; > + ); > +}; > + > +#endif /* _NET_NETMEM_TYPE_H */ > -- > 2.17.1 > [0] https://lore.kernel.org/netdev/1549550196-25581-1-git-send-email-ilias.apalodimas@linaro.org/ Thanks /Ilias