From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E0FC4167B for ; Fri, 1 Dec 2023 10:35:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8EA08D006E; Fri, 1 Dec 2023 05:35:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B16E88D0001; Fri, 1 Dec 2023 05:35:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B76C8D006E; Fri, 1 Dec 2023 05:35:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7C9168D0001 for ; Fri, 1 Dec 2023 05:35:30 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F55A1A01A5 for ; Fri, 1 Dec 2023 10:35:30 +0000 (UTC) X-FDA: 81517892820.14.9F7838D Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf12.hostedemail.com (Postfix) with ESMTP id 7263C40009 for ; Fri, 1 Dec 2023 10:35:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nNNpkU8k; spf=pass (imf12.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.181 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701426928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LYWWJmccuk3pmnu+6VAt2vzSATSgd9B73Hxs2lwVQqw=; b=ISumZqzrnEXxpkATQjmdgskreBKWEXn8S3/0IkfRSE6qau091lRaxI9aKhIrPz6pZfcIUf 4seq7X0BkGH1rQ0dCnHmITF8jL2JsZP7ORY6WV8bbrLh+HF1tAqx9+Do9SMqjnO+fa+tIS lqgWWgRQNAMEFHMCPz9KCvKpZdjb2cU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nNNpkU8k; spf=pass (imf12.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.181 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701426928; a=rsa-sha256; cv=none; b=MSnUgkydjdPesltg2w6i1W/z7APdlX3h9+V2PUsu1EU58VwYBfPre2WDCfnJzOkGxrxeBj d4Wa6V6omENBVIuHahjQLYoobxMtFMp4U5lvqgzSupPQm5SuqR+zXQNmZxfTzSNQg731pz zELl7ZvLoVBncQ83bH9vk0Ac36By85A= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2c9c5d30b32so25444971fa.2 for ; Fri, 01 Dec 2023 02:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701426927; x=1702031727; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LYWWJmccuk3pmnu+6VAt2vzSATSgd9B73Hxs2lwVQqw=; b=nNNpkU8kNDwshthppdYYxzZz1jTycfH+UmO6ikgzaSHPeUQiwAq4WbTqPc0qYwQ3Bz OevICtTsCDOY6OLi1JxkBFrxIiFO9d2RcORFJJCJ5M4GiCw38M9VrntKJtqpPDEBVUmN If/a2tyxN6sCxoA8UC4hgMis+GwjMTBhBJA87sOMdBBJd1YbqdGgHF6DVfEyL3LC9+xL gB8VpabJXISDFbpyAjc1DsbLsy2PCGz8u4JyISe9Rgr4JrV/DF+Ji5osF2hx4CM08shV AXZszqgahlteUFahdexE9mocS1NArcAGt5MYL5OomaIE6g5NW14cMIWOVd9s3xMwZNzJ pTrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701426927; x=1702031727; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LYWWJmccuk3pmnu+6VAt2vzSATSgd9B73Hxs2lwVQqw=; b=eHZSZ9lkcmF7d21ZYWxPr1ENzyil2dRG75ahXg5EnhJZ+ocYjhCUBIgVxosryKNke4 Sag0CVEXacCnO1qTenoqIyKenHi7YRZfDhJ8NyjpzgftpTtB3kcx3MYTnaJG7aROyCK7 Ed9mgvSnXzsAQAHCpuSO28+ghhKjNMtiTarCFclLkQ3PT6rOozQIDoFNOy1KAUiRY6Xj FaZeGB+VLR9JQ4NY1cwEKhIaRB5IQz1mJkHWqv8PVvBIgFJLF2jII+Fe1U/t6ZOHgy+i 5eI/26XbK3GELzPLoat5CQBG5e4ccL5X4p2gOSvY/p6VohZ2rOJM/AZ/M5jgigwkbhAf 21nQ== X-Gm-Message-State: AOJu0Yz6e/gm6RXqV+nGjt0T19AJUD7nENkIzJmHccTx+59NuA56cg1c a70K60/IH1YXM1fP0Zlia8hEtyR1AnPIt3HnX3warw== X-Google-Smtp-Source: AGHT+IF1SwSHApiul0brKGkeM/rT+9In35ZMqPnEuzPqvKgKCwtxBY9cwHSgRoM+AkCTdsM9i1XD/EuSkZ+VQHXSYkg= X-Received: by 2002:a2e:87d9:0:b0:2c9:d862:c64b with SMTP id v25-20020a2e87d9000000b002c9d862c64bmr603662ljj.56.1701426926712; Fri, 01 Dec 2023 02:35:26 -0800 (PST) MIME-Version: 1.0 References: <20231130115611.6632-1-liangchen.linux@gmail.com> <20231130115611.6632-5-liangchen.linux@gmail.com> In-Reply-To: <20231130115611.6632-5-liangchen.linux@gmail.com> From: Ilias Apalodimas Date: Fri, 1 Dec 2023 12:34:50 +0200 Message-ID: Subject: Re: [PATCH net-next v6 4/4] skbuff: Optimization of SKB coalescing for page pool To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7263C40009 X-Rspam-User: X-Stat-Signature: g6p93medy6j5jxxa57ijs4b8biutdo11 X-Rspamd-Server: rspam01 X-HE-Tag: 1701426928-898112 X-HE-Meta: U2FsdGVkX1+KtCigU3D2dtiOYjAslBK8XYD7BL9qHi2Wwv7eG9b6C6Ejgwfa8mtwOz9bXzXVDZYRl62SmKhVoZ14rp9fY8ilji5ilYh6p7+mvF6FMfSYAca34jdOAZTulkuDfR3rfljWluMjazoEYuvikEQzqpRA8HVJKkBV9519WrvchjP0ptndaB2f08Fcvh6oIjuCYLLGjdRhNLMmMBcIfpujC5XztJSmvLn+ZFK7KrCt5g88VYR4CMyBDUtF1TZ4XNTw6MJQNZoXNFTMU1S0nh0Mude3VyUuASIcMToo6LewePq7d2gwktQc9yEev2vKZnb9h9PE7D+xkYIoxCQU9yyve7Re3Xkr2MtN+E5lPJq1zX1h+sX9SeaZaksDWvDs7DNrCPJwnbKYYKFlbyEejvBSlNPjblxHJOyCZDNG1WBR52K2KBNigV5n/TOQ6QThzHpUK6NrX3O3at8IbNRGgKTCRNVJYZhXaBHRJ5QMqkHMPB69iorcC/Ke7iEsi3Q4F6eSxop23z+2ss1Tzdy/WlxroyERM9SnKz2HUjL19bd79BpN8iYHJ7UM0pV0DBVmQUlL9UM8KbOrFEDHPTMyt+BJPYc6i3vxFGN0Sd/eJkx/6GQIVp7I3Q4b5DIWNnucaSlHn3VqByvruk+S1LG9WWln9snDnKHm/K7Kw25buZJFSXoWYtzq9jqwR6K9wnc5J9GjYUQuG73Ngdd9AtdBcM3UmPQR6kK/4X6+3J11C9Dc0pgW7MLlhth57/+31ss/jeJ0N0q9mik8w7YIhV8nLeAU+vcZfO3i9sKSiDpcPH5eSY7WjcfqrjF709esg6farOnFq7lCsR9lDRxTKeZnR5nmR+vDxvAUG2dM419g3iKJGSwv1oV2PTvWTr6R+ow3bqkG1Px1PROfR0lgFI6gux58PJKiXoL8s4e6nTB/FdVOQ2z5S2Ticn2g5IOrgzNBkAFHNo9SUeux0kV YdUto88b rNRpsMUujkl22NA84Y1ZxpDxHFMvLFV22oyUOyIvF0+D78rSS+5djtVS2vyw3MGCqK/dXWJolK274O6/ei/NianPGF5xAOAYM5Hp+nEt2JPp4DIu97RTiwCW4CEB/8bNKsBeMn/plsK49IGpHPqzaBWGjo+6WyZbuF7133LV4pe3g0L5Ff83BmhI3E19xXWilRiDddgn34DtPcPD0xl0DvVjWVelVWCsK/HJa6hi6x2Kj55EsrsJh2NtB6sAv6ZwQjdIKif+cM7ifKZFmzlrBqWTKbZ2wzgaWpo/j X-Bogosity: Ham, tests=bogofilter, spamicity=0.017397, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: HI Liang, [...] > } > > +/** > + * skb_pp_frag_ref() - Increase fragment reference count of a page > + * @page: page of the fragment on which to increase a reference > + * > + * Increase fragment reference count (pp_ref_count) on a page, but if it is > + * not a page pool page, fallback to increase a reference(_refcount) on a > + * normal page. > + */ > +static void skb_pp_frag_ref(struct page *page) > +{ > + struct page *head_page = compound_head(page); > + > + if (likely(skb_frag_is_pp_page(head_page))) > + page_pool_ref_page(head_page); > + else > + page_ref_inc(head_page); I think I've mentioned this in the past, but I think shoehorning page pool awareness in the skbuff is not the direction we want to go. Up to now, we've tried hard to make that as seamless as possible. The code looks correct, but I'd prefer people with a better understanding of the core network stack to comment on this. [...] Thanks /Ilias