From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B27C54EBD for ; Mon, 9 Jan 2023 17:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D18448E0002; Mon, 9 Jan 2023 12:31:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC8928E0001; Mon, 9 Jan 2023 12:31:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B43998E0002; Mon, 9 Jan 2023 12:31:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A46208E0001 for ; Mon, 9 Jan 2023 12:31:09 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 72AE7809D6 for ; Mon, 9 Jan 2023 17:31:09 +0000 (UTC) X-FDA: 80335951458.26.A063768 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf03.hostedemail.com (Postfix) with ESMTP id B363420018 for ; Mon, 9 Jan 2023 17:31:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=msfhnd0w; spf=pass (imf03.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673285467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o37AcJEUaJU5V1Za+eAxuPSBm9n29u/Fpw2wr9C7DtQ=; b=KPkVP/xCscEEp2mPaTVeFkjVJcfa5v9pFd9eonx9+O4tJZe/FUaRnCNkgxC179eyzRmpp9 v/pu4q0QNT+rttKDdYWFEFbZcG644Ar/b57b99KLL5iGwLwxbMWOtmwUXpbmaawTf/3+ns wuISYPr3nY1yoHKQwmum5ZnOE270XPg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=msfhnd0w; spf=pass (imf03.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673285467; a=rsa-sha256; cv=none; b=6vkIKmUwKJ+Dryq7HwY4DVp+IAKiTD1dTw2dNIMy17ql7jBGvmFO4Fa6JU8XYRcDgqpZ/1 PVh0z9pKuR/YANlnDQrGCWTSPWJ9pUwR/DNSFS9OZCUNZ+h1H0jHhSa+niYUyR7iO4j+59 qCXdhvvkGm8NqkkOzsaD+XNSEPLTeGw= Received: by mail-lf1-f54.google.com with SMTP id bu8so14110145lfb.4 for ; Mon, 09 Jan 2023 09:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o37AcJEUaJU5V1Za+eAxuPSBm9n29u/Fpw2wr9C7DtQ=; b=msfhnd0wvCf5N6dMfcEYd1RnIac92f89ZQT8bps/A30qUz7f+hElb3sOW7wNK42UXt DnF2d4TTsehxYeeOTvlakCcWdVsRPil1d3MP/tZY8EdGHwSqsd1cUYVSeDt4FWYGqsPw g6g+RTOvCVvQvVn0PK5lTKK+3U2e6m/Z1rIdMvO1sU1k8Ta10KDQzI4K34JrYe8NfQUi F9TGAyHLdAiQYnOEVX4ND06HrB+75tCLTienGjUVK69D50+BSfGu0xyxOi678hQLcI8C Y/tU02oW6jxuzJA2r3vbezzovibukexk7mSmbicFIyDAXOW0wXtj8VHzgqKaH5CIMmxS ZEGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o37AcJEUaJU5V1Za+eAxuPSBm9n29u/Fpw2wr9C7DtQ=; b=yusQN+0ENhAfhlV+nXowcrZNuKTyD7wig+3YomPI5P9PCmV0O53TF4NyPL8B4O4hzc M6tUTIpK+xdnUj3qTOhXmhV8YFzhf6+B+IQMgw5HKEoZfO2FTuXeLAo24bdU/dlZrLtP WkQZ3wcwt1c+afxW9jR6HQ+r7xD1usO53wnGxuEmLBtKtoGT6aMgqkQNLjW+M72TDOw2 oAury4skwbJwyWgtFAipDdDO6mQmUNnVpEvvg2cWB+txkllLJJaetJJ8jF8ZVPx6iO2O RKEnu9iTmmqBCLOHBIrYb1mORPpo3NLf+squzMtQhetJLbIgm0EbH8GEZuGvxM7jEhJX EznQ== X-Gm-Message-State: AFqh2kr8/ONlfYhgcHb9tIjvAYo2+TV/b6jNjB/EvTwHKy36vzLz2PMH w0uJxShohVriENjuv640Z2eMeqD7sZwwDBYlWNw/5w== X-Google-Smtp-Source: AMrXdXspDP6Qxnnn56o6fxGjptGFL2CHy7RXas0ePAG6MdB3P+MkMKOMT5MMxHspKmdR/ooznwTZjiV7h1FJzqxuQv0= X-Received: by 2002:a05:6512:3b22:b0:4b6:4c3e:c2fa with SMTP id f34-20020a0565123b2200b004b64c3ec2famr4639888lfv.243.1673285465941; Mon, 09 Jan 2023 09:31:05 -0800 (PST) MIME-Version: 1.0 References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-4-willy@infradead.org> In-Reply-To: <20230105214631.3939268-4-willy@infradead.org> From: Ilias Apalodimas Date: Mon, 9 Jan 2023 19:30:30 +0200 Message-ID: Subject: Re: [PATCH v2 03/24] page_pool: Add netmem_set_dma_addr() and netmem_get_dma_addr() To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: wfx3gfwodksahe6nmdaoxu1hw3ngspby X-Rspam-User: X-Rspamd-Queue-Id: B363420018 X-Rspamd-Server: rspam06 X-HE-Tag: 1673285467-414854 X-HE-Meta: U2FsdGVkX18RuTXWKpAqe9Jw20B9SEbXmnVAz4qMO0PgQOLk/veeHyQ/bQA+0giVtlTTfOUGxFu2RtmcQroOeqZV4sNvhkUGVYzFMXRC598CZd9ekml6p+LKmiTgttACJn3L7vARdcYJJKZ1qAjATPG3uAI3k42Uf7VQvPM7U9+6ey81WwjKrx4iCJ/I1GbrU4ITHQEeywdWnRj++OZv2F8KejjWw6U51w3BGSne7YzcSibOdvA1ON6+qIhOqUhbxtW20Lx1fg/sKd1e3jNvV43ZS+JuKGQ2PRxToHYPzPz6w8aiLWcB90b+DFZx3Np7Nns+m2Whfu5uffWaFNeixj8gDKaQ7w4IlvNuyxhK8HwyWINvDOTzGiVlfestE1n1ZqSF5nSHCdGGq7ilj/1L1OG65wSjFPXxEcLBagkPHmk83UN8Hps3UcT2lfbOuy2XDWdEGXXumu6+FW92sMaWK4ASfY74BYhtIRsBgb9LCxNA2T0hsP0vBlyFUoQbnwTBEylTX28hJEPTBLdejc3QTlfag6Q4fq/VCvHYv3rQ6W/9PjaM4Jse5Tz8Vj3fzSdflozeHorbpSA3ydJrOVDNVoP86gxCulNqyGMLpXWFEG+egYmV5DnGMoq91mVeJEjyHe665Wgv7byWzGcQkgGAqD2g/AoNGTrcZdd+ZAV3Y+xV+pmTfdnDMtlwvKpWa4uzViVj5tc+rr8GTrpuRRJM9mOzDQAv6R+kqgIXSaORit1VuYsDKzFo24laRJ5Ab1yeYqrEmxn0d/e2zpE5muv8NAC3OZRj8XjHpZOin0DnRTe54R3eHAUO4Wrv8XJ4G7gWYw5KJ+2SJ9DFoWlTA2nll/Okl8JVteDfH7pzktr79LA6i5w03cXywUDizpJ5nbQZx2YQUkOtrfXGB8rZzEc3/kJ8lLlv9wHeJbm3SLWpLBWCnntE7m17Qq8Ru/9sEUt+jk4UMHO106SJ7SJujyI Zdv+PROD uruEcP/WF6v5s7GhTTqvfqnu9EfFjcLLziBQsixTywzIG16t7g6oHOeZBsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew On Thu, 5 Jan 2023 at 23:46, Matthew Wilcox (Oracle) wrote: > > Turn page_pool_set_dma_addr() and page_pool_get_dma_addr() into > wrappers. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/page_pool.h | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index 84b4ea8af015..196b585763d9 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -449,21 +449,31 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > #define PAGE_POOL_DMA_USE_PP_FRAG_COUNT \ > (sizeof(dma_addr_t) > sizeof(unsigned long)) > > -static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > +static inline dma_addr_t netmem_get_dma_addr(struct netmem *nmem) Ideally, we'd like to avoid having people call these directly and use the page_pool_(get|set)_dma_addr wrappers. Can we add a comment in v3? > { > - dma_addr_t ret = page->dma_addr; > + dma_addr_t ret = nmem->dma_addr; > > if (PAGE_POOL_DMA_USE_PP_FRAG_COUNT) > - ret |= (dma_addr_t)page->dma_addr_upper << 16 << 16; > + ret |= (dma_addr_t)nmem->dma_addr_upper << 16 << 16; > > return ret; > } > > -static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t addr) > +static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > +{ > + return netmem_get_dma_addr(page_netmem(page)); > +} > + > +static inline void netmem_set_dma_addr(struct netmem *nmem, dma_addr_t addr) > { > - page->dma_addr = addr; > + nmem->dma_addr = addr; > if (PAGE_POOL_DMA_USE_PP_FRAG_COUNT) > - page->dma_addr_upper = upper_32_bits(addr); > + nmem->dma_addr_upper = upper_32_bits(addr); > +} > + > +static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t addr) > +{ > + netmem_set_dma_addr(page_netmem(page), addr); > } > > static inline bool is_page_pool_compiled_in(void) > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas