From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B43C4167B for ; Tue, 5 Dec 2023 11:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC636B0080; Tue, 5 Dec 2023 06:03:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2467D6B0081; Tue, 5 Dec 2023 06:03:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0336B0082; Tue, 5 Dec 2023 06:03:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E76216B0080 for ; Tue, 5 Dec 2023 06:03:25 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B652AC032E for ; Tue, 5 Dec 2023 11:03:25 +0000 (UTC) X-FDA: 81532478370.01.7ED636D Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf05.hostedemail.com (Postfix) with ESMTP id E46CC100012 for ; Tue, 5 Dec 2023 11:03:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=CmVPzyg4; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf05.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.177 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701774204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AJd4oMd5EA5C/VFOZRiD6wc4ORLmC56RXNr+hZDHSaM=; b=XwOUReHAm9sMAcdRHFU77rtcOw1W/PMfRN7fbtSWWny4sTf5BpN82i+YEEJgkc5R9Aybeh XJa1c8AjjljU8/FPKhxab6euY6kQMpgHX+pYBZfb3KcSJgwmMIcw/8j+9QvTGJHhGVKMOh d+CLVbNYBAZwDglDzOos4HA/XcyVBb8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=CmVPzyg4; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf05.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.177 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701774204; a=rsa-sha256; cv=none; b=UvsdJj9F8vEZjhqq5NTUiQlNNewAvBPlKHPtk88jDCcP7iBu5HCBJm9+cFvNiHgj2b2eH0 +9BhmmO3dkCjQaIRUQcrGNPpogAzka+SuqAp6Gg6EzP9+jPGgJLumzczCaEj/DoOZkfOn6 wI/3F1nP7myRcTRsATahgh+s8lfm4l4= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c9f57d9952so35531301fa.3 for ; Tue, 05 Dec 2023 03:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701774202; x=1702379002; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AJd4oMd5EA5C/VFOZRiD6wc4ORLmC56RXNr+hZDHSaM=; b=CmVPzyg4YKoJsisAoBif78qmYD0cKuz2hK1g5ZgQ/n0Fk6ekcf1P7s4OzJ0g85/bxO mpQLs/yLbe4qJ3trPTVDo9mUqgaweiPC/r3gMlDu4Cs8t2pb4xhgLENlD06A8UJ46qi0 LYHxw7zQMBRE1z+LcFUHxQ5YKj3L6TTxCq6U8tYki/TnS7wDPhJuSjEZdFGo89xdPfZH MvsFA/4dqXUSni1RBk25KZWOa2Jw3czTS8NemBsMSBIrO7/I1CDEPAF0pbW7p4nRnZBN gFMjJZF8Z53bqMLM1JEmspZVgCLeXmy4mTePRtaNr4O7JdtfVjJF19kzB0EG4W1AP3td bsEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701774202; x=1702379002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AJd4oMd5EA5C/VFOZRiD6wc4ORLmC56RXNr+hZDHSaM=; b=YNbpbmsnJGORv/3lbVBcgBXUHkLoX4+/xdh973zGPWBH9NSwN73Jfl36ISM2RRdMJj nhZih/n0BSohvo1okhce3wRs7hrghcU2o6Ai0mpnDOJhKmB32DAsDr34FnNIQHQ4YTUQ aMFCJBDZc32eyG6IZvwzuu+n3Of69zYksrpXuz7+bJNwdlHzcMCp88FrLuFtfwMwr/G1 81vFxf0MZplUZsFr4TVNRZ5ny8TfO2yQVr1IaEnAbBRpGAel+EYKxOwdmopn4AHWhbvR 2tZLXQ5AdwJBErRThUHd/4Y3z2U1DsFlov5QOgKREXdqRU67DNipdzeEPuVSwhV0gpJb Z7kQ== X-Gm-Message-State: AOJu0YzmKDYO7wM8LM8Bij499AG3JCcJdvgE+F3pJWB1KudW86YtatIc vOZklNsY/B6RkFGfua7aK561Ja3EG8i+Os0bm5Z5zA== X-Google-Smtp-Source: AGHT+IG7SpDz/QiWwULBTrktELF3o8Kag0qEqzvmNnF2brmckaGERotIYRE7mpIFn9MaR99qqMKPKTAhMHwYrBaUaOk= X-Received: by 2002:a2e:b615:0:b0:2ca:fe7:1ec9 with SMTP id r21-20020a2eb615000000b002ca0fe71ec9mr726188ljn.44.1701774202088; Tue, 05 Dec 2023 03:03:22 -0800 (PST) MIME-Version: 1.0 References: <20231130115611.6632-1-liangchen.linux@gmail.com> <20231130115611.6632-4-liangchen.linux@gmail.com> In-Reply-To: From: Ilias Apalodimas Date: Tue, 5 Dec 2023 13:02:46 +0200 Message-ID: Subject: Re: [PATCH net-next v6 3/4] skbuff: Add a function to check if a page belongs to page_pool To: Liang Chen Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E46CC100012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: akj1fncjyg3qk4dr5icmmdz4rsbzgn1d X-HE-Tag: 1701774203-627217 X-HE-Meta: U2FsdGVkX1+1xG9Mv34EDeBmwdmtftrVYHxpiIVoZTBnnnWFV/PAmggXlXiV9QaLQx/jNH/orcEolHauXZKLEtyYl8DPNp8cJ0v/7HhuWmhTNqVcCmefIDBo/m6DeGFkCYWl5JoIe8IJjoke2HQQCVdHeTa5KXBjxcTB0vrc2bbMQ/XlsIvkc6x3ifYksMQyTCU4tFVK2jVJO/sxsYFlW5ToXCR2fQro/8UiAyTf+ocy/RHGTJjqmOKNjifAlxnja2VcBDmyH9KDq59+li+ChyMmyMc7lhXYLFFdFIauhVRzi3AcpXVPwKMjOITVFYfWjvbOk88YBNnv7JPiuZVEpmpeIFIFOJ1YNKFUXDpSji463AyJXJ5MkH+MFjdLmsFYyusnGQ5dg9IBglte398dOHuzmDPW6RIDRJ3kTGFBE0DpMNL162EDEzS550McGPdofxyRCheU0CwHPR/W0WpVVHlKKDDpmElWIwOl1zdXdQ+kbO2iWxSkcG8AgKZZVTOiD+FOrsluPbtpjxzGt8B1cEdoNRIS6TBqRpv/dUVQQUELI9nxsNapzKOVFdM1sQURAIrg0vW0uYyNbu0uTSuKqjbI6tup8n9ol4Zeu1MROQ6GGdmvm2Zy5T56QC1RPtdofAOCYjvktWvidpNpGd3KeenuCdSg1rUwf6/fEDbk2rZF1fvE3Cddt8sdjLWlucmWW4smaqRf/7vC4a6rL1UF8cdh2suTSGUrpSAJZnKXO1G5Y+uKt/F85kCpVAIc1MIa/JyenH9mIVm+SN0fsN5ysvkVclUUIG1xduwbwcqmVfhXyaSlGR5TJtKvj9EdSXiCLg8vi3yoWoNzsdg1lzIoKveQeO8sRVao8T43fP0KFdAkSra13ioOKBB/g2z/XER6HaWcWKrmHDWCAxteXPpM/hjqI846yx9bOuWmK1O5KspbHyeCvV8wP7gR9dUQmYmWX9QeC0yq5fi9o/O8fEj 1wlfzKBL WmlG0a0FPTVzFIuVekuBmhZhmjUd4MJ9Q9N07KWtIETXrJKH0lFEpGzr+F4GLZOCVAIm2K6bXa0UAUc1nwsUdnF/LJ6KahdbEqQJ3T/BuhfNWSOEEiU4onzMxvc/ySUc6UwrY2xoSMI/N85cOqC4b0V1rDh1BklxEYzmlVaJF+drf8uYWuqckVRnKQOJlbi4wj4BgxSVZFUlk5KYhbCMTDv3dxR17iD3AVRpySFX2Q5r9o71CsZtQcjVgngBhYaPJCDvzaboI7YcXqipMweZZfQvkeVLNCXe7zHg9LfheEf3sMQoNZ5dtsQazr8M2iQJUq+iG0M9t9yeiCJvrqY8VFh9zjTu+P8avXCDHZLixgjuOdw/mJXLYDde/z4/sAXhTEX+kXuWxmqIDYNW1FJlSgXrXIeTj0CXuBJzpAJljfBbNKF6Dbi8bV0RmAjXnKfYUV+09nUY5NgWKH6+fUnfxsKBzMEhPDC/f8IzZB45Gx4vtb8NTvmC7e+a3rok/LZHOYYA8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liang, On Mon, 4 Dec 2023 at 04:40, Liang Chen wrote: > > On Fri, Dec 1, 2023 at 6:23=E2=80=AFPM Ilias Apalodimas > wrote: > > > > The second time is the charm, apologize for the noise.. resending it > > as plain-text > > > > On Thu, 30 Nov 2023 at 13:59, Liang Chen wr= ote: > > > > > > Wrap code for checking if a page is a page_pool page into a > > > function for better readability and ease of reuse. > > > > > > Signed-off-by: Liang Chen > > > Reviewed-by: Yunsheng Lin > > > --- > > > net/core/skbuff.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > index b157efea5dea..31e57c29c556 100644 > > > --- a/net/core/skbuff.c > > > +++ b/net/core/skbuff.c > > > @@ -890,6 +890,11 @@ static void skb_clone_fraglist(struct sk_buff *s= kb) > > > skb_get(list); > > > } > > > > > > +static bool skb_frag_is_pp_page(struct page *page) > > > +{ > > > + return (page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE; > > > +} > > > + > > > > That's fine, but why _frag? The same logic applies to non-fragmented pa= ges no? > > So rename it to skb_from_pp()? > > > > Yeah, the same logic applies to non-fragmented pages. How about > changing it to 'is_pp_page'? It takes a page as an argument instead of > the entire skb. Naming stuff is always hard. Any of skb_from_pp/is_pp_page would work for m= e Thanks /Ilias > > [...] > > > > Thanks > > /Ilias