From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC31C021B3 for ; Fri, 21 Feb 2025 17:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2A5628001A; Fri, 21 Feb 2025 12:14:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD949280016; Fri, 21 Feb 2025 12:14:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C379128001A; Fri, 21 Feb 2025 12:14:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A415E280016 for ; Fri, 21 Feb 2025 12:14:33 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 22FAC1A19C3 for ; Fri, 21 Feb 2025 17:14:33 +0000 (UTC) X-FDA: 83144600826.26.273615B Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 45E99100009 for ; Fri, 21 Feb 2025 17:14:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gKPqFQYS; spf=pass (imf14.hostedemail.com: domain of kaleshsingh@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=kaleshsingh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740158071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F0gSK2FCxaWmxefntBhNlF54L7D98cEEXS9T8Pg40TY=; b=L/aKRGvArYFBLZV0zw3k79eo471XXc7ZnH0pzQvAPnK36YYqZbPe2tcvo7ei2QUcaQq+AD VJa3J5/s6ajzP9XiDhMeSyje/2802fd2TQlk+YzOQ+xL1cmEylQeWdfu2/yMHY/evK/NNZ AoUXKRbBVSbMHwIADwikqCtk9weP3+s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gKPqFQYS; spf=pass (imf14.hostedemail.com: domain of kaleshsingh@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=kaleshsingh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740158071; a=rsa-sha256; cv=none; b=jKFgcc9C3XYCtcbUAVliqmXUx8fytz797ChPnvUiw8eT+sybYVhobMGXzvRZIv1O1ZIaMy OCqfpzciRmcYP0Aljg39oIb5lqpNMGMDfQI9TLjj6OPfjMrJT3g5t5eFy3U0KxBusbOsqX frm+OO6uaHykWORxzmiako22g3hah5A= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-220e0575f5bso193515ad.0 for ; Fri, 21 Feb 2025 09:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740158070; x=1740762870; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F0gSK2FCxaWmxefntBhNlF54L7D98cEEXS9T8Pg40TY=; b=gKPqFQYSMZGil5dHemxPryJ+ydMetOY9XHlPxmt2a4d9TA5zl9syDfJPL1R0BBtLRI r6ulcylUc+nnm5LiwZBLZs1zZfej+7uVUbMXETCiqznS7nPFr4bm26IpdZWLiFjDoUFA jcQbjV05L0lBe7WwoPKgcN03Qze2VQntfVEjg3AcZMsDTTWzCGlmqbXWY0+ZIfKTQniX de896wcKbAszpueaCULcQkOV5OIq8MaDmXV2+cZsMMmSLlFLKeyd1CXzmhCC4rZbu8F2 phqnoyeFOkBeH83c8GBkiv9DnGZ3rXNsGEDakrYBltacOTuLGMvOVQ6Iz/HPjsxwio0F g31w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740158070; x=1740762870; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F0gSK2FCxaWmxefntBhNlF54L7D98cEEXS9T8Pg40TY=; b=c9ZmumnJOf/SHToMTwRghlQzTCWJd67BLHcuDNYask4bty9a2U/Fp46xwYMxWbaRoQ YIsDHVehKhDHqtRoXuJzdqS5dgraBB7iLPjEC+UkeaxLEbMZ6MdqmqEmpC8D02h9//2A EW58nPPt7gwHyiXvsZ+lCBXyxV8lzqOFtDnAHoB77c6n16FBeJF55+DXf1QyDyyH0wad Vw3kHTeCCDmrQIfyzMl8l97COVRlKkSUdtFt1K6OqTbfr/XqHZ03Zp3d3uItMxCW+mKm uqsmoiGS/4EjDlKXJFATBTVo+zMNRENG1/Tc1eioNoaO6V91SCdYHrVmpYZwWku4YfOo g3ug== X-Forwarded-Encrypted: i=1; AJvYcCV1qVGNxskm4hhL454Rj4ZvnkOoYj4MIou7nxO0FIdZOYVV6KI+PhC8OmPWr+GL3mryHr+5jQ2DJA==@kvack.org X-Gm-Message-State: AOJu0YwJAG2MutSxG6SRfo0abByeiumiok25oZLoPgDlbEnuQ12oiDV2 wLAMM5Xjlz5+MfBtFzl9nLYYIbY5qc4wQ3YvbJrwxTOm0tA3CSyKiYdE7aq+xk6xiho3gu5XAZJ maspIsRFAW50saXjWzv06QchUYY2bfrWGbEbk X-Gm-Gg: ASbGncufXJAidX39Yxu+68wy5cwng5fy3PnfppX8MgnHXIz6xLbd2E7L5vCapMilLK/ mYCM5P1o4hV3X96tE+Xl7AnN0aIo3lv3M5EEK3GYbEqB7KoL2UMR6Wbnlk1kQhP49Q+KTsCP7E5 Q/QOGjcEOGd02uj+lqRG1W8953JwCkRyw4xaytn31Z X-Google-Smtp-Source: AGHT+IFNyUGqlslXX37x4LbVQZRrq75tIiNhK2lhe/pPGYWt/2yXJVlCueghSa7c76ItC22g78yrCg/UqJB9sy8R4qo= X-Received: by 2002:a17:903:2bcb:b0:21f:44eb:80f4 with SMTP id d9443c01a7336-221a045943dmr2994765ad.4.1740158070005; Fri, 21 Feb 2025 09:14:30 -0800 (PST) MIME-Version: 1.0 References: <164feb0a43ae72650e6b20c3910213f469566311.1740139449.git.lorenzo.stoakes@oracle.com> <32e83941-e6f5-42ee-9292-a44c16463cf1@lucifer.local> In-Reply-To: <32e83941-e6f5-42ee-9292-a44c16463cf1@lucifer.local> From: Kalesh Singh Date: Fri, 21 Feb 2025 09:14:18 -0800 X-Gm-Features: AWEUYZk3mhTNh_WBC5ffotM6wthK5i4atwZUkga3FHvQ0eq4dodOkvuYfjsE_F0 Message-ID: Subject: Re: [PATCH 2/2] tools/selftests: add guard region test for /proc/$pid/pagemap To: Lorenzo Stoakes Cc: Andrew Morton , Jonathan Corbet , Shuah Khan , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , Juan Yescas , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 45E99100009 X-Stat-Signature: hsh9pxn48nggasro63r753ewnz8kkko1 X-Rspamd-Server: rspam03 X-HE-Tag: 1740158071-150145 X-HE-Meta: U2FsdGVkX18J82GcZ9XimH+3KJl52ADnJGze1WDTDTQB7GikHF1P79R56/XGWf4HSCtjmAyVgtYPuxpDTVtP7+zblulpHJBRVn0TIATPrj+nyS4boahDpKyxa+1F5O31bHBafsKP7iaDVwhkccsjO/INYuiuuYDighuTfdO9Ahs7A4MzCVIvtz2rG3vCoLkInx84Mk0p3w34kXoBdK6lm6x7Sevs3k09wLm45DyBJw7+NaMB3EvLeibUTHM7LDi1ePBn1lVYrVos4MnbuQUQzrgZzyzdZSOLrmWhs1xROjgn2xI67lxxVlB60dXDFlaKrVD/lUmIBkN1df4XZBkb4V2nSvyCnQ9osDy6EG++66o0DKRs0HBjOS4vquW7bKjfSZ8R3j3umnT9K2ByW7/AirW5r3xtL/4qxcB9jQGSbOMIlTcE4p4dT1Yrt3ME/n0ZSQQXPsOVq4J5NfvJzAphaG5XZBrXHnF4axBZbnS8vG63EBIvcKYrMSXMjrHwfvZ3+OkzVA/4B4gx5Dufn7gchE1zp/aaHEyutE7c8qopCsDAG/jQzYS3rlq4m9XKx3UmXRwA5Yq+uVZ8oLnizOThwm4y/VN6qCe2NWKZeMB5S+I/47Me34Ds5jTyms+2X3RIiSlDFwhKDW2YgHEQLdsPaTkO4DGr5NLUgebxpmnK3mgHYYrY1mw+r4b/itEVFhboTXDIpx6D4rrfdG19fOKFYGKFBVE8tZEFKD0MzXAWGxLc1LneArpfhoFoKhwvHyapGRQf6PLl0z5pRDBd9eYZc1q7qceNOebCTMaMvJnB2w1yxCrZshgP9T5Ul0XtD0/hOBcom6ut9EblVpJmJ7gFneeF5H20cO4TPQReJ7eB7QPmwoHM5y+13z1qfpD5WWWQ43YOMD5KIaRJpOimK54fDiwdlPfu4jPgiyGLHlLqMGV4sewoCWnuuWbiHMSD84Of7k6TdD/500k36GiNgDy hA/gzKE6 1NZtZMkHFWAS4MWlCV1TRkEAvnPWEZGVqV5Qt5A4Er7Jb4KZnjdkSsQpozV1HXF6SLzg5YglwyvqrdlI2tShVTSDxjyiQesYjUl1jAEoMI6MwJI24Ns9OQsu4SGaO2HHsLl8uBnAPe8tyGPdAzFCiQtH7JPc0ZgbrfVSiafO0tSXZIJxrUFp5E0QsBCNIUVlLfijzClWE54t5vKMb2y2iFjbT9hIVecUM/pHZBsVnMNHLyas0sB2o/i7RhLZhLt1du7ncXSPGSayU2UMj3rWRFxvW/0CPeyhyV+Dc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 5:51=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Feb 21, 2025 at 12:05:23PM +0000, Lorenzo Stoakes wrote: > > Add a test to the guard region self tests to assert that the > > /proc/$pid/pagemap information now made availabile to the user correctl= y > > identifies and reports guard regions. > > > > As a part of this change, update vm_util.h to add the new bit (note the= re > > is no header file in the kernel where this is exposed, the user is expe= cted > > to provide their own mask) and utilise the helper functions there for > > pagemap functionality. > > > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Kalesh Singh > > Andrew - Apologies, > > I managed to not commit a change I quickly made before sending this out > (I'm ill, seems it is having an impact...) > > If the series is ok would you mind tacking on this fix-patch? It's simply > to rename a clumsily named define here. > > No functional changes... > > Thanks! > > ----8<---- > From 60be19e88b3bfe9a6ec459115f0027721c494b30 Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Fri, 21 Feb 2025 13:45:48 +0000 > Subject: [PATCH] fixup define name > > Fix badly named define so it's consistent with the others. > > Signed-off-by: Lorenzo Stoakes > --- > tools/testing/selftests/mm/guard-regions.c | 6 +++--- > tools/testing/selftests/mm/vm_util.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/guard-regions.c b/tools/testing/s= elftests/mm/guard-regions.c > index 0c7183e8b661..280d1831bf73 100644 > --- a/tools/testing/selftests/mm/guard-regions.c > +++ b/tools/testing/selftests/mm/guard-regions.c > @@ -2054,7 +2054,7 @@ TEST_F(guard_regions, pagemap) > for (i =3D 0; i < 10; i++) { > char *ptr_p =3D &ptr[i * page_size]; > unsigned long entry =3D pagemap_get_entry(proc_fd, ptr_p)= ; > - unsigned long masked =3D entry & PM_GUARD_REGION_MASK; > + unsigned long masked =3D entry & PM_GUARD_REGION; > > ASSERT_EQ(masked, 0); > } > @@ -2070,9 +2070,9 @@ TEST_F(guard_regions, pagemap) > for (i =3D 0; i < 10; i++) { > char *ptr_p =3D &ptr[i * page_size]; > unsigned long entry =3D pagemap_get_entry(proc_fd, ptr_p)= ; > - unsigned long masked =3D entry & PM_GUARD_REGION_MASK; > + unsigned long masked =3D entry & PM_GUARD_REGION; > > - ASSERT_EQ(masked, i % 2 =3D=3D 0 ? PM_GUARD_REGION_MASK := 0); > + ASSERT_EQ(masked, i % 2 =3D=3D 0 ? PM_GUARD_REGION : 0); > } > > ASSERT_EQ(close(proc_fd), 0); > diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftes= ts/mm/vm_util.h > index 73a11443b7f6..0e629586556b 100644 > --- a/tools/testing/selftests/mm/vm_util.h > +++ b/tools/testing/selftests/mm/vm_util.h > @@ -10,7 +10,7 @@ > #define PM_SOFT_DIRTY BIT_ULL(55) > #define PM_MMAP_EXCLUSIVE BIT_ULL(56) > #define PM_UFFD_WP BIT_ULL(57) > -#define PM_GUARD_REGION_MASK BIT_ULL(58) > +#define PM_GUARD_REGION BIT_ULL(58) > #define PM_FILE BIT_ULL(61) > #define PM_SWAP BIT_ULL(62) > #define PM_PRESENT BIT_ULL(63) > -- > 2.48.1